)]}'
{"watcher_tempest_plugin/infra_optim_clients.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12aeb5704aad3d44d65ca007f219a27e102fe4c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from watcher_tempest_plugin.services.infra_optim.v1.json import client as ioc"},{"line_number":26,"context_line":"from watcher_tempest_plugin.services.metric.v1.json import client as gc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"base_compute_client.COMPUTE_MICROVERSION \u003d \"2.53\""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fce034c_5b213ab4","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":49},"updated":"2019-04-12 01:03:59.000000000","message":"you are setting the base_compute_client.COMPUTE_MICROVERSION directly. This can be dangerous as that is global var and can affect other tests running at the same time. \nyou should use APIMicroversionFixture to set the microversion on the service client. let me make APIMicroversionFixture a lib interface so that tempest plugin can use this.","commit_id":"9ed312ad411e24a4c33e85d0720d46a021522448"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"46796f5acfd0ca8959ef2695809067b607480d78","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from watcher_tempest_plugin.services.infra_optim.v1.json import client as ioc"},{"line_number":26,"context_line":"from watcher_tempest_plugin.services.metric.v1.json import client as gc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"base_compute_client.COMPUTE_MICROVERSION \u003d \"2.53\""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fce034c_fe3494e0","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":49},"in_reply_to":"3fce034c_5b213ab4","updated":"2019-04-12 01:13:21.000000000","message":"yes, thanks. Indeed, setting this to a global variable is not appropriate. If your changes are merged, please let me know.","commit_id":"9ed312ad411e24a4c33e85d0720d46a021522448"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"384f6e6f35afa8bcf665fde51c1e0279956ad19e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from watcher_tempest_plugin.services.infra_optim.v1.json import client as ioc"},{"line_number":26,"context_line":"from watcher_tempest_plugin.services.metric.v1.json import client as gc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"base_compute_client.COMPUTE_MICROVERSION \u003d \"2.53\""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fce034c_42be1866","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":49},"in_reply_to":"3fce034c_fe3494e0","updated":"2019-04-13 01:32:52.000000000","message":"+1. proposed that - https://review.openstack.org/#/c/652181/","commit_id":"9ed312ad411e24a4c33e85d0720d46a021522448"}]}