)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5e862538be3951e2b41f46cad7496cbc27232dd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db5d0c4d_9412680a","updated":"2025-01-02 11:48:10.000000000","message":"Thank you @mtembo@redhat.com, The overall code looks good. Left few improvement to the datasource config.","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"06c36d15e2536253aca5666a30987858a9d5e8a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"095d2a91_1a78e79b","updated":"2025-01-08 05:50:28.000000000","message":"@mtembo@redhat.com, Thank you for updating the patch. We are almost there. we can run `tox -e pep8` command in watcher-tempest-plugin repo to reproduce these failure. Then we can fix the pep8 issues.","commit_id":"232e80b90f12408f4d626cbc32f47dac5709e04b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"96dd98f1b471e13325a6f03fa0ddc4a05a33b38a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"385a55c2_549d3315","updated":"2025-01-11 13:22:19.000000000","message":"Need one more fix in order to pass the tempest tests.","commit_id":"ca741200f69c1122f2d02af74aab16257a88b986"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"d05b4a5c7054cfa8b47f95b697e7ef686285c4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cb173364_cf988abb","updated":"2025-01-17 14:41:34.000000000","message":"Log of the failing tests\n\nhttps://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136/8#message-7220fcf953be1b9e5f21a139b5ee45c81e1b7e5c","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"eb0973d910df956ca30bc7d36e970901f651ed68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"752f208b_de55b484","updated":"2025-01-17 14:39:52.000000000","message":"failing test: watcher_tempest_plugin.tests.scenario.test_execute_strategies.TestExecuteStrategies\n\nIt seems all three tests\nvm_workload_consolidation_strategy,\nworkload_stabilization_strategy\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4a1/938136/8/check/watcher-tempest-strategies/4a18ad4/testr_results.html","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9e66678f247b7d6e85d4176510bda77c107c5d53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"687e9b37_9a3de11c","updated":"2025-01-20 05:31:46.000000000","message":"recheck","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9e66678f247b7d6e85d4176510bda77c107c5d53","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c3febbc5_f40e313e","in_reply_to":"cb173364_cf988abb","updated":"2025-01-20 05:31:46.000000000","message":"If we see the traceback of the failure.\n```\n Response - Headers: {\u0027date\u0027: \u0027Wed, 15 Jan 2025 15:01:42 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.58 (Ubuntu)\u0027, \u0027vary\u0027: \u0027OpenStack-API-Version\u0027, \u0027openstack-api-minimum-version\u0027: \u00271.0\u0027, \u0027openstack-api-maximum-version\u0027: \u00271.4\u0027, \u0027openstack-api-version\u0027: \u0027infra-optim 1.0\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027content-length\u0027: \u0027132\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027status\u0027: \u0027400\u0027, \u0027content-location\u0027: \u0027https://217.182.142.247/infra-optim/v1/audits/64fbf23f-b31a-475b-9210-1422ed37e0b9\u0027}\n        Body: b\u0027{\"error_message\": \"{\\\\\"faultcode\\\\\": \\\\\"Client\\\\\", \\\\\"faultstring\\\\\": \\\\\"Couldn\\\u0027t delete when state is \\\u0027PENDING\\\u0027.\\\\\", \\\\\"debuginfo\\\\\": null}\"}\u0027\n2025-01-15 15:01:42,288 101180 INFO     [tempest.lib.common.rest_client] Request (TestExecuteStrategies:_run_cleanups): 204 DELETE https://217.182.142.247/infra-optim/v1/audit_templates/1cd9d6d6-a17f-4edf-8a70-959df4776dc2 0.099s\n2025-01-15 15:01:42,288 101180 DEBUG    [tempest.lib.common.rest_client] Request - Headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Accept\u0027: \u0027application/json\u0027, \u0027X-Auth-Token\u0027: \u0027\u003comitted\u003e\u0027}\n        Body: None\n```\nand\n```\ntraceback-1: {{{\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/watcher_tempest_plugin/tests/scenario/base.py\", line 439, in delete_audit\n    resp, _ \u003d self.client.delete_audit(audit_uuid)\n              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/watcher_tempest_plugin/services/base.py\", line 37, in wrapper\n    return f(*args, **kwargs)\n           ^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/watcher_tempest_plugin/services/infra_optim/v1/json/client.py\", line 149, in delete_audit\n    return self._delete_request(\u0027audits\u0027, audit_uuid)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/watcher_tempest_plugin/services/base.py\", line 165, in _delete_request\n    resp, body \u003d self.delete(uri, headers\u003dheaders)\n                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 359, in delete\n    return self.request(\u0027DELETE\u0027, url, extra_headers, headers, body)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 762, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 877, in _error_checker\n    raise exceptions.BadRequest(resp_body, resp\u003dresp)\ntempest.lib.exceptions.BadRequest: Bad request\nDetails: {\u0027error_message\u0027: \u0027{\"faultcode\": \"Client\", \"faultstring\": \"Couldn\\\u0027t delete when state is \\\u0027PENDING\\\u0027.\", \"debuginfo\": null}\u0027}\n}}}\n```\nThe audit template is still pending state while api is trying to delete it and expecting it to be deleted. that\u0027s why the test is failing.\n\nLet me re-run the job and see if it still comes.","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6316d8820b4076f2b36719e5ba8fc013074a7a5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c77fbf21_e6940d00","updated":"2025-01-23 11:43:52.000000000","message":"LGTM, thanks Malinga. Some tests results using new config option are here: https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e0d8f8f34c2be532263f23d21ed0e806266f178c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fd0cb0c6_872130ed","updated":"2025-01-22 14:44:35.000000000","message":"Thank you @mtembo@redhat.com, The new config works perfectly in the new job https://review.opendev.org/c/openstack/watcher/+/939702 , test results: https://d5c0e4c80966c29b54ec-9ed411199ab33310a8b6bd95d117cd22.ssl.cf1.rackcdn.com/939702/10/check/watcher-no-datasource-tempest/989d331/testr_results.html and tempest config https://d5c0e4c80966c29b54ec-9ed411199ab33310a8b6bd95d117cd22.ssl.cf1.rackcdn.com/939702/10/check/watcher-no-datasource-tempest/989d331/controller/logs/tempest_conf.txt \n\n```\n[optimize]\ndatasource \u003d \n```","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"02fa784955567bf1e37718a232bacd4f7c0fcde7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8d5db898_4ddf40fd","updated":"2025-01-23 07:55:36.000000000","message":"lgtm","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"00a4292661d08a54f6c97e17423ed50eadf7dc0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0612fe12_533af873","updated":"2025-01-24 16:15:14.000000000","message":"we shoudl not add config option until there is code that uses them\n\nthere is no code using this or the new option introduced so this shoudl not be a separate patch.","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee2e659537c0c56a3f74a4d504454364715ab3f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0c8a1269_bfff47d0","in_reply_to":"0509c17e_b563c2f1","updated":"2025-01-27 12:11:00.000000000","message":"Sounds good to merge https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517 into this code review.","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e36a194394ec50518a7156e5987bc94a1e2d0658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a1f2572b_a84f1a51","in_reply_to":"0612fe12_533af873","updated":"2025-01-24 20:34:51.000000000","message":"There is another change[1] from Chandan which uses this new config option. So we could ask to merge both patches into a single one to proceed. WDYT?\n\n[1] https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a7beb074122e9f82cafabf7b0e0424775189d8e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8132ac58_cdddb2fc","in_reply_to":"0c8a1269_bfff47d0","updated":"2025-02-06 09:34:52.000000000","message":"Implementation to start with","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"be66ce99e6347673dca0f541e622cd65a828cf0e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0509c17e_b563c2f1","in_reply_to":"8ca648e0_54fb4e2a","updated":"2025-01-24 21:05:40.000000000","message":"https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/940171\n\nthat is proably wrong but somethign along those lines should work.","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a7beb074122e9f82cafabf7b0e0424775189d8e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"57b75001_3ef48eb6","in_reply_to":"8d5db898_4ddf40fd","updated":"2025-02-06 09:34:52.000000000","message":"thanks for the review and guidance @mandreou@redhat.com","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25df39684c1deaeeaf2bbb9435c2a58ba28b6937","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8ca648e0_54fb4e2a","in_reply_to":"a1f2572b_a84f1a51","updated":"2025-01-24 20:43:56.000000000","message":"that still pretty bare bone btu we could,\nreally the prometheus option should not be added until there is an implamtion.\n\nso if we combine the two into one then we shoudl start with just gnocci and \u0027\u0027 for none.\n\nthen you can chose to disable mertric injection.\n\nwith that said im not entirely convice \u0027\u0027 is the right way to handel that.\n\ntest tha tneed injection will never work with \u0027\u0027\nand those that doen should not inject data when datasource \u003d gnocchi or promethus.\n\ni would personaly combine all 3 patches.\n\nremove the empty sting \u0027\u0027 form the set of valid options.\nand skip metric injection in the tests patches that dont need it.","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a7beb074122e9f82cafabf7b0e0424775189d8e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6a25d31b_446e95f7","in_reply_to":"fd0cb0c6_872130ed","updated":"2025-02-06 09:34:52.000000000","message":"Thanks for the guidance @chandan.kumar@imaginea.com 😊","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ef6a2a866201e8fff8b9ba947757b64d38171b38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cce799c4_7a055386","updated":"2025-01-29 10:19:00.000000000","message":"Looks good now . Tested it here also https://review.opendev.org/c/openstack/watcher/+/939702 and tempest tests are passing https://5447eebf83bcd6fc5a63-dc6e15462e9da95e02ee0e042cb47d52.ssl.cf2.rackcdn.com/939702/12/check/watcher-no-datasource-tempest/837e538/testr_results.html","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ddbbfe6a853da0ce653c89c9ccb7bd041d224a9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b64497d0_a0715de1","updated":"2025-01-30 17:44:15.000000000","message":"based on results here: https://review.opendev.org/c/openstack/watcher/+/939702\nlooks good","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e2be27708c6fe87be4b5542f26609ddd36e6cc6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4e2dc50e_5c710512","updated":"2025-01-29 06:53:01.000000000","message":"looks reasonable","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7efa40ed52daedc9c7e4bb740eac714655b49be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"aabc87a7_3c2d5dca","updated":"2025-02-04 15:46:20.000000000","message":"this will work but i dont think its quite correct.","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"}],"watcher_tempest_plugin/config.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5e862538be3951e2b41f46cad7496cbc27232dd1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"                             help\u003d\"Whether or not watcher is expected to be \""},{"line_number":23,"context_line":"                                  \"available\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"optimization_group \u003d cfg.OptGroup(name\u003d\"optimization\","},{"line_number":26,"context_line":"                                  title\u003d\"Watcher Service Options\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OptimizationGroup \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"453a0abd_0287c480","line":25,"range":{"start_line":25,"start_character":40,"end_line":25,"end_character":52},"updated":"2025-01-02 11:48:10.000000000","message":"Openstack cli uses `optimize` sub commands to call watcher commands. can we use `optimize` as a group name?","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                             help\u003d\"Whether or not watcher is expected to be \""},{"line_number":23,"context_line":"                                  \"available\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"optimization_group \u003d cfg.OptGroup(name\u003d\"optimization\","},{"line_number":26,"context_line":"                                  title\u003d\"Watcher Service Options\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OptimizationGroup \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa448f3_bf61a045","line":25,"range":{"start_line":25,"start_character":40,"end_line":25,"end_character":52},"in_reply_to":"453a0abd_0287c480","updated":"2025-01-15 10:46:17.000000000","message":"Acknowledged","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fbc8b0e85d4a71c5b40755db9c8cf8cae5219b77","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                             help\u003d\"Whether or not watcher is expected to be \""},{"line_number":23,"context_line":"                                  \"available\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"optimization_group \u003d cfg.OptGroup(name\u003d\"optimization\","},{"line_number":26,"context_line":"                                  title\u003d\"Watcher Service Options\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OptimizationGroup \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"13217db8_48ca78b2","line":25,"range":{"start_line":25,"start_character":40,"end_line":25,"end_character":52},"in_reply_to":"453a0abd_0287c480","updated":"2025-01-08 05:47:48.000000000","message":"Done","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"c3b5f74bebc922cc225c18e1e364c55ed020009e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5bd12d3b_bd42296c","line":33,"updated":"2025-01-02 20:28:44.000000000","message":"Looks like the order is name, default, choices and lastly help. example: https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/config.py#L48","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5e862538be3951e2b41f46cad7496cbc27232dd1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33d31825_ff5d1053","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":1},"updated":"2025-01-02 11:48:10.000000000","message":"We need to add help message for the datasource.\n```suggestion\nOptimizationGroup \u003d [\n    cfg.StrOpt(\u0027datasource\u0027,\n               default\u003d\u0027gnocchi\u0027,\n               help\u003d\"Name of the datasource used with the Watcher Service\"\n                    \"Default is gnocchi. Other options are gnocchi, prometheus.\"\n               choices\u003d[\u0027gnocchi\u0027, \u0027prometheus\u0027]),\n]\n\n```","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fbc8b0e85d4a71c5b40755db9c8cf8cae5219b77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e83d6cf_fef3c1ce","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"33d31825_ff5d1053","updated":"2025-01-08 05:47:48.000000000","message":"Done","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9acae182_e2fb8a5c","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"33d31825_ff5d1053","updated":"2025-01-15 10:46:17.000000000","message":"Fix applied.","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"334fee1c_4d2f6a73","line":33,"in_reply_to":"5bd12d3b_bd42296c","updated":"2025-01-15 10:46:17.000000000","message":"Acknowledged","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               choices\u003d[\u0027gnocchi\u0027, \u0027prometheus\u0027],"},{"line_number":32,"context_line":"               help\u003d\u0027Name of the data source used with the Watcher Service\u0027"},{"line_number":33,"context_line":"                    \u0027Defaut is gnocchi. Other options are gnocchi\u0027),"},{"line_number":34,"context_line":"                    \u0027, prometheus\u0027),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"35c4ef54_5d2beff6","line":34,"in_reply_to":"aa72581b_0786db9a","updated":"2025-01-15 10:46:17.000000000","message":"\u003e pep8: E999 SyntaxError: closing parenthesis \u0027)\u0027 does not match opening parenthesis \u0027[\u0027 on line 28\n\nPlease fix.","commit_id":"232e80b90f12408f4d626cbc32f47dac5709e04b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fbcb0b5f0c247e07ab6410af7ad23dcda70591e2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":34,"context_line":"                    \", prometheus\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"8cf86ba6_1a5aeebc","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"updated":"2025-01-20 14:59:20.000000000","message":"I think we should support a empty datasource too (in future), since some strategies do not need an gnocchi or prometheus datasource to properly work. But I also think that this plugin is not yet ready for that, and requires at least a gnocchi datasource to work with most of the tests.","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"00a4292661d08a54f6c97e17423ed50eadf7dc0e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":34,"context_line":"                    \", prometheus\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"f2f194be_c9f460c3","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"in_reply_to":"8cf86ba6_1a5aeebc","updated":"2025-01-24 16:15:14.000000000","message":"Done","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a7beb074122e9f82cafabf7b0e0424775189d8e2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":34,"context_line":"                    \", prometheus\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da49da3f_2e38e6fe","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"in_reply_to":"8cf86ba6_1a5aeebc","updated":"2025-02-06 09:34:52.000000000","message":"Provision for an empty datasource has since been added. \nThank you.","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fbcb0b5f0c247e07ab6410af7ad23dcda70591e2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":34,"context_line":"                    \", prometheus\"),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"b021471c_c3653da4","line":34,"range":{"start_line":33,"start_character":20,"end_line":34,"end_character":34},"updated":"2025-01-20 14:59:20.000000000","message":"TBH, I don\u0027t think that you need to keep default and choices in help message, since they are already defined in the option, and it is another point to be updated afterwards.","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"00a4292661d08a54f6c97e17423ed50eadf7dc0e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":34,"context_line":"                    \", prometheus\"),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3abb3bc0_86e5270d","line":34,"range":{"start_line":33,"start_character":20,"end_line":34,"end_character":34},"in_reply_to":"b021471c_c3653da4","updated":"2025-01-24 16:15:14.000000000","message":"Done","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a7beb074122e9f82cafabf7b0e0424775189d8e2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":34,"context_line":"                    \", prometheus\"),"},{"line_number":35,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"05c3e8c0_492145e0","line":34,"range":{"start_line":33,"start_character":20,"end_line":34,"end_character":34},"in_reply_to":"b021471c_c3653da4","updated":"2025-02-06 09:34:52.000000000","message":"an update has been made here, highlighting that gnocchi and prometheus are supported data sources in addition to the provision for no datasource.","commit_id":"4dfa10d4a80f91a9b218e9bfbc1a96a050aae7b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"00a4292661d08a54f6c97e17423ed50eadf7dc0e","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\", \"\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"gnocchi and prometheus are supported datasources. use \u0027\u0027\""}],"source_content_type":"text/x-python","patch_set":11,"id":"c8e1eb06_c47809ec","line":30,"updated":"2025-01-24 16:15:14.000000000","message":"it\u0027s possible, actuly normal, to have multiple data sources or to have different strategies use different data sources.\n\nfor now, I don\u0027t think we have a plan to test that any time soone so using only one data souces is proably ok.\n\nhttps://docs.openstack.org/watcher/latest/configuration/watcher.html#watcher_strategies.node_resource_consolidation.datasources\n\nif we want to test those advanced configures in the future we can \nrevisit if we wantto make this a list or something more complex.\n\nfor now, we plan to only enable one data souce in each tempest job so this meets our needs.","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7efa40ed52daedc9c7e4bb740eac714655b49be","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"prometheus\", \"\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"gnocchi and prometheus are supported datasources. use \u0027\u0027\""}],"source_content_type":"text/x-python","patch_set":11,"id":"f9504a28_bd569741","line":30,"in_reply_to":"c8e1eb06_c47809ec","updated":"2025-02-04 15:46:20.000000000","message":"I am still leaning towards having no default value and explicitly configuring gnocchi in the existing jobs instead.\n\nperhaps we can make that change in a follow up once the config option exists.","commit_id":"44c56774b7f74f784bbb61be0310e3e0a60cc295"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7efa40ed52daedc9c7e4bb740eac714655b49be","unresolved":true,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"gnocchi is a supported datasources. use \u0027\u0027\""},{"line_number":34,"context_line":"                    \"for no datasource\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f6376e7_eedee23e","line":31,"range":{"start_line":31,"start_character":34,"end_line":31,"end_character":37},"updated":"2025-02-04 15:46:20.000000000","message":"im also not a fan of \"\" for disableing injection. we can do this but i dont think we should have a seperate job to test with out datasouces.\n\nhttps://review.opendev.org/c/openstack/watcher-tempest-plugin/+/940171\ni think is a better approach long term.\n\ni\u0027m not going to block on this but ci jobs are not free and we need to consider the value of a separate job upstream and downstream vs the cost.","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"}],"watcher_tempest_plugin/plugin.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5e862538be3951e2b41f46cad7496cbc27232dd1","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        conf.register_group(watcher_config.optimization_group)"},{"line_number":34,"context_line":"        conf.register_opts(watcher_config.OptimizationGroup,"},{"line_number":35,"context_line":"                           watcher_config.optimization_group)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_opt_lists(self):"},{"line_number":38,"context_line":"        return [(\u0027service_available\u0027, [watcher_config.service_option])]"}],"source_content_type":"text/x-python","patch_set":1,"id":"476e4af1_ce7b2fbf","line":36,"updated":"2025-01-02 11:48:10.000000000","message":"Based on https://docs.openstack.org/tempest/latest/plugins/plugin.html#dealing-with-configuration-options doc\n```\n If you need to add any plugin specific configuration options you should use the register_opts and get_opt_lists methods to pass them to Tempest when the plugin is loaded. \n```\nWe also need to add these group names and options to get_opt_lists function at line 38.\n```\nreturn [(\u0027service_available\u0027, [watcher_config.service_option]),\n        (watcher_config.optimization_group.name, watcher_config.OptimizationGroup)\n       ]\n```","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2c540c6ffce60ae759c5af5a1cdbf4563db1417a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        conf.register_group(watcher_config.optimization_group)"},{"line_number":34,"context_line":"        conf.register_opts(watcher_config.OptimizationGroup,"},{"line_number":35,"context_line":"                           watcher_config.optimization_group)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_opt_lists(self):"},{"line_number":38,"context_line":"        return [(\u0027service_available\u0027, [watcher_config.service_option])]"}],"source_content_type":"text/x-python","patch_set":1,"id":"0fffd9f3_8b4da81b","line":36,"in_reply_to":"476e4af1_ce7b2fbf","updated":"2025-01-15 04:26:06.000000000","message":"Done","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        conf.register_group(watcher_config.optimization_group)"},{"line_number":34,"context_line":"        conf.register_opts(watcher_config.OptimizationGroup,"},{"line_number":35,"context_line":"                           watcher_config.optimization_group)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_opt_lists(self):"},{"line_number":38,"context_line":"        return [(\u0027service_available\u0027, [watcher_config.service_option])]"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6d25aff_57816820","line":36,"in_reply_to":"476e4af1_ce7b2fbf","updated":"2025-01-15 10:46:17.000000000","message":"Done","commit_id":"9a06be607276c041a0e4cd8dad9d7e432258c999"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_opt_lists(self):"},{"line_number":38,"context_line":"        return [(\u0027service_available\u0027, [watcher_config.service_option])"},{"line_number":39,"context_line":"               (watcher_config.optimization_group.name, "},{"line_number":40,"context_line":"                watcher_config.OptimizationGroup)"},{"line_number":41,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"e71bd0c8_835dd73b","line":39,"in_reply_to":"c40cef1b_d9fd4c5f","updated":"2025-01-15 10:46:17.000000000","message":"\u003e pep8: W291 trailing whitespace\n\nPlease fix.","commit_id":"232e80b90f12408f4d626cbc32f47dac5709e04b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"96dd98f1b471e13325a6f03fa0ddc4a05a33b38a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                           watcher_config.optimization_group)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_opt_lists(self):"},{"line_number":38,"context_line":"        return [(\u0027service_available\u0027, [watcher_config.service_option])"},{"line_number":39,"context_line":"                (watcher_config.optimization_group.name,"},{"line_number":40,"context_line":"                watcher_config.OptimizationGroup)"},{"line_number":41,"context_line":"                ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"b53f4af1_ae70276b","line":38,"updated":"2025-01-11 13:22:19.000000000","message":"All the jobs are failing with following error https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7c4/938136/4/check/watcherclient-tempest-functional/7c4159a/job-output.txt:\n```\nall run-test: commands[1] | tempest run --regex watcher_tempest_plugin.tests.client_functional --concurrency\u003d1\n2025-01-09 11:46:41.338204 | controller | /opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/watcher_tempest_plugin/plugin.py:38: SyntaxWarning: \u0027tuple\u0027 object is not callable; perhaps you missed a comma?\n```\nWe need to add comma in the list item.\n```suggestion\n                return [(\u0027service_available\u0027, [watcher_config.service_option]),\n                (watcher_config.optimization_group.name,\n                watcher_config.OptimizationGroup)\n                ]\n\n```","commit_id":"ca741200f69c1122f2d02af74aab16257a88b986"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"7d29ec6003f1065b5b7ab7d75b0596f38f331092","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                           watcher_config.optimization_group)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_opt_lists(self):"},{"line_number":38,"context_line":"        return [(\u0027service_available\u0027, [watcher_config.service_option])"},{"line_number":39,"context_line":"                (watcher_config.optimization_group.name,"},{"line_number":40,"context_line":"                watcher_config.OptimizationGroup)"},{"line_number":41,"context_line":"                ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"8871fa23_63c865b2","line":38,"in_reply_to":"b53f4af1_ae70276b","updated":"2025-01-15 10:46:17.000000000","message":"Done","commit_id":"ca741200f69c1122f2d02af74aab16257a88b986"}],"watcher_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ddbbfe6a853da0ce653c89c9ccb7bd041d224a9e","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param metrics: The metrics add to resource when using Gnocchi"},{"line_number":308,"context_line":"        \"\"\""},{"line_number":309,"context_line":"        if not CONF.optimize.datasource:"},{"line_number":310,"context_line":"            pass"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":315,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":13,"id":"1c1d4852_b7fa339a","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":53},"updated":"2025-01-30 17:44:15.000000000","message":"I think that would be better to check for datasource \u003d\u003d \u0027gnocchi\u0027 and then call the make statistic metrics. It works since we only have gnocchi metrics generation for now, but we will need to change that when adding prometheus metrics.","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"6ba1c0e0f58f8a6baedccf23b08624f1d7a62945","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param metrics: The metrics add to resource when using Gnocchi"},{"line_number":308,"context_line":"        \"\"\""},{"line_number":309,"context_line":"        if not CONF.optimize.datasource:"},{"line_number":310,"context_line":"            pass"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":315,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a2836be_01fe336d","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":53},"in_reply_to":"1c1d4852_b7fa339a","updated":"2025-01-30 20:10:03.000000000","message":"So this is a reasonable comment depending on how far out we are in merging the prometheus piece. If that patch is close to be mergeable, I\u0027d let this go.","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"104c416f5fc027cab926377f0b1159365744ba9e","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param metrics: The metrics add to resource when using Gnocchi"},{"line_number":308,"context_line":"        \"\"\""},{"line_number":309,"context_line":"        if not CONF.optimize.datasource:"},{"line_number":310,"context_line":"            pass"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":315,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a612446_8a8132e8","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":53},"in_reply_to":"44d4a60a_6931a701","updated":"2025-02-05 13:22:46.000000000","message":"ack we chatted about this a little offline and agreed that while we shoudl revisit this we can proceed in its current form and refactor this in a followup.\n\nwith that in mind im upgrading to +2w","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7efa40ed52daedc9c7e4bb740eac714655b49be","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param metrics: The metrics add to resource when using Gnocchi"},{"line_number":308,"context_line":"        \"\"\""},{"line_number":309,"context_line":"        if not CONF.optimize.datasource:"},{"line_number":310,"context_line":"            pass"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":315,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":13,"id":"a3f1b916_be322b08","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":53},"in_reply_to":"9a2836be_01fe336d","updated":"2025-02-04 15:46:20.000000000","message":"CONF.optimize.datasource will always be defined so the first if will never be taken because it has a default.\nrelying on the empty string to be interpreted as false is not best practice.\n\ni generally agree with doug it would be better to\n\n\n\n```suggestion\n        if CONF.optimize.datasource \u003d\u003d \u0027gnocci\u0027:\n            self.make_host_statistic_gnocchi(metrics)\n```\n\nthe same applies to make_instance_statistic","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ca8e05a40a7be0e10cc8407de98ba07924beba3a","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param metrics: The metrics add to resource when using Gnocchi"},{"line_number":308,"context_line":"        \"\"\""},{"line_number":309,"context_line":"        if not CONF.optimize.datasource:"},{"line_number":310,"context_line":"            pass"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":315,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":13,"id":"44d4a60a_6931a701","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":53},"in_reply_to":"a3f1b916_be322b08","updated":"2025-02-05 13:08:09.000000000","message":"Lets defer this improvement to a new patch, and lets proceed with this code since it is already passing on CI.\nThanks @mtembo","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a7beb074122e9f82cafabf7b0e0424775189d8e2","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param metrics: The metrics add to resource when using Gnocchi"},{"line_number":308,"context_line":"        \"\"\""},{"line_number":309,"context_line":"        if not CONF.optimize.datasource:"},{"line_number":310,"context_line":"            pass"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":315,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":13,"id":"d608b4c4_29cc17bd","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":53},"in_reply_to":"a3f1b916_be322b08","updated":"2025-02-06 09:34:52.000000000","message":"so do we let this go for now or do you still lean more towards implementing the best practice changes ?","commit_id":"580f55665415327fbdf44c060875d819dac9c24d"}]}