)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41f45c016aa84b591e9851d832f151b74396bfa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c1d9fbd_0cb59268","updated":"2025-02-04 16:02:43.000000000","message":"-1 for the general direction.\nthis is a viaable path but i thinks we shoudl avoid using prometheus_client unless we decide to remove python-observabilityclient from watcher and swap to it for all calls.\n\nwe shoudl not need to package both clients to be be able to execute the tests.","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"86d4eb9282408908e12486e817e20e6c69815a99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8cc0e48b_923b419c","updated":"2025-02-10 13:56:11.000000000","message":"-1: setting this until we discuss about the client approach. Thanks Chandan!","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"}],"requirements.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41f45c016aa84b591e9851d832f151b74396bfa3","unresolved":true,"context_lines":[{"line_number":8,"context_line":"tempest\u003e\u003d27.0.0 # Apache-2.0"},{"line_number":9,"context_line":"os-traits\u003e\u003d0.15.0 # Apache-2.0"},{"line_number":10,"context_line":"python-observabilityclient\u003e\u003d0.3.0 # Apache-2.0"},{"line_number":11,"context_line":"prometheus_client\u003e\u003d0.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"344294a2_1bbef7a8","line":11,"updated":"2025-02-04 16:02:43.000000000","message":"im not sure how i feel about takign the prometheus_client as a depency fo the plugin.\n\nif we can do everthing we need via the python-observabilityclient that would be preferable as we currently dont use the prometheus_client in watcher itself so I\u0027m not sure we shoudl be extenedign our deps in the tempest plugin.\n\nthis will have packaging implications that we may be able to avoid if python-observabilityclient is sufficent.","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f745ec6bb658fc7f07ec7065b91d9155abc33d92","unresolved":true,"context_lines":[{"line_number":8,"context_line":"tempest\u003e\u003d27.0.0 # Apache-2.0"},{"line_number":9,"context_line":"os-traits\u003e\u003d0.15.0 # Apache-2.0"},{"line_number":10,"context_line":"python-observabilityclient\u003e\u003d0.3.0 # Apache-2.0"},{"line_number":11,"context_line":"prometheus_client\u003e\u003d0.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"0e5e0d68_aa656185","line":11,"in_reply_to":"344294a2_1bbef7a8","updated":"2025-02-10 13:55:35.000000000","message":"right, we should be able to use a PrometheusAPIClient object to get/post everything that we need. It would be also aligned with the implementation on watcher side.","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"}],"watcher_tempest_plugin/config.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f745ec6bb658fc7f07ec7065b91d9155abc33d92","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        \"datasource\","},{"line_number":31,"context_line":"        default\u003d\"gnocchi\","},{"line_number":32,"context_line":"        choices\u003d[\"gnocchi\", \"prometheus\"],"},{"line_number":33,"context_line":"        help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":34,"context_line":"        \"Defaut is gnocchi. Other options are gnocchi\""},{"line_number":35,"context_line":"        \"prometheus\","},{"line_number":36,"context_line":"    ),"},{"line_number":37,"context_line":"    cfg.StrOpt("},{"line_number":38,"context_line":"        \"prometheus_service_url\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9340b3f2_2e5a2e93","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":21},"updated":"2025-02-10 13:55:35.000000000","message":"I think that we can improve this help message and explain what the plugin will actually do, which is populate with metrics. Also, I would drop the info about default and options. If we generate a proper doc, this info will be there already. wdyt?","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41f45c016aa84b591e9851d832f151b74396bfa3","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        default\u003d\"127.0.0.1:9091\","},{"line_number":45,"context_line":"        help\u003d\"Prometheus push gateway url\","},{"line_number":46,"context_line":"    ),"},{"line_number":47,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"852b4db6_8e02312a","line":47,"updated":"2025-02-04 16:02:43.000000000","message":"we proably shoudl align the cofnig option to be similar between the service and tempest pluging so taking host/port and ca seperately","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f745ec6bb658fc7f07ec7065b91d9155abc33d92","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        default\u003d\"127.0.0.1:9091\","},{"line_number":45,"context_line":"        help\u003d\"Prometheus push gateway url\","},{"line_number":46,"context_line":"    ),"},{"line_number":47,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5d0e8485_d22d1b30","line":47,"in_reply_to":"852b4db6_8e02312a","updated":"2025-02-10 13:55:35.000000000","message":"+1\n[1] https://github.com/openstack/watcher/blob/master/watcher/conf/prometheus_client.py","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"}],"watcher_tempest_plugin/infra_optim_clients.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41f45c016aa84b591e9851d832f151b74396bfa3","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from tempest.lib.services.placement import placement_client"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from watcher_tempest_plugin.services.infra_optim.v1.json import client as ioc"},{"line_number":27,"context_line":"from watcher_tempest_plugin.services.metric.v1.json import client as gc"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b5fb044d_763e79fa","line":27,"range":{"start_line":27,"start_character":69,"end_line":27,"end_character":71},"updated":"2025-02-04 16:02:43.000000000","message":"gc stands for gnocci client.\n\nwe probably shoudl address that too.","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"}],"watcher_tempest_plugin/services/metric/v1/json/client.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41f45c016aa84b591e9851d832f151b74396bfa3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from datetime import datetime"},{"line_number":21,"context_line":"from observabilityclient import prometheus_client"},{"line_number":22,"context_line":"from oslo_serialization import jsonutils"},{"line_number":23,"context_line":"from prometheus_client import CollectorRegistry"},{"line_number":24,"context_line":"from prometheus_client import Gauge"},{"line_number":25,"context_line":"from prometheus_client import push_to_gateway"},{"line_number":26,"context_line":"from tempest.lib import exceptions"},{"line_number":27,"context_line":"from watcher_tempest_plugin.services import base"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b056712c_53426e29","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":45},"updated":"2025-02-04 16:02:43.000000000","message":"the openstack convetnio is to import moduels not classes or functions so you shoudl not be importign these directly\n\ni also dong think access to teh class defintions is  sufficent reason to include \n\nprometheus_client as a depency","commit_id":"e27ff77d7a63d438d8f46b803ee03bb6113d08d8"}]}