)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a816d1499620994ff99bf5041436c91557700fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a9c2d6aa_be69e8a4","updated":"2025-01-20 13:52:55.000000000","message":"tks chandan! providing some feedback since is not marked as WIP?","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3d91af2e73bb169e82ecb18cc96be59de39d4ef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba018592_0dbd2ad2","updated":"2025-01-22 11:35:56.000000000","message":"Loos good Chandan, tks for the updates","commit_id":"44a9c1785ad736e44b165df59523f8d1d3c455bf"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"43ef1e80afd834d19b1b76ecfa40cfc5290153d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bdc81692_91e982d1","updated":"2025-01-23 11:26:39.000000000","message":"looks good with current changes - thank you","commit_id":"44a9c1785ad736e44b165df59523f8d1d3c455bf"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"22025625bbe0b203069872fa8207c4a70e44de97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c049fbdb_731ad5e4","updated":"2025-01-24 11:22:22.000000000","message":"+1: ps was just rebased. thanks","commit_id":"9f45cd63e4d11d649c1e6ff1ad6d12d940416883"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bdb7193475ecece56accbd8f77201ceae0551b25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ccdc9d30_d65bca57","updated":"2025-01-24 07:29:29.000000000","message":"re-adding vote\nlooks like no updates/only rebases since my last visit","commit_id":"9f45cd63e4d11d649c1e6ff1ad6d12d940416883"}],"watcher_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a816d1499620994ff99bf5041436c91557700fe3","unresolved":true,"context_lines":[{"line_number":242,"context_line":"            instance \u003d self.mgr.servers_client.show_server("},{"line_number":243,"context_line":"                instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":244,"context_line":"            created_instances.append(instance)"},{"line_number":245,"context_line":"            if CONF.optimize.datasource \u003d\u003d \"gnocchi\":"},{"line_number":246,"context_line":"                self.make_instance_statistic(instance, metrics\u003dmetrics)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return created_instances"}],"source_content_type":"text/x-python","patch_set":4,"id":"5328c1c0_541600c8","line":245,"range":{"start_line":245,"start_character":12,"end_line":245,"end_character":53},"updated":"2025-01-20 13:52:55.000000000","message":"shoudn\u0027t you always call make_instances_statistic here, since you already have a datasource check inside it?","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dcf1ef41b79bdd8b12220da75c7a3fc6c77c869f","unresolved":true,"context_lines":[{"line_number":242,"context_line":"            instance \u003d self.mgr.servers_client.show_server("},{"line_number":243,"context_line":"                instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":244,"context_line":"            created_instances.append(instance)"},{"line_number":245,"context_line":"            if CONF.optimize.datasource \u003d\u003d \"gnocchi\":"},{"line_number":246,"context_line":"                self.make_instance_statistic(instance, metrics\u003dmetrics)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return created_instances"}],"source_content_type":"text/x-python","patch_set":4,"id":"abca52cb_ae5b8388","line":245,"range":{"start_line":245,"start_character":12,"end_line":245,"end_character":53},"in_reply_to":"5328c1c0_541600c8","updated":"2025-01-21 13:43:05.000000000","message":"there are two functions, make_instance_statistic and make_host_statistic. I have taken similar approach and added the datasource check with in the function itself.","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3d91af2e73bb169e82ecb18cc96be59de39d4ef0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            instance \u003d self.mgr.servers_client.show_server("},{"line_number":243,"context_line":"                instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":244,"context_line":"            created_instances.append(instance)"},{"line_number":245,"context_line":"            if CONF.optimize.datasource \u003d\u003d \"gnocchi\":"},{"line_number":246,"context_line":"                self.make_instance_statistic(instance, metrics\u003dmetrics)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return created_instances"}],"source_content_type":"text/x-python","patch_set":4,"id":"7260ab7e_24b2978d","line":245,"range":{"start_line":245,"start_character":12,"end_line":245,"end_character":53},"in_reply_to":"abca52cb_ae5b8388","updated":"2025-01-22 11:35:56.000000000","message":"Done","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a816d1499620994ff99bf5041436c91557700fe3","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        if CONF.optimize.datasource \u003d\u003d \"gnocchi\":"},{"line_number":311,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":312,"context_line":"        else:"},{"line_number":313,"context_line":"            # Add 5 sec sleep to send metric via node_exporter"},{"line_number":314,"context_line":"            # to prometheus server."},{"line_number":315,"context_line":"            time.sleep(5)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":318,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":4,"id":"29da4a7d_c838fbf5","line":315,"range":{"start_line":312,"start_character":0,"end_line":315,"end_character":25},"updated":"2025-01-20 13:52:55.000000000","message":"so, 2 things to consider: that we can have another datasource type supported, so the best is to compare with \u003d\u003d \u0027prometheus\u0027 to take any action on prometheus, otherwise \"do nothing\"\nanother thing is that these sleep may work from one environment and not to another, don\u0027t we have another way to check if data is there? before proceeding? with a loop and a timeout?","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dcf1ef41b79bdd8b12220da75c7a3fc6c77c869f","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        if CONF.optimize.datasource \u003d\u003d \"gnocchi\":"},{"line_number":311,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":312,"context_line":"        else:"},{"line_number":313,"context_line":"            # Add 5 sec sleep to send metric via node_exporter"},{"line_number":314,"context_line":"            # to prometheus server."},{"line_number":315,"context_line":"            time.sleep(5)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":318,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":4,"id":"5439513a_59351ddf","line":315,"range":{"start_line":312,"start_character":0,"end_line":315,"end_character":25},"in_reply_to":"29da4a7d_c838fbf5","updated":"2025-01-21 13:43:05.000000000","message":"Thank you Doug for the suggestion. I think we need to keep datasource empty as you have already commented in previous patch. I will update the same.","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3d91af2e73bb169e82ecb18cc96be59de39d4ef0","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        if CONF.optimize.datasource \u003d\u003d \"gnocchi\":"},{"line_number":311,"context_line":"            self.make_host_statistic_gnocchi(metrics)"},{"line_number":312,"context_line":"        else:"},{"line_number":313,"context_line":"            # Add 5 sec sleep to send metric via node_exporter"},{"line_number":314,"context_line":"            # to prometheus server."},{"line_number":315,"context_line":"            time.sleep(5)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def make_host_statistic_gnocchi(self, metrics\u003ddict()):"},{"line_number":318,"context_line":"        \"\"\"Create host resource and its measures in Gnocchi DB"}],"source_content_type":"text/x-python","patch_set":4,"id":"89dfcd8f_3a7bbc38","line":315,"range":{"start_line":312,"start_character":0,"end_line":315,"end_character":25},"in_reply_to":"5439513a_59351ddf","updated":"2025-01-22 11:35:56.000000000","message":"Done","commit_id":"02c9f92bebc6d5e3c71c5ca2020a5fb8436ee3c5"}]}