)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d7e7281827c8d2bdb92d54a792e807965a39f642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fc202c3_390d332b","updated":"2025-01-28 06:52:23.000000000","message":"Thank you @mtembo@redhat.com for merging the two reviews https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517 and https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136 into single one.\n\nBut somehow new review got created. I think we can reuse existing review https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136 and add this code review changes in this review 938136.\n\nIt will help reviewer to avoid switching the context.","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e802a021b35d70ef7a597988f52895e38cff333d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d59635bd_560b8c8f","updated":"2025-01-28 06:55:03.000000000","message":"why do we need this as a separate patch i mean why not include this in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136\n\nif you are going to have it as a separate patch, then may as well keep @chkumar@redhat.com patch https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517 \n\n(apologies if i missed this being discussed already)","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"ff83c5531d4bf5709968057912aa0653fd66249f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97afb743_7f736464","in_reply_to":"8b6ce3fe_299e5d76","updated":"2025-01-28 11:39:37.000000000","message":"@mandreou@redhat.com you did not miss any discussion. It was a mistake on my part with creating a seperate patch. \nPlease find the (original) updated patch here: https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"ff83c5531d4bf5709968057912aa0653fd66249f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76f30071_b7e8e367","in_reply_to":"9fc202c3_390d332b","updated":"2025-01-28 11:39:37.000000000","message":"Hello @chandan.kumar@imaginea.com. I think that is a better approach. I will reuse \n https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"521c4c2c1a3e044d220cbd8acaf38f5388e9238c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b6ce3fe_299e5d76","in_reply_to":"d59635bd_560b8c8f","updated":"2025-01-28 06:56:00.000000000","message":"ah it appears Chandan and I added a similar comment at about the same time ;)","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"}],"watcher_tempest_plugin/config.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e802a021b35d70ef7a597988f52895e38cff333d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"gnocchi is a supported datasources. use \u0027\u0027\""},{"line_number":34,"context_line":"                    \"for no datasource\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"0afe5700_b11f5f6f","line":31,"updated":"2025-01-28 06:55:03.000000000","message":"why are we removing prometheus from here though","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b476a5f0d666174dbeed97be21df5dcfe850bb89","unresolved":true,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"gnocchi is a supported datasources. use \u0027\u0027\""},{"line_number":34,"context_line":"                    \"for no datasource\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f631f99_71ae11cb","line":31,"in_reply_to":"0afe5700_b11f5f6f","updated":"2025-01-28 08:22:14.000000000","message":"as discussed with Malinga just now... \n\nI think the idea is we wait for Alfredo patch at https://review.opendev.org/c/openstack/watcher/+/938893 to add the vm metrics and then we can iterate to add prometheus here\n\nso fine to not have prometheus here for now\n\nbut please squash your patches into one this is hard to follow vs https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136\n\nyou\u0027re not actually removing prometheus here... it is actually first added in the parent patch 938136 ... so lets just not have it in the first place","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"ff83c5531d4bf5709968057912aa0653fd66249f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"OptimizationGroup \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\"datasource\","},{"line_number":30,"context_line":"               default\u003d\"gnocchi\","},{"line_number":31,"context_line":"               choices\u003d[\"gnocchi\", \"\"],"},{"line_number":32,"context_line":"               help\u003d\"Name of the data source used with the Watcher Service\""},{"line_number":33,"context_line":"                    \"gnocchi is a supported datasources. use \u0027\u0027\""},{"line_number":34,"context_line":"                    \"for no datasource\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa2c1dab_1c5e2f57","line":31,"in_reply_to":"7f631f99_71ae11cb","updated":"2025-01-28 11:39:37.000000000","message":"@mandreou@redhat.com , prometheus has now been removed. See https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136","commit_id":"e32ea7d8c629efc4328997cb8b02bc616a15e5ac"}]}