)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2f100e72102f3f4c1a64f60613a9ddf570229365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e93dc648_988f227a","updated":"2025-03-03 07:33:50.000000000","message":"Thank you Doug for improving the logging and exception.\n\nAll the watcher tempest plugin scenario tests are passing:\nhttps://logserver.rdoproject.org/99/99/f08a00d0360aebfd603d3024f34356e70487057c/github-check/watcher-operator-validation-master/5e88bbc/controller/ci-framework-data/tests/test_operator/tempest-tests-tempest/stestr_results.html\n\nCommand logging https://logserver.rdoproject.org/99/99/f08a00d0360aebfd603d3024f34356e70487057c/github-check/watcher-operator-validation-master/5e88bbc/controller/ci-framework-data/tests/test_operator/tempest-tests-tempest/tempest.log\n```\n2025-02-28 19:31:45.348 109 DEBUG watcher_tempest_plugin.services.metric.prometheus_client [-] Configuring PromtoolClient for podified  deployment. __init__ /var/lib/tempest/external-plugins/.venv/lib64/python3.9/site-packages/watcher_tempest_plugin/services/metric/prometheus_client.py:37\n2025-02-28 19:31:45.348 109 DEBUG watcher_tempest_plugin.services.metric.prometheus_client [-] Getting prometheus service pod names. get_prometheus_pod /var/lib/tempest/external-plugins/.venv/lib64/python3.9/site-packages/watcher_tempest_plugin/services/metric/prometheus_client.py:188\n2025-02-28 19:31:45.348 109 DEBUG watcher_tempest_plugin.services.base [-] Executing command \u0027KUBECONFIG\u003d/home/zuul/.crc/machines/crc/kubeconfig oc -n openstack get pods -o\u003dname --field-selector\u003dstatus.phase\u003dRunning -l app.kubernetes.io/name\u003dprometheus | cut -d\u0027/\u0027 -f 2; true\u0027 on host \u002738.102.83.230\u0027 exec_cmd /var/lib/tempest/external-plugins/.venv/lib64/python3.9/site-packages/watcher_tempest_plugin/services/base.py:308\n```","commit_id":"7faed28e23d3b9ae528aba9993c6470891d72e8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"edca78c706ab890dca5bbd4d8a112c3bdc3341bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a896ec7_ca6ddc1e","updated":"2025-03-03 18:51:13.000000000","message":"there are some valid nits but i think includign this as is to stablise teh flaky test is more imporant then a respin.\n\nif this fails in ci and needs to be rebased then we should fix the two other cases of return vs returns","commit_id":"7faed28e23d3b9ae528aba9993c6470891d72e8c"}],"watcher_tempest_plugin/services/base.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"3d12dbf27381fa32c95e879a42f789f2ab95603f","unresolved":true,"context_lines":[{"line_number":227,"context_line":"            or a sequence of arguments."},{"line_number":228,"context_line":"        :param input_data: data to be sent to process stdin"},{"line_number":229,"context_line":"        :param timeout: communication timeout in seconds"},{"line_number":230,"context_line":"        :return: output written to stdout."},{"line_number":231,"context_line":"        :raises: Exception when command fails."},{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"82ef8fbf_2dd6732e","line":230,"updated":"2025-03-03 12:04:57.000000000","message":"should we also change return to returns here as well?","commit_id":"7faed28e23d3b9ae528aba9993c6470891d72e8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"edca78c706ab890dca5bbd4d8a112c3bdc3341bd","unresolved":true,"context_lines":[{"line_number":227,"context_line":"            or a sequence of arguments."},{"line_number":228,"context_line":"        :param input_data: data to be sent to process stdin"},{"line_number":229,"context_line":"        :param timeout: communication timeout in seconds"},{"line_number":230,"context_line":"        :return: output written to stdout."},{"line_number":231,"context_line":"        :raises: Exception when command fails."},{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b9231a3_98d1ae2b","line":230,"in_reply_to":"82ef8fbf_2dd6732e","updated":"2025-03-03 18:51:13.000000000","message":"technically yes.\n\nwe dont actully use this go generate typing or docs content so while it would be more important if we did we can defer this to a follow up\n\ni have not checked fi we have other cases wehre its inconcistent but ideally we would have one patch to fix all cases.","commit_id":"7faed28e23d3b9ae528aba9993c6470891d72e8c"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"3d12dbf27381fa32c95e879a42f789f2ab95603f","unresolved":true,"context_lines":[{"line_number":243,"context_line":"          or a sequence of arguments."},{"line_number":244,"context_line":"        :param input_data: data to be sent to process stdin"},{"line_number":245,"context_line":"        :param timeout: communication timeout in seconds"},{"line_number":246,"context_line":"        :return: output written to stdout."},{"line_number":247,"context_line":"        :raises: Exception when command fails."},{"line_number":248,"context_line":"        \"\"\""},{"line_number":249,"context_line":"        LOG.debug(f\"Executing command \u0027{cmd}\u0027 with input data \u0027{input_data}\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"f4e3fb6a_c97194ba","line":246,"updated":"2025-03-03 12:04:57.000000000","message":"same","commit_id":"7faed28e23d3b9ae528aba9993c6470891d72e8c"}],"watcher_tempest_plugin/tests/scenario/test_execute_zone_migration.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"edca78c706ab890dca5bbd4d8a112c3bdc3341bd","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            instance[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":64,"context_line":"        node \u003d instance.get(\u0027OS-EXT-SRV-ATTR:hypervisor_hostname\u0027)"},{"line_number":65,"context_line":"        # Wait for the instance to be added in compute model"},{"line_number":66,"context_line":"        self.wait_for_instances_in_model([instance])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        vacant_node \u003d [hyp[\u0027hypervisor_hostname\u0027] for hyp"},{"line_number":69,"context_line":"                       in self.get_hypervisors_setup()"}],"source_content_type":"text/x-python","patch_set":2,"id":"8334fc2c_54a20398","line":66,"updated":"2025-03-03 18:51:13.000000000","message":"this is impartant to stablise the test.\n\nthis may have been better as a sepreate patch but we can do a partial backport of this if needed.","commit_id":"7faed28e23d3b9ae528aba9993c6470891d72e8c"}]}