)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"fdedc2983fc92426c014977edf1b1dbbf2bbe80b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a0611c4_22e6cb20","updated":"2025-05-08 19:47:16.000000000","message":"recheck","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"90c0bb796f582f82a9c93f2a95f89154a467062c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b297b6d3_8508eb9c","updated":"2025-05-26 13:48:05.000000000","message":"LGTM, waiting Sean\u0027s review in this one.\n\nFrom pep8 job:\n```\ncmd: check-uuid --package watcher_tempest_plugin\nexit_code: 0\n```","commit_id":"0023e39c73d9565199bdab36b7bb37074e253e19"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"59f791408826f50cb1d475c4fda1c4d73b7d08cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b207d362_fabb163b","updated":"2025-05-20 10:05:54.000000000","message":"https://33807c6af0e20453b14c-c0af318d07ef9bf7ba9a60c77add6086.ssl.cf5.rackcdn.com/openstack/2e61ece9894346e6bc23328da18cb1be/job-output.txt\n```\npep8: 1814 W commands[3]\u003e check-uuid --package watcher_tempest_plugin [tox/tox_env/api.py:434]\n2025-05-13 09:43:51.150704 | ubuntu-noble | /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin/.tox/pep8/lib/python3.12/site-packages/oslo_utils/eventletutils.py:29: DeprecationWarning: eventuletutils module is deprecated and will be removed.\n2025-05-13 09:43:51.150770 | ubuntu-noble |   debtcollector.deprecate(\n2025-05-13 09:43:51.337591 | ubuntu-noble | /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin/.tox/pep8/lib/python3.12/site-packages/tempest/lib/common/jsonschema_validator.py:21: DeprecationWarning: Accessing jsonschema.draft4_format_checker is deprecated and will be removed in a future release. Instead, use the FORMAT_CHECKER attribute on the corresponding Validator.\n2025-05-13 09:43:51.337675 | ubuntu-noble |   FORMAT_CHECKER \u003d jsonschema.draft4_format_checker\n2025-05-13 09:43:51.337706 | ubuntu-noble | /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin/.tox/pep8/lib/python3.12/site-packages/tempest/lib/common/jsonschema_validator.py:42: DeprecationWarning: FormatChecker.cls_checks is deprecated. Call FormatChecker.checks on a specific FormatChecker instance instead.\n2025-05-13 09:43:51.337730 | ubuntu-noble |   @jsonschema.FormatChecker.cls_checks(\u0027base64\u0027)\n2025-05-13 09:43:51.538515 | ubuntu-noble | /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin/.tox/pep8/lib/python3.12/site-packages/tempest/lib/services/volume/v2/__init__.py:50: DeprecationWarning: The tempest.lib.services.volume.v2 module (volume v2 APIs service clients) is deprecated in favor of tempest.lib.services.volume.v3 (volume v3 APIs service clients) and will be removed once Tempest stop supporting stable wallaby.\n2025-05-13 09:43:51.538648 | ubuntu-noble |   warnings.warn(\n2025-05-13 09:43:51.773614 | ubuntu-noble | /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin/watcher_tempest_plugin/tests/client_functional/__init__.py:20: DeprecationWarning: The \u0027watcher_tempest_plugin.tests.client_functional\u0027 module usage is deprecated and will be removed in version \u00272026.1\u0027, please use watcherclient.tests.client_functional instead: The \u0027watcher_tempest_plugin.tests.client_functional\u0027 module is deprecated and will be removed in version 2026.1. We recommend using watcherclient.tests.client_functional for running functional tests.\n2025-05-13 09:43:51.773749 | ubuntu-noble |   removals.removed_module(\n2025-05-13 09:43:51.773915 | ubuntu-noble | /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin/watcher_tempest_plugin/tests/client_functional/__init__.py:20: DeprecationWarning: The \u0027watcher_tempest_plugin.tests.client_functional.__init__\u0027 module usage is deprecated and will be removed in version \u00272026.1\u0027, please use watcherclient.tests.client_functional instead: The \u0027watcher_tempest_plugin.tests.client_functional\u0027 module is deprecated and will be removed in version 2026.1. We recommend using watcherclient.tests.client_functional for running functional tests.\n2025-05-13 09:43:51.773924 | ubuntu-noble |   removals.removed_module(\n2025-05-13 09:43:52.025303 | ubuntu-noble | pep8: 2910 I exit 0 (1.09 seconds) /home/zuul/src/opendev.org/openstack/watcher-tempest-plugin\u003e check-uuid --package watcher_tempest_plugin pid\u003d2166 [tox/execute/api.py:294]\n2025-05-13 09:43:52.026619 | ubuntu-noble |   pep8: OK (2.57\u003dsetup[0.07]+cmd[0.36,0.62,0.43,1.09] seconds)\n2025-05-13 09:43:52.026633 | ubuntu-noble |   congratulations :) (2.67 seconds)\n2025-05-13 09:43:52.268630 | ubuntu-noble | ok: Runtime: 0:00:03.034175\n```\nLooks good!","commit_id":"0023e39c73d9565199bdab36b7bb37074e253e19"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d2a6a1de91489dce6bb5ab439e4bdb001bb96b26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c6b7c868_512738e3","updated":"2025-05-13 09:40:47.000000000","message":"recheck","commit_id":"0023e39c73d9565199bdab36b7bb37074e253e19"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ec4f661123761ee2e5137d744ad170f040c165ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"df884cc4_d3399432","in_reply_to":"b297b6d3_8508eb9c","updated":"2025-05-26 13:59:10.000000000","message":"so eventully we should simplfy the pep8 target to effectivly use pre-commit to replace each of the commands but there i no rush to do that so we can get to that whenever.\n\nFor now I\u0027m fine with the curretn change.","commit_id":"0023e39c73d9565199bdab36b7bb37074e253e19"}],"test-requirements.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52e21b5976b74ae453b18bd48cf8c37cc877ad6b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"WebTest\u003e\u003d2.0.27 # MIT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# check-uuid"},{"line_number":24,"context_line":"tempest\u003e\u003d40.0.0 # Apache-2.0"},{"line_number":25,"context_line":"os-traits\u003e\u003d0.15.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"478b7f0a_2a916936","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":30},"updated":"2025-05-09 00:56:04.000000000","message":"these are both runtime depencies so you shoudl nto need to list them again in test requirements","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6e0d1e4c6b38116c060d030b7367ed690dfbe2fd","unresolved":true,"context_lines":[{"line_number":21,"context_line":"WebTest\u003e\u003d2.0.27 # MIT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# check-uuid"},{"line_number":24,"context_line":"tempest\u003e\u003d40.0.0 # Apache-2.0"},{"line_number":25,"context_line":"os-traits\u003e\u003d0.15.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"0bfb3196_9562b252","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":30},"in_reply_to":"478b7f0a_2a916936","updated":"2025-05-09 08:37:27.000000000","message":"ok, adding -r{toxinidir}/requirements.txt as mentioned on https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/949178/comment/41ea1e82_ef3caca1/ makes this not necessary","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52e21b5976b74ae453b18bd48cf8c37cc877ad6b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"install_command \u003d pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} {opts} {packages}"},{"line_number":11,"context_line":"setenv \u003d"},{"line_number":12,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":13,"context_line":"deps \u003d"},{"line_number":14,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":15,"context_line":"commands \u003d stestr run --slowest {posargs}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"41ea1e82_ef3caca1","line":13,"updated":"2025-05-09 00:56:04.000000000","message":"this is a bug\n\nit shoudl also be including  -r{toxinidir}/requirements.txt","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6e0d1e4c6b38116c060d030b7367ed690dfbe2fd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"install_command \u003d pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} {opts} {packages}"},{"line_number":11,"context_line":"setenv \u003d"},{"line_number":12,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":13,"context_line":"deps \u003d"},{"line_number":14,"context_line":"    -r{toxinidir}/test-requirements.txt"},{"line_number":15,"context_line":"commands \u003d stestr run --slowest {posargs}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"01e0c492_a1522dfd","line":13,"in_reply_to":"41ea1e82_ef3caca1","updated":"2025-05-09 08:37:27.000000000","message":"Done","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52e21b5976b74ae453b18bd48cf8c37cc877ad6b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    doc8 doc/source/ CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":20,"context_line":"    flake8"},{"line_number":21,"context_line":"    bandit -r watcher_tempest_plugin -x tests -n5 -ll"},{"line_number":22,"context_line":"    check-uuid --package watcher_tempest_plugin"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1357bdf7_db9eaf72","line":22,"updated":"2025-05-09 00:56:04.000000000","message":"we should move over to pre-commit for most of our linting as we have done\nfor watcher but im ok with adding this for now.\n\nit is https://github.com/openstack/tempest/blob/master/setup.cfg#L34 yes?\n\nlooking at the code \nhttps://github.com/openstack/tempest/blob/master/tempest/lib/cmd/check_uuid.py\n\nit seam to enforce that all the test have static test uuids correct?\ni.e. it enfoces that they have @decorators.idempotent_id applied","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6e0d1e4c6b38116c060d030b7367ed690dfbe2fd","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    doc8 doc/source/ CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":20,"context_line":"    flake8"},{"line_number":21,"context_line":"    bandit -r watcher_tempest_plugin -x tests -n5 -ll"},{"line_number":22,"context_line":"    check-uuid --package watcher_tempest_plugin"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":4,"id":"8298249d_686f97ed","line":22,"in_reply_to":"1357bdf7_db9eaf72","updated":"2025-05-09 08:37:27.000000000","message":"so check-uuid only checks if all functions has the decorator applied, and it makes pop8 fails if any do not have it.\n\nI added another environment with check-uud --fix, which creates the decorator if it is not present.\n\nI got the idea from the tox file of cinder https://github.com/openstack/cinder-tempest-plugin/blob/master/tox.ini","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52e21b5976b74ae453b18bd48cf8c37cc877ad6b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d"},{"line_number":26,"context_line":"    {[testenv]setenv}"},{"line_number":27,"context_line":"    PYTHON\u003dcoverage run --source ironic_tempest_plugin --parallel-mode"},{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"    stestr run {posargs}"},{"line_number":30,"context_line":"    coverage combine"}],"source_content_type":"text/x-properties","patch_set":4,"id":"ef630c31_14777f72","line":27,"range":{"start_line":27,"start_character":33,"end_line":27,"end_character":54},"updated":"2025-05-09 00:56:04.000000000","message":"also this should be watcher","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6e0d1e4c6b38116c060d030b7367ed690dfbe2fd","unresolved":true,"context_lines":[{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"setenv \u003d"},{"line_number":26,"context_line":"    {[testenv]setenv}"},{"line_number":27,"context_line":"    PYTHON\u003dcoverage run --source ironic_tempest_plugin --parallel-mode"},{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"    stestr run {posargs}"},{"line_number":30,"context_line":"    coverage combine"}],"source_content_type":"text/x-properties","patch_set":4,"id":"b323114e_696e076c","line":27,"range":{"start_line":27,"start_character":33,"end_line":27,"end_character":54},"in_reply_to":"ef630c31_14777f72","updated":"2025-05-09 08:37:27.000000000","message":"good catch","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52e21b5976b74ae453b18bd48cf8c37cc877ad6b","unresolved":true,"context_lines":[{"line_number":77,"context_line":"extension\u003d.rst"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"[testenv:uuidgen]"},{"line_number":80,"context_line":"commands \u003d check-uuid --fix --package watcher_tempest_plugin"}],"source_content_type":"text/x-properties","patch_set":4,"id":"181af2d3_65450868","line":80,"updated":"2025-05-09 00:56:04.000000000","message":"and then this can fix them\n\n\nby adding check-uuid to the pep8 target it will automatically be enfoced in ci which is good but it alos means you need ot fix any missisng ids in this patch too\n\nor it will fail the pep8 job.\n\ni guess we currently are not missing any so making sure we dont regress is nice.","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6e0d1e4c6b38116c060d030b7367ed690dfbe2fd","unresolved":true,"context_lines":[{"line_number":77,"context_line":"extension\u003d.rst"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"[testenv:uuidgen]"},{"line_number":80,"context_line":"commands \u003d check-uuid --fix --package watcher_tempest_plugin"}],"source_content_type":"text/x-properties","patch_set":4,"id":"9f0564ba_3539aff9","line":80,"in_reply_to":"181af2d3_65450868","updated":"2025-05-09 08:37:27.000000000","message":"yes, pep8 wont fix, just checks and fails if there is a missing uuid.","commit_id":"57b499a137ed12f01876198f5e27768eb714a974"}]}