)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a17663c39b65f6aea0252b112b4cb32025c8bca1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     morenod \u003cdsanzmor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-13 15:11:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for workload balance with real data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8980b025526175a43aaa1c7231ff89ae45279b2e"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/watcher/+/951639"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"6c6fc511_a0d68968","line":7,"updated":"2025-06-16 14:24:01.000000000","message":"why?\n\nwe do not want to have per stragy tests that use real data.\n\nwe only want to have basic coverage of the querise used by watcher internally.","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d5f581cfd470cd7d9cbc5a3c77fad243424a889d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     morenod \u003cdsanzmor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-13 15:11:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for workload balance with real data"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8980b025526175a43aaa1c7231ff89ae45279b2e"},{"line_number":10,"context_line":"Depends-On: https://review.opendev.org/c/openstack/watcher/+/951639"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"fa25edce_ffd1fbbe","line":7,"in_reply_to":"6c6fc511_a0d68968","updated":"2025-06-17 09:39:27.000000000","message":"if we have real data tests for workload balance, we need it for any other strategy that uses metrics for taking decisions","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"83a66dbeb59a5ad38d0ddf50d3e849f8de45ccd7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3716f47_b7177820","updated":"2025-05-20 07:08:10.000000000","message":"recheck","commit_id":"5f225e16d19003041a1cb4362c3c8b0e68112409"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"34eb21072f86746f3c3ee7840ce37fc9d03dfea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02b2758b_46a60e1a","in_reply_to":"c3716f47_b7177820","updated":"2025-05-20 07:08:47.000000000","message":"Done","commit_id":"5f225e16d19003041a1cb4362c3c8b0e68112409"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e028934fe9bb440c51a0a821011da6e80d3a1728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82c303e7_fe720c5d","updated":"2025-05-21 11:31:03.000000000","message":"recheck","commit_id":"249ed327d95fe1fe6498e59a1c0e1c3b5db3c732"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"818778c2f4217628479a09d184c80a4c466c6c77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fd8c6d13_afd67a23","updated":"2025-05-22 09:25:53.000000000","message":"check experimental","commit_id":"192a87004233fe09d3297c8e86fba5717b8ce8ac"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"379ed3698bbb131360a1f2260332c000c8f89d2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c64ee0e4_733506b7","updated":"2025-05-22 15:40:09.000000000","message":"Hi guys, the real tests are ready to review, the experimental pipeline is the only where they have been executed","commit_id":"15b6bcec940b26427a6163f3b92e00638df43a5a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c1b1989ac46a8c978f9e6c6dfe2b95c46236ef4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7c8c534_a994e041","updated":"2025-05-26 07:30:07.000000000","message":"Overall looks good, one small improvement!","commit_id":"15b6bcec940b26427a6163f3b92e00638df43a5a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"b8ba3f16d405706db36ea8802f0f49366ec54f46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf0937f0_32b30b5b","updated":"2025-05-22 11:54:08.000000000","message":"check experimental","commit_id":"15b6bcec940b26427a6163f3b92e00638df43a5a"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4fccf1f6bd6211ace6246b89b9c5b5a28df3547b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4810a2e9_20539f48","updated":"2025-06-03 08:16:43.000000000","message":"There is an issue with the command to generate ram consumption. I also have doubts about how the strategy is managing metrics. Some comments inline.","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"12a767535cfcc45485808d5d409ca40e65e2c34e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a2a5dbd2_08561c16","updated":"2025-05-26 13:58:51.000000000","message":"check experimental","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"cfe4f37a66859920fc2ceb6944d8ecd503348149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0f9b08a7_d82ae897","updated":"2025-06-03 10:19:10.000000000","message":"check experimental","commit_id":"d0f211f2fdf1c76a115dd1db58a928ed3750527f"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e51cc984fb4cfe1eeac13365628a6926697eeddc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"43d3a9c0_0299ff7e","updated":"2025-06-03 10:06:22.000000000","message":"recheck","commit_id":"d0f211f2fdf1c76a115dd1db58a928ed3750527f"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"640135c162a13939e020033eb022503f810385a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"969c2ddd_c1d670a6","updated":"2025-06-03 12:29:16.000000000","message":"check experimental","commit_id":"823bfc34a8198b25ec37d898920c3097e2bc2b3c"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"81c2fb7468fe220d5458fac52de494cec0af61b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a2c59af6_876fd883","updated":"2025-06-03 13:45:35.000000000","message":"check experimental","commit_id":"771594f47c7fda0d27852bcb3a5c7e5ec07bd1c7"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"238e482f5a893e5f65fdc2977bd12669d84683e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ad9043f8_c3981248","updated":"2025-06-03 15:08:35.000000000","message":"check experimental","commit_id":"bdc87a7383c687cdff20690c7a8552dd50ebceda"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"7bb9c7d0b30e1dd908ed4f855c59f953a7fd9ba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5d8a6690_c6968af6","updated":"2025-06-04 06:13:22.000000000","message":"check experimental","commit_id":"fc3b73a8f4669db5221b02249e1b7be9f6136667"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d4286d879f89dacbaf8d2fdeddd7ae677488a83e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"81c097bd_0b9c6cbd","updated":"2025-06-04 10:21:40.000000000","message":"check experimental","commit_id":"32315ec43ad8e4a0568f776bd915e3946db2a900"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"bfbba7340d79843996d4aa262e93823f0e32c916","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"fbcba696_614bbdf5","updated":"2025-06-05 08:00:57.000000000","message":"check experimental","commit_id":"0064c3f0359fc78e542ff3ded44c9393e73f80bd"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"0bdc0e35a86f2a7819cab50adbda0e97e45d99ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e7c347e0_00c7987a","updated":"2025-06-05 09:28:22.000000000","message":"check experimental","commit_id":"778f44d1a50d8fa35fbf2ca621b85019bd57b094"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"ea9af3524063ae015b1214586667404b4b542c11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b8fb404d_d8877c9e","updated":"2025-06-05 10:37:54.000000000","message":"check experimental","commit_id":"69f00a04b6dc2f6521724437ec9d30518f23b90f"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"9482a2f0b248a2caaea8cf42bf5470323cc96f47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"df38d9f4_3bc0d153","updated":"2025-06-05 12:28:49.000000000","message":"check experimental","commit_id":"68d3efb9f1865dcafa2db2607d1b2a3ce40aa647"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"eadd7925e6ad59274d9e35fa65f7b4270d9ead0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"4669403a_a4af0bc5","updated":"2025-06-05 14:35:39.000000000","message":"check experimental","commit_id":"e3a0f287965c49388af2e9562147acc620b0080b"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e8f67f50f471ac78ce5e28a16d3ea24ea15b779b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"c94d031c_7082bae4","updated":"2025-06-05 13:38:47.000000000","message":"check experimental","commit_id":"e3a0f287965c49388af2e9562147acc620b0080b"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"92f30c3a1d36c78ef01b7882c4d282d21bdefded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0083dbc2_e0693b53","updated":"2025-06-06 10:52:12.000000000","message":"check experimental","commit_id":"1b1b96607b3dec3b9a268b2d9f958c272938b8ed"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6f1f164bb71b50b563d78e5495cf25699080fb04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0a61593f_7e30b091","updated":"2025-06-06 11:47:29.000000000","message":"check experimental","commit_id":"1b1b96607b3dec3b9a268b2d9f958c272938b8ed"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"f361f7ddb398a55c8e3e1767f5fabe74c268aec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"9c99f7d5_6d971e31","updated":"2025-06-06 13:01:53.000000000","message":"check experimental","commit_id":"1b1b96607b3dec3b9a268b2d9f958c272938b8ed"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"656754f0d1ede4d67e145f875dd441474e4bb08c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"bc695e9a_57f5a1f4","updated":"2025-06-06 08:07:55.000000000","message":"check experimental","commit_id":"1b1b96607b3dec3b9a268b2d9f958c272938b8ed"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"0a185f694c84dadfa718da45508628529a0cce7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"992eb2a6_a1e6e149","updated":"2025-06-06 10:07:31.000000000","message":"recheck","commit_id":"1b1b96607b3dec3b9a268b2d9f958c272938b8ed"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"875883890d8caaa5849991a71198dc10318cb57e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"036d0dec_552c1d52","updated":"2025-06-09 13:09:32.000000000","message":"check experimental","commit_id":"9442c565c1d189d570874a4749d60ac4ddf9fd3e"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d41d6f844f0346e9228f146bef1a788d5f3e061c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"a91500a2_500475ef","updated":"2025-06-09 11:40:13.000000000","message":"check experimental","commit_id":"9442c565c1d189d570874a4749d60ac4ddf9fd3e"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"5e1477f9c3cbe20225231b61345cadeb06962694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"e40fc83d_adfa356e","updated":"2025-06-09 14:46:38.000000000","message":"check experimental","commit_id":"9442c565c1d189d570874a4749d60ac4ddf9fd3e"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"129b52a3516664377bcdd4da18e299983e972eba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"b5203516_cff6e9c9","updated":"2025-06-10 09:02:55.000000000","message":"check experimental","commit_id":"b3d8ed77ed968ff92ed762e9fcd0a33896624f0e"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"44607f7d72af79e66ffa6923b6ad3d16ceef007e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"077ab9ca_0882feb0","updated":"2025-06-10 13:39:10.000000000","message":"check experimental","commit_id":"d02adf63092445a15a3a4ccea98962ea1499af21"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"1af94d48b44ae3e29e7d4440e731d965065347d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"dae8d48f_51472873","updated":"2025-06-11 08:17:42.000000000","message":"check experimental","commit_id":"d02adf63092445a15a3a4ccea98962ea1499af21"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"559e8314b76f4f41c61620597b14e93156b225e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"f1f7bf16_28c2fecc","updated":"2025-06-12 20:24:14.000000000","message":"Looks good, still not sure if the ram test is what we were expecting, but since it runs only in experimental pipeline, it will not affect the gate in case it gets unstable. But the multiple runs of it are all passing. I\u0027m ok merging it.","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"4b80b75230dfe668c8bf517857aadaae416ae064","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"0b317811_2c24e01f","updated":"2025-06-11 22:07:55.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"ab3f0df67f94c68c555f745949c7dc5e07a2d4f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"79ce8e8c_332bc435","updated":"2025-06-11 14:52:53.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"ee196f6ba2587e201b19488d55c01d52aa2f0adb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"7fb9c4c5_df5da7e9","updated":"2025-06-11 20:52:43.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"db127b7323c5d918730317d0618d76f195e67f2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"b6a09da6_ceb793c9","updated":"2025-06-12 06:47:04.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"7c874ff20331ab140efe5ec266dea74401adfd19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"cd4f3a1f_27426683","updated":"2025-06-11 12:46:44.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e4824d7053f600e03ca9dfd8b393d6112c4b8ec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"d588528b_d6cf4e99","updated":"2025-06-11 19:44:00.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"02c24487ed51ccbe1ba7bdd2ffc474be3dcb2adb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ee383b81_c744a4a1","updated":"2025-06-12 13:24:49.000000000","message":"check experimental","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e96d9faaf91d5de9d5b3bc153c2e9c38578aae3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"52207770_4e48c8f4","updated":"2025-06-12 10:30:44.000000000","message":"recheck","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"3b1a841d2af974e8cfe51ee74c770387319e0330","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ad02c6bb_2ebc36e4","updated":"2025-06-12 06:47:12.000000000","message":"recheck","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"0c6963a6d64cdce480f08e6ad362d1f93d913fba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"b16a33fc_ed677804","updated":"2025-06-12 13:24:54.000000000","message":"recheck","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"53ba87561754d949deb3ce93f768d1d25c64f71b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"cc19ee34_cc4c6973","updated":"2025-06-12 09:08:32.000000000","message":"recheck","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d9c20742142a9c42b5f135fea90183c7b4486eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"f8803660_244a338f","updated":"2025-06-11 14:05:24.000000000","message":"recheck","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6332d9ec6b2fc18c431f4da8b09b84cbd30350fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"8c007ea3_49cdd23b","updated":"2025-06-16 11:59:26.000000000","message":"Thanks","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"06367c93dac7af2023d9d741d375ec8937c83d2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"1280c031_974c4a9f","updated":"2025-06-13 18:15:36.000000000","message":"check experimental","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"8d775848d24026d0381e6a6be33d7f7ede79b5ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"13c1eb64_61967319","updated":"2025-06-13 21:04:20.000000000","message":"check experimental","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"42ff891e452986940cb1dcff3e252a5497005519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"5546f5cc_257d9042","updated":"2025-06-13 17:05:36.000000000","message":"check experimental","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"06ff782f1f2bb4075eab114a4dfa08688d351cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"a3fd6e24_e9a77ce4","updated":"2025-06-17 12:15:36.000000000","message":"check experimental","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"45c7a5189a5cfe6a409fe8ffe2bb8e17c0b2dbd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"c434c215_c001fcc3","updated":"2025-06-13 13:11:47.000000000","message":"check experimental","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a17663c39b65f6aea0252b112b4cb32025c8bca1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"765ec567_00510a30","updated":"2025-06-16 14:24:01.000000000","message":"im not sure this type of testing should be done or is in scope.\n\nplease provide more context on this as i would not consider a feature sufficnnelty tested if it only has real data test and over time i would like use to not get too relient on this. type of testing.","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d5f581cfd470cd7d9cbc5a3c77fad243424a889d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"afd672dc_327e2678","in_reply_to":"765ec567_00510a30","updated":"2025-06-17 09:39:27.000000000","message":"this is a requirement for new strategies. if they are based on metrics, I was required to add fake and real data tests for all the metrics, in this case, cpu and ram","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"99d3cd22096e5efa39a74fdf0fa5ca24062a8a81","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"40e9be7c_87a55711","in_reply_to":"839c7a0b_491d983c","updated":"2025-06-17 12:20:06.000000000","message":"We don\u0027t have any real_load test covering use of memory metrics. IMO this is a gap and we should have at least one real_load test based on memory. Past issues showed it helps catching issues related to metrics gathering system. For me adding test_workload_balance_strategy_ram is a strong +1 (i have not +2 :) ) \n\nIMO having real_load test for cpu in workload_balance is also a good thing and an improvement to coverage as, specially taking into account that we run this only in experimental and given the difficulties that we have had wrt simulating metrics.","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"81ac06c8a88019526c5230594dddd075e37d734f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":32,"id":"839c7a0b_491d983c","in_reply_to":"afd672dc_327e2678","updated":"2025-06-17 10:07:25.000000000","message":"so i feel like i hsould be elevating this to a -2\n\nthat is ablsolutely not a requirement\n\nit was eixplity a non-goal to add real data test for all stragies new or old.","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"cf270918e8400aaab48d84a9fc38cea13dfb2bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"72bd6cb9_a60bb0bd","updated":"2025-06-18 12:02:05.000000000","message":"I\u0027m still not really sure that the RAM test is going to be stable, due to values in logs that are close to the threshold [1]:\n\n```\nJun 17 18:05:38.762320 np0041151170 watcher-decision-engine[100400]: DEBUG watcher.decision_engine.strategy.strategies.workload_balance [None req-68e31286-f786-49b7-b1dd-5f220e3197d8 None None] Host np0041151171 evaluated as destination for 68a7c1f5-bc91-45d9-8113-36efc30c27b0. Host usage for ram would be 1.4102122048006194.The threshold is: 2. selected: True {{(pid\u003d100400)\n```\n\nBut, since this is an experimental job, it will not block our gate, so that\u0027s why my vote is +2.\n\nSetting workflow to -1: we can check with watcher team, including Sean Mooney, at irc channel or weekly meeting if everybody is ok to merge this. If we agree on merging, we can release.\n\n[1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a8f/openstack/a8f0c12ea30648b0b5975686ec57dce3/controller/logs/screen-watcher-decision-engine.txt","commit_id":"c6f36a8beb9524f6113d47cc7760a58c3666b087"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a1bebbd4c4234645106a5b20ec950d6f4d366c44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"c6e34a9f_ea991179","updated":"2025-06-20 17:20:39.000000000","message":"Removing W-1 from this patch. We agreed that is ok to have these additional real data tests since we don\u0027t have any that cover RAM scenario.\nThis patch still depends-on on patch that have not merged yet , or it should be rebased on top of this another refactor: https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/952884\nIt will depends on which approach is close to merge.\nMerging https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/952559 does not block from merging the refactoring afterwards.","commit_id":"c6f36a8beb9524f6113d47cc7760a58c3666b087"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"cd028d67921604da8dd91011a226c2a934e19173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"761ff5e1_5bdd4ca6","updated":"2025-06-18 05:41:04.000000000","message":"Since these new tests are added to real strategies and it runs in experimental pipeline, It will not impact the existing CI.\n\nThank you for updating the commit message, looks good.","commit_id":"c6f36a8beb9524f6113d47cc7760a58c3666b087"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"877532422ea92ebb9f7d66ddc6b734a9a2c25032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"6c9c5938_dd58c394","updated":"2025-06-18 05:40:02.000000000","message":"check experimental","commit_id":"c6f36a8beb9524f6113d47cc7760a58c3666b087"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"b0b0535dd1891566eb8d3215fa0035311177d668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"c5382a8c_acd41e31","updated":"2025-06-17 17:18:41.000000000","message":"check experimental","commit_id":"c6f36a8beb9524f6113d47cc7760a58c3666b087"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e1ebfc7bebe493fd4b4eb8a676b9d85497b6a6d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"62dad12a_e93ce7ea","updated":"2025-06-23 14:06:42.000000000","message":"Overall looks good. https://e19cc3c363aec878e5fe-59609554a432e7e8aa7eb757d01d2dcd.ssl.cf5.rackcdn.com/openstack/138acb7904a049e38a3aa722248c7977/testr_results.html","commit_id":"2215030decd329ccc7fdc38fa787b8e08b74c72a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"514b8843b796848abf3090bffbd36b41cc577984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"04c4f982_51076229","updated":"2025-06-23 11:40:39.000000000","message":"check experimental","commit_id":"2215030decd329ccc7fdc38fa787b8e08b74c72a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"82244ee60ac79c704bd9b66bc44397053900d36b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"28765c71_0a099c8e","updated":"2025-06-23 09:11:21.000000000","message":"check experimental","commit_id":"2215030decd329ccc7fdc38fa787b8e08b74c72a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"90fc9f7bb0fce1f267aad4292e8edc5772dd2b72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"f0b4c47e_7a782858","updated":"2025-06-23 07:32:36.000000000","message":"check experimental","commit_id":"2215030decd329ccc7fdc38fa787b8e08b74c72a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9cc23cd1be91038099be8c8962807d6bd32a5be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"bd188049_6311132a","updated":"2025-06-23 14:59:56.000000000","message":"lgtm, thanks!","commit_id":"2215030decd329ccc7fdc38fa787b8e08b74c72a"}],"watcher_tempest_plugin/tests/scenario/test_execute_strategies_real.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c1b1989ac46a8c978f9e6c6dfe2b95c46236ef4c","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        INJECT_METRICS \u003d False"},{"line_number":64,"context_line":"        self.addCleanup(self.rollback_compute_nodes_status)"},{"line_number":65,"context_line":"        self.addCleanup(self.wait_delete_instances_from_model)"},{"line_number":66,"context_line":"        instances \u003d self._create_one_instance_per_host_with_statistic("},{"line_number":67,"context_line":"            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],"},{"line_number":68,"context_line":"            inject\u003dINJECT_METRICS)"},{"line_number":69,"context_line":"        instances +\u003d self._create_one_instance_per_host_with_statistic("},{"line_number":70,"context_line":"            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],"},{"line_number":71,"context_line":"            inject\u003dINJECT_METRICS)"},{"line_number":72,"context_line":"        instances +\u003d self._create_one_instance_per_host_with_statistic("},{"line_number":73,"context_line":"            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],"},{"line_number":74,"context_line":"            inject\u003dINJECT_METRICS)"},{"line_number":75,"context_line":"        self._pack_all_created_instances_on_one_host(instances)"},{"line_number":76,"context_line":"        # wait for compute model updates"},{"line_number":77,"context_line":"        self.wait_for_instances_in_model(instances)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1756b7fb_317a5fcb","line":74,"range":{"start_line":66,"start_character":8,"end_line":74,"end_character":34},"updated":"2025-05-26 07:30:07.000000000","message":"Can we write it like this, It will avoid repetition and make more readable?\n```suggestion\n        instances \u003d []\nfor _ in range(3):\n    instances.extend(\n        self._create_one_instance_per_host_with_statistic(\n            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],\n            inject\u003dINJECT_METRICS\n        )\n    )\n\n```","commit_id":"15b6bcec940b26427a6163f3b92e00638df43a5a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"ddfd7d5bbb770f08340b6ace24744fa78578b513","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        INJECT_METRICS \u003d False"},{"line_number":64,"context_line":"        self.addCleanup(self.rollback_compute_nodes_status)"},{"line_number":65,"context_line":"        self.addCleanup(self.wait_delete_instances_from_model)"},{"line_number":66,"context_line":"        instances \u003d self._create_one_instance_per_host_with_statistic("},{"line_number":67,"context_line":"            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],"},{"line_number":68,"context_line":"            inject\u003dINJECT_METRICS)"},{"line_number":69,"context_line":"        instances +\u003d self._create_one_instance_per_host_with_statistic("},{"line_number":70,"context_line":"            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],"},{"line_number":71,"context_line":"            inject\u003dINJECT_METRICS)"},{"line_number":72,"context_line":"        instances +\u003d self._create_one_instance_per_host_with_statistic("},{"line_number":73,"context_line":"            run_command\u003dself.COMMANDS_CREATE_LOAD[\u0027instance_cpu_usage\u0027],"},{"line_number":74,"context_line":"            inject\u003dINJECT_METRICS)"},{"line_number":75,"context_line":"        self._pack_all_created_instances_on_one_host(instances)"},{"line_number":76,"context_line":"        # wait for compute model updates"},{"line_number":77,"context_line":"        self.wait_for_instances_in_model(instances)"}],"source_content_type":"text/x-python","patch_set":6,"id":"94047c3b_c0631406","line":74,"range":{"start_line":66,"start_character":8,"end_line":74,"end_character":34},"in_reply_to":"1756b7fb_317a5fcb","updated":"2025-05-26 09:32:14.000000000","message":"good idea, I have changed to it","commit_id":"15b6bcec940b26427a6163f3b92e00638df43a5a"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4fccf1f6bd6211ace6246b89b9c5b5a28df3547b","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # Commands used to create load for different metrics"},{"line_number":30,"context_line":"    COMMANDS_CREATE_LOAD \u003d dict("},{"line_number":31,"context_line":"        instance_cpu_usage\u003d\u0027nohup dd if\u003d/dev/random of\u003d/dev/null \u0026\u0027,"},{"line_number":32,"context_line":"        instance_ram_usage\u003d\u0027yes | head -c 1G \u003e/tmp/x \u0026\u0026 cat /tmp/x \u003e/dev/null\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"4efad8c6_ebf7cd8d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":2},"updated":"2025-06-03 08:16:43.000000000","message":"Good trick with the head -c, i like it.\n\nHowever, in my test in cirros it does not accept size in gig, only in bytes, kilobytes or megabytes.\n\n\t-c [-]N[kbm]\tPrint first N bytes\n\n\nAlso, I\u0027d adjust this based on the memory usage:\n\n```\nyes | head -c $(($(grep MemAvailable /proc/meminfo|awk \u0027{print $2}\u0027)*9/10))k \u003e/tmp/x\n```\nThat will use 90% of the available memory.","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e51cc984fb4cfe1eeac13365628a6926697eeddc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # Commands used to create load for different metrics"},{"line_number":30,"context_line":"    COMMANDS_CREATE_LOAD \u003d dict("},{"line_number":31,"context_line":"        instance_cpu_usage\u003d\u0027nohup dd if\u003d/dev/random of\u003d/dev/null \u0026\u0027,"},{"line_number":32,"context_line":"        instance_ram_usage\u003d\u0027yes | head -c 1G \u003e/tmp/x \u0026\u0026 cat /tmp/x \u003e/dev/null\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e2538e4b_91d11006","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":2},"in_reply_to":"4efad8c6_ebf7cd8d","updated":"2025-06-03 10:06:22.000000000","message":"Done","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4fccf1f6bd6211ace6246b89b9c5b5a28df3547b","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        audit_parameters \u003d {"},{"line_number":83,"context_line":"            \"metrics\": \"instance_cpu_usage\","},{"line_number":84,"context_line":"            \"threshold\": 10,"},{"line_number":85,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":86,"context_line":"            \"granularity\": int(CONF.optimize.real_workload_period/4)}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1ab918e5_1acfe08b","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":2},"updated":"2025-06-03 08:16:43.000000000","message":"I have doubts on this. \n\nAssuming 8vCPUs compute nodes, fully loading 2 vms with 1vcpu would mean 25% of cpu usage. We shouldn\u0027t need 6 instances for a threshold of 10. I understand some deviation from the expected values because of granularity and period parameters but not so much.\n\nThe strategy does not log the calculated value of resources used in the host, which is what compares with the threshold so it\u0027s hard to guess what is happening.","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e51cc984fb4cfe1eeac13365628a6926697eeddc","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        audit_parameters \u003d {"},{"line_number":83,"context_line":"            \"metrics\": \"instance_cpu_usage\","},{"line_number":84,"context_line":"            \"threshold\": 10,"},{"line_number":85,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":86,"context_line":"            \"granularity\": int(CONF.optimize.real_workload_period/4)}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3c2cc512_1cf5f096","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":2},"in_reply_to":"1ab918e5_1acfe08b","updated":"2025-06-03 10:06:22.000000000","message":"Acknowledged","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4fccf1f6bd6211ace6246b89b9c5b5a28df3547b","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        audit_parameters \u003d {"},{"line_number":112,"context_line":"            \"metrics\": \"instance_ram_usage\","},{"line_number":113,"context_line":"            \"threshold\": 1,"},{"line_number":114,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":115,"context_line":"            \"granularity\": CONF.optimize.real_workload_period}"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"e29ce9b4_4d11a68b","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":2},"updated":"2025-06-03 08:16:43.000000000","message":"we could slighly increase this threashold, 1% (i.e. assuming 8GB host and having 2 192MB instances at 90% mem usage would be ~ 4%).\n\nAnyway, even with such a low value, this test should be enough to check that the metrics gathering and querying system is working properly and basic functionality of the strategy for ram.","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e51cc984fb4cfe1eeac13365628a6926697eeddc","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        audit_parameters \u003d {"},{"line_number":112,"context_line":"            \"metrics\": \"instance_ram_usage\","},{"line_number":113,"context_line":"            \"threshold\": 1,"},{"line_number":114,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":115,"context_line":"            \"granularity\": CONF.optimize.real_workload_period}"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"67e81d6d_7d3f39fd","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":2},"in_reply_to":"e29ce9b4_4d11a68b","updated":"2025-06-03 10:06:22.000000000","message":"Acknowledged","commit_id":"f1808df543e1d57d60371a4775c1b9be773f1c23"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"559e8314b76f4f41c61620597b14e93156b225e5","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            inject\u003dINJECT_METRICS,"},{"line_number":74,"context_line":"            num_instances\u003d4"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        self._pack_all_created_instances_on_one_host(instances)"},{"line_number":77,"context_line":"        # wait for compute model updates"},{"line_number":78,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":79,"context_line":"        # This is the time that we want to generate metrics"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f4bede1_507c4214","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":52},"updated":"2025-06-12 20:24:14.000000000","message":"one thing that we should improve is to create a new method or change the existing _create_instances_per_host_with_statistic to create instances in only one host, so we could avoid these instance migrations from this method. Makes sense? Not related to this patch, but something to work when we have some time.","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"a9986b0cb7288d4a2755970bc0e384a38d0ab15b","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            inject\u003dINJECT_METRICS,"},{"line_number":74,"context_line":"            num_instances\u003d4"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        self._pack_all_created_instances_on_one_host(instances)"},{"line_number":77,"context_line":"        # wait for compute model updates"},{"line_number":78,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":79,"context_line":"        # This is the time that we want to generate metrics"}],"source_content_type":"text/x-python","patch_set":31,"id":"5f3dea98_742db6aa","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":52},"in_reply_to":"3f4bede1_507c4214","updated":"2025-06-13 09:00:12.000000000","message":"yes, I\u0027ve also considered that for a future release to avoid this function and needing to take care about the model","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"1e2c49805baa80d1cab85f3f68ecc0e2126ff15d","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            inject\u003dINJECT_METRICS,"},{"line_number":74,"context_line":"            num_instances\u003d4"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        self._pack_all_created_instances_on_one_host(instances)"},{"line_number":77,"context_line":"        # wait for compute model updates"},{"line_number":78,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":79,"context_line":"        # This is the time that we want to generate metrics"}],"source_content_type":"text/x-python","patch_set":31,"id":"72f66fd9_01d86fa6","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":52},"in_reply_to":"5f3dea98_742db6aa","updated":"2025-06-13 13:08:10.000000000","message":"it was easier than expected\n\nhttps://review.opendev.org/c/openstack/watcher-tempest-plugin/+/952559","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"559e8314b76f4f41c61620597b14e93156b225e5","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        audit_parameters \u003d {"},{"line_number":114,"context_line":"            \"metrics\": \"instance_ram_usage\","},{"line_number":115,"context_line":"            \"threshold\": 2,"},{"line_number":116,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":117,"context_line":"            \"granularity\": 300}"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"2fc8541f_f01e7e76","line":115,"range":{"start_line":115,"start_character":25,"end_line":115,"end_character":26},"updated":"2025-06-12 20:24:14.000000000","message":"2%? is the command generating the load in the end? I don\u0027t really know how to generate this memory load using bash tbh.\nI see that the real load job is passing, but not sure if is going to pass also in other environments, where hosts could have more memory available.","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"a9986b0cb7288d4a2755970bc0e384a38d0ab15b","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        audit_parameters \u003d {"},{"line_number":114,"context_line":"            \"metrics\": \"instance_ram_usage\","},{"line_number":115,"context_line":"            \"threshold\": 2,"},{"line_number":116,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":117,"context_line":"            \"granularity\": 300}"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"39e6cdc7_cf9e3597","line":115,"range":{"start_line":115,"start_character":25,"end_line":115,"end_character":26},"in_reply_to":"2fc8541f_f01e7e76","updated":"2025-06-13 09:00:12.000000000","message":"we are using flavors with ~190MB of RAM and loading them around 80-90%. Even creating 2-3 instances per host, they are ~7000MB of RAM so the impact on loading instances on them is really low","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6332d9ec6b2fc18c431f4da8b09b84cbd30350fe","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        audit_parameters \u003d {"},{"line_number":114,"context_line":"            \"metrics\": \"instance_ram_usage\","},{"line_number":115,"context_line":"            \"threshold\": 2,"},{"line_number":116,"context_line":"            \"period\": CONF.optimize.real_workload_period,"},{"line_number":117,"context_line":"            \"granularity\": 300}"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"16bcebda_f862cc77","line":115,"range":{"start_line":115,"start_character":25,"end_line":115,"end_character":26},"in_reply_to":"39e6cdc7_cf9e3597","updated":"2025-06-16 11:59:26.000000000","message":"ack, indeed we need another flavor with more memory to make an impact in the total amount of ram. We could take a look on that for future tests. Thanks","commit_id":"5576ad91f06286e4ad23a315c6c039a7f3419665"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a17663c39b65f6aea0252b112b4cb32025c8bca1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    @decorators.idempotent_id(\u0027672a7a4d-91a0-4753-a7a4-be28db8c1bfb\u0027)"},{"line_number":66,"context_line":"    def test_workload_balance_strategy_cpu(self):"},{"line_number":67,"context_line":"        # This test does not require metrics injection"},{"line_number":68,"context_line":"        INJECT_METRICS \u003d False"},{"line_number":69,"context_line":"        self.addCleanup(self.rollback_compute_nodes_status)"},{"line_number":70,"context_line":"        self.addCleanup(self.wait_delete_instances_from_model)"},{"line_number":71,"context_line":"        instances \u003d self._create_instances_per_host_with_statistic("}],"source_content_type":"text/x-python","patch_set":32,"id":"a1f55a11_534b5652","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":30},"updated":"2025-06-16 14:24:01.000000000","message":"in general i would prefer if hte real data test just verifed that he metrics we need exist and are repored correctly reahter then building out a parrlel set of thest that use real data.\n\nthe majority of our testing should not require real data so i don on want to beuidl out a exhaustive test suite for each strategy that uses real data.\n\nI specifically do not trust real data testing to be stable in CI over time.","commit_id":"5d4ffd38fd442f335b177acb673b27f23d692ca5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e1ebfc7bebe493fd4b4eb8a676b9d85497b6a6d6","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super(TestRealExecuteStrategies, cls).skip_checks()"},{"line_number":44,"context_line":"        if not CONF.network_feature_enabled.floating_ips:"},{"line_number":45,"context_line":"            raise cls.skipException("},{"line_number":46,"context_line":"                \"network_feature_enabled.floating_ips option must be enabled\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":35,"id":"26d048e7_35d4e4c8","line":46,"range":{"start_line":44,"start_character":1,"end_line":46,"end_character":78},"updated":"2025-06-23 14:06:42.000000000","message":"I think this code is not needed. As we are not doing anything related to floating ips. Now the tests look good and much cleaner now.","commit_id":"2215030decd329ccc7fdc38fa787b8e08b74c72a"}]}