)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2cb6a667e0c1fe65bce4f33a976512c6ac6e0df4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c06cd49d_e7eca7d0","updated":"2025-05-29 05:30:08.000000000","message":"Based on discussion, we are going to keep this file and reuse this file to add future tests here for host maintenance strategy.","commit_id":"ab3e91dd34bcf1d6fd24977c7e05518407d79541"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"09f5463b277a5a58828c6b4755c4fa0db20faf04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4fa80d36_a3ad50b4","updated":"2025-05-28 06:57:59.000000000","message":"Since we are removing the file, Do we need a release notes here to avoid issues if anyone running tests using this file?","commit_id":"ab3e91dd34bcf1d6fd24977c7e05518407d79541"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"7e89ff2f927757a0fe1823ef01826e61cd653a59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5c082ce7_8268e58c","updated":"2025-05-27 08:34:20.000000000","message":"recheck","commit_id":"ab3e91dd34bcf1d6fd24977c7e05518407d79541"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"85f834a00d3b353eaffa8c1ffad7ab1aeec272fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5636f124_a68f6ddf","in_reply_to":"c06cd49d_e7eca7d0","updated":"2025-05-29 07:53:10.000000000","message":"based on the talk, I have removed the host_maintenance tests from test_execute_strategies and updated the ones on tests_execute_host_maintenance with the latest code we have for strategy tests using the common function for executing the strategy which verifies the actions","commit_id":"ab3e91dd34bcf1d6fd24977c7e05518407d79541"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"a91958cc68cac16fb521bc74e1876d6e94dca19b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"07dd0d62_3492a45f","updated":"2025-06-02 07:35:39.000000000","message":"recheck","commit_id":"4d857a39f345be10d84fce29e22b3a19aa9ced75"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"8f31a4bf9e3b7b1b9d30770c61962c3de1879d95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1b83ebd0_c7a3b230","updated":"2025-06-02 18:28:57.000000000","message":"recheck","commit_id":"4d857a39f345be10d84fce29e22b3a19aa9ced75"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"f137f5f8779dda4553eb9bdb0b36df6f742dc0f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"98061852_bd00a31c","updated":"2025-05-30 16:06:32.000000000","message":"recheck","commit_id":"4d857a39f345be10d84fce29e22b3a19aa9ced75"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6757e7f5a28f86291971a7019b60ee820459a168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f147e6de_59021271","updated":"2025-06-03 06:34:11.000000000","message":"recheck","commit_id":"4d857a39f345be10d84fce29e22b3a19aa9ced75"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"56494e515948939e6bc6c9110ae4b2d9ac539527","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"09636b97_b1308901","updated":"2025-06-04 06:14:37.000000000","message":"recheck","commit_id":"225ce411bb007cccd087a80934ad983150ad7b66"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"765f7332fac16d3fd91207eb33cffc9c7717107d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a5e893e4_b9993257","updated":"2025-06-06 05:41:33.000000000","message":"Moving tests from one file to another, looks good based on https://3737a6b1ea4fc714d01b-164d5a3be9b73b43cf7bfb5d1ec3d41f.ssl.cf1.rackcdn.com/openstack/7dacdc67037f42e3bf001589155b7408/testr_results.html","commit_id":"50be2920d15b391cd395480c60c900b5e211d6df"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8ec69245fd608bc8680920ffa161dbd5e766ecac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1684b56a_4289389d","updated":"2025-06-09 04:56:43.000000000","message":"It needs some updates!","commit_id":"4d77b51807f3557eee40bfcb10f169811bcfc4aa"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"037646811329cf34ada605ee6f52bd2e343f4f4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"17b406b4_a94f6e1c","updated":"2025-06-09 11:05:14.000000000","message":"Looks good now","commit_id":"558b855697e184d59d327927a1adadb79d426794"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"cdcc49a2b55461a6daaaafaf1f98c09874a02a7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"a78fb411_2adbae8a","updated":"2025-06-10 07:16:55.000000000","message":"Fixed merge conflict with change for common procedure for enabled compute nodes","commit_id":"c99e552d5e34eea90bb2ad0586b8eb3df5efec63"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"555269aa026a45be3075c3753befdfef741415df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5aed73a3_0a05b9ea","updated":"2025-06-11 11:10:55.000000000","message":"LGTM, thanks\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5f3/openstack/5f3e53bb031b4477ba928a00e4611a0a/testr_results.html","commit_id":"307a3e6f14f7bff924c61f6b1882ef5953b69188"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"1100fc0cfddca8de818624f80201da074c8fc4fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7ae32f27_91f8842f","updated":"2025-06-11 08:09:08.000000000","message":"lgtm now, thanks David","commit_id":"307a3e6f14f7bff924c61f6b1882ef5953b69188"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6ba0fe581244c5eed81f2f70e4fb2402ff6684e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9cb38822_e775f3d3","updated":"2025-06-12 10:19:56.000000000","message":"recheck","commit_id":"307a3e6f14f7bff924c61f6b1882ef5953b69188"}],"watcher_tempest_plugin/tests/scenario/test_execute_host_maintenance.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"85c3e52e2893154897e51e9319b03cba65a6caaa","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    \"\"\"Tests for host_maintenance\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Minimal version required for _create_one_instance_per_host_with_statistic"},{"line_number":31,"context_line":"    compute_min_microversion \u003d \u00272.74\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    GOAL \u003d \"cluster_maintaining\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"aa279c99_82dcd576","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":2},"updated":"2025-06-06 07:17:55.000000000","message":"I guess you created this on top of https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/950389 ? we need to get it merged before in that case. Note that, I finally created a constant NOVA_API_VERSION_CREATE_WITH_HOST for it.","commit_id":"50be2920d15b391cd395480c60c900b5e211d6df"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"f7b0282fda9429562f405e55c73e3bf955f5b3c7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\"Tests for host_maintenance\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Minimal version required for _create_one_instance_per_host_with_statistic"},{"line_number":31,"context_line":"    compute_min_microversion \u003d \u00272.74\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    GOAL \u003d \"cluster_maintaining\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"669ca2fe_c638c33a","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":2},"in_reply_to":"aa279c99_82dcd576","updated":"2025-06-06 08:06:25.000000000","message":"ok I think I didnt rebased your change to the last patch. Now it is using the variable","commit_id":"50be2920d15b391cd395480c60c900b5e211d6df"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8ec69245fd608bc8680920ffa161dbd5e766ecac","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        self.execute_strategy(goal_name, strategy_name,"},{"line_number":110,"context_line":"                              expected_actions\u003d[\u0027change_nova_service_state\u0027,"},{"line_number":111,"context_line":"                                                \u0027migrate\u0027],"},{"line_number":112,"context_line":"                              **audit_kwargs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"efc878bb_c29aaa68","line":112,"updated":"2025-06-09 04:56:43.000000000","message":"this part https://github.com/openstack/watcher-tempest-plugin/commit/8aa31042302740929043f866e5540cf95af3ebf2#diff-f2bcae9ca3d555403ad3100f63f77c71eef9c7899858dd42f0ef8be36302f32aR98-R139 got missing while moving the tests.\n```\n# Make sure servers are migrated to backup node\nfor server in instances:\n    self.assertEqual(self.get_host_for_server(server[\u0027id\u0027]),\n                     backup_node)\n```","commit_id":"4d77b51807f3557eee40bfcb10f169811bcfc4aa"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"413e5fcbc604f6cf7bcc3bacd40fa034587b61b1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.execute_strategy(goal_name, strategy_name,"},{"line_number":110,"context_line":"                              expected_actions\u003d[\u0027change_nova_service_state\u0027,"},{"line_number":111,"context_line":"                                                \u0027migrate\u0027],"},{"line_number":112,"context_line":"                              **audit_kwargs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"0e910b7e_e2f646f4","line":112,"in_reply_to":"efc878bb_c29aaa68","updated":"2025-06-09 09:46:30.000000000","message":"restored","commit_id":"4d77b51807f3557eee40bfcb10f169811bcfc4aa"}],"watcher_tempest_plugin/tests/scenario/test_execute_strategies.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6dd7e29446e82a622130997dad32f01b7859d006","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        # wait for compute model updates"},{"line_number":176,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        vacant_node \u003d [hyp[\u0027hypervisor_hostname\u0027] for hyp"},{"line_number":179,"context_line":"                       in self.get_hypervisors_setup()"},{"line_number":180,"context_line":"                       if hyp[\u0027state\u0027] \u003d\u003d \u0027up\u0027"},{"line_number":181,"context_line":"                       and hyp[\u0027hypervisor_hostname\u0027] !\u003d node][0]"}],"source_content_type":"text/x-python","patch_set":17,"id":"695cf9e1_e5c99370","line":178,"updated":"2025-06-06 15:32:34.000000000","message":"this change does not look related ot the host maintenance strategy,unless I\u0027m missing something I would move it to a separate change","commit_id":"4d77b51807f3557eee40bfcb10f169811bcfc4aa"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8ec69245fd608bc8680920ffa161dbd5e766ecac","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        # wait for compute model updates"},{"line_number":176,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        vacant_node \u003d [hyp[\u0027hypervisor_hostname\u0027] for hyp"},{"line_number":179,"context_line":"                       in self.get_hypervisors_setup()"},{"line_number":180,"context_line":"                       if hyp[\u0027state\u0027] \u003d\u003d \u0027up\u0027"},{"line_number":181,"context_line":"                       and hyp[\u0027hypervisor_hostname\u0027] !\u003d node][0]"}],"source_content_type":"text/x-python","patch_set":17,"id":"a87f28c7_33bc71c8","line":178,"in_reply_to":"695cf9e1_e5c99370","updated":"2025-06-09 04:56:43.000000000","message":"Yes, correct, we donot need this change. We need to restore that.","commit_id":"4d77b51807f3557eee40bfcb10f169811bcfc4aa"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"413e5fcbc604f6cf7bcc3bacd40fa034587b61b1","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        # wait for compute model updates"},{"line_number":176,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        vacant_node \u003d [hyp[\u0027hypervisor_hostname\u0027] for hyp"},{"line_number":179,"context_line":"                       in self.get_hypervisors_setup()"},{"line_number":180,"context_line":"                       if hyp[\u0027state\u0027] \u003d\u003d \u0027up\u0027"},{"line_number":181,"context_line":"                       and hyp[\u0027hypervisor_hostname\u0027] !\u003d node][0]"}],"source_content_type":"text/x-python","patch_set":17,"id":"a4e98af0_727b9256","line":178,"in_reply_to":"a87f28c7_33bc71c8","updated":"2025-06-09 09:46:30.000000000","message":"yes, you are correct, I mixed the two reviews.\n\nRestored","commit_id":"4d77b51807f3557eee40bfcb10f169811bcfc4aa"}]}