)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"836db246f5ad58dc00e2afef064fd61c751c6278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cee0c84_056a923a","updated":"2025-09-30 15:42:02.000000000","message":"so, iiuc, this is kind of testing the same case that was implemented in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/955775 as the api testing should not cover the applier part of the workflow, right? if so, I think we should reduce the coverage of the TestPatchAction.test_skip_action to only update the value of state and status_message an then read it back.","commit_id":"ebaf6e20f1d892913764d0fdc46fd393918dc5a9"}],"watcher_tempest_plugin/tests/scenario/test_execute_dummy_optim.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"836db246f5ad58dc00e2afef064fd61c751c6278","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        _, action_plan \u003d self.client.show_action_plan(action_plan[\u0027uuid\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        if action_plan[\u0027state\u0027] in [\u0027SUPERSEDED\u0027, \u0027SUCCEEDED\u0027]:"},{"line_number":143,"context_line":"            # This means the action plan is superseded so we cannot trigger it,"},{"line_number":144,"context_line":"            # or it is empty."},{"line_number":145,"context_line":"            return"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Get all actions"},{"line_number":148,"context_line":"        _, action_list \u003d self.client.list_actions("}],"source_content_type":"text/x-python","patch_set":1,"id":"1e4c66c7_a35d45f1","line":145,"range":{"start_line":142,"start_character":0,"end_line":145,"end_character":18},"updated":"2025-09-30 15:42:02.000000000","message":"In which case may the action_plan be in SUPERSEDED or SUCCEEDED at this point? wouldn\u0027t that imply some kind of error and be reflected as an failed test?","commit_id":"ebaf6e20f1d892913764d0fdc46fd393918dc5a9"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"836db246f5ad58dc00e2afef064fd61c751c6278","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        self.assertEqual(1, state_counter.get(\u0027SKIPPED\u0027))"},{"line_number":201,"context_line":"        self.assertEqual(2, state_counter.get(\u0027SUCCEEDED\u0027))"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        # Verify the skipped action kept its custom reason"},{"line_number":204,"context_line":"        skipped_actions \u003d [a for a in final_actions"},{"line_number":205,"context_line":"                           if a[\u0027state\u0027] \u003d\u003d \u0027SKIPPED\u0027]"},{"line_number":206,"context_line":"        self.assertEqual(1, len(skipped_actions))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        # Fetch full action details to get status_message"},{"line_number":209,"context_line":"        _, skipped_action_details \u003d self.client.show_action("},{"line_number":210,"context_line":"            skipped_actions[0][\u0027uuid\u0027])"},{"line_number":211,"context_line":"        self.assertIn(skip_reason,"},{"line_number":212,"context_line":"                      skipped_action_details[\u0027status_message\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df5094ed_583b682b","line":212,"range":{"start_line":203,"start_character":0,"end_line":212,"end_character":63},"updated":"2025-09-30 15:42:02.000000000","message":"IMO we may simplify this a bit by just saving in a variable the uuid of the action we modified in line 158, instead of searching for the SKIPPED action in the final_actions list. Also, with that we would make sure that the action marked as skipped is the same we modified.","commit_id":"ebaf6e20f1d892913764d0fdc46fd393918dc5a9"}]}