)]}'
{"watcher_tempest_plugin/tests/api/admin/base.py":[{"robot_id":"zuul","robot_run_id":"3c69287c48eb4d7d8fac599c534ccd1a","url":"https://zuul.teim.app/t/main/buildset/3c69287c48eb4d7d8fac599c534ccd1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"28e9590a8865d0141946233b026405de4a1261a2","patch_set":3,"id":"7bdb87c9_26ee1036","line":38,"updated":"2025-11-19 06:56:38.000000000","message":"Duplicate IDLE_STATES constant definition in both BaseCommon and BaseInfraOptimTest\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Could cause confusion about which IDLE_STATES is being used in inherited methods\n\n**Suggestion**:\nRemove the IDLE_STATES definition from BaseInfraOptimTest and use the one from BaseCommon to avoid duplication","commit_id":"f9bcd9693ea6ab8eba62b4bec1d68e41c111c156"},{"robot_id":"zuul","robot_run_id":"3c69287c48eb4d7d8fac599c534ccd1a","url":"https://zuul.teim.app/t/main/buildset/3c69287c48eb4d7d8fac599c534ccd1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"28e9590a8865d0141946233b026405de4a1261a2","patch_set":3,"id":"3128c08d_41459e3e","line":174,"updated":"2025-11-19 06:56:38.000000000","message":"Add docstring examples for create_action_plan method to clarify None return value handling\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Better documentation helps future test developers understand edge cases and proper usage patterns\n\n**Recommendation**:\nAdd example in docstring showing how to handle None return value and when it might occur","commit_id":"f9bcd9693ea6ab8eba62b4bec1d68e41c111c156"},{"robot_id":"zuul","robot_run_id":"ff76ff203f844bcfaa1a017995aad89a","url":"https://zuul.teim.app/t/main/buildset/ff76ff203f844bcfaa1a017995aad89a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d6c2163368e1180b0ce57730b4b75cfc49e37ab0","patch_set":4,"id":"5e41c2d9_54a6b7bb","line":182,"updated":"2025-11-19 09:17:11.000000000","message":"Consider adding proper exception handling for create_action_plan return value\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Would improve error handling consistency across test methods\n\n**Recommendation**:\nAdd explicit checks for None return value in calling methods or document when None can be returned","commit_id":"ca9abc67796ea848afd36acb472918a3e0197c6a"}],"watcher_tempest_plugin/tests/common/base.py":[{"robot_id":"zuul","robot_run_id":"3c69287c48eb4d7d8fac599c534ccd1a","url":"https://zuul.teim.app/t/main/buildset/3c69287c48eb4d7d8fac599c534ccd1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"28e9590a8865d0141946233b026405de4a1261a2","patch_set":3,"id":"2edf4f1a_3d46cae6","line":52,"updated":"2025-11-19 06:56:38.000000000","message":"Inconsistent cleanup strategy between test classes - BaseCommon uses addClassResourceCleanup while scenario tests use addCleanup\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Resource leaks could occur if cleanup methods are not properly inherited or overridden\n\n**Priority**: Before merge\n**Why This Matters**: Inconsistent resource cleanup patterns could lead to test isolation issues and resource leaks in CI environments\n\n**Recommendation**:\nStandardize on addClassResourceCleanup across all test classes or ensure scenario tests properly inherit and use BaseCommon\u0027s cleanup registration","commit_id":"f9bcd9693ea6ab8eba62b4bec1d68e41c111c156"},{"robot_id":"zuul","robot_run_id":"3c69287c48eb4d7d8fac599c534ccd1a","url":"https://zuul.teim.app/t/main/buildset/3c69287c48eb4d7d8fac599c534ccd1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"28e9590a8865d0141946233b026405de4a1261a2","patch_set":3,"id":"266b1f25_bbbf2a84","line":66,"updated":"2025-11-19 06:56:38.000000000","message":"Improve error handling in delete_audit_template to use call_and_ignore_notfound_exc pattern for consistency\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Consistent error handling across all deletion methods reduces maintenance burden\n\n**Recommendation**:\nReplace the try/except NotFound pattern with cls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc, cls.delete_audit_template, audit_template_uuid) approach","commit_id":"f9bcd9693ea6ab8eba62b4bec1d68e41c111c156"},{"robot_id":"zuul","robot_run_id":"3c69287c48eb4d7d8fac599c534ccd1a","url":"https://zuul.teim.app/t/main/buildset/3c69287c48eb4d7d8fac599c534ccd1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"28e9590a8865d0141946233b026405de4a1261a2","patch_set":3,"id":"d5945951_4775e048","line":144,"updated":"2025-11-19 06:56:38.000000000","message":"Potential resource leak in delete_audit method - action plan deletion doesn\u0027t verify success before proceeding to audit deletion\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: Action plans might remain in database if deletion fails silently, causing subsequent test failures\n\n**Priority**: Before merge\n**Why This Matters**: Silent failures in resource cleanup can cause cascade failures in test suites and waste resources in CI environments\n\n**Recommendation**:\nAdd verification that action plans are actually deleted before proceeding with audit deletion, or use call_and_ignore_notfound_exc pattern consistently","commit_id":"f9bcd9693ea6ab8eba62b4bec1d68e41c111c156"},{"robot_id":"zuul","robot_run_id":"ff76ff203f844bcfaa1a017995aad89a","url":"https://zuul.teim.app/t/main/buildset/ff76ff203f844bcfaa1a017995aad89a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d6c2163368e1180b0ce57730b4b75cfc49e37ab0","patch_set":4,"id":"62188fba_2c9043da","line":25,"updated":"2025-11-19 09:17:11.000000000","message":"Add audit state constants to BaseCommon for consistency\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Would improve maintainability and reduce hardcoded state strings\n\n**Recommendation**:\nAdd AUDIT_FINISHED_STATES constant to eliminate missing reference in scenario base","commit_id":"ca9abc67796ea848afd36acb472918a3e0197c6a"},{"robot_id":"zuul","robot_run_id":"ff76ff203f844bcfaa1a017995aad89a","url":"https://zuul.teim.app/t/main/buildset/ff76ff203f844bcfaa1a017995aad89a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d6c2163368e1180b0ce57730b4b75cfc49e37ab0","patch_set":4,"id":"db4f666d_2a0111cb","line":72,"updated":"2025-11-19 09:17:11.000000000","message":"Inconsistent error handling in resource cleanup methods\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: May hide deletion failures in test scenarios\n\n**Suggestion**:\nConsider adding logging when resources are not found during cleanup to aid debugging","commit_id":"ca9abc67796ea848afd36acb472918a3e0197c6a"},{"robot_id":"zuul","robot_run_id":"ff76ff203f844bcfaa1a017995aad89a","url":"https://zuul.teim.app/t/main/buildset/ff76ff203f844bcfaa1a017995aad89a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d6c2163368e1180b0ce57730b4b75cfc49e37ab0","patch_set":4,"id":"175165e3_83e973ab","line":87,"updated":"2025-11-19 09:17:11.000000000","message":"Missing parameter type documentation in create_audit method\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Reduces code documentation quality\n\n**Suggestion**:\nUpdate docstring to properly document the \u0027audit_type\u0027 parameter instead of \u0027type\u0027","commit_id":"ca9abc67796ea848afd36acb472918a3e0197c6a"}]}