)]}'
{"watcher_tempest_plugin/tests/scenario/base.py":[{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"d4923542_adedd9c2","line":332,"updated":"2026-05-05 12:09:55.000000000","message":"The _create_one_instance_per_host method signature change adds boot_from_volume\u003dFalse as a keyword argument with a default, preserving backward compatibility with all existing callers.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Clean API extension that does not break existing tests or require changes to other callers.\n\n**Recommendation**:\nNo action needed. The default value ensures backward compatibility and the parameter is well-documented in the docstring.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"}],"watcher_tempest_plugin/tests/scenario/test_execute_host_maintenance.py":[{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"2a70f65a_a7f015f8","line":139,"updated":"2026-05-05 12:09:55.000000000","message":"The test methods use comments rather than docstrings to describe test purpose. While this matches the existing pattern in the codebase, tempest tests benefit from docstrings for generated documentation.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Docstrings would improve test discoverability and could be consumed by test reporting tools.\n\n**Recommendation**:\nThis is a pre-existing pattern in the codebase and does not need to be fixed in this patch. If a documentation effort is started later, all tests in the plugin could be updated together.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"4683bf72_2b4ff870","line":147,"updated":"2026-05-05 12:09:55.000000000","message":"The host_maintenance BfV test has a comment on line 147 saying \u0027This test does not require metrics injection\u0027 but it still calls check_min_enabled_compute_nodes and addCleanup. The comment placement before the flavor-disk logic is slightly misleading.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Improved readability -- the comment was inherited from the non-BfV tests and is accurate (no metrics injection), but placing it above the flavor-disk setup block rather than at the top of the method could confuse future readers.\n\n**Recommendation**:\nMove the \u0027# This test does not require metrics injection\u0027 comment to the line immediately after the addCleanup calls (before the flavor creation block starts), or add a blank comment line separating it from the flavor setup logic.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"10104d54_40824f9f","line":151,"updated":"2026-05-05 12:09:55.000000000","message":"The BfV flavor-creation pattern (int(available_disk) + 2) is duplicated identically across three new test classes. If the calculation logic changes, all three must be updated independently.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Maintenance burden -- the same ~10-line block for computing available disk and creating an oversized flavor is repeated in host_maintenance:151-159, node_resource_consolidation:138-147, and vm_workload_consolidation:137-145.\n\n**Suggestion**:\nExtract a helper method such as `_create_bfv_flavor_with_oversized_disk()` into the base class or the BfV test base. This would reduce the three copies to one and make future changes to the disk-calculation logic safer.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"4e88ac461a3648bd928004d358b4d88e","url":"https://zuul.teim.app/t/main/buildset/4e88ac461a3648bd928004d358b4d88e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bf7b243480a00ba51492f79d9391713cd2e41d65","patch_set":2,"id":"449fd9d6_9f526847","line":139,"updated":"2026-05-05 13:35:59.000000000","message":"The large block comments at the start of each BfV test method describe the rationale well but could be more concise. The same conceptual explanation is repeated nearly verbatim in all three methods.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Concise, DRY documentation reduces cognitive load and risk of comments diverging from code over time.\n\n**Recommendation**:\nMove the shared BFV rationale explanation to the class docstring and keep method-level comments focused on test-specific details (e.g. which strategy parameter is being exercised).","commit_id":"8de039cdd312acd1b3851bf093aaec5468c29860"},{"robot_id":"zuul","robot_run_id":"4e88ac461a3648bd928004d358b4d88e","url":"https://zuul.teim.app/t/main/buildset/4e88ac461a3648bd928004d358b4d88e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bf7b243480a00ba51492f79d9391713cd2e41d65","patch_set":2,"id":"e48e4bf6_26ec70ce","line":151,"updated":"2026-05-05 13:35:59.000000000","message":"Duplicated flavor-disk-override logic across all three BfV test methods. The same 6-line block (get host, get hypervisor, get disk inventory, compute available_disk, compute flavor_disk, create flavor) is copy-pasted identically. A shared helper method would reduce maintenance burden.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: If the disk override logic needs to change (e.g. accounting for reserved disk or allocation_ratio edge cases), it must be updated in 6+ places across both this patch and the related change 986616.\n\n**Suggestion**:\nExtract a helper method like _create_bfv_flavor_exceeding_local_disk() on the base class that encapsulates the host/hypervisor/inventory lookup and flavor creation, then call it from each BfV test.","commit_id":"8de039cdd312acd1b3851bf093aaec5468c29860"}],"watcher_tempest_plugin/tests/scenario/test_execute_node_resource_consolidation.py":[{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"397a6a85_3d6883a4","line":114,"updated":"2026-05-05 12:09:55.000000000","message":"The three new BfV test classes follow the same skip_checks pattern checking CONF.service_available.cinder and CONF.optimize.run_bfv_tests. This is consistent with the existing BfV tests from the sibling change (986616).\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Consistent skip-check patterns across all BfV tests makes the test suite predictable and maintainable.\n\n**Recommendation**:\nConsider extracting a shared BfV base class (e.g., BaseBfVTestMixin) with the common skip_checks in a follow-up patch if more BfV tests are anticipated. For now, the repetition is acceptable given only three classes.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"cf5851cb_53f8e5d3","line":165,"updated":"2026-05-05 12:09:55.000000000","message":"The node_resource_consolidation BfV test does not execute the action plan (no call to execute_action_plan_and_validate_states). The existing non-BfV tests for this strategy both execute the action plan.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The test validates the action plan is generated correctly but does not verify the migration executes successfully for BfV instances. Both existing non-BfV tests (auto and specify) execute the action plan.\n\n**Suggestion**:\nAdd `self.execute_action_plan_and_validate_states(action_plan[\u0027uuid\u0027])` after the RECOMMENDED assertion, consistent with the non-BfV tests in this file.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"4e88ac461a3648bd928004d358b4d88e","url":"https://zuul.teim.app/t/main/buildset/4e88ac461a3648bd928004d358b4d88e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bf7b243480a00ba51492f79d9391713cd2e41d65","patch_set":2,"id":"1d5582f5_f3890ad1","line":110,"updated":"2026-05-05 13:35:59.000000000","message":"The BfV test class name TestNodeResourceConsolidationStrategyBfV drops the \u0027Execute\u0027 prefix used by the non-BfV class TestExecuteNodeResourceConsolidationStrategy, breaking the naming consistency.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Consistent naming makes it easier to locate and pair related test classes via grep or IDE search.\n\n**Recommendation**:\nRename to TestExecuteNodeResourceConsolidationStrategyBfV to match the established pattern.","commit_id":"8de039cdd312acd1b3851bf093aaec5468c29860"},{"robot_id":"zuul","robot_run_id":"4e88ac461a3648bd928004d358b4d88e","url":"https://zuul.teim.app/t/main/buildset/4e88ac461a3648bd928004d358b4d88e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bf7b243480a00ba51492f79d9391713cd2e41d65","patch_set":2,"id":"05a1be42_cc222250","line":168,"updated":"2026-05-05 13:35:59.000000000","message":"TestNodeResourceConsolidationStrategyBfV does not execute the action plan or verify migration success, unlike the corresponding non-BFV tests (both auto and specify variants).\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The test only validates action plan state is RECOMMENDED but does not call execute_action_plan_and_validate_states. The non-BFV specify test does execute and validate, so this BfV test provides weaker coverage.\n\n**Suggestion**:\nConsider adding self.execute_action_plan_and_validate_states(action_plan[\u0027uuid\u0027]) after the RECOMMENDED assertion to match the non-BFV specify test and validate that BFV migration actually succeeds.","commit_id":"8de039cdd312acd1b3851bf093aaec5468c29860"}],"watcher_tempest_plugin/tests/scenario/test_execute_vm_workload_consolidation.py":[{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"52cd984b_0df64492","line":26,"updated":"2026-05-05 12:09:55.000000000","message":"The vm_workload_consolidation file renames TestExecuteVmWorkloadBalanceStrategy to TestExecuteVmWorkloadConsolidationStrategyBase. The old name contained \u0027Balance\u0027 but the strategy is \u0027consolidation\u0027. This is a good fix but could be noted in the commit message.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Improves naming consistency. The old class name was misleading since \u0027balance\u0027 refers to a different strategy entirely.\n\n**Recommendation**:\nThe rename is correct. Consider mentioning the TestExecuteVmWorkloadBalanceStrategy -\u003e TestExecuteVmWorkloadConsolidationStrategyBase rename in the commit message body to aid future reviewers tracing the class history.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"32476ccfaa4e4909b6762728e6f265aa","url":"https://zuul.teim.app/t/main/buildset/32476ccfaa4e4909b6762728e6f265aa","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9e77f3c85a663e29ea5a25346089a3494109e29a","patch_set":1,"id":"baf57e15_173c390a","line":166,"updated":"2026-05-05 12:09:55.000000000","message":"The vm_workload_consolidation BfV test does not execute the action plan (no call to execute_action_plan_and_validate_states), unlike the host_maintenance BfV test which does. The existing non-BfV vm_workload_consolidation test also executes the action plan, so this is inconsistent.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The test verifies Watcher generates a valid action plan but does not confirm the migration actually succeeds for BfV instances. This leaves a gap in coverage compared to the host_maintenance BfV test.\n\n**Suggestion**:\nConsider adding `self.execute_action_plan_and_validate_states(action_plan[\u0027uuid\u0027])` after the RECOMMENDED assertion to validate the end-to-end migration flow, consistent with the pattern in host_maintenance BfV and the non-BfV vm_workload_consolidation test.","commit_id":"82132c0c0d2f229d63551866dabd89cb6d365ddc"},{"robot_id":"zuul","robot_run_id":"4e88ac461a3648bd928004d358b4d88e","url":"https://zuul.teim.app/t/main/buildset/4e88ac461a3648bd928004d358b4d88e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bf7b243480a00ba51492f79d9391713cd2e41d65","patch_set":2,"id":"976ca049_31fc44ff","line":116,"updated":"2026-05-05 13:35:59.000000000","message":"The vm_workload_consolidation BfV test uses \u0027with_specify_bfv\u0027 in its name but the strategy does not have a \u0027host_choice\u0027 parameter like node_resource_consolidation. The test name may be misleading.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Clearer test naming improves discoverability and understanding of what each test validates.\n\n**Recommendation**:\nConsider renaming to test_execute_vm_workload_consolidation_strategy_bfv since the \u0027with_specify\u0027 suffix implies a host_choice parameter that vm_workload_consolidation does not use.","commit_id":"8de039cdd312acd1b3851bf093aaec5468c29860"},{"robot_id":"zuul","robot_run_id":"4e88ac461a3648bd928004d358b4d88e","url":"https://zuul.teim.app/t/main/buildset/4e88ac461a3648bd928004d358b4d88e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bf7b243480a00ba51492f79d9391713cd2e41d65","patch_set":2,"id":"da30f62f_1b360d7a","line":169,"updated":"2026-05-05 13:35:59.000000000","message":"TestExecuteVmWorkloadConsolidationStrategyBfV does not execute the action plan or verify migration success, unlike the corresponding non-BFV test and the other two BfV tests in this patch.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The test only validates that the action plan state is RECOMMENDED but does not call execute_action_plan_and_validate_states. This is a weaker assertion than the equivalent test in the non-BFV class and may miss runtime BFV migration failures.\n\n**Suggestion**:\nConsider adding self.execute_action_plan_and_validate_states(action_plan[\u0027uuid\u0027]) after the RECOMMENDED assertion to match the pattern used by the non-BFV vm_workload_consolidation test and ensure the migration actually succeeds.","commit_id":"8de039cdd312acd1b3851bf093aaec5468c29860"}]}