)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f94c1e487bb0996046e51b937af11adc5610f860","unresolved":true,"context_lines":[{"line_number":97,"context_line":"  - test_execute_basic_strategy_with_instance_scope (PASS)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Summary:"},{"line_number":100,"context_line":"- Total: 16 new tests (14 strategy-specific + 2 generic)"},{"line_number":101,"context_line":"- Host scope tests: 7 (all should PASS)"},{"line_number":102,"context_line":"- Instance scope tests: 7 (4 PASS, 3 FAIL and document bugs)"},{"line_number":103,"context_line":"- Bugs documented:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8d77ab28_852ad8de","line":100,"range":{"start_line":100,"start_character":2,"end_line":100,"end_character":56},"updated":"2026-09-10 14:27:36.000000000","message":"I am not sure how long this is going to take on CI, but would increase the time to complete, which can turn to a problem in future, while we add more tests for new features. We should discuss with the team about this, if we should only add one or two scenario tests, and rely on more functional tests in watcher repo itself.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1ae0cb58d6523abf9d6971629e7dea70681ad845","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     0d13c97a (Merge \"Fix duplicated comment on delete and shelve actions\")"},{"line_number":2,"context_line":"Author:     morenod \u003cdsanzmor@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-04-29 12:24:24 +0200"},{"line_number":4,"context_line":"Commit:     morenod \u003cdsanzmor@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e2d5e9f4_34ade8c5","line":1,"updated":"2026-10-08 09:00:56.000000000","message":"The commit message\u0027s per-file breakdown claims \u0027Reorganized: TestExecuteHostMaintenanceStrategyBase (new)\u0027, \u0027TestExecuteWorkloadBalanceStrategyBase (new)\u0027 and \u0027TestExecuteWorkloadStabilizationStrategyBase (new)\u0027, but those Base classes already existed before this change and their files only append the new Scope classes. Only TestExecuteBasicStrategyBase is genuinely new (converted from the former single class); the node_resource_consolidation and vm_workload_consolidation bases were renamed, not created.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: Future readers using git log to determine when the Base/Regular/Scope structure was introduced, or auditing which classes a change renamed, are misled about what the commit actually did.\n\n**Recommendation**:\nCorrect the per-file notes to state that those Base classes already existed and only Scope subclasses were appended, and that the Regular/BfV classes in the node_resource_consolidation and vm_workload_consolidation files were renamed.","commit_id":"462cdcd48e648fe67067e0e2bfe7e3ab97113a84"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"4ca9378b8a5212cc9878b14aa05eb9a4ec33d85f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c042b89_58f01632","updated":"2026-07-02 10:42:04.000000000","message":"Audit Scope test suite to be used to verify fixes for:\n - Host Maintenance: https://bugs.launchpad.net/watcher/+bug/2154805\n - Node Resource Consolidation: https://bugs.launchpad.net/watcher/+bug/2154806\n - Zone Migration: https://bugs.launchpad.net/watcher/+bug/2154807","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f94c1e487bb0996046e51b937af11adc5610f860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39031071_2af89e6d","updated":"2026-09-10 14:27:36.000000000","message":"I think that we should or remove run_scope_tests or set it to default\u003dtrue for now, so we can tests everything in all branches (while we also backport fixes)","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e59c8e6762218d5b58efc09674a81831a7e04900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a48cfa5_aabff5ec","updated":"2026-07-08 08:34:27.000000000","message":"recheck","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"79edf5f248466b5890c8409c031d06239fecf3c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"416a457b_d13cd496","updated":"2026-07-07 10:37:47.000000000","message":"recheck","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"6c7a26768e62698c66accfc925e292c89a9752d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"baeb93e3_b00d7535","in_reply_to":"39031071_2af89e6d","updated":"2026-09-15 13:26:20.000000000","message":"Yes, you are right. I have set to to default\u003dtrue so it will be executed always by now.\n\nYou can set now a depends-on in your fix to run those tests and check the status","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c71b10b141a18328624abdbeda74abdf9fe35f5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"647aff87_040c2e06","updated":"2026-09-17 12:17:43.000000000","message":"Some tests failed to create a project, due to project name being too long. Since it uses the Class name as project name, it is getting too long for long classes names:\n\n\"Invalid input for field/attribute name. Value: tempest-TestExecuteNodeResourceConsolidationStrategyScope-619913348. \u0027tempest-TestExecuteNodeResourceConsolidationStrategyScope-619913348\u0027 is too long\"","commit_id":"d1e415b1ff929e995bd5bcd771adb8610c19848a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"8e2505342890bd113914c25d5389e492e370f8fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"26705fa4_be20ffb1","updated":"2026-09-24 07:54:45.000000000","message":"recheck","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"e4f37f228c2695f567c0529a37fedf485cfba230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"39f11f21_134801f7","updated":"2026-09-25 11:28:08.000000000","message":"recheck","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"a3877ff060cd2d05ade47b03c5c958ab3f351c6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"514b1952_20ef3f8e","updated":"2026-10-02 09:51:53.000000000","message":"recheck","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"b4a287426de437fd32315b208f5135c015fa4958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"503aa53a_d1849492","updated":"2026-10-07 15:06:08.000000000","message":"recheck","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"efb9b23298cd82ddc4eb01a76c9b2ce9aa43c232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"978d5bd3_95dc13ca","updated":"2026-10-06 14:47:45.000000000","message":"recheck","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"ae7d9e9ea933a2f910437e0dd773a83e6cc3f536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d80b4569_0f82e553","updated":"2026-10-09 12:43:31.000000000","message":"recheck","commit_id":"551f44405e24a59c01de7ee84ce44a353aafd0f5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1686a608_22a2bacd","updated":"2026-10-20 14:19:04.000000000","message":"In my opinion, what we should do in tempest wrt scope is:\n\n- The scoped model is properly created. This is what we do in TestAuditScopeBase, but we should add more cases (filter by project and if possible by instance_metadata and host_aggregates).\n- For each strategy, the critical check is validate that instances with watcher_exclude are ignored and we can also test that exclussion per host works.\n\nI understand implementing these tests is difficult in some cases as the behavior depends of it they are executed in two or three node clusters. Instead of just accepting empty actionplans, we should validate that actions plans are empty in the expected cases, i.e. in consolidation or balancing strategies with 2-nodes clusters.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"bde15e328a68e0c5c267ec1123627c3c62969834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0dd6035b_db5f2176","updated":"2026-10-13 14:03:45.000000000","message":"recheck","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"0800dd85d566103c54457a76e78f0db407f20c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8a14dc0b_209b76f5","updated":"2026-10-14 08:03:34.000000000","message":"recheck","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"c07b689e52ed5c72f5e8b1433075884ab4f83d30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a20644e8_feff72be","updated":"2026-10-13 07:34:42.000000000","message":"recheck","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"1f1e51b1ce8dcaf0d7d9ba8f8963f856852445a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"eb31ff95_d0047b99","updated":"2026-10-14 11:13:50.000000000","message":"recheck","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"tox.ini":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"envlist \u003d py3,pypy,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"}],"source_content_type":"text/x-properties","patch_set":2,"id":"cc7a81c3_8ac6392a","line":1,"updated":"2026-07-02 11:41:05.000000000","message":"The [DNM] (Do Not Merge) prefix in the commit subject signals this is a work-in-progress draft that must not be merged.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Merging a DNM commit would introduce the critical issues (missing expectedFailure, wrong bug numbers) into the gate, breaking CI when run_scope_tests is enabled.\n\n**Suggestion**:\nRemove the [DNM] prefix only after all blocking issues are resolved. The commit subject should be reworded to describe the feature without the DNM marker before final review.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[flake8]"},{"line_number":71,"context_line":"show-source\u003dTrue"},{"line_number":72,"context_line":"ignore\u003d H105,E123,E226,N320,H202,W503,W504"},{"line_number":73,"context_line":"builtins\u003d _"},{"line_number":74,"context_line":"enable-extensions \u003d H106,H203"},{"line_number":75,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,demo/,releasenotes"}],"source_content_type":"text/x-properties","patch_set":2,"id":"a7ded3f2_ff3ccba1","line":72,"updated":"2026-07-02 11:41:05.000000000","message":"W504 (line break after binary operator) was added to the flake8 ignore list alongside the existing W503 ignore, which is redundant when W503 is already suppressed.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: With W503 already ignored, W504 does not change behavior since pep8 considers the two mutually exclusive. The addition is harmless but may indicate the changed code introduced a line-break style not previously used.\n\n**Suggestion**:\nVerify whether W504 is truly needed. If the changed code introduced line breaks after binary operators, consider formatting the code to avoid them instead, or document the rationale for ignoring both W503 and W504.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"fd982a60626df5169b75ebf3b30b17cf37fce4e4","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[flake8]"},{"line_number":71,"context_line":"show-source\u003dTrue"},{"line_number":72,"context_line":"ignore\u003d H105,E123,E226,N320,H202,W503,W504"},{"line_number":73,"context_line":"builtins\u003d _"},{"line_number":74,"context_line":"enable-extensions \u003d H106,H203"},{"line_number":75,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,demo/,releasenotes"}],"source_content_type":"text/x-properties","patch_set":5,"id":"359f3809_9e5a6e14","line":72,"updated":"2026-09-16 14:09:32.000000000","message":"The change appends W504 (line break after binary operator) to the flake8 ignore list in tox.ini. Previously the project ignored only W503, which enforced break-before-operator continuations. The new threshold expressions in test_execute_workload_balance.py break after \u0027*\u0027, so instead of reformatting two lines, the check is disabled for the whole project, leaving no enforced convention for operator line breaks in future code.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: The shared lint configuration is loosened for all future code to fit two lines, so mixed break-before and break-after operator styles can accumulate without lint feedback, eroding the previously enforced OpenStack continuation style.\n\n**Recommendation**:\nReformat the two expressions to break before the operator (e.g. \u0027(len(instances_host1) - 0.5)\u0027 then \u0027* (0.8 / int(hypervisor[\"vcpus\"])) * 100)\u0027) and remove W504 from the ignore list, keeping the lint contract unchanged.","commit_id":"d1e415b1ff929e995bd5bcd771adb8610c19848a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ccaab69b2bed1f60151c9fe737b54e1ded96469a","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[flake8]"},{"line_number":71,"context_line":"show-source\u003dTrue"},{"line_number":72,"context_line":"ignore\u003d H105,E123,E226,N320,H202,W503,W504"},{"line_number":73,"context_line":"builtins\u003d _"},{"line_number":74,"context_line":"enable-extensions \u003d H106,H203"},{"line_number":75,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,demo/,releasenotes"}],"source_content_type":"text/x-properties","patch_set":10,"id":"c83d760a_7fcf7012","line":72,"updated":"2026-10-07 15:46:27.000000000","message":"tox.ini appends W504 (line break after binary operator) to the project-wide flake8 ignore list. Within the changed files the only lines that trigger W504 are the two threshold expressions `(len(instances_host1) - 0.5) *` in test_execute_workload_balance.py, where the multiplication operator ends the first line of a wrapped expression. W503 (line break before binary operator) is already ignored, so wrapping with the operator at the start of the continuation line complies with the existing configuration.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: Weakening the project-wide lint configuration to accommodate two lines reduces style enforcement for all future code in every environment consuming this flake8 config, and the relaxation outlives the two lines that motivated it. No runtime behavior is affected.\n\n**Recommendation**:\nRevert the W504 addition in tox.ini and wrap the two expressions with the operator at the start of the continuation line, e.g. `(len(instances_host1) - 0.5)\\n            * (0.8 / int(hypervisor[\u0027vcpus\u0027])) * 100`, which triggers only the already-ignored W503.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"624987375ab89f9d09bdcf904eed44b343711384","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[flake8]"},{"line_number":71,"context_line":"show-source\u003dTrue"},{"line_number":72,"context_line":"ignore\u003d H105,E123,E226,N320,H202,W503,W504"},{"line_number":73,"context_line":"builtins\u003d _"},{"line_number":74,"context_line":"enable-extensions \u003d H106,H203"},{"line_number":75,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,demo/,releasenotes"}],"source_content_type":"text/x-properties","patch_set":13,"id":"f041e08c_e3fbd105","line":72,"updated":"2026-10-09 08:22:55.000000000","message":"The change appends W504 to the flake8 ignore list, disabling the line-break-after-binary-operator check for the entire repository. The only code that triggers W504 is the two new threshold computations in test_execute_workload_balance.py that break after the \u0027*\u0027 operator. The identical expression already exists in the same file formatted with operators kept off line ends, so the ignore change is unnecessary: reformatting the two new occurrences keeps the existing lint gate intact.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Repo-wide lint enforcement is weakened: future code in any file may break lines after binary operators, and the previously enforced operator style is no longer flagged for contributors, eroding the pep8 gate this project runs on every change.\n\n**Suggestion**:\nReformat the two new threshold expressions to break before the operator, matching the existing style at lines 80-81 (e.g. \u0027threshold \u003d round((len(instances_host1) - 0.5)\\n            * (0.8 / int(hypervisor[\u0027vcpus\u0027])) * 100)\u0027), and drop W504 from the flake8 ignore list so the repo-wide rule stays enabled.","commit_id":"bd0eed80eaf274691a09a906688650105dbb448a"}],"watcher_tempest_plugin/config.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f94c1e487bb0996046e51b937af11adc5610f860","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f56b035_d708cec6","line":212,"range":{"start_line":206,"start_character":0,"end_line":212,"end_character":0},"updated":"2026-09-10 14:27:36.000000000","message":"Since this feature should work in all stable releases, we can merge the fixes and backports before merging this patch, so we don\u0027t need this in the end. Something that we can\u0027t do for new features.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"53fa4e3c7df9da786987685a1a94385dbebe868c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"             \"are not met. Requires Watcher to support the action \""},{"line_number":204,"context_line":"             \"skipping feature.\""},{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""}],"source_content_type":"text/x-python","patch_set":4,"id":"12708510_38ecf0c7","line":206,"updated":"2026-09-15 13:52:37.000000000","message":"The new cfg.BoolOpt(\"run_scope_tests\") defaults to True. The commit message states the option defaults to False (\u0027CONF.optimize.run_scope_tests (default: False)\u0027), and every other gating option in the same OptimizeGroup (run_continuous_audit_tests, run_extended_attributes_tests, run_zone_migration_extra_tests, run_zone_migration_storage_tests, run_bfv_tests, run_skipped_action_tests) defaults to False. Three of the new tests contain assertions explicitly written and commented to fail by design to document watcher bugs, and they are gated only by live_migration and compute-node-count skip checks, so the default True turns them on everywhere by default.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Impact**: Any default tempest run of this plugin where live migration is enabled and at least 2-3 compute nodes exist (the standard watcher multinode CI topology) executes the three bug-documenting tests and reports failures, turning default CI runs red and blocking merges. The documented opt-in behavior of the new option is inverted, and operators who never asked for scope tests get them, with failures.\n\n**Priority**: Before merge\n**Recommendation**:\nChange the default to False in config.py so scope tests are opt-in exactly as the commit message documents, matching every other run_* gating option in this group.","commit_id":"fbf77b7592fa8905dbbaee4f572df79056edc313"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"fd982a60626df5169b75ebf3b30b17cf37fce4e4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"             \"are not met. Requires Watcher to support the action \""},{"line_number":204,"context_line":"             \"skipping feature.\""},{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dee076e8_aaec448f","line":206,"updated":"2026-09-16 14:09:32.000000000","message":"The new config option is registered with default\u003dTrue, but the commit message states it defaults to False and exists to allow selective execution of scope tests. Every sibling opt-in flag in the same group (run_bfv_tests, run_skipped_action_tests, run_zone_migration_extra_tests, run_zone_migration_storage_tests) defaults to False. Three new scope tests hard-code failure messages and docstrings stating they are expected to FAIL to document watcher bugs (zone_migration, host_maintenance, node_resource_consolidation instance-scope), so with default\u003dTrue they are not skipped in any default tempest run. The two generic tests in test_audit_scope.py carry the \u0027scope\u0027 attribute but are not gated by this flag at all, so the flag also fails to deliver the selective execution described.\n\n**Severity**: HIGH | **Confidence**: 0.92\n\n**Impact**: Any default run of the watcher scenario suite, including this project\u0027s own gate and downstream verification jobs, executes the three guaranteed-failing tests and goes red until an operator discovers the flag and sets run_scope_tests\u003dFalse. The intentionally-failing bug-documentation tests leak into default CI instead of being opt-in, which is the opposite of the documented intent.\n\n**Priority**: Before merge\n**Recommendation**:\nChange the option default to False, matching the commit message and the established opt-in convention of run_bfv_tests and the other optional test flags; scope tests are then enabled explicitly via [optimize] run_scope_tests \u003d True as the commit message documents.","commit_id":"d1e415b1ff929e995bd5bcd771adb8610c19848a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"cea9c04d968e421902cb6aded62236f6d0de9a08","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":210,"context_line":"    ),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5941175a_21d80e33","line":208,"updated":"2026-09-22 09:32:00.000000000","message":"config.py registers cfg.BoolOpt(\u0027run_scope_tests\u0027, default\u003dTrue). The commit message states the option defaults to False and exists to allow selective execution \u0027similar to how boot-from-volume tests are organized\u0027; the sibling gating options run_bfv_tests and run_skipped_action_tests both default to False. Because the default is True, every new *Scope test class runs in each default scenario run, including three instance-scope tests whose assertions the commit message documents as failing against watcher builds without the audit-scope fix.\n\n**Severity**: HIGH | **Confidence**: 0.85\n\n**Impact**: Any default run of this plugin\u0027s scenario suite against a watcher lacking the fix (stable or downstream builds, or this change\u0027s own gate if the Depends-On is dropped or rebased) executes three tests that fail by design, breaking the suite with no opt-out besides editing tempest.conf. The documented configuration contract also permanently contradicts the implemented default.\n\n**Priority**: Before merge\n**Recommendation**:\nChange the default to False to match the commit message and the established run_bfv_tests/run_skipped_action_tests pattern; if True is genuinely intended, update the commit message and explain why this group differs from its siblings.","commit_id":"70b52f49803fd93543fa67018d4fe5d212d13d86"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3f754add284378564b64c30aa86c7b8d7b1c4f88","unresolved":false,"context_lines":[{"line_number":203,"context_line":"             \"are not met. Requires Watcher to support the action \""},{"line_number":204,"context_line":"             \"skipping feature.\""},{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f369e4d_2a9c117f","line":206,"updated":"2026-09-23 14:06:50.000000000","message":"The new option is declared with default\u003dTrue (config.py:208), but the commit message states \"CONF.optimize.run_scope_tests (default: False)\" and designs the scope tests as opt-in. All six sibling gating options (run_bfv_tests, run_skipped_action_tests, run_continuous_audit_tests, etc.) default to False. Three of the new scope tests assert behavior watcher does not implement until the Depends-On watcher change 1002779 merges and is deployed, and are written to fail by design.\n\n**Severity**: HIGH | **Confidence**: 0.95\n\n**Impact**: Once merged, any environment running the plugin\u0027s scenario suite without explicitly setting [optimize] run_scope_tests\u003dFalse executes the three intentionally failing tests (when node/migration preconditions are met), failing the run against watcher builds without fix 1002779. This includes watcher-tempest-plugin master CI and downstream users if the Depends-On change does not merge or is not deployed. The documented opt-in contract is inverted, so the flag\u0027s purpose (selective execution) is defeated out of the box.\n\n**Priority**: Before merge\n**Recommendation**:\nChange the declaration to default\u003dFalse in config.py to match the commit message and the established pattern of the other run_* gating options; environments that want the scope tests can then opt in explicitly via tempest.conf.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d3cf30022cdca9b5f2cca8b1bc9ce63404eda84b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":210,"context_line":"    ),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"c351f700_5a9cdc07","line":208,"updated":"2026-09-24 08:08:27.000000000","message":"config.py registers run_scope_tests with default\u003dTrue, but the commit message documents \u0027CONF.optimize.run_scope_tests (default: False)\u0027 and says scope tests allow selective execution \u0027similar to how boot-from-volume tests are organized\u0027. Every other selective-execution option in the same group (run_bfv_tests, run_skipped_action_tests, run_zone_migration_storage_tests) defaults to False. Because each Scope class\u0027s skip_checks tests only this flag, all 16 scope tests run under the default configuration, including the three instance-scope tests the commit message itself lists as expected to FAIL (bugs #2154805, #2154806, #2154807).\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Impact**: With the default configuration, every default scenario run executes the three documented-to-fail tests and goes red, breaking the default gate for all users until they discover and set an override the commit message tells them is unnecessary. Operators reading the permanent change history will believe scope tests are opt-in when they are enabled by default.\n\n**Priority**: Before merge\n**Recommendation**:\nSet run_scope_tests default\u003dFalse to match the commit message and the established opt-in pattern of run_bfv_tests and run_skipped_action_tests; if default-on is truly intended, land the watcher fixes for the three bugs first and correct the commit message instead.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"5e830836b74ff7d74bca7d0ac294e33bff8e131e","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":210,"context_line":"    ),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"c8dd2092_cc08b5ff","line":208,"updated":"2026-09-24 13:23:20.000000000","message":"The new [optimize] run_scope_tests gate defaults to True, but the commit message states the default is False, and every existing selective-execution gate in this group (run_zone_migration_storage_tests, run_bfv_tests, run_skipped_action_tests) defaults to False. Three of the newly gated tests are explicitly documented as expected to FAIL: the zone_migration, host_maintenance, and node_resource_consolidation instance-scope tests that document open watcher bugs. With default\u003dTrue the gate never skips anything in default configurations, so it does not protect default runs from the known failures.\n\n**Severity**: HIGH | **Confidence**: 0.95\n\n**Impact**: In any deployment with live migration enabled (the normal configuration for this plugin\u0027s scenario jobs), a default full run will now execute the three bug-documenting tests and fail, breaking CI runs that the gate was supposedly keeping green. The gate also contradicts the permanent commit history, which documents the opposite default.\n\n**Priority**: Before merge\n**Recommendation**:\nSet default\u003dFalse so scope tests run only when explicitly enabled, matching the commit message and the run_bfv_tests precedent; operators can opt in while the documented bugs remain open.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"25692dfc40cca801a85ddc719aee677f10bd6de5","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    ),"},{"line_number":206,"context_line":"    cfg.BoolOpt("},{"line_number":207,"context_line":"        \"run_scope_tests\","},{"line_number":208,"context_line":"        default\u003dTrue,"},{"line_number":209,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":210,"context_line":"    ),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"e7f669d2_fd5098cb","line":208,"updated":"2026-09-25 11:38:53.000000000","message":"The new gate option is introduced with default\u003dTrue while the commit message documents it as \u0027CONF.optimize.run_scope_tests (default: False)\u0027 enabling \u0027selective execution of scope tests\u0027. By the change\u0027s own documentation, 3 of the 16 new tests are designed to FAIL (bugs #2154805 host_maintenance, #2154806 node_resource_consolidation, #2154807 zone_migration ignore instance exclusions). With default True these failing tests are not opt-in: every default run of the watcher scenario suite executes them and reports failures. The default also diverges from all six existing run_* gates in the same config group, which all default to False.\n\n**Severity**: HIGH | **Confidence**: 0.88\n\n**Impact**: Default CI runs of the plugin\u0027s scenario suite will execute the three tests documented to fail, producing failing jobs for any deployment using the default configuration, and the selective opt-in behavior described in the commit message is not achieved.\n\n**Priority**: Before merge\n**Recommendation**:\nChange default\u003dTrue to default\u003dFalse at watcher_tempest_plugin/config.py:208 so scope tests remain opt-in like every other run_* gate and match the documented behavior.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ccaab69b2bed1f60151c9fe737b54e1ded96469a","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    ),"},{"line_number":213,"context_line":"    cfg.BoolOpt("},{"line_number":214,"context_line":"        \"run_scope_tests\","},{"line_number":215,"context_line":"        default\u003dTrue,"},{"line_number":216,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":217,"context_line":"    )"},{"line_number":218,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"b43bc4aa_56d8f9f4","line":215,"updated":"2026-10-07 15:46:27.000000000","message":"config.py adds the run_scope_tests option with default\u003dTrue, but the commit message states \u0027CONF.optimize.run_scope_tests (default: False)\u0027 and every sibling test-suite opt-in option (run_continuous_audit_tests, run_extended_attributes_tests, run_zone_migration_extra_tests, run_zone_migration_storage_tests, run_bfv_tests, run_skipped_action_tests, run_delete_shelve_action_tests) defaults to False. Three of the new scope tests (host_maintenance, node_resource_consolidation and zone_migration instance-scope) are explicitly written to FAIL while their watcher bugs are open; this flag is their only gate.\n\n**Severity**: HIGH | **Confidence**: 0.85\n\n**Impact**: Any default run of the scenario suite on an environment with at least 2 compute nodes and live migration enabled (the project\u0027s documented workflow and typical watcher CI topology) will now execute the three expected-to-fail tests and fail. Default gating runs break until operators discover they must set run_scope_tests \u003d False, which contradicts the opt-in design described in the commit message.\n\n**Priority**: Before merge\n**Recommendation**:\nChange the option to `default\u003dFalse` in watcher_tempest_plugin/config.py to match the commit message, the sibling run_* options, and the opt-in design; operators then enable the suite explicitly as described in the commit message.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ef7faa03df548e3c3fa19c66bea977b8f4c7aa86","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    ),"},{"line_number":213,"context_line":"    cfg.BoolOpt("},{"line_number":214,"context_line":"        \"run_scope_tests\","},{"line_number":215,"context_line":"        default\u003dTrue,"},{"line_number":216,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":217,"context_line":"    )"},{"line_number":218,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"2b6470f8_cfdced7e","line":215,"updated":"2026-10-06 14:59:33.000000000","message":"watcher_tempest_plugin/config.py:215 sets run_scope_tests to default\u003dTrue, while the commit message documents \"CONF.optimize.run_scope_tests (default: False)\" and every sibling optional-suite flag in the same group (run_continuous_audit_tests, run_extended_attributes_tests, run_zone_migration_extra_tests, run_zone_migration_storage_tests, run_bfv_tests, run_skipped_action_tests, run_delete_shelve_action_tests) defaults to False. The commit message also states three instance-scope tests (zone_migration, host_maintenance, node_resource_consolidation) are expected to FAIL to document watcher bugs 2154805/2154806/2154807, and the test docstrings say the same. Because the *Scope test classes gate only on run_scope_tests plus the same preconditions as existing CI-passing strategy tests (min 2 compute nodes, live migration), the default of True makes those three designed-to-fail tests run in standard CI.\n\n**Severity**: HIGH | **Confidence**: 0.93\n\n**Impact**: Once merged, the voting watcher gate jobs execute three tests that their own documentation says will fail (on any environment meeting the same preconditions as the existing live-migration strategy tests), turning every gate run red and blocking the watcher queue until the plugin is reverted or patched. The opt-in mechanism documented in the commit message does not behave as described.\n\n**Priority**: Before merge\n**Recommendation**:\nChange the default to False so the scope suite is opt-in as documented and consistent with all sibling run_*_tests flags; it can be flipped to True once the documented watcher bugs are fixed.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1ae0cb58d6523abf9d6971629e7dea70681ad845","unresolved":false,"context_lines":[{"line_number":210,"context_line":"             \"These tests validate the actuator strategy\u0027s delete and \""},{"line_number":211,"context_line":"             \"shelve actions, including precondition validation.\""},{"line_number":212,"context_line":"    ),"},{"line_number":213,"context_line":"    cfg.BoolOpt("},{"line_number":214,"context_line":"        \"run_scope_tests\","},{"line_number":215,"context_line":"        default\u003dTrue,"},{"line_number":216,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""}],"source_content_type":"text/x-python","patch_set":11,"id":"f5b40dd0_754993b8","line":213,"updated":"2026-10-08 09:00:56.000000000","message":"The new run_scope_tests option defaults to True and gates all 14 strategy scope tests, but three of them assert behavior that current watcher does not implement, and the commit message itself records them as failing (bug 2154805 host_maintenance, 2154806 node_resource_consolidation, 2154807 zone_migration). None of the three tests carries skip_because, expectedFailure, or any per-test opt-in, so with the default configuration they execute and fail wherever the suite runs.\n\n**Severity**: HIGH | **Confidence**: 0.85\n\n**Impact**: Until the three watcher fixes merge and are backported to all four stable branches, every gate job whose topology meets the 3-compute-node and live-migration preconditions reports test failures, red-flagging check and gate queues for this plugin and watcher and blocking merges across branches.\n\n**Priority**: Before merge\n**Recommendation**:\nApply tempest\u0027s standard mechanism for bug-linked tests: decorate the three known-failing tests with skip_because(bug\u003d...) and remove it as each fix lands, or gate only those three tests behind an opt-in flag defaulting to False (mirroring run_delete_shelve_action_tests) while the 11 passing scope tests remain on by default.","commit_id":"462cdcd48e648fe67067e0e2bfe7e3ab97113a84"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    ),"},{"line_number":213,"context_line":"    cfg.BoolOpt("},{"line_number":214,"context_line":"        \"run_scope_tests\","},{"line_number":215,"context_line":"        default\u003dTrue,"},{"line_number":216,"context_line":"        help\u003d\"Whether or not to run audit scope tests.\""},{"line_number":217,"context_line":"    )"},{"line_number":218,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"5e31b5d8_8a0dccfe","line":215,"updated":"2026-10-20 14:19:04.000000000","message":"As Doug mentioned before, given that we are setting default to True and running this for all supported branches, i think we may not need to add this config parameter at all. We usually add it only when we are adding tests that want to run in specific branches only for new features or bugs that we are not backporting.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_audit_scope.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    GOAL \u003d \"dummy\""},{"line_number":52,"context_line":"    STRATEGY \u003d \"dummy\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @decorators.idempotent_id(\u0027a1b2c3d4-e5f6-4789-a012-3456789abcde\u0027)"},{"line_number":55,"context_line":"    @decorators.attr(type\u003d[\u0027scope\u0027])"},{"line_number":56,"context_line":"    def test_audit_scope_with_compute_nodes(self):"},{"line_number":57,"context_line":"        \"\"\"Verify that scope filters data model to specified compute nodes."}],"source_content_type":"text/x-python","patch_set":2,"id":"2bedeb45_04d80339","line":54,"updated":"2026-07-02 11:41:05.000000000","message":"All newly added idempotent_id UUIDs are hand-crafted placeholder patterns (e.g. a1b2c3d4-e5f6-4789-a012-3456789abcde) rather than genuine random UUIDs.\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: Tempest idempotent_id relies on globally unique random UUIDs. Placeholder-style sequential UUIDs risk future collisions across plugin installations and conflict with the purpose of the check-uuid pep8 target.\n\n**Priority**: Before merge\n**Why This Matters**: The project runs check-uuid --package in its pep8 job. While these may be technically unique today, the predictable non-random pattern is fragile and against tempest conventions for test identification.\n\n**Recommendation**:\nGenerate proper random UUIDs using the project\u0027s own [testenv:uuidgen] target (check-uuid --fix) or uuidgen, and replace all hand-crafted values across the 8 changed test files.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # Define scope: exclude the third compute node"},{"line_number":82,"context_line":"        # This effectively limits the scope to the first two nodes"},{"line_number":83,"context_line":"        scoped_nodes \u003d [compute_nodes[0][\u0027host\u0027], compute_nodes[1][\u0027host\u0027]]"},{"line_number":84,"context_line":"        excluded_node \u003d compute_nodes[2][\u0027host\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        audit_scope \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"07cb2d17_8269f5d6","line":83,"updated":"2026-07-02 11:41:05.000000000","message":"The same audit_scope exclude dict structure (13 lines) and data-model entity extraction loop are copy-pasted verbatim across 8+ test files, representing hundreds of lines of duplicated logic.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Any change to the scope format or model-extraction logic requires editing 8+ files identically, creating a significant maintenance burden and high risk of drift between tests.\n\n**Priority**: Before merge\n**Why This Matters**: The project already has a base.py with shared helpers. The scope dict construction and the for-elem-in-context extraction loop are prime candidates for shared helpers that would eliminate ~200 lines of duplication.\n\n**Recommendation**:\nAdd shared helpers to base.py, e.g. build_host_exclude_scope(host) returning the exclude dict and extract_model_entities(body) returning (nodes_set, instances_list). Extend create_audit_template_for_strategy to accept an optional scope parameter.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            }"},{"line_number":100,"context_line":"        ]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        LOG.info(f\"Creating audit excluding node: {excluded_node}\")"},{"line_number":103,"context_line":"        LOG.info(f\"Scoped nodes (via exclusion): {scoped_nodes}\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Create audit template with scope"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e9317b6_29bcc8eb","line":102,"updated":"2026-07-02 11:41:05.000000000","message":"f-strings are used inside LOG.info() calls throughout all new test files instead of the OpenStack-preferred percent-style lazy interpolation.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: f-strings force eager string construction even when the INFO log level is disabled. The percent-style (LOG.info(\u0027msg: %s\u0027, val)) enables lazy evaluation and is the dominant OpenStack/oslo convention.\n\n**Suggestion**:\nReplace f-string LOG calls with percent-style lazy interpolation: LOG.info(\u0027Creating audit excluding node: %s\u0027, excluded_node). There are 15+ such occurrences across test_audit_scope.py, test_execute_basic_optim.py, and all other changed test files.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        LOG.info(f\"Scoped nodes (via exclusion): {scoped_nodes}\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Create audit template with scope"},{"line_number":106,"context_line":"        _, goal \u003d self.client.show_goal(self.GOAL)"},{"line_number":107,"context_line":"        _, strategy \u003d self.client.show_strategy(self.STRATEGY)"},{"line_number":108,"context_line":"        _, audit_template \u003d self.create_audit_template("},{"line_number":109,"context_line":"            goal[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b4c477f_0645a2ff","line":106,"updated":"2026-07-02 11:41:05.000000000","message":"The show_goal + show_strategy + create_audit_template triplet is repeated identically in every scope test (~6 lines each, 16 tests).\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Extending the existing create_audit_template_for_strategy() helper in base.py to accept an optional scope parameter would eliminate ~96 lines of boilerplate.\n\n**Recommendation**:\nAdd scope\u003dNone kwarg to create_audit_template_for_strategy in base.py and use it in all scope tests instead of the manual show_goal/show_strategy/create_audit_template sequence.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027c3d4e5f6-a7b8-4901-c234-56789abcdef0\u0027)"},{"line_number":156,"context_line":"    @decorators.attr(type\u003d[\u0027scope\u0027])"},{"line_number":157,"context_line":"    def test_audit_scope_with_multiple_compute_nodes(self):"},{"line_number":158,"context_line":"        \"\"\"Verify that scope works with multiple compute nodes specified."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This test validates that when multiple compute nodes are specified"}],"source_content_type":"text/x-python","patch_set":2,"id":"a358ac9f_d3da686e","line":157,"updated":"2026-07-02 11:41:05.000000000","message":"test_audit_scope_with_multiple_compute_nodes is functionally identical to test_audit_scope_with_compute_nodes: both exclude exactly one node from a 3-node setup with the same assertions.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: The test name implies multi-node exclusion but tests single-node exclusion. It wastes CI resources (instance creation, audit execution) without adding coverage beyond the first test.\n\n**Suggestion**:\nEither make the second test genuinely exclude 2 of 4+ nodes to test real multi-node exclusion, or remove it as redundant.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"53fa4e3c7df9da786987685a1a94385dbebe868c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    min_microversion \u003d \"1.3\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super().skip_checks()"},{"line_number":44,"context_line":"        if not CONF.compute_feature_enabled.live_migration:"},{"line_number":45,"context_line":"            raise cls.skipException(\"Live migration is not enabled\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec4bb5b1_5c42bc4a","line":42,"updated":"2026-09-15 13:52:37.000000000","message":"The commit message states \u0027The scope tests are gated by a new configuration option: CONF.optimize.run_scope_tests\u0027. All seven strategy Scope classes implement this skip check, but the two tests in TestAuditScopeComputeModel inherit only the live_migration skip from TestAuditScopeBase and never consult run_scope_tests, so setting the option to False does not disable them.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Setting run_scope_tests \u003d False in tempest.conf does not disable these two heavyweight three-node scenario tests; they run whenever live migration is enabled. The same gating decision is enforced inconsistently across the new test classes, so the documented opt-out is incomplete and the two enforcement points can drift apart in future edits.\n\n**Suggestion**:\nAdd the same \u0027if not CONF.optimize.run_scope_tests: raise cls.skipException(\"Audit scope tests are not enabled.\")\u0027 gate to TestAuditScopeBase.skip_checks, consistent with the other Scope classes.","commit_id":"fbf77b7592fa8905dbbaee4f572df79056edc313"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"cea9c04d968e421902cb6aded62236f6d0de9a08","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    min_microversion \u003d \"1.3\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super().skip_checks()"},{"line_number":44,"context_line":"        if not CONF.compute_feature_enabled.live_migration:"},{"line_number":45,"context_line":"            raise cls.skipException(\"Live migration is not enabled\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"4f2d3732_cdbb7b74","line":42,"updated":"2026-09-22 09:32:00.000000000","message":"The commit message states \u0027The scope tests are gated by a new configuration option: CONF.optimize.run_scope_tests\u0027. Every new strategy *Scope class implements that skip check, but TestAuditScopeBase.skip_checks only checks the live migration flag, so test_audit_scope_with_compute_nodes and test_audit_scope_with_multiple_compute_nodes always run in the default suite regardless of the option.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Operators who set run_scope_tests \u003d False to opt out of scope tests still execute the two generic scope tests (each creates instances on 3 compute nodes, runs audits and inspects data models), so the documented opt-out is incomplete and default-suite runtime and requirements differ from the documented behavior.\n\n**Suggestion**:\nAdd the same run_scope_tests skip check to TestAuditScopeBase (or to TestAuditScopeComputeModel) so all scope tests honour the documented option consistently.","commit_id":"70b52f49803fd93543fa67018d4fe5d212d13d86"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3f754add284378564b64c30aa86c7b8d7b1c4f88","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # Minimal version required for listing data model"},{"line_number":39,"context_line":"    min_microversion \u003d \"1.3\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super().skip_checks()"},{"line_number":44,"context_line":"        if not CONF.compute_feature_enabled.live_migration:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2edf623c_99cde73d","line":41,"updated":"2026-09-23 14:06:50.000000000","message":"The commit message says \"The scope tests are gated by a new configuration option: CONF.optimize.run_scope_tests\", but TestAuditScopeBase.skip_checks (test_audit_scope.py:41-45) only checks compute_feature_enabled.live_migration. The two TestAuditScopeComputeModel tests therefore still run when run_scope_tests\u003dFalse, so the new option does not actually control all of the audit scope tests this change adds.\n\n**Severity**: WARNING | **Confidence**: 0.88\n\n**Impact**: Operators who set run_scope_tests\u003dFalse (per the option\u0027s help text and the commit message) still execute these two heavyweight tests, each creating one instance per host across 3 compute nodes and running full audits. The configuration contract documented for the change does not hold, producing surprising test selection and longer CI runs.\n\n**Suggestion**:\nAdd the same run_scope_tests skip check to TestAuditScopeBase.skip_checks that the strategy Scope classes use, so the option controls every scope test added by this change.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d3cf30022cdca9b5f2cca8b1bc9ce63404eda84b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super().skip_checks()"},{"line_number":44,"context_line":"        if not CONF.compute_feature_enabled.live_migration:"},{"line_number":45,"context_line":"            raise cls.skipException(\"Live migration is not enabled\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"a6a437e8_fa1c2827","line":44,"updated":"2026-09-24 08:08:27.000000000","message":"TestAuditScopeBase.skip_checks raises skipException when CONF.compute_feature_enabled.live_migration is false (test_audit_scope.py:44-45). Both tests in the module use the dummy goal and strategy and only create instances, run an audit, and inspect the returned data model; no migration action is requested, executed, or asserted. The copied gate makes sense for the strategy scope tests that assert migrate actions, but not for this module, whose two tests are pure data-model checks.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: On valid multi-compute deployments where live migration is disabled, the change\u0027s generic host-exclusion data-model tests are skipped entirely, reducing the core coverage this change adds for no functional reason.\n\n**Recommendation**:\nRemove the live_migration check from TestAuditScopeBase.skip_checks and keep check_min_enabled_compute_nodes(3), which is the actual requirement of these tests.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3f754add284378564b64c30aa86c7b8d7b1c4f88","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027c3d4e5f6-a7b8-4901-c234-56789abcdef0\u0027)"},{"line_number":156,"context_line":"    @decorators.attr(type\u003d[\u0027scope\u0027])"},{"line_number":157,"context_line":"    def test_audit_scope_with_multiple_compute_nodes(self):"},{"line_number":158,"context_line":"        \"\"\"Verify that scope works with multiple compute nodes specified."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This test validates that when multiple compute nodes are specified"}],"source_content_type":"text/x-python","patch_set":8,"id":"31540006_c19f2f70","line":157,"updated":"2026-09-23 14:06:50.000000000","message":"The second new test\u0027s docstring claims it validates \"when multiple compute nodes are specified in the scope, all of them (and only them) are included\", and the commit message says it \"Verifies multiple node exclusions work correctly\". Its body instead builds the identical single-node exclusion scope as test_audit_scope_with_compute_nodes (excluding only compute_nodes[2]) and makes the same node-set assertions; it is the first test minus the instance-filtering assertions and the scope equality check.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: CI pays for a full duplicate scenario run (three servers plus an audit) with no additional coverage, and the name and docstring conceal that multi-node exclusion (and combined instance+node scopes) are not actually covered, so a regression there would pass while appearing to be tested.\n\n**Suggestion**:\nEither make this test exercise what it documents (e.g., exclude two of four nodes, or combine instance and compute_node excludes in one scope) or drop it and fold the unique assertions into test_audit_scope_with_compute_nodes.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"5e830836b74ff7d74bca7d0ac294e33bff8e131e","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @decorators.idempotent_id(\u0027c3d4e5f6-a7b8-4901-c234-56789abcdef0\u0027)"},{"line_number":156,"context_line":"    @decorators.attr(type\u003d[\u0027scope\u0027])"},{"line_number":157,"context_line":"    def test_audit_scope_with_multiple_compute_nodes(self):"},{"line_number":158,"context_line":"        \"\"\"Verify that scope works with multiple compute nodes specified."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This test validates that when multiple compute nodes are specified"}],"source_content_type":"text/x-python","patch_set":9,"id":"b0ff51b0_d239fcb0","line":157,"updated":"2026-09-24 13:23:20.000000000","message":"test_audit_scope_with_multiple_compute_nodes (line 157) repeats test_audit_scope_with_compute_nodes (line 56) nearly verbatim: same dummy goal/strategy, same three positionally selected compute nodes, same exclude-single-node scope payload. It only drops the audit-template scope assertion and the instance-membership assertion. Its name and docstring claim to validate a scope that specifies multiple compute nodes, but it exercises the same single-exclusion mechanism, so include-style scoping remains untested.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: The same scope-format invariant now has two independent copies that must be edited together when the audit scope schema evolves and that can drift apart; the misleading name suggests multi-node include coverage that does not exist.\n\n**Recommendation**:\nDifferentiate the second test by scoping with an include list of both compute nodes (or excluding two nodes) so it adds distinct coverage, or remove it and keep the single comprehensive test.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ef7faa03df548e3c3fa19c66bea977b8f4c7aa86","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # Minimal version required for listing data model"},{"line_number":39,"context_line":"    min_microversion \u003d \"1.3\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super().skip_checks()"},{"line_number":44,"context_line":"        if not CONF.compute_feature_enabled.live_migration:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7613567a_3f12edb0","line":41,"updated":"2026-10-06 14:59:33.000000000","message":"The commit message states \"The scope tests are gated by a new configuration option: CONF.optimize.run_scope_tests\". All seven strategy Scope classes implement that skip check, but test_audit_scope.py does not: TestAuditScopeBase.skip_checks (lines 41-45) only checks live_migration, and TestAuditScopeComputeModel adds no gate of its own. The two generic scope tests in this new file therefore run whenever live migration is enabled, regardless of the run_scope_tests option, leaving the documented gating incomplete and inconsistent across the new suite.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Operators who leave run_scope_tests disabled (its documented default) still execute these two scenario tests, each of which creates three instances and runs a full audit, so the documented opt-out is incomplete and behavior differs between the generic and strategy-specific scope suites.\n\n**Suggestion**:\nAdd the same skip check to TestAuditScopeBase.skip_checks: raise cls.skipException(\"Audit scope tests are not enabled.\") when CONF.optimize.run_scope_tests is false.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ccaab69b2bed1f60151c9fe737b54e1ded96469a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    min_microversion \u003d \"1.3\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"},{"line_number":43,"context_line":"        super().skip_checks()"},{"line_number":44,"context_line":"        if not CONF.compute_feature_enabled.live_migration:"},{"line_number":45,"context_line":"            raise cls.skipException(\"Live migration is not enabled\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"51127ca5_a8e2ba83","line":42,"updated":"2026-10-07 15:46:27.000000000","message":"The commit message states \u0027The scope tests are gated by a new configuration option: CONF.optimize.run_scope_tests\u0027, and all seven new strategy Scope classes skip unless that flag is set. The two new generic tests in test_audit_scope.py are decorated with the \u0027scope\u0027 attribute but their base class never checks the flag: TestAuditScopeBase.skip_checks only verifies live_migration, so these tests execute regardless of run_scope_tests.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Setting run_scope_tests \u003d False does not disable the audit scope suite as documented: the two generic tests still run whenever live migration is enabled and three compute nodes are present. Selective execution via the flag is therefore inconsistent, and environments that deliberately disable scope tests still execute this part of the suite.\n\n**Suggestion**:\nAdd the same skip_checks guard to TestAuditScopeBase (or TestAuditScopeComputeModel) that the strategy Scope classes use: `if not CONF.optimize.run_scope_tests: raise cls.skipException(\"Audit scope tests are not enabled.\")`.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"02d5a934f336dea6edc8aca033e939eeaafbe844","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @decorators.idempotent_id(\u0027c3d4e5f6-a7b8-4901-c234-56789abcdef0\u0027)"},{"line_number":158,"context_line":"    @decorators.attr(type\u003d[\u0027scope\u0027])"},{"line_number":159,"context_line":"    def test_audit_scope_with_multiple_compute_nodes(self):"},{"line_number":160,"context_line":"        \"\"\"Verify that scope works with multiple compute nodes specified."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        This test validates that when multiple compute nodes are specified"}],"source_content_type":"text/x-python","patch_set":12,"id":"59d33b8f_5cbf3175","line":159,"updated":"2026-10-08 11:08:49.000000000","message":"The new test is a near-verbatim copy of test_audit_scope_with_compute_nodes: same 3-node setup, same scope structure that excludes exactly one node (compute_nodes[2]), same audit execution and data-model assertions, minus the template-scope and instance-membership assertions. Its name and docstring claim to verify that \u0027multiple compute nodes are specified in the scope\u0027 and the commit message says it \u0027verifies multiple node exclusions\u0027, but the code excludes a single node exactly like the first test, so no multi-node scope scenario is actually exercised.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: The suite advertises 16 new tests but this one adds no distinct coverage: operators and bug validators will assume multi-node scope behavior is covered when it is not, and the duplicated block can drift from the original test (it already omits two assertions).\n\n**Suggestion**:\nMake this test exercise what its name claims, e.g. exclude two of four compute nodes (or use an explicit multi-node inclusion list) and assert the data model matches, or drop the test and keep the single exclusion test.","commit_id":"f199bd0f2e9e12274ca4739fec2f6d1aeb2081ed"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u0027a1b2c3d4-e5f6-4789-a012-3456789abcde\u0027)"},{"line_number":57,"context_line":"    @decorators.attr(type\u003d[\u0027scope\u0027])"},{"line_number":58,"context_line":"    def test_audit_scope_with_compute_nodes(self):"},{"line_number":59,"context_line":"        \"\"\"Verify that scope filters data model to specified compute nodes."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        This test validates that when an audit scope is defined with specific"}],"source_content_type":"text/x-python","patch_set":15,"id":"c1649efa_08f4b18d","line":58,"updated":"2026-10-20 14:19:04.000000000","message":"I like the idea of creating audits with different scopes and checking the model content independently of the strategy used here. However, i\u0027d use it to validate more cases. Here you are only validating the exclude.compute_nodes, but we may also add tests for other cases\n\nThe schema of the scope for compute is in https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/collector/nova.py#L46\n\n as:\n\n- Use exclude.instances (check that the instance in exclude have watcher_exclude \u003d true).\n- Use exclude.projects (check that the instance in exclude have watcher_exclude \u003d true).\n- Use exclude.instance_metadata. For that we need to add some metadata to any of the instances we create.\n\nAlso, we can set host_aggregates as initial list of hosts to be included or in exclude. May we create a host_aggregate in the job, add one of the hosts and exclude it later?\n\n\n-","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ed5350453571c6d9c1522144987827f41cedade2","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Define scope: exclude the third compute node"},{"line_number":84,"context_line":"        # This effectively limits the scope to the first two nodes"},{"line_number":85,"context_line":"        scoped_nodes \u003d [compute_nodes[0][\u0027host\u0027], compute_nodes[1][\u0027host\u0027]]"},{"line_number":86,"context_line":"        excluded_node \u003d compute_nodes[2][\u0027host\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        audit_scope \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"ff7fb732_4c650281","line":85,"updated":"2026-10-14 08:19:09.000000000","message":"Both tests in test_audit_scope.py guard with check_min_enabled_compute_nodes(3), which only enforces a minimum, but they build the audit scope by excluding a fixed subset of the first three nodes and then assert the scoped data model equals exactly the remaining one or two nodes. On any deployment with more than three enabled compute nodes, the non-excluded fourth (and later) nodes legitimately remain in the scoped model, so the exact-equality assertions fail even when audit scope filtering works correctly. The strategy-specific scope tests avoid this by asserting only membership (assertNotIn for excluded, assertIn for in-scope), which is node-count agnostic.\n\n**Severity**: WARNING | **Confidence**: 0.86\n\n**Impact**: On any CI job or operator lab with more than three enabled compute nodes, both new generic scope tests report false failures even though Watcher\u0027s audit scope works correctly, contradicting the tests\u0027 own minimum-node guard and reducing trust in the suite the change adds.\n\n**Suggestion**:\nDerive the exclusion list from the intended scoped set instead of fixed indices, e.g. audit_scope excluding every node not in scoped_nodes: excluded \u003d [{\"name\": n[\u0027host\u0027]} for n in compute_nodes if n[\u0027host\u0027] not in scoped_nodes]. Alternatively, keep the fixed exclusion and relax the assertions to assertNotIn for the excluded node(s) plus assertIn for the scoped nodes (matching the strategy-specific scope tests), and filter expected_instances accordingly.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"eadfc82574a016ffc9bca2542e1a39ffad3c59cb","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Verify that only the scoped nodes are in the data model"},{"line_number":138,"context_line":"        LOG.info(f\"Nodes in scoped model: {nodes_in_model}\")"},{"line_number":139,"context_line":"        self.assertEqual(nodes_in_model, set(scoped_nodes),"},{"line_number":140,"context_line":"                         f\"Data model should contain only {scoped_nodes}, \""},{"line_number":141,"context_line":"                         f\"but contains: {nodes_in_model}\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ab2a7042_8ba9cd95","line":139,"updated":"2026-10-13 14:22:50.000000000","message":"Both generic tests in test_audit_scope.py build the audit scope only by excluding compute_nodes[1] (and compute_nodes[2] in the second test) and then assert the scoped data model contains exactly scoped_nodes via set equality. check_min_enabled_compute_nodes(3) only enforces \u003e\u003d3 nodes, not exactly 3. On any deployment with more than three enabled compute nodes, nodes outside compute_nodes[0:3] remain in scope, so Watcher legitimately includes them in the scoped model and both tests fail even though audit scope filtering works correctly.\n\n**Severity**: WARNING | **Confidence**: 0.82\n\n**Impact**: On clouds with more than three compute nodes (a common topology for operators running this plugin against real deployments), both new tests report spurious failures against a correctly functioning Watcher, producing false regressions and eroding trust in the suite; on exactly-three-node CI the defect stays hidden.\n\n**Suggestion**:\nEither exclude every node outside the intended scope, e.g. excluded_nodes \u003d [n[\u0027host\u0027] for n in compute_nodes[2:]], so the scoped model contents are fully determined for any topology, or weaken the assertions to the properties actually under test (assertNotIn for each excluded node, assertIn for each scoped node), matching the topology-safe pattern already used by the strategy host-scope tests.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"4d0755be1dbd4e76a611e27ce7f55b81d96c2603","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Verify that only the scoped nodes are in the data model"},{"line_number":138,"context_line":"        LOG.info(f\"Nodes in scoped model: {nodes_in_model}\")"},{"line_number":139,"context_line":"        self.assertEqual(nodes_in_model, set(scoped_nodes),"},{"line_number":140,"context_line":"                         f\"Data model should contain only {scoped_nodes}, \""},{"line_number":141,"context_line":"                         f\"but contains: {nodes_in_model}\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5eff048c_c0a3353b","line":139,"updated":"2026-10-14 11:31:50.000000000","message":"Both tests in test_audit_scope.py guard with check_min_enabled_compute_nodes(3), which enforces \u0027at least\u0027 (assertGreaterEqual), but then assert the audit-scoped compute data model contains exactly the first two (or first one) enabled compute nodes. Only compute_nodes[2] (test 1) or compute_nodes[1:3] (test 2) are excluded, so any fourth or later enabled node remains in scope and appears in the scoped model, making the exact-set equality assertions fail deterministically on clusters with more than three enabled compute nodes, even though the docstrings assume a 3-node scenario.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: On any valid deployment with four or more enabled compute nodes, the two generic scope tests fail regardless of Watcher\u0027s correctness, producing false CI failures for downstream users and third-party CI. Because the tests are on by default, operators consuming the plugin get unreliable signal exactly where the change aims to increase coverage.\n\n**Suggestion**:\nBuild the exclude list from every enabled node outside the intended scoped set (e.g., excluded \u003d all enabled nodes minus compute_nodes[0:2], or minus compute_nodes[0]) so the exact-set assertions hold on any cluster size; alternatively skip unless the environment has exactly three enabled compute nodes. The first option keeps the tests running everywhere and mirrors the spirit of the bc33530 fix.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"da394b2ccbb4e68b727ab70dd6cd01f7530d575f","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Verify that only the scoped nodes are in the data model"},{"line_number":138,"context_line":"        LOG.info(f\"Nodes in scoped model: {nodes_in_model}\")"},{"line_number":139,"context_line":"        self.assertEqual(nodes_in_model, set(scoped_nodes),"},{"line_number":140,"context_line":"                         f\"Data model should contain only {scoped_nodes}, \""},{"line_number":141,"context_line":"                         f\"but contains: {nodes_in_model}\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"de8a800f_1e22d5ad","line":139,"updated":"2026-10-13 07:50:08.000000000","message":"test_audit_scope_with_compute_nodes (line 139) and test_audit_scope_with_multiple_compute_nodes (line 234) assert the scoped data model equals exactly the first two (resp. first one) enabled compute nodes. But the audit scope only excludes compute_nodes[2] (resp. compute_nodes[1] and [2]); every other enabled node legitimately remains in scope. The gate used is check_min_enabled_compute_nodes(3), which base.py:273-277 implements as assertGreaterEqual, so deployments with 4+ enabled compute nodes are admitted and then fail spuriously because nodes beyond index 2 appear in nodes_in_model. The instance-set assertion (lines 149-155) breaks the same way when CONF.compute.min_compute_nodes \u003e 3, since _create_one_instance_per_host then creates instances on non-excluded nodes outside scoped_nodes. The strategy-specific scope tests added in this same change correctly use assertNotIn/assertIn membership checks instead; only this generic module uses exact set equality.\n\n**Severity**: WARNING | **Confidence**: 0.82\n\n**Impact**: On any cloud with more than 3 enabled compute nodes (or min_compute_nodes \u003e 3), the two new generic audit-scope tests fail even when Watcher\u0027s scope filtering works correctly, producing false CI failures for the very bug fixes (2154805-7) this suite is meant to validate across branches. Since run_scope_tests defaults to True, any operator running the plugin against a larger cloud hits this.\n\n**Suggestion**:\nReplace exact set equality with membership assertions that hold for any node count: assert the excluded node(s) are absent, the scoped nodes and their instances are present, and no instances on excluded nodes appear in the model (the pattern already used by the strategy-specific host-scope tests in this change), or skip unless the deployment has exactly 3 enabled nodes.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"eadfc82574a016ffc9bca2542e1a39ffad3c59cb","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    def test_audit_scope_with_multiple_compute_nodes(self):"},{"line_number":160,"context_line":"        \"\"\"Verify that scope works when multiple compute nodes are excluded."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        This test validates that when several compute nodes are excluded from"},{"line_number":163,"context_line":"        the scope at once, none of them (nor their instances) appear in the"},{"line_number":164,"context_line":"        resulting data model. Uses 3 nodes where 2 are excluded and 1 remains"},{"line_number":165,"context_line":"        in scope."}],"source_content_type":"text/x-python","patch_set":15,"id":"4373ec21_39f6c4e6","line":162,"updated":"2026-10-13 14:22:50.000000000","message":"The docstring of test_audit_scope_with_multiple_compute_nodes states that when several compute nodes are excluded, none of them \u0027nor their instances\u0027 appear in the resulting data model, but the test only collects node_hostname values and never inspects server_uuid entries. Its sibling test_audit_scope_with_compute_nodes does verify instance-level exclusion, so the suite\u0027s documentation claims coverage that the implementation does not provide.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Impact**: Maintainers reading the docstring will assume multi-node exclusion also removes the excluded nodes\u0027 instances from the model; if that behavior regresses in Watcher, no assertion fails, and future edits may rely on a guarantee the suite does not actually check.\n\n**Recommendation**:\nEither add the instance assertions, reusing the expected_instances filtering pattern from test_audit_scope_with_compute_nodes (lines 148-155), or correct the docstring to state that only node membership is verified.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_basic_optim.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"25692dfc40cca801a85ddc719aee677f10bd6de5","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":323,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":326,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":327,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":328,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ab3c50e2_f303a8a2","line":325,"updated":"2026-09-25 11:38:53.000000000","message":"Twelve of the sixteen new scope tests wrap their exclusion assertions inside \u0027if len(action_plans[\u0027action_plans\u0027]) \u003e 0:\u0027 blocks, six of them additionally under \u0027if len(migrate_actions) \u003e 0:\u0027. If Watcher produces no action plan, or an action plan with no migrate actions, every assertion is skipped and the test passes while checking nothing. This undermines the change\u0027s stated purpose: the four instance-scope tests documented as PASS (basic, vm_workload_consolidation, workload_balance, workload_stabilization) cannot distinguish \u0027strategy respects watcher_exclude\u0027 from \u0027nothing was produced to check\u0027, and the FAIL-documented tests (e.g. node_resource_consolidation instance scope) can silently turn their intended FAIL into a PASS. The zone_migration and host_maintenance scope tests instead use get_action_plan_and_validate_actions, which fails loudly when no action plan exists, so the signal is inconsistent within one change.\n\n**Severity**: WARNING | **Confidence**: 0.82\n\n**Impact**: The suite can report PASS for exclusion behavior it never checked, giving false confidence in the conclusions the change documents about which strategies respect instance exclusion, and letting bug-documentation tests silently stop failing if Watcher stops producing action plans.\n\n**Suggestion**:\nUse get_action_plan_and_validate_actions (or fail explicitly when the action plan or migrate actions are missing) in the conditional scope tests, matching the pattern already used by the zone_migration and host_maintenance scope tests.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ef7faa03df548e3c3fa19c66bea977b8f4c7aa86","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":323,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":326,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":327,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":328,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"63d1c83f_3db3069b","line":325,"updated":"2026-10-06 14:59:33.000000000","message":"In five of the new scope test files, the instance-scope tests wrap every assertion inside \"if len(action_plans[\u0027action_plans\u0027]) \u003e 0:\" and add no positive control (asserting the non-excluded instances ARE migrated) and no action-plan state check. If the audit produces no action plan, or no migrate actions, the tests end silently in a pass. The node_resource_consolidation instance-scope test adds a second nested \"if len(migrate_actions) \u003e 0:\" guard. This diverges from the strict pattern used by the zone_migration and host_maintenance scope tests in the same change, which call get_action_plan_and_validate_actions; that helper fails loudly when no plan exists (it indexes action_plans[0]) and validates the expected action types.\n\n**Severity**: WARNING | **Confidence**: 0.88\n\n**Impact**: A watcher regression that makes these strategies recommend nothing (empty or missing action plan) would pass these verification tests silently, defeating the purpose stated in their docstrings (\"Verify excluded instances are NOT in action plan\"). The node_resource_consolidation test, documented as expected to fail to expose bug 2154806, would instead silently pass if the buggy strategy recommends no migrate actions at all, masking the bug it claims to document.\n\n**Suggestion**:\nUse get_action_plan_and_validate_actions as the zone_migration and host_maintenance scope tests do, and additionally assert that the non-excluded instances are present in the migrate actions so the test has a positive control.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"02d5a934f336dea6edc8aca033e939eeaafbe844","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                               if a[\u0027action_type\u0027] \u003d\u003d \u0027migrate\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            # If there are migrate actions, verify they don\u0027t include host2"},{"line_number":226,"context_line":"            if len(migrate_actions) \u003e 0:"},{"line_number":227,"context_line":"                for action in migrate_actions:"},{"line_number":228,"context_line":"                    _, action_detail \u003d self.client.show_action("},{"line_number":229,"context_line":"                        action[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"339511ac_82c66a36","line":226,"updated":"2026-10-08 11:08:49.000000000","message":"Ten of the new scope tests wrap their exclusion checks in \u0027if len(action_plans[\"action_plans\"]) \u003e 0:\u0027 and, in most cases, \u0027if len(migrate_actions) \u003e 0:\u0027. When the strategy produces no migrate actions, the test completes without ever executing the exclusion assertion and reports success vacuously. This is weaker than the zone_migration and host_maintenance scope tests in the same change, which fetch the action plan via get_action_plan_and_validate_actions with expected action types and hard-assert exact migrate counts.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: An environment issue or a watcher regression that yields an empty recommendation makes these ten tests pass without validating scope exclusion at all, masking exactly the regressions (e.g. bugs 2154805-2154807) the change was added to detect, while CI reports green.\n\n**Suggestion**:\nAssert the expected non-empty outcome before checking exclusion: assert the non-excluded instances ARE migrated (as test_execute_zone_migration_with_instance_scope does with assertEqual(2, len(migrate_actions)) plus assertIn), or fail explicitly when migrate_actions is empty, so the exclusion property cannot pass vacuously.","commit_id":"f199bd0f2e9e12274ca4739fec2f6d1aeb2081ed"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"624987375ab89f9d09bdcf904eed44b343711384","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":211,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":214,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":215,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":216,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"33a837a3_b428350a","line":213,"updated":"2026-10-09 08:22:55.000000000","message":"In five new host-scope tests (basic, workload_balance, workload_stabilization, vm_workload_consolidation, node_resource_consolidation) the action-plan verification is wrapped in \u0027if len(action_plans[\u0027action_plans\u0027]) \u003e 0:\u0027 and \u0027if len(migrate_actions) \u003e 0:\u0027 guards, so if the audit produces no action plan or no migrate actions, the migration-exclusion checks are silently skipped. These tests also only assert that the excluded host and its instance are absent from the data model (assertNotIn); there is no positive assertion that the in-scope host or any instance is present, so an empty or over-filtered data model would satisfy every unconditional assertion. The instance-scope tests added in the same commit explicitly guard against this hazard with assertNotEmpty and a comment acknowledging that the checks would otherwise \u0027pass vacuously\u0027, making the inconsistency visible within one patch.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The host-scope tests can report success without exercising their migration-exclusion checks or with no scoped data present at all, weakening regression protection for exactly the watcher scope bugs this suite was written to validate (bugs 2154805/2154806/2154807 per the commit message).\n\n**Suggestion**:\nAfter fetching the data model, add positive assertions (e.g. self.assertIn(host1, nodes_in_model) or assert instances_in_model is not empty), and replace the conditional blocks with explicit assertions like the instance-scope tests use; if an empty action plan is genuinely possible for these setups, extract a shared helper (e.g. assert_excluded_from_action_plan) that asserts or explicitly skips, so a silent pass cannot occur.","commit_id":"bd0eed80eaf274691a09a906688650105dbb448a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"785cec3f618335963ed10b8ccdab0f1a6fcad858","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":218,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":221,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":222,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":223,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"e8505946_6ce953a5","line":220,"updated":"2026-10-09 09:59:49.000000000","message":"In the five new host-scope tests, the action-plan and migrate-action inspections are nested inside \u0027if len(action_plans[\u0027action_plans\u0027]) \u003e 0:\u0027 and \u0027if len(migrate_actions) \u003e 0:\u0027 guards. If the strategy recommends nothing, all assertions about which instances may be migrated are skipped and the test passes. The instance-scope counterparts added in the same change deliberately avoid this with assertNotEmpty plus a comment that the checks \u0027would pass vacuously\u0027 otherwise, so the two halves of the suite apply different rigor to the same claim.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: When an audit yields no action plan or no migrate actions (for example if injected metrics fail to trigger a recommendation, or a watcher regression suppresses recommendations entirely), the host-scope tests still pass without having verified that instances on the excluded node are never selected. A backported-fix regression could then land with green CI, defeating the purpose documented in the commit message.\n\n**Suggestion**:\nMirror the instance-scope tests: assert the action plan and migrate actions are non-empty (assertNotEmpty) before inspecting them, or additionally assert that the in-scope instance is present in the migrated set, so exclusion is only accepted when a comparable migration plan actually exists.","commit_id":"551f44405e24a59c01de7ee84ce44a353aafd0f5"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":218,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":221,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":222,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":223,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"a8ac0d79_04000096","line":220,"updated":"2026-10-20 14:19:04.000000000","message":"I think we should not need this condition?. I\u0027d say the action plan should always be created, otherwise would be some form of issue.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                               if a[\u0027action_type\u0027] \u003d\u003d \u0027migrate\u0027]"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            # If there are migrate actions, verify they don\u0027t include host2"},{"line_number":233,"context_line":"            if len(migrate_actions) \u003e 0:"},{"line_number":234,"context_line":"                for action in migrate_actions:"},{"line_number":235,"context_line":"                    _, action_detail \u003d self.client.show_action("},{"line_number":236,"context_line":"                        action[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"f137e29a_49f2a72b","line":233,"range":{"start_line":233,"start_character":15,"end_line":233,"end_character":18},"updated":"2026-10-20 14:19:04.000000000","message":"In some case we may have 0 migrate_actions ?","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_host_maintenance.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @decorators.idempotent_id(\u0027e5f6a7b8-c9d0-4e1f-2a3b-4c5d6e7f8a9b\u0027)"},{"line_number":208,"context_line":"    @decorators.attr(type\u003d[\u0027strategy\u0027, \u0027host_maintenance\u0027, \u0027scope\u0027])"},{"line_number":209,"context_line":"    def test_execute_host_maintenance_with_instance_scope(self):"},{"line_number":210,"context_line":"        \"\"\"Verify that instance exclusion via scope works (or fails)."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        This test validates whether host_maintenance respects the"}],"source_content_type":"text/x-python","patch_set":2,"id":"591dc957_ba2999d9","line":209,"updated":"2026-07-02 11:41:05.000000000","message":"The three expected-failure tests reference bugs only in docstrings (with the wrong number). Tempest supports machine-readable @decorators.related(\u0027bug\u0027, \u0027NNNNN\u0027) linkage.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Machine-readable bug linkage is more durable than docstring comments and enables automated tracking of when expected failures can be removed once bugs are fixed.\n\n**Recommendation**:\nAfter correcting the bug numbers (critical C2), consider adding @decorators.related(\u0027bug\u0027, \u00272154805\u0027) to each failing test for robust tracking.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @decorators.idempotent_id(\u0027e5f6a7b8-c9d0-4e1f-2a3b-4c5d6e7f8a9b\u0027)"},{"line_number":208,"context_line":"    @decorators.attr(type\u003d[\u0027strategy\u0027, \u0027host_maintenance\u0027, \u0027scope\u0027])"},{"line_number":209,"context_line":"    def test_execute_host_maintenance_with_instance_scope(self):"},{"line_number":210,"context_line":"        \"\"\"Verify that instance exclusion via scope works (or fails)."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        This test validates whether host_maintenance respects the"}],"source_content_type":"text/x-python","patch_set":2,"id":"f987948f_a8711722","line":209,"updated":"2026-07-02 11:41:05.000000000","message":"Three tests documented as \u0027expected to FAIL\u0027 lack the @decorators.expectedFailure decorator. When run_scope_tests\u003dTrue they will fail as hard gate errors instead of xfails.\n\n**Severity**: CRITICAL | **Confidence**: 1.0\n\n**Risk**: Enabling run_scope_tests in any CI job will turn the gate red with hard test failures rather than recording known-bug xfails, defeating the stated purpose of the patch.\n\n**Priority**: Before merge\n**Why This Matters**: The commit message explicitly states \u00273 FAIL and document bugs\u0027. Without expectedFailure the tests cannot serve their intended purpose of documenting bugs without blocking CI.\n\n**Recommendation**:\nAdd @decorators.expectedFailure to test_execute_host_maintenance_with_instance_scope, test_execute_node_resource_consolidation_with_instance_scope, and test_execute_zone_migration_with_instance_scope. Alternatively use @decorators.skip_because(bug\u003d\u0027...\u0027) to skip until the bugs are fixed.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        does NOT check this flag, so this test is expected to FAIL,"},{"line_number":215,"context_line":"        documenting the bug."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        Steps:"},{"line_number":220,"context_line":"        1. Create 2 instances on maintenance_node"}],"source_content_type":"text/x-python","patch_set":2,"id":"5265dc5a_5c9bfbcb","line":217,"updated":"2026-07-02 11:41:05.000000000","message":"Bug number mismatch: all three failing-test docstrings reference bug #2151776, but the commit message references distinct bugs #2154805, #2154806, #2154807 for each strategy.\n\n**Severity**: CRITICAL | **Confidence**: 0.9\n\n**Risk**: Incorrect bug references mislead developers tracing test failures and break the bug-tracking linkage that these tests are specifically designed to provide.\n\n**Priority**: Before merge\n**Why This Matters**: The tests exist to document specific strategy bugs. Pointing all three at the wrong single bug number (2151776) makes the tracking useless and contradicts the commit message.\n\n**Recommendation**:\nCorrect each docstring to reference the matching bug from the commit message: host_maintenance to #2154805, node_resource_consolidation to #2154806, zone_migration to #2154807. The same wrong reference appears at test_execute_node_resource_consolidation.py:196 and test_execute_zone_migration.py:255.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        3. Create audit with host_maintenance"},{"line_number":223,"context_line":"        4. Verify excluded instance is NOT migrated (will fail - bug)"},{"line_number":224,"context_line":"        \"\"\""},{"line_number":225,"context_line":"        self.check_min_enabled_compute_nodes(2)"},{"line_number":226,"context_line":"        self.addCleanup(self.rollback_compute_nodes_status)"},{"line_number":227,"context_line":"        self.addCleanup(self.wait_delete_instances_from_model)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7b0efab9_9bb89521","line":225,"updated":"2026-07-02 11:41:05.000000000","message":"test_execute_host_maintenance_with_instance_scope places both instances on a single maintenance_node, unlike the zone_migration and vm_workload_consolidation instance_scope tests which spread instances across two hosts.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Consistent multi-host instance placement across all instance_scope tests would make the suite easier to reason about and provide more thorough coverage of the exclusion path.\n\n**Recommendation**:\nEvaluate whether 2 instances on a single host sufficiently exercises the instance-exclusion path for host_maintenance. If the strategy only migrates from the maintenance node, the current setup may be acceptable, but document the rationale.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"cea9c04d968e421902cb6aded62236f6d0de9a08","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        documenting the bug."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        Steps:"},{"line_number":220,"context_line":"        1. Create 2 instances on maintenance_node"},{"line_number":221,"context_line":"        2. Define scope excluding 1 instance"}],"source_content_type":"text/x-python","patch_set":6,"id":"2e702979_c8985cf1","line":218,"updated":"2026-09-22 09:32:00.000000000","message":"The three instance-scope tests that document watcher bugs all reference the same Launchpad bug 2151776 in their docstrings, while the commit message and the Depends-On watcher fix use three distinct per-strategy bugs (#2154805 host_maintenance, #2154806 node_resource_consolidation, #2154807 zone_migration). The docstrings also state each test \u0027is expected to FAIL, documenting the bug\u0027, although this same change Depends-Ons the watcher fix that closes those bugs and makes the tests pass once merged.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: These tests are explicitly designed as executable bug documentation. Contradictory bug links misdirect maintainers to the wrong reports, and once the watcher fix merges the \u0027expected to FAIL\u0027 comments and failure messages become false, so any future failure of these tests would be misattributed to bugs that are already fixed.\n\n**Suggestion**:\nReference the per-strategy bug numbers from the commit message (2154805/2154806/2154807) in each docstring, or the correct shared bug if one exists, and reword the \u0027expected to FAIL\u0027 comments and assertion messages to state that the tests verify the watcher audit-scope exclusions fix rather than document an open bug.","commit_id":"70b52f49803fd93543fa67018d4fe5d212d13d86"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d3cf30022cdca9b5f2cca8b1bc9ce63404eda84b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        documenting the bug."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        Steps:"},{"line_number":220,"context_line":"        1. Create 2 instances on maintenance_node"},{"line_number":221,"context_line":"        2. Define scope excluding 1 instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"4cdb69e4_1d20e63c","line":218,"updated":"2026-09-24 08:08:27.000000000","message":"All three tests documented as expected to FAIL reference the same bug URL in their docstrings: test_execute_host_maintenance.py:218, test_execute_node_resource_consolidation.py:196, and test_execute_zone_migration.py:258 each say \u0027Related bug: https://bugs.launchpad.net/watcher/+bug/2151776\u0027. The commit message instead documents three distinct bugs: #2154805 (host_maintenance), #2154806 (node_resource_consolidation), and #2154807 (zone_migration). At least one set of references is wrong, and the docstrings conflate three separate per-strategy defects into a single identifier.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Anyone triaging the expected failures from the test code will look up or file the wrong bug, and three distinct watcher strategy bugs will be linked to one issue. This undermines the change\u0027s stated purpose of documenting which strategies ignore the watcher_exclude flag and tracking their fixes.\n\n**Suggestion**:\nReconcile the references: point each expected-failure docstring at the specific bug listed in the commit message (2154805, 2154806, 2154807 respectively), or, if 2151776 is a single tracking bug, correct the commit message to say so and keep the docstrings consistent with it.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3f754add284378564b64c30aa86c7b8d7b1c4f88","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        documenting the bug."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        Steps:"},{"line_number":220,"context_line":"        1. Create 2 instances on maintenance_node"},{"line_number":221,"context_line":"        2. Define scope excluding 1 instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"d080f739_c3c9c89c","line":218,"updated":"2026-09-23 14:06:50.000000000","message":"The three instance-scope tests written to document watcher bugs each carry \"Related bug: https://bugs.launchpad.net/watcher/+bug/2151776\", but the commit message states the tests document bugs #2154805 (host_maintenance), #2154806 (node_resource_consolidation), and #2154807 (zone_migration). No file in this change references 2154805-2154807, and the commit message never mentions 2151776, so the bug-tracking trail is internally inconsistent.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: Anyone tracing an expected failure from the commit history to the tests (or from a failing test back to the tracker) lands on different bug numbers, weakening the per-strategy bug documentation that is this change\u0027s stated purpose and risking follow-up fixes being filed against the wrong report.\n\n**Recommendation**:\nAlign the references: cite the per-strategy bug numbers from the commit message in the corresponding test docstrings, or reference 2151776 in the commit message as the umbrella report, so failures are traceable to the intended reports.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"5e830836b74ff7d74bca7d0ac294e33bff8e131e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        documenting the bug."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        Steps:"},{"line_number":220,"context_line":"        1. Create 2 instances on maintenance_node"},{"line_number":221,"context_line":"        2. Define scope excluding 1 instance"}],"source_content_type":"text/x-python","patch_set":9,"id":"f8631638_38f96f62","line":218,"updated":"2026-09-24 13:23:20.000000000","message":"The commit message documents three distinct per-strategy bugs (2154805 host_maintenance, 2154806 node_resource_consolidation, 2154807 zone_migration), but the expected-to-fail test docstrings all reference the same report, https://bugs.launchpad.net/watcher/+bug/2151776. At least one set of references is wrong, and the permanent test documentation points future readers to conflicting bug reports.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Developers triaging the expected failures cannot tell which bug reports are authoritative; wrong links misdirect subscribers and can leave the real bugs untriaged or spawn duplicate reports against the wrong issue.\n\n**Suggestion**:\nUpdate the three docstrings to cite the per-strategy bug numbers from the commit message, or, if 2151776 is the correct single report, correct the commit message before merge so the permanent history and the code agree.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ccaab69b2bed1f60151c9fe737b54e1ded96469a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        does NOT check this flag, so this test is expected to FAIL,"},{"line_number":216,"context_line":"        documenting the bug."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        Steps:"},{"line_number":221,"context_line":"        1. Create 2 instances on maintenance_node"}],"source_content_type":"text/x-python","patch_set":10,"id":"dc831cb6_476b1532","line":218,"updated":"2026-10-07 15:46:27.000000000","message":"All three instance-scope tests that are expected to fail reference the same bug in their docstrings (\u0027Related bug: https://bugs.launchpad.net/watcher/+bug/2151776\u0027), but the commit message says each test documents a distinct, per-strategy bug: 2154805 for host_maintenance, 2154806 for node_resource_consolidation, and 2154807 for zone_migration. Either the docstrings or the change message points reviewers at the wrong report(s).\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Anyone triaging the failing tests, closing the bugs, or reading the permanent test documentation will follow a reference that contradicts the change message. The three per-strategy bugs may never be linked to the tests that document them (or the tests keep pointing at an unrelated umbrella report), causing duplicated triage and incorrect bug closure.\n\n**Suggestion**:\nUpdate each expected-failure docstring to cite its specific bug from the commit message (2154805 in test_execute_host_maintenance.py, 2154806 in test_execute_node_resource_consolidation.py, 2154807 in test_execute_zone_migration.py), or, if 2151776 is the intended umbrella report, correct the commit message so both references agree.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":338,"context_line":"        self.wait_for_instances_in_model(instances)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # Define scope: exclude host2"},{"line_number":341,"context_line":"        audit_scope \u003d ["},{"line_number":342,"context_line":"            {"},{"line_number":343,"context_line":"                \"compute\": ["},{"line_number":344,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":15,"id":"0ddbd153_5ccf4261","line":341,"updated":"2026-10-20 14:19:04.000000000","message":"With this test we are actually not validating any scope functionality. We are excluding a compute node which is actually not involved in the audit. The only valid test for excluding compute_nodes in host_maintenance would be to exclude maintenance_node which should produce and empty action plan. Other than that, it doesn\u0027t make much sense to test exclude.compute_nodes in host_maintenance.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_node_resource_consolidation.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7de235d482badc6ba0b1f25920edb30c63c6462b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":264,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":267,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":268,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":269,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"6996b1c5_0eb665c5","line":266,"updated":"2026-07-02 11:41:05.000000000","message":"node_resource_consolidation instance_scope test nests all assertions inside if-len-greater-than-0 conditionals, so it passes vacuously if no action plan or migrate actions are produced.\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: If the strategy produces zero actions (e.g. instances too small to consolidate), the test passes without verifying that the excluded instance was respected. The instance-exclusion bug goes undetected.\n\n**Priority**: Before merge\n**Why This Matters**: A test that can pass without exercising the behavior under test provides false confidence. The same conditional-guard pattern affects host_scope tests in basic_optim, workload_balance, workload_stabilization, and vm_workload_consolidation.\n\n**Recommendation**:\nAssert that an action plan with migrate actions exists before the conditional checks, or restructure to use get_action_plan_and_validate_actions (as host_maintenance does) which fails if no actions are produced.","commit_id":"dbee62ca0aea5de2d23501df78f19fec3effb542"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"fd982a60626df5169b75ebf3b30b17cf37fce4e4","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        _, action_plans \u003d self.client.list_action_plans("},{"line_number":264,"context_line":"            audit_uuid\u003daudit[\u0027uuid\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        if len(action_plans[\u0027action_plans\u0027]) \u003e 0:"},{"line_number":267,"context_line":"            action_plan \u003d action_plans[\u0027action_plans\u0027][0]"},{"line_number":268,"context_line":"            _, action_plan_detail \u003d self.client.show_action_plan("},{"line_number":269,"context_line":"                action_plan[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"32547f2c_c29400a0","line":266,"updated":"2026-09-16 14:09:32.000000000","message":"In six of the eight extended strategy files, the new Scope tests execute their action-plan and action assertions only inside \u0027if len(action_plans[\"action_plans\"]) \u003e 0:\u0027 and \u0027if len(migrate_actions) \u003e 0:\u0027 blocks. If watcher produces no action plan, or an action plan with no migrate actions, the test completes with no strategy-level assertion at all. The instance-scope tests never assert that the non-excluded instances WERE recommended for migration, so an over-exclusion regression that empties the action plan (the mirror image of the bugs this suite documents) passes silently. This also undermines the bug-documentation design: test_execute_node_resource_consolidation_with_instance_scope is documented as expected to FAIL, yet it passes vacuously whenever the strategy recommends nothing.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Regressions in exactly the behavior this suite targets are masked: an empty or migrate-free action plan yields a green run, the PASS-expected instance-scope tests cannot detect over-exclusion, and the expected-FAIL node_resource_consolidation test loses its documented failure signal on environments where the strategy recommends nothing.\n\n**Suggestion**:\nAssert unconditionally that the finished audit produced an action plan, and where the scenario expects migrations, assert that the expected non-excluded instance UUIDs appear in migrated_uuids before or alongside the existing assertNotIn exclusion checks; reusing get_action_plan_and_validate_actions as the sibling regular tests do provides this for free.","commit_id":"d1e415b1ff929e995bd5bcd771adb8610c19848a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d3cf30022cdca9b5f2cca8b1bc9ce63404eda84b","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            migrate_actions \u003d [a for a in actions"},{"line_number":276,"context_line":"                               if a[\u0027action_type\u0027] \u003d\u003d \u0027migrate\u0027]"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            if len(migrate_actions) \u003e 0:"},{"line_number":279,"context_line":"                # Get full details for each action"},{"line_number":280,"context_line":"                migrated_uuids \u003d []"},{"line_number":281,"context_line":"                for action in migrate_actions:"}],"source_content_type":"text/x-python","patch_set":8,"id":"44c9159b_26f394cf","line":278,"updated":"2026-09-24 08:08:27.000000000","message":"The new scope tests wrap their action-plan assertions in \u0027if len(action_plans[\\\u0027action_plans\\\u0027]) \u003e 0:\u0027 and \u0027if len(migrate_actions) \u003e 0:\u0027. When an audit produces no action plan or no migrate actions, these tests complete successfully without running a single assertion and without verifying that non-excluded instances were migrated. This affects the instance-scope tests in test_execute_basic_optim.py, test_execute_node_resource_consolidation.py, test_execute_vm_workload_consolidation.py, test_execute_workload_balance.py, and test_execute_workload_stabilization.py. The pre-existing tests in these same files, and the new host_maintenance and zone_migration scope tests, instead use get_action_plan_and_validate_actions(), which fails when no action plan is returned.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: A regression or environment issue that causes a strategy to emit no recommendations makes the exclusion tests pass vacuously, giving false confidence that instance exclusion is respected. For node_resource_consolidation the test is explicitly written to fail while bug #2154806 exists; an empty action plan would silently pass, defeating that documented bug-coverage purpose.\n\n**Suggestion**:\nUse self.get_action_plan_and_validate_actions(audit[\u0027uuid\u0027], [\u0027migrate\u0027]) as the existing tests in these files do, then assert the excluded instance is absent and at least one non-excluded instance is present among the migrated resource_ids, so an empty action plan fails loudly instead of passing silently.","commit_id":"733b5eac0100d7cd02e7a27912e729d5458de1bc"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":258,"context_line":"            audit_template[\u0027uuid\u0027], **audit_kwargs"},{"line_number":259,"context_line":"        )"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Verify the scope was applied in the compute data model: the excluded"},{"line_number":262,"context_line":"        # instance must be flagged watcher_exclude, while the others must not."},{"line_number":263,"context_line":"        # This is deterministic and does not depend on the strategy producing"},{"line_number":264,"context_line":"        # any migration."}],"source_content_type":"text/x-python","patch_set":15,"id":"652e660c_36078ab7","line":261,"updated":"2026-10-20 14:19:04.000000000","message":"We are actually testing exactly the same here that we did in the TestAuditScopeComputeModel class where we validate the content of the model, as it\u0027s independent of the strategy. In the tests associated to the strategies we should validate that the strategy uses properly the model (i.e. ignoring instances with watcher_exclude) by checking the content of the action plan, as done in the host_maintenance. Validating the content of the model only in strategy tests doesn\u0027t add much value.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"            # If there are migrate actions, verify they don\u0027t include"},{"line_number":409,"context_line":"            # excluded_node"},{"line_number":410,"context_line":"            if len(migrate_actions) \u003e 0:"},{"line_number":411,"context_line":"                for action in migrate_actions:"},{"line_number":412,"context_line":"                    _, action_detail \u003d self.client.show_action("},{"line_number":413,"context_line":"                        action[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"a5912db0_c9bd3913","line":410,"updated":"2026-10-20 14:19:04.000000000","message":"This test is correct. I suspect that this test is needed to pass in 2-nodes cluster where a consolidation strategy with a host excluded would produce no migration at all?. If so, i think validating that when there are two compute_nodes, the action plan is empty would be a good test instead of just accepting it without any check. I understand the same applies to some other tests.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_vm_workload_consolidation.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":424,"context_line":"            audit_template[\u0027uuid\u0027], **audit_kwargs"},{"line_number":425,"context_line":"        )"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        # Verify the scope was applied in the compute data model: the excluded"},{"line_number":428,"context_line":"        # instances must be flagged watcher_exclude, while the others must not."},{"line_number":429,"context_line":"        # This is deterministic and does not depend on the strategy producing"},{"line_number":430,"context_line":"        # any migration."}],"source_content_type":"text/x-python","patch_set":15,"id":"e749c98b_24c2c093","line":427,"updated":"2026-10-20 14:19:04.000000000","message":"See my other comment. It doesn\u0027t make sense to have multiple tests only checking the content of the model with different strategies, as the model build process is independent of the strategy.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_workload_balance.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":547,"context_line":"            audit_template[\u0027uuid\u0027], parameters\u003daudit_parameters"},{"line_number":548,"context_line":"        )"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        # Verify the scope was applied in the compute data model: the excluded"},{"line_number":551,"context_line":"        # instance must be flagged watcher_exclude, while the others must not."},{"line_number":552,"context_line":"        # This is deterministic and does not depend on the strategy producing"},{"line_number":553,"context_line":"        # any migration."}],"source_content_type":"text/x-python","patch_set":15,"id":"8e36a5ef_b30649bd","line":550,"updated":"2026-10-20 14:19:04.000000000","message":"same comment, we should validate the content of the actionplan or remove the test. Only checking the model does not help much.","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_workload_stabilization.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f197d41d93ac3c0e2bf5ad81c45ab6fbce4acb54","unresolved":true,"context_lines":[{"line_number":440,"context_line":"            audit_template[\u0027uuid\u0027], parameters\u003daudit_parameters"},{"line_number":441,"context_line":"        )"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        # Verify the scope was applied in the compute data model: the excluded"},{"line_number":444,"context_line":"        # instance must be flagged watcher_exclude, while the others must not."},{"line_number":445,"context_line":"        # This is deterministic and does not depend on the strategy producing"},{"line_number":446,"context_line":"        # any migration."}],"source_content_type":"text/x-python","patch_set":15,"id":"9e3bd3ca_e3566003","line":443,"updated":"2026-10-20 14:19:04.000000000","message":"ditto","commit_id":"4b3500e762a0a01c043296cdd4e3e48adb8794a4"}],"watcher_tempest_plugin/tests/scenario/test_execute_zone_migration.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"53fa4e3c7df9da786987685a1a94385dbebe868c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        Steps:"},{"line_number":258,"context_line":"        1. Create 2 instances on host1 and 2 on host2"},{"line_number":259,"context_line":"        2. Define scope excluding 1 instance from each host"},{"line_number":260,"context_line":"        3. Create audit with zone_migration (host1+host2 -\u003e host3)"},{"line_number":261,"context_line":"        4. Verify excluded instances are NOT in action plan (will fail)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df6d15aa_d951a8c3","line":258,"updated":"2026-09-15 13:52:37.000000000","message":"The three new instance-scope test docstrings each say \u0027Related bug: https://bugs.launchpad.net/watcher/+bug/2151776\u0027, but the change message documents three distinct bugs: #2154805 (host_maintenance ignores instance exclusions), #2154806 (node_resource_consolidation), and #2154807 (zone_migration), and links all three. A single bug number cannot represent three distinct per-strategy defects, so at least two of the three docstring references point to the wrong bug report.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: The permanent in-code documentation directs maintainers who investigate or fix these strategy defects to one shared bug report that contradicts the change\u0027s own bug list, misattributing at least two of the three bugs and slowing the future fixes these tests are meant to track.\n\n**Suggestion**:\nUpdate each docstring to cite the bug the commit message documents (2154805 for host_maintenance, 2154806 for node_resource_consolidation, 2154807 for zone_migration); if 2151776 is actually the correct umbrella bug, instead correct the commit message and say so in the docstrings.","commit_id":"fbf77b7592fa8905dbbaee4f572df79056edc313"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"fd982a60626df5169b75ebf3b30b17cf37fce4e4","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        Steps:"},{"line_number":258,"context_line":"        1. Create 2 instances on host1 and 2 on host2"},{"line_number":259,"context_line":"        2. Define scope excluding 1 instance from each host"},{"line_number":260,"context_line":"        3. Create audit with zone_migration (host1+host2 -\u003e host3)"},{"line_number":261,"context_line":"        4. Verify excluded instances are NOT in action plan (will fail)"}],"source_content_type":"text/x-python","patch_set":5,"id":"76634d13_6e503662","line":258,"updated":"2026-09-16 14:09:32.000000000","message":"All three instance-scope tests that are expected to fail embed \u0027Related bug: https://bugs.launchpad.net/watcher/+bug/2151776\u0027. The commit message instead maps these same tests to three distinct reports: Bug #2154805 (host_maintenance ignores instance exclusions), Bug #2154806 (node_resource_consolidation), and Bug #2154807 (zone_migration), and lists them under \u0027Related bugs\u0027 as what this suite documents. The tests and the commit message therefore disagree about which bug each failing test documents; one of the two references is wrong, or the tests omit the per-strategy bugs entirely.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: Broken traceability for future triage: a maintainer investigating the failing scope tests follows the docstring links to one report while the commit-message links point to three others, so the per-strategy bugs can appear unreferenced by the tests that are supposed to document them, and fixes may not remove or flip the right tests.\n\n**Recommendation**:\nConfirm the correct reports and cite the per-strategy IDs (2154805-07) in the matching test docstrings; keep the 2151776 link only if it is the umbrella report, and say so in the docstring to avoid ambiguity.","commit_id":"d1e415b1ff929e995bd5bcd771adb8610c19848a"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"5e830836b74ff7d74bca7d0ac294e33bff8e131e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def test_execute_zone_migration_with_host_scope(self):"},{"line_number":128,"context_line":"        \"\"\"Verify that host exclusion via scope works correctly."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        This test validates that when a compute node is excluded from the"},{"line_number":131,"context_line":"        scope, zone_migration will not migrate instances from it, and the"},{"line_number":132,"context_line":"        excluded node does not appear in the data model."},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"29f8708e_0313bee8","line":130,"updated":"2026-09-24 13:23:20.000000000","message":"The immediately preceding commit (227584a) added skip_if_missing_migration_hosts() and converted every existing directed live-migration test to configured host pairs because pinned source/destination hosts can sit in different Nova cells, where live migration is unsupported. The new scope tests reintroduce positionally selected, pinned source/destination pairs without calling the guard, in the very files the base commit just fixed.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: In multi-cell deployments, the exact scenario commit 227584a addressed, these tests fail intermittently through cross-cell live migration whenever scope tests are enabled, producing false signals about audit-scope behavior and undermining the suite\u0027s purpose of documenting strategy bugs reliably.\n\n**Suggestion**:\nCall self.skip_if_missing_migration_hosts() at the start of test_execute_zone_migration_with_host_scope, test_execute_zone_migration_with_instance_scope, and both host_maintenance scope tests, or derive the pinned pairs from CONF.compute.migration_source_host/migration_dest_host as the regular tests now do.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"25692dfc40cca801a85ddc719aee677f10bd6de5","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        Steps:"},{"line_number":258,"context_line":"        1. Create 2 instances on host1 and 2 on host2"},{"line_number":259,"context_line":"        2. Define scope excluding 1 instance from each host"},{"line_number":260,"context_line":"        3. Create audit with zone_migration (host1+host2 -\u003e host3)"},{"line_number":261,"context_line":"        4. Verify excluded instances are NOT in action plan (will fail)"}],"source_content_type":"text/x-python","patch_set":9,"id":"03e4fd0a_8d9be945","line":258,"updated":"2026-09-25 11:38:53.000000000","message":"All three instance-scope tests expected to fail point to the same single bug URL (2151776) in their docstrings, while the commit message documents three distinct strategy-specific bugs: #2154805 host_maintenance, #2154806 node_resource_consolidation, #2154807 zone_migration. At least one set of references is wrong; if the docstrings are stale, failures encountered when enabling run_scope_tests route contributors to one shared bug instead of the per-strategy tracking bugs the change announces.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Developers enabling scope tests and hitting the documented failures are directed to a bug reference that conflicts with the change\u0027s own bug list, weakening traceability and risking duplicate or misdirected bug reports.\n\n**Suggestion**:\nPoint each docstring at the strategy-specific bug from the commit message (host_maintenance 2154805, node_resource_consolidation 2154806, zone_migration 2154807), or correct the commit message if 2151776 is the intended umbrella bug.","commit_id":"6462068b817d544072d8ea4734a420fd06d75857"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ef7faa03df548e3c3fa19c66bea977b8f4c7aa86","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        flag for instances. As of now, zone_migration does NOT check this flag,"},{"line_number":256,"context_line":"        so this test is expected to FAIL, documenting the bug."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        Related bug: https://bugs.launchpad.net/watcher/+bug/2151776"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        Steps:"},{"line_number":261,"context_line":"        1. Create 2 instances on host1 and 2 on host2"}],"source_content_type":"text/x-python","patch_set":10,"id":"055b6f99_0c9faa80","line":258,"updated":"2026-10-06 14:59:33.000000000","message":"The three instance-scope tests documented as failing all link the same Launchpad bug 2151776 in their docstrings, while the commit message documents three distinct per-strategy bugs: 2154805 for host_maintenance, 2154806 for node_resource_consolidation, and 2154807 for zone_migration. The per-strategy bug numbers appear nowhere in the code, so a reader following the docstring links lands on one bug for all three strategies and loses the per-strategy tracking the commit message promises.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: Misdirects triage and long-term traceability: contributors investigating a failing scope test will follow the docstring link to a single bug rather than the per-strategy bugs recorded in the permanent change history, making it harder to tell when each strategy\u0027s exclusion bug is fixed and the test should stop failing.\n\n**Recommendation**:\nAlign the docstrings with the per-strategy bug numbers from the commit message (2154807 for zone_migration, 2154805 for host_maintenance, 2154806 for node_resource_consolidation), or, if 2151776 is the intended tracking bug, cite it consistently and drop the conflicting per-strategy numbers from the commit message on the next patchset.","commit_id":"4e50544aed8015ecea57fdca7995b87949d29b4a"}]}
