)]}'
{"watcher/decision_engine/goal/efficacy/pipeline.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"67addfd017bdf758c4b3a3cc6bbace0d1fbf0b4a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    name\u003d\u0027pipeline_instance_migrations_count\u0027,"},{"line_number":105,"context_line":"    description\u003d\u0027Total instance migrations across all pipeline stages\u0027,"},{"line_number":106,"context_line":"    unit\u003d\u0027\u0027,"},{"line_number":107,"context_line":"    source_names\u003d["},{"line_number":108,"context_line":"        \u0027instance_migrations_count\u0027,"},{"line_number":109,"context_line":"        \u0027planned_live_migrate_instance_count\u0027,"},{"line_number":110,"context_line":"        \u0027planned_cold_migrate_instance_count\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e708d68_b20dd53c","line":107,"updated":"2026-08-14 21:54:11.000000000","message":"INSTANCE_MIGRATIONS_GROUP sums both the candidate counters (live_migrate_instance_count) and the planned-action counters (planned_live_migrate_instance_count) for the same strategy, so a zone_migration stage contributes roughly double the actual migration count.\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: Action plans from pipelines containing zone_migration stages persist inflated EfficacyIndicator values, giving operators wrong efficacy data for the new pipeline feature.\n\n**Priority**: Before merge\n**Why This Matters**: Action plans from pipelines containing zone_migration stages persist inflated EfficacyIndicator values, giving operators wrong efficacy data for the new pipeline feature.\n\n**Recommendation**:\nFor zone_migration stages use only the planned_* variants (planned_live_migrate_instance_count, planned_cold_migrate_instance_count), and keep instance_migrations_count for the consolidation/workload strategies. Verify counts against the actual emitted migrate actions for each contributing strategy.","commit_id":"8938fd5e83a33c14a6cbb4adbced472be29bf2a6"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2249375c4888bd60554fe021a0713ce87bc89431","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the same concept is often measured with different indicator names across"},{"line_number":21,"context_line":"stages.  For example:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- ``zone_migration`` reports ``live_migrate_instance_count`` and"},{"line_number":24,"context_line":"  ``cold_migrate_instance_count`` separately."},{"line_number":25,"context_line":"- ``workload_stabilization`` and consolidation strategies report a single"},{"line_number":26,"context_line":"  ``instance_migrations_count`` for all migration types."}],"source_content_type":"text/x-python","patch_set":3,"id":"3213ecc5_7236d664","line":23,"updated":"2026-08-18 14:40:07.000000000","message":"The module docstring explains the naming divergence it solves by saying zone_migration reports ``live_migrate_instance_count`` and ``cold_migrate_instance_count`` separately, but the INSTANCE_MIGRATIONS_GROUP at line 107 sums ``instance_migrations_count``, ``planned_live_migrate_instance_count`` and ``planned_cold_migrate_instance_count``. zone_migration actually sets both total and planned variants (watcher/decision_engine/strategy/strategies/zone_migration.py:329-335), and only the planned_* variants feed the group. The names the docstring cites are never aggregated.\n\n**Severity**: SUGGESTION | **Confidence**: 0.95\n\n**Impact**: A developer extending the aggregation groups or debugging indicator values from the docstring example would target the total-count names, silently summing the wrong indicators (totals include instances considered but not planned). Low runtime impact, but it misleads maintainers of new code.\n\n**Recommendation**:\nUpdate the docstring example (and/or the group comment) to name the aggregated variants explicitly: zone_migration reports ``planned_live_migrate_instance_count`` and ``planned_cold_migrate_instance_count`` (plus non-aggregated total counts), while consolidation/workload_stabilization strategies report ``instance_migrations_count``.","commit_id":"148c156c3a2cc0fc404b3b147f1bf85a961ea338"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f4f605d945aec841dd24aa35726afba9e30b3fe5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the same concept is often measured with different indicator names across"},{"line_number":21,"context_line":"stages.  For example:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- ``zone_migration`` reports ``live_migrate_instance_count`` and"},{"line_number":24,"context_line":"  ``cold_migrate_instance_count`` separately."},{"line_number":25,"context_line":"- ``workload_stabilization`` and consolidation strategies report a single"},{"line_number":26,"context_line":"  ``instance_migrations_count`` for all migration types."}],"source_content_type":"text/x-python","patch_set":3,"id":"af22bfc2_44c7548d","line":23,"in_reply_to":"3213ecc5_7236d664","updated":"2026-08-19 20:13:16.000000000","message":"ack","commit_id":"148c156c3a2cc0fc404b3b147f1bf85a961ea338"}]}