)]}'
{"id":"openstack%2Fwatcher~1002694","triplet_id":"openstack%2Fwatcher~master~Idf00bcb6f3fd7e5c92bc966c69a9deaa88661fb3","project":"openstack/watcher","branch":"master","topic":"bp/audit-pipeline","attention_set":{"30002":{"account":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"last_update":"2026-08-27 22:57:10.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Idf00bcb6f3fd7e5c92bc966c69a9deaa88661fb3","subject":"Consolidate strategy metric-query params behind get_ methods","status":"NEW","created":"2026-08-27 21:00:11.000000000","updated":"2026-08-27 22:57:10.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a2d7252283a1cb8cc1257a38857c8f0c7cf683b7","_number":1002694,"virtual_id_number":1002694,"owner":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-08-27 22:36:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"all":[{"value":-1,"date":"2026-08-27 21:56:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"}],"CC":[{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-27 21:00:44.000000000","updated_by":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"reviewer":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"state":"CC"},{"updated":"2026-08-27 21:11:17.000000000","updated_by":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"reviewer":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"state":"REVIEWER"},{"updated":"2026-08-27 22:36:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dda079095a705e02ff6c1c180a04fd32c26b9460","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2026-08-27 21:00:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f331daa0efc49730a0683920054941a80550eb83","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2026-08-27 21:00:44.000000000","message":"Patch Set 1:\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":1},{"id":"bbb9aefb36674d6e6d7d241a87ad55ee73beec06","author":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"date":"2026-08-27 21:11:17.000000000","message":"Patch Set 1: Code-Review-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\nhttps://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/ed6b51b814b24bcca15ec6c09993db14\n\n- openstack-meta-content-provider-master https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/dd3b4e6a2bbf44539d57d5b912314059 : FAILURE in 9m 19s\n- watcher-operator-validation-master https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/8d4f152b298d43448bea9a7a3c55282d : SKIPPED Skipped due to failed job openstack-meta-content-provider-master\n- s2i-openstack-container-content-provider https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/b576d50093e24235b1cffc72caefb195 : SUCCESS in 4m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bc8a983dae23b73d86f18e1967b1e321345d01ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2026-08-27 21:46:19.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review-1 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fe09967cb86099faa16c83b3d056f7013c0076b3","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2026-08-27 21:46:53.000000000","message":"Patch Set 2:\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":2},{"id":"558488e3a43f2b9f241025bd08726a6167a80149","author":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"date":"2026-08-27 21:56:12.000000000","message":"Patch Set 2: Code-Review-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\nhttps://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/0ee7963c5a7d411399023346b15bcff4\n\n- openstack-meta-content-provider-master https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/e0e52f64e90e4a4492d7b754f383112a : FAILURE in 7m 46s\n- watcher-operator-validation-master https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/d87ec47fce0b45489c0b18edb7cf11d3 : SKIPPED Skipped due to failed job openstack-meta-content-provider-master\n- s2i-openstack-container-content-provider https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/f88f32439bd34340964b2f9a5da04db9 : SUCCESS in 4m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5882575e31fa4fe8585c29db68a4b083da871d6d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-27 22:36:02.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/b6411e6f03004d16b9c748b19b3ec951\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d0fc1dc7e6534337a47f7e3668f73aaa : FAILURE in 4m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/23182d6639424d46846eccc3f9821272 : SUCCESS in 4m 12s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8ac988abfaa64d3b8d4a6005f4dabe09 : FAILURE in 5m 46s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/48d2c7a536594a14852350705312b438 : FAILURE in 5m 44s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/22d3bbb8d3d74e2d9a9be534047db856 : FAILURE in 6m 56s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cefe2b93ab7446589b6d34459136f348 : SUCCESS in 8m 24s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4ea8026e2b874118878c566cf2daff23 : SUCCESS in 4m 19s\n- openstack-tox-py313-eventlet https://zuul.opendev.org/t/openstack/build/d0df3854464a417998115c6de742b5f7 : FAILURE in 4m 32s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/cd5a0ea5eff9446db11c64826a16bd57 : FAILURE in 22m 52s\n- watcher-grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/e9e7571ed2244d199627dce49f1fec64 : FAILURE in 19m 46s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/d7d66a26f3624214ac43186fb19c33d3 : FAILURE in 33m 49s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/18c9a7cc712d4a53a3a55df95dde0176 : FAILURE in 35m 48s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/48c0786b86794817872bf99945103120 : FAILURE in 17m 23s\n- watcher-tempest-prometheus-eventlet https://zuul.opendev.org/t/openstack/build/a62808ca2bee4d6c9aeaa62c60d08b7a : FAILURE in 27m 06s\n- watcher-tempest-aetos https://zuul.opendev.org/t/openstack/build/453dda1082be496fb87cfb23b7a576cb : FAILURE in 37m 46s\n- openstack-tox-functional-py313 https://zuul.opendev.org/t/openstack/build/f3a06e50a3c74a89a30160e78746e235 : SUCCESS in 4m 49s","accounts_in_message":[],"_revision_number":2},{"id":"a2d7252283a1cb8cc1257a38857c8f0c7cf683b7","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2026-08-27 22:57:10.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nBuild succeeded (automatic-ci pipeline).\nhttps://zuul.teim.app/t/main/buildset/3e4929182926497b994da14c0d0a26b8\n\n- teim-code-review https://zuul.teim.app/t/main/build/aa8b7e1c655043dea15c9fecb593a6b3 : SUCCESS in 8m 43s\n\nWarning:\n  The commit message body reads \"fold their logic into get_period()/get_granularity()/get_aggregate(), androute all internal reads through the get_ interface.\" The words \"and\" and \"route\" are run together as \"androute\", a clear typo in the permanent change history. The intended meaning (\"and route all internal reads through the get_ interface\") remains obvious.\n\n**Severity**: SUGGESTION | **Confidence**: 0.95\n\n**Impact**: Minor readability defect in the permanent git history; no code impact.\n\n**Recommendation**:\nAmend the commit message to read \"... get_aggregate(), and route all internal reads through the get_ interface.\"","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6ee90dde41b97f548645e56480c70941c5fa8778","revisions":{"3524a77ce7e627cb6831dcb4894cfcdfb11ba297":{"kind":"REWORK","_number":1,"created":"2026-08-27 21:00:11.000000000","uploader":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"ref":"refs/changes/94/1002694/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/94/1002694/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/94/1002694/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/94/1002694/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/94/1002694/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/94/1002694/1"}}},"commit":{"parents":[{"commit":"07c3b091dcf890deaad3d18d63f62db8ff501b7f","subject":"Add Audit Pipeline REST API endpoints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/07c3b091dcf890deaad3d18d63f62db8ff501b7f"}]}],"author":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2026-08-27 17:56:19.000000000","tz":-180},"committer":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2026-08-27 20:58:45.000000000","tz":-180},"subject":"Consolidate strategy metric-query params behind get_ methods","message":"Consolidate strategy metric-query params behind get_ methods\n\nComplete the migration started in previous change by removing the\nredundant period, granularity, and aggregation_method @property\naccessors from the strategies, fold their logic into\nget_period()/get_granularity()/get_aggregate(), androute all internal\nreads through the get_ interface.\nAlso rename get_datasource_metrics() to get_datasource_metrics_in_use()\nsince datasource metrics can be retrieved from DATASOURCE_METRICS but\nsome strategies allow users to select a subset of metrics when creating\ntheir audits. get_datasource_metrics_in_use() will provide the in_use\nmetrics based on the strategy\u0027s input_parameters. No behavior change;\ntests updated accordingly.\n\nAssisted-By: Claude Code (Opus 4.8)\nPartially-implements: bp audit-pipeline\nChange-Id: Idf00bcb6f3fd7e5c92bc966c69a9deaa88661fb3\nSigned-off-by: Douglas Viroel \u003cviroel@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/3524a77ce7e627cb6831dcb4894cfcdfb11ba297"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/3524a77ce7e627cb6831dcb4894cfcdfb11ba297"}]},"branch":"refs/heads/master"},"6ee90dde41b97f548645e56480c70941c5fa8778":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-08-27 21:46:19.000000000","uploader":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"ref":"refs/changes/94/1002694/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/94/1002694/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/94/1002694/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/94/1002694/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/94/1002694/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/94/1002694/2"}}},"commit":{"parents":[{"commit":"f068af143732a4d10126d84b0c348db94bc9f3de","subject":"Add Audit Pipeline REST API endpoints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f068af143732a4d10126d84b0c348db94bc9f3de"}]}],"author":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2026-08-27 17:56:19.000000000","tz":-180},"committer":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2026-08-27 21:42:35.000000000","tz":-180},"subject":"Consolidate strategy metric-query params behind get_ methods","message":"Consolidate strategy metric-query params behind get_ methods\n\nComplete the migration started in previous change by removing the\nredundant period, granularity, and aggregation_method @property\naccessors from the strategies, fold their logic into\nget_period()/get_granularity()/get_aggregate(), androute all internal\nreads through the get_ interface.\nAlso rename get_datasource_metrics() to get_datasource_metrics_in_use()\nsince datasource metrics can be retrieved from DATASOURCE_METRICS but\nsome strategies allow users to select a subset of metrics when creating\ntheir audits. get_datasource_metrics_in_use() will provide the in_use\nmetrics based on the strategy\u0027s input_parameters. No behavior change;\ntests updated accordingly.\n\nAssisted-By: Claude Code (Opus 4.8)\nPartially-implements: bp audit-pipeline\nChange-Id: Idf00bcb6f3fd7e5c92bc966c69a9deaa88661fb3\nSigned-off-by: Douglas Viroel \u003cviroel@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6ee90dde41b97f548645e56480c70941c5fa8778"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6ee90dde41b97f548645e56480c70941c5fa8778"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}