)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"24ce44a9cab1cc74b00eeee4737d74ccb9ee5841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0cf3b40b_cc5995a7","updated":"2026-09-17 09:33:40.000000000","message":"good cleanup, thanks","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2605f0b8d289cedbe355ea7e0d016779fd984527","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec0c7590_4144c7a3","updated":"2026-09-17 14:55:12.000000000","message":"i think we have waited long enough for maintaienr or users to experss interest in keeping this so lets continue focusing watcher on its core usecases","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"}],"watcher/cmd/eventlet/__init__.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3f14fc8e83c045654026a51f8e7ef21e42941fdb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# common/service.py.  This allows the API service to run without monkey"},{"line_number":16,"context_line":"# patching under Apache (which uses its own concurrency model). Mixing"},{"line_number":17,"context_line":"# concurrency models can cause undefined behavior and potentially API timeouts."},{"line_number":18,"context_line":"# NOTE(sean-k-mooney) while ^ is true, since that was written asyncio was added"},{"line_number":19,"context_line":"# to the code base in addition to apscheduler which provides native threads."},{"line_number":20,"context_line":"# As such we have a lot of technical debt to fix with regards to watchers"},{"line_number":21,"context_line":"# concurrency model as we are mixing up to 3 models the same process."}],"source_content_type":"text/x-python","patch_set":1,"id":"a6c92d1a_09059540","line":18,"updated":"2026-09-11 17:39:11.000000000","message":"The change deletes the \u0027maas support added asyncio\u0027 sentence from the NOTE(sean-k-mooney) comment but leaves the preceding claims that \u0027asyncio was added to the code base\u0027 and that Watcher mixes \u0027up to 3 models the same process\u0027. MAAS was the only asyncio consumer, and after this patch no module in watcher/ imports asyncio, so the retained comment misstates the concurrency models actually present in the process.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Impact**: The comment documents the concurrency-model debt that the follow-up eventlet-removal effort must address. A maintainer reading it would still expect asyncio call sites to exist and to need migration or guarding, and the \u00273 models\u0027 count is now wrong (only eventlet plus apscheduler native threads remain).\n\n**Recommendation**:\nReword lines 18-21 to drop the asyncio/3-model claims, e.g. note that the asyncio usage (the MAAS integration) was removed in 2026.2 and the remaining mixing is eventlet with apscheduler native threads.","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"24ce44a9cab1cc74b00eeee4737d74ccb9ee5841","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# common/service.py.  This allows the API service to run without monkey"},{"line_number":16,"context_line":"# patching under Apache (which uses its own concurrency model). Mixing"},{"line_number":17,"context_line":"# concurrency models can cause undefined behavior and potentially API timeouts."},{"line_number":18,"context_line":"# NOTE(sean-k-mooney) while ^ is true, since that was written asyncio was added"},{"line_number":19,"context_line":"# to the code base in addition to apscheduler which provides native threads."},{"line_number":20,"context_line":"# As such we have a lot of technical debt to fix with regards to watchers"},{"line_number":21,"context_line":"# concurrency model as we are mixing up to 3 models the same process."}],"source_content_type":"text/x-python","patch_set":1,"id":"adbc61f5_ab6c343a","line":18,"in_reply_to":"a6c92d1a_09059540","updated":"2026-09-17 09:33:40.000000000","message":"not a big deal, but worth addressing if we need a respin imo","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"035f390ec17e9694e3736a6276ca0a7ac426e36c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# common/service.py.  This allows the API service to run without monkey"},{"line_number":16,"context_line":"# patching under Apache (which uses its own concurrency model). Mixing"},{"line_number":17,"context_line":"# concurrency models can cause undefined behavior and potentially API timeouts."},{"line_number":18,"context_line":"# NOTE(sean-k-mooney) while ^ is true, since that was written asyncio was added"},{"line_number":19,"context_line":"# to the code base in addition to apscheduler which provides native threads."},{"line_number":20,"context_line":"# As such we have a lot of technical debt to fix with regards to watchers"},{"line_number":21,"context_line":"# concurrency model as we are mixing up to 3 models the same process."}],"source_content_type":"text/x-python","patch_set":1,"id":"c57cd7ba_cde16ef1","line":18,"in_reply_to":"adbc61f5_ab6c343a","updated":"2026-09-17 10:49:57.000000000","message":"yeah, i saw that, this file is deleted in the last eventlet removal patch:\nhttps://review.opendev.org/c/openstack/watcher/+/973995/7/watcher/cmd/eventlet/__init__.py","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"cd40ba6ac2141a778bafe9bf345e7df88800c6ca","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# common/service.py.  This allows the API service to run without monkey"},{"line_number":16,"context_line":"# patching under Apache (which uses its own concurrency model). Mixing"},{"line_number":17,"context_line":"# concurrency models can cause undefined behavior and potentially API timeouts."},{"line_number":18,"context_line":"# NOTE(sean-k-mooney) while ^ is true, since that was written asyncio was added"},{"line_number":19,"context_line":"# to the code base in addition to apscheduler which provides native threads."},{"line_number":20,"context_line":"# As such we have a lot of technical debt to fix with regards to watchers"},{"line_number":21,"context_line":"# concurrency model as we are mixing up to 3 models the same process."}],"source_content_type":"text/x-python","patch_set":1,"id":"aaac3e90_c0745c78","line":18,"in_reply_to":"c57cd7ba_cde16ef1","updated":"2026-09-17 10:53:37.000000000","message":"ah I had not gotten to that patch yet, all good then, thanks!","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"}]}