)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"9de760b5cc1286a70fc15e9a022615477613ccfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"372fec49_1f400d30","updated":"2026-09-17 10:56:47.000000000","message":"lgtm, the docs render well https://0740d61f08d30dfd6005-0bcd974829c5636eec53c54a828a88e5.ssl.cf5.rackcdn.com/openstack/b13fab17ac1e42baa16f8a193aefc351/docs/admin/wsgi.html and  https://0740d61f08d30dfd6005-0bcd974829c5636eec53c54a828a88e5.ssl.cf5.rackcdn.com/openstack/b13fab17ac1e42baa16f8a193aefc351/docs/admin/apache-mod-wsgi.html","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bb7d4b85ed2bf98b7961f7baa710aae31c3a1f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc7c1989_148840b9","updated":"2026-09-15 17:37:04.000000000","message":"recheck\n\nlets get teim-ci run again","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"d1dac46471496d9d6bb0d8c38973f03097a32647","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3170c49c_585642a7","updated":"2026-09-18 09:26:41.000000000","message":"the original deprecation was ok, but I agree removing the unused options is better, thanks!","commit_id":"6f78fa64e1a8975df5a84cd25b0e213b520e68d7"}],"doc/source/admin/apache-mod-wsgi.rst":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bb7d4b85ed2bf98b7961f7baa710aae31c3a1f05","unresolved":true,"context_lines":[{"line_number":30,"context_line":"   * Modify the ``WSGIDaemonProcess`` directive to set the ``user`` and"},{"line_number":31,"context_line":"     ``group`` values to appropriate user on your server."},{"line_number":32,"context_line":"   * Modify the ``WSGIScriptAlias`` directive to point to the"},{"line_number":33,"context_line":"     watcher/api/app.wsgi script."},{"line_number":34,"context_line":"   * Modify the ``Directory`` directive to set the path to the Watcher API"},{"line_number":35,"context_line":"     code."},{"line_number":36,"context_line":"   * Modify the ``ErrorLog and CustomLog`` to redirect the logs to the right"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f8380c32_23a74f1e","side":"PARENT","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":25},"updated":"2026-09-15 17:37:04.000000000","message":"I think that this should also be deleted","commit_id":"91ddc626edeb5fd6589eab8cfcae4882453afa7f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f0513374052237873102f11ed17b50f4fbb4e6c6","unresolved":true,"context_lines":[{"line_number":11,"context_line":"``mod_wsgi`` requires a script on disk and cannot reference the"},{"line_number":12,"context_line":"``watcher.wsgi.api:application`` module path directly. The steps below use"},{"line_number":13,"context_line":"the ``watcher-api-wsgi`` script generated at install time. See"},{"line_number":14,"context_line":":doc:`wsgi` for the other deployment options."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#. Install the Apache Service::"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"57fd4ae9_96322ffb","line":14,"updated":"2026-09-17 17:25:28.000000000","message":"while that is tecnially true the watcher-api-wsgi script is also deprecated for removal so can we include that a followup and isntead docuemnt this like\n\nhttps://review.opendev.org/c/openstack/cyborg/+/1003596/5/doc/source/admin/config-wsgi.rst#77\n\nim doing the same removal in cybrog now because i forgot to do it in 2026.1","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fac518545e90e1ae403103e1c1ad77cd95f9dadf","unresolved":true,"context_lines":[{"line_number":11,"context_line":"``mod_wsgi`` requires a script on disk and cannot reference the"},{"line_number":12,"context_line":"``watcher.wsgi.api:application`` module path directly. The steps below use"},{"line_number":13,"context_line":"the ``watcher-api-wsgi`` script generated at install time. See"},{"line_number":14,"context_line":":doc:`wsgi` for the other deployment options."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#. Install the Apache Service::"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b0cbc3c1_fa0b5adb","line":14,"in_reply_to":"57fd4ae9_96322ffb","updated":"2026-09-17 20:38:25.000000000","message":"ack, I pushed a new PS to remove script generation which also updates this reno.","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3c7a4b0c7014ec3cc6dd10c83a4e41803a27ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"``mod_wsgi`` requires a script on disk and cannot reference the"},{"line_number":12,"context_line":"``watcher.wsgi.api:application`` module path directly. The steps below use"},{"line_number":13,"context_line":"the ``watcher-api-wsgi`` script generated at install time. See"},{"line_number":14,"context_line":":doc:`wsgi` for the other deployment options."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#. Install the Apache Service::"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1e6d0b71_2cccc6ab","line":14,"in_reply_to":"b0cbc3c1_fa0b5adb","updated":"2026-09-18 11:53:01.000000000","message":"Acknowledged","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"}],"doc/source/user/ways-to-install.rst":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b8c89b9f481ab4b93e198c3f4b5a9815d3f97b74","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. code-block:: bash"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $ watcher-decision-engine"},{"line_number":88,"context_line":"    $ watcher-applier"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The Watcher API is a WSGI application and must be served by a WSGI server,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b2e68aab_f21eb5e1","line":87,"updated":"2026-09-15 17:53:31.000000000","message":"The change removes the watcher-api console script and updates the run-the-services section of doc/source/user/ways-to-install.rst, but the same file still tells readers that watcher-api is a command available on the PATH and still ships a Docker example that installs and runs the removed binary. The file is now internally inconsistent: following its own instructions yields a command-not-found error or a broken container entrypoint.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: A user installing from source following this guide will look for or attempt to run a watcher-api command that no longer exists, and the documented Docker container fails to start because /usr/bin/watcher-api is no longer shipped. Both outcomes directly contradict the WSGI guidance the same change added to this file.\n\n**Suggestion**:\nRemove the watcher-api bullet from the command list at line 64 and update or drop the Debian experimental Docker example (lines 127-135) so it either serves the API via watcher.wsgi.api:application under a WSGI server or is removed with a pointer to the admin WSGI guide (:doc:`../admin/wsgi`).","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f0513374052237873102f11ed17b50f4fbb4e6c6","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. code-block:: bash"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $ watcher-decision-engine"},{"line_number":88,"context_line":"    $ watcher-applier"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The Watcher API is a WSGI application and must be served by a WSGI server,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2f8c05ee_48039c5a","line":87,"in_reply_to":"b2e68aab_f21eb5e1","updated":"2026-09-17 17:25:28.000000000","message":"this is a misreproting its form the a sided of the diff not the b side","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ae8542a55368cbc5efac4f6d5ca12ec2cd0ae87c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    $ watcher-decision-engine"},{"line_number":88,"context_line":"    $ watcher-applier"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The Watcher API is a WSGI application and must be served by a WSGI server,"},{"line_number":91,"context_line":"referencing the ``watcher.wsgi.api:application`` module path. See"},{"line_number":92,"context_line":":doc:`../admin/wsgi` for details."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"75694311_4c2eba75","line":90,"updated":"2026-09-17 20:45:42.000000000","message":"The change deletes the watcher-api console script (pyproject.toml) and watcher/cmd/eventlet/api.py, and adds docs stating the API must be served as a WSGI application. However, several operator-facing documents still present watcher-api as an installable command or startable service: doc/source/user/ways-to-install.rst:64 lists it as a command available on the PATH, doc/source/user/ways-to-install.rst:133-135 gives a Dockerfile example that installs the watcher-api Debian package and runs /usr/bin/watcher-api, doc/source/install/install-ubuntu.rst:18,33,37 installs and enables/starts watcher-api.service, doc/source/install/install-rdo.rst:19,32,36 installs and enables/starts openstack-watcher-api.service. doc/source/install/get_started.rst:10-12 and doc/source/admin/gmr.rst:24-27 also reference the removed server by name.\n\n**Severity**: WARNING | **Confidence**: 0.83\n\n**Impact**: Operators, packagers, and CI authors following the install guides, the command list, or the Docker example will try to install or start a watcher-api command/service that this release no longer provides and will fail, while the docs contradict the release note that claims the removal is complete.\n\n**Suggestion**:\nFinish the documentation sweep in this change: drop watcher-api from the command list and rewrite the Dockerfile example in ways-to-install.rst to use the WSGI application, and update install-ubuntu.rst/install-rdo.rst to describe serving watcher.wsgi.api:application (e.g., via Apache and the watcher-api-wsgi script) instead of enabling watcher-api.service; refresh the wording in get_started.rst and gmr.rst.","commit_id":"6f78fa64e1a8975df5a84cd25b0e213b520e68d7"}],"watcher/conf/api.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b8c89b9f481ab4b93e198c3f4b5a9815d3f97b74","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.PortOpt("},{"line_number":34,"context_line":"        \u0027port\u0027,"},{"line_number":35,"context_line":"        default\u003d9322,"},{"line_number":36,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":37,"context_line":"        deprecated_since\u003d\u00272027.1\u0027,"},{"line_number":38,"context_line":"        deprecated_reason\u003d\u0027The standalone Watcher API server has been \u0027"},{"line_number":39,"context_line":"        \u0027removed. The API is now deployed as a WSGI application, so the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"462e18ce_4f3b36ef","line":36,"updated":"2026-09-15 17:53:31.000000000","message":"The new deprecation metadata marks the four [api] options as deprecated since 2027.1 and the new WSGI doc uses a 2027.1 versionchanged directive, but this change is part of the 2026.2 (Watcher 17.0.0) cycle: the 2026.2 prelude release note was committed on 2026-09-03 and the 17.0.0.0rc1 tag was created on 2026-09-08, one week before this review. oslo_config will emit deprecation warnings naming 2027.1 in a 2026.2 release, misstating when the options were deprecated and when they will be removed.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Operators reading deprecation warnings, the generated configuration reference, or the new WSGI doc will believe the [api] options were deprecated in (and the watcher-api script removed in) 2027.1 rather than 2026.2. The six-month discrepancy misleads upgrade planning for deployments that still set these options and cannot be reconciled once the 2026.2 notes ship.\n\n**Suggestion**:\nChange the four deprecated_since values in watcher/conf/api.py (lines 37, 47, 63, 76) and the versionchanged directive in doc/source/admin/wsgi.rst:5 from 2027.1 to 2026.2, unless maintainers deliberately hold this change for the 2027.1 release, in which case it must not merge into the 2026.2 cycle.","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f0513374052237873102f11ed17b50f4fbb4e6c6","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    cfg.PortOpt("},{"line_number":34,"context_line":"        \u0027port\u0027,"},{"line_number":35,"context_line":"        default\u003d9322,"},{"line_number":36,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":37,"context_line":"        deprecated_since\u003d\u00272027.1\u0027,"},{"line_number":38,"context_line":"        deprecated_reason\u003d\u0027The standalone Watcher API server has been \u0027"},{"line_number":39,"context_line":"        \u0027removed. The API is now deployed as a WSGI application, so the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"525fcd4c_04938716","line":36,"in_reply_to":"462e18ce_4f3b36ef","updated":"2026-09-17 17:25:28.000000000","message":"i think you should just remove these outright honestly\n\nyes they shoudl have been deprecated  before but they will have no effect now so we should jsut nuke them","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fac518545e90e1ae403103e1c1ad77cd95f9dadf","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    cfg.PortOpt("},{"line_number":34,"context_line":"        \u0027port\u0027,"},{"line_number":35,"context_line":"        default\u003d9322,"},{"line_number":36,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":37,"context_line":"        deprecated_since\u003d\u00272027.1\u0027,"},{"line_number":38,"context_line":"        deprecated_reason\u003d\u0027The standalone Watcher API server has been \u0027"},{"line_number":39,"context_line":"        \u0027removed. The API is now deployed as a WSGI application, so the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"eacec64d_e61222a0","line":36,"in_reply_to":"525fcd4c_04938716","updated":"2026-09-17 20:38:25.000000000","message":"yeah, I was thinking about that. IT will have no effect anymore, it will just highlight the deprecation warning to user as an additional report.\nremoved in new PS","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3c7a4b0c7014ec3cc6dd10c83a4e41803a27ff","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.PortOpt("},{"line_number":34,"context_line":"        \u0027port\u0027,"},{"line_number":35,"context_line":"        default\u003d9322,"},{"line_number":36,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":37,"context_line":"        deprecated_since\u003d\u00272027.1\u0027,"},{"line_number":38,"context_line":"        deprecated_reason\u003d\u0027The standalone Watcher API server has been \u0027"},{"line_number":39,"context_line":"        \u0027removed. The API is now deployed as a WSGI application, so the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"a28ec655_11c8874c","line":36,"in_reply_to":"eacec64d_e61222a0","updated":"2026-09-18 11:53:01.000000000","message":"Done","commit_id":"d1d774b55f06dbf0a7484af127e1d3bed857e519"}]}
