)]}'
{"watcher/decision_engine/audit/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd707f6cda0374aeabd94259cd8a608ee91e318c","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            raise"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @staticmethod"},{"line_number":115,"context_line":"    def update_audit_state(audit, state, status_message\u003dNone):"},{"line_number":116,"context_line":"        if audit.state !\u003d state:"},{"line_number":117,"context_line":"            LOG.debug(\"Update audit state: %s\", state)"},{"line_number":118,"context_line":"            audit.state \u003d state"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b624148_e35f18e5","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":26},"updated":"2026-11-05 18:50:11.000000000","message":"i honestly dont think this really adds much value as its own function but i don\u0027t object to adding this","commit_id":"b9b3e30e8451afcc826740b1c4efa64964b1eb77"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6e9a0dc116f21ac0510be5772210b89102eaebcd","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            raise"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @staticmethod"},{"line_number":115,"context_line":"    def update_audit_state(audit, state, status_message\u003dNone):"},{"line_number":116,"context_line":"        if audit.state !\u003d state:"},{"line_number":117,"context_line":"            LOG.debug(\"Update audit state: %s\", state)"},{"line_number":118,"context_line":"            audit.state \u003d state"}],"source_content_type":"text/x-python","patch_set":1,"id":"c53af252_759280b5","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":26},"in_reply_to":"0b624148_e35f18e5","updated":"2026-11-06 10:44:09.000000000","message":"I wanted to separe this from my actual use case (which is related to the new upgrade implementation) but i can just squast it if you prefer.","commit_id":"b9b3e30e8451afcc826740b1c4efa64964b1eb77"}],"watcher/tests/unit/decision_engine/audit/test_audit_handlers.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"ded6a373d60b6622ddaf0611bd5802fe7e03d23d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def test_update_audit_state(self):"},{"line_number":143,"context_line":"        audit_handler \u003d oneshot.OneShotAuditHandler()"},{"line_number":144,"context_line":"        self.assertEqual(objects.audit.State.PENDING, self.audit.state)"},{"line_number":145,"context_line":"        audit_handler.update_audit_state(self.audit, objects.audit.State.FAILED)"},{"line_number":146,"context_line":"        self.assertEqual(objects.audit.State.FAILED, self.audit.state)"},{"line_number":147,"context_line":"        self.assertIsNone(self.audit.status_message)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8c40e425_8ff2762e","line":145,"updated":"2026-11-05 15:18:05.000000000","message":"Two lines added to test_audit_handlers.py exceed the project line-length limit: line 145 is 80 characters and line 152 is 94 characters. The project enforces 79 characters through ruff (pyproject.toml sets line-length \u003d 79 and the lint select list includes the E5 rules, which contain E501), and the pep8 tox environment runs \u0027pre-commit run --all-files\u0027, which invokes the ruff-check hook pinned to ruff 0.15.7. Unlike the pre-existing over-length lines in the repository, which carry explicit \u0027# noqa: E501\u0027 markers, the new lines carry no marker and are easily wrappable.\n\n**Severity**: HIGH | **Confidence**: 0.95\n\n**Impact**: The pep8 gating job fails deterministically, so the change cannot merge until the lines are fixed; after a merge without the fix, \u0027pre-commit run --all-files\u0027 would keep failing pep8 for subsequent changes until the lines are corrected.\n\n**Priority**: Before merge\n**Recommendation**:\nWrap the two calls to stay within 79 characters, for example: audit_handler.update_audit_state(\n    self.audit, objects.audit.State.FAILED\n) and audit_handler.update_audit_state(\n    self.audit, objects.audit.State.FAILED, \"Test error\"\n). A \u0027# noqa: E501\u0027 marker is unnecessary because both calls are easily wrappable.","commit_id":"b9b3e30e8451afcc826740b1c4efa64964b1eb77"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd707f6cda0374aeabd94259cd8a608ee91e318c","unresolved":true,"context_lines":[{"line_number":142,"context_line":"    def test_update_audit_state(self):"},{"line_number":143,"context_line":"        audit_handler \u003d oneshot.OneShotAuditHandler()"},{"line_number":144,"context_line":"        self.assertEqual(objects.audit.State.PENDING, self.audit.state)"},{"line_number":145,"context_line":"        audit_handler.update_audit_state(self.audit, objects.audit.State.FAILED)"},{"line_number":146,"context_line":"        self.assertEqual(objects.audit.State.FAILED, self.audit.state)"},{"line_number":147,"context_line":"        self.assertIsNone(self.audit.status_message)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"819aa4a6_bb770dc8","line":145,"in_reply_to":"8c40e425_8ff2762e","updated":"2026-11-05 18:50:11.000000000","message":"ya this is valid.\n\nthis is proably the pep8 job failure as well but trivial to fix.","commit_id":"b9b3e30e8451afcc826740b1c4efa64964b1eb77"}]}
