)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"4b4b107a3fdd3267084fe02f8de76c19275d941c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Even though Watcher was mentioning python 3.4 as supported, it"},{"line_number":10,"context_line":"really wasn\u0027t the case as all the unit tests were not passing in this"},{"line_number":11,"context_line":"version of Python."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset fixes all the failing tests in Python 3.4 while"},{"line_number":14,"context_line":"keeping Watcher Python 2.7 compatible."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_03519c0e","line":12,"updated":"2015-12-09 14:36:06.000000000","message":"Can you please add the tag : DocImpact  ?\n\nwe need to change the documentation for example : \nsudo apt-get install python3-dev :)","commit_id":"0f2fd82f0df98ab6f65d876f521dc3e64acd40cd"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"62196ea751b98f9ac13c597667ec93390ac83805","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Even though Watcher was mentioning python 3.4 as supported, it"},{"line_number":10,"context_line":"really wasn\u0027t the case as all the unit tests were not passing in this"},{"line_number":11,"context_line":"version of Python."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset fixes all the failing tests in Python 3.4 while"},{"line_number":14,"context_line":"keeping Watcher Python 2.7 compatible."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_c9b0208e","line":12,"in_reply_to":"7a740942_03519c0e","updated":"2015-12-11 10:40:45.000000000","message":"Done","commit_id":"0f2fd82f0df98ab6f65d876f521dc3e64acd40cd"}],"watcher/api/controllers/v1/utils.py":[{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"4b4b107a3fdd3267084fe02f8de76c19275d941c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def validate_limit(limit):"},{"line_number":31,"context_line":"    if limit is not None and limit \u003c\u003d 0:"},{"line_number":32,"context_line":"        raise wsme.exc.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":33,"context_line":"    return (min(CONF.api.max_limit, limit or 0) or limit) or CONF.api.max_limit"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def validate_sort_dir(sort_dir):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_08f21b70","line":33,"updated":"2015-12-09 14:36:06.000000000","message":"This code is hard to read :)\n\nWhat do you think of about this version?\n\ndef validate_limit(limit):\n    if limit is None:\n        return CONF.api.max_limit\n\n    if limit \u003c\u003d 0:\n        raise wsme.exc.ClientSideError(_(\"Limit must be positive\"))\n\n    return min(CONF.api.max_limit, limit)","commit_id":"0f2fd82f0df98ab6f65d876f521dc3e64acd40cd"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"62196ea751b98f9ac13c597667ec93390ac83805","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def validate_limit(limit):"},{"line_number":31,"context_line":"    if limit is not None and limit \u003c\u003d 0:"},{"line_number":32,"context_line":"        raise wsme.exc.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":33,"context_line":"    return (min(CONF.api.max_limit, limit or 0) or limit) or CONF.api.max_limit"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def validate_sort_dir(sort_dir):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_49bc306c","line":33,"in_reply_to":"7a740942_08f21b70","updated":"2015-12-11 10:40:45.000000000","message":"Done","commit_id":"0f2fd82f0df98ab6f65d876f521dc3e64acd40cd"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"4b4b107a3fdd3267084fe02f8de76c19275d941c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    if limit is not None and limit \u003c\u003d 0:"},{"line_number":32,"context_line":"        raise wsme.exc.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":33,"context_line":"    return (min(CONF.api.max_limit, limit or 0) or limit) or CONF.api.max_limit"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def validate_sort_dir(sort_dir):"},{"line_number":37,"context_line":"    if sort_dir not in [\u0027asc\u0027, \u0027desc\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ebe78644","line":34,"updated":"2015-12-09 14:36:06.000000000","message":"Can you can add a test to validate_limit with a parameter as None ?","commit_id":"0f2fd82f0df98ab6f65d876f521dc3e64acd40cd"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"62196ea751b98f9ac13c597667ec93390ac83805","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    if limit is not None and limit \u003c\u003d 0:"},{"line_number":32,"context_line":"        raise wsme.exc.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":33,"context_line":"    return (min(CONF.api.max_limit, limit or 0) or limit) or CONF.api.max_limit"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def validate_sort_dir(sort_dir):"},{"line_number":37,"context_line":"    if sort_dir not in [\u0027asc\u0027, \u0027desc\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_be8dc9d4","line":34,"in_reply_to":"7a740942_ebe78644","updated":"2015-12-11 10:40:45.000000000","message":"Done","commit_id":"0f2fd82f0df98ab6f65d876f521dc3e64acd40cd"}]}