)]}'
{"watcher/common/ceilometer.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"0c53968ec7419590d1cdca957fa59dbc454d3d11","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ceilometerclient import client"},{"line_number":21,"context_line":"from ceilometerclient.exc import HTTPUnauthorized"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from watcher.common.keystone import KeystoneClient"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class CeilometerClient(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_e399c620","line":23,"updated":"2015-12-10 06:01:48.000000000","message":"Is there any reason for this?","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"86491a6cb337d9282f69a1a6c9ee2f093fce21f2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ceilometerclient import client"},{"line_number":21,"context_line":"from ceilometerclient.exc import HTTPUnauthorized"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from watcher.common.keystone import KeystoneClient"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class CeilometerClient(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_f3a01492","line":23,"in_reply_to":"7a740942_e399c620","updated":"2015-12-14 10:49:52.000000000","message":"Done","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"}],"watcher/tests/common/test_ceilometer.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"0c53968ec7419590d1cdca957fa59dbc454d3d11","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from mock import MagicMock"},{"line_number":21,"context_line":"from mock import mock"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from watcher.common.ceilometer import CeilometerClient"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from watcher.tests.base import BaseTestCase"},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_26b6fc3d","line":23,"updated":"2015-12-10 06:01:48.000000000","message":"The imports in this file don\u0027t file the defined import order template at http://docs.openstack.org/developer/hacking/#import-order-template.","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"9211b1a11c0e96812657bb726fae82f667a96196","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from mock import MagicMock"},{"line_number":21,"context_line":"from mock import mock"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from watcher.common.ceilometer import CeilometerClient"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from watcher.tests.base import BaseTestCase"},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_f3f94281","line":23,"in_reply_to":"7a740942_26b6fc3d","updated":"2015-12-11 13:15:01.000000000","message":"IMHO, if we want to apply this rule we have to automatically check it.\nIt seem that is possible : \nhttps://github.com/openstack/neutron/blob/master/tox.ini#L169\nhttps://github.com/openstack/neutron/blob/master/neutron/hacking/checks.py\n\nDo you want to work on it ?","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"0c53968ec7419590d1cdca957fa59dbc454d3d11","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                    resource_ids\u003d[\"resource_ids\"])"},{"line_number":46,"context_line":"        self.assertEqual(query, expected)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027, autospec\u003dTrue)"},{"line_number":49,"context_line":"    @mock.patch(\u0027ceilometerclient.v2.client.Client\u0027, autospec\u003dTrue)"},{"line_number":50,"context_line":"    def test_get_ceilometer_v2(self, mock_keystone, mock_ceilometer):"},{"line_number":51,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a6a98ce1","line":48,"updated":"2015-12-10 06:01:48.000000000","message":"Would it make more sense to mock keystone.KeystoneClient instead of specifically keystoneclient v2.0?","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"9211b1a11c0e96812657bb726fae82f667a96196","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                    resource_ids\u003d[\"resource_ids\"])"},{"line_number":46,"context_line":"        self.assertEqual(query, expected)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027, autospec\u003dTrue)"},{"line_number":49,"context_line":"    @mock.patch(\u0027ceilometerclient.v2.client.Client\u0027, autospec\u003dTrue)"},{"line_number":50,"context_line":"    def test_get_ceilometer_v2(self, mock_keystone, mock_ceilometer):"},{"line_number":51,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_53b85675","line":48,"in_reply_to":"7a740942_a6a98ce1","updated":"2015-12-11 13:15:01.000000000","message":"IMHO, I don\u0027t think this will improve this test.","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"}],"watcher/tests/common/test_keystone.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"0c53968ec7419590d1cdca957fa59dbc454d3d11","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import absolute_import"},{"line_number":18,"context_line":"from __future__ import unicode_literals"},{"line_number":19,"context_line":"from keystoneclient.auth.identity import Password"},{"line_number":20,"context_line":"from keystoneclient.session import Session"},{"line_number":21,"context_line":"from mock import mock"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a3ec1e90","line":19,"updated":"2015-12-10 06:01:48.000000000","message":"The imports in this file don\u0027t file the defined import order template at http://docs.openstack.org/developer/hacking/#import-order-template.","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"9211b1a11c0e96812657bb726fae82f667a96196","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import absolute_import"},{"line_number":18,"context_line":"from __future__ import unicode_literals"},{"line_number":19,"context_line":"from keystoneclient.auth.identity import Password"},{"line_number":20,"context_line":"from keystoneclient.session import Session"},{"line_number":21,"context_line":"from mock import mock"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_65cca5bb","line":19,"in_reply_to":"7a740942_a3ec1e90","updated":"2015-12-11 13:15:01.000000000","message":"ditto","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"0c53968ec7419590d1cdca957fa59dbc454d3d11","unresolved":false,"context_lines":[{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestKeyStone(BaseTestCase):"},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestKeyStone, self).setUp()"},{"line_number":32,"context_line":"        self.ckeystone \u003d KeystoneClient()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_23902eec","line":29,"updated":"2015-12-10 06:01:48.000000000","message":"s/TestKeyStone/TestKeystone","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"9211b1a11c0e96812657bb726fae82f667a96196","unresolved":false,"context_lines":[{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestKeyStone(BaseTestCase):"},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestKeyStone, self).setUp()"},{"line_number":32,"context_line":"        self.ckeystone \u003d KeystoneClient()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_855f51e4","line":29,"in_reply_to":"7a740942_23902eec","updated":"2015-12-11 13:15:01.000000000","message":"Done","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"0c53968ec7419590d1cdca957fa59dbc454d3d11","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.ckeystone \u003d KeystoneClient()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027, autospec\u003dTrue)"},{"line_number":35,"context_line":"    def test_get_endpoint(self, keystone):"},{"line_number":36,"context_line":"        expected_endpoint \u003d \"http://ip:port/v2\""},{"line_number":37,"context_line":"        cfg.CONF.set_override("},{"line_number":38,"context_line":"            \u0027auth_uri\u0027, expected_endpoint, group\u003d\"keystone_authtoken\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_23034e11","line":35,"updated":"2015-12-10 06:01:48.000000000","message":"s/test_get_endpoint/test_get_endpoint_v2 ?","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"9211b1a11c0e96812657bb726fae82f667a96196","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.ckeystone \u003d KeystoneClient()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027, autospec\u003dTrue)"},{"line_number":35,"context_line":"    def test_get_endpoint(self, keystone):"},{"line_number":36,"context_line":"        expected_endpoint \u003d \"http://ip:port/v2\""},{"line_number":37,"context_line":"        cfg.CONF.set_override("},{"line_number":38,"context_line":"            \u0027auth_uri\u0027, expected_endpoint, group\u003d\"keystone_authtoken\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a564cdb8","line":35,"in_reply_to":"7a740942_23034e11","updated":"2015-12-11 13:15:01.000000000","message":"Done","commit_id":"532f7cd6ec7eeca7b049ba2b929c151c53a450b9"}]}