)]}'
{"watcher/applier/primitives/wrapper/nova_wrapper.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95bef30cbdcdc1fbf0bc2cca9d5926d0e05b7a34","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    break"},{"line_number":96,"context_line":"        return network_names_list, floating_ip"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _blocks_settings(self, attached_volumes, blocks,"},{"line_number":99,"context_line":"                         instance_id, image_id):"},{"line_number":100,"context_line":"        \"\"\"Create blocks\"\"\""},{"line_number":101,"context_line":"        for attached_volume in attached_volumes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_956231d7","line":98,"updated":"2015-12-11 08:25:18.000000000","message":"nit: can you add a verb in your method name? How about \"create_blocks()\" to match with what the docstring says?","commit_id":"8c7e576be35d4b7d38d38db5803d5e22f4652287"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95bef30cbdcdc1fbf0bc2cca9d5926d0e05b7a34","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    return False"},{"line_number":147,"context_line":"            except ciexceptions.NotFound:"},{"line_number":148,"context_line":"                LOG.debug(\"Volume \u0027%s\u0027 not found \" % image_id)"},{"line_number":149,"context_line":"                return False"},{"line_number":150,"context_line":"        return blocks"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _parameter_settings(self, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_e2541955","line":149,"updated":"2015-12-11 08:25:18.000000000","message":"This function can either return a boolean (i.e. False) or a list of block.\nCan you change this so we only expect a single return type (i.e. lists) from this function.\nIn this case, I guess that returning an empty list should do the job.","commit_id":"8c7e576be35d4b7d38d38db5803d5e22f4652287"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95bef30cbdcdc1fbf0bc2cca9d5926d0e05b7a34","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return instance_name, flavordict, flavor_id, flavor, \\"},{"line_number":163,"context_line":"            flavor_name, keypair_name, addresses"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _instace_action(self, new_instance, instance_id,"},{"line_number":166,"context_line":"                        floating_ip, instance):"},{"line_number":167,"context_line":"        if not new_instance:"},{"line_number":168,"context_line":"            LOG.debug("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a2e5b1a8","line":165,"updated":"2015-12-11 08:25:18.000000000","message":"nit: typo in function name","commit_id":"8c7e576be35d4b7d38d38db5803d5e22f4652287"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95bef30cbdcdc1fbf0bc2cca9d5926d0e05b7a34","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        return True"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _group_settings(self, instance, instance_id, new_image_name):"},{"line_number":204,"context_line":"        \"\"\"Create security groups\"\"\""},{"line_number":205,"context_line":"        sec_groups_list \u003d getattr(instance, \"security_groups\")"},{"line_number":206,"context_line":"        sec_groups \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d53af9cc","line":203,"updated":"2015-12-11 08:25:18.000000000","message":"nit: can you add a verb in your method name? Hwo about \"create_security_groups()\" to match with what the docstring says","commit_id":"8c7e576be35d4b7d38d38db5803d5e22f4652287"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95bef30cbdcdc1fbf0bc2cca9d5926d0e05b7a34","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            LOG.debug(\"Instance %s not found !\" % instance_id)"},{"line_number":310,"context_line":"            return False"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            return self._is_instance(self, instance, instance_id,"},{"line_number":313,"context_line":"                                     keep_original_image_name, hypervisor_id)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def built_in_non_live_migrate_instance(self, instance_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_22e781e5","line":312,"updated":"2015-12-11 08:25:18.000000000","message":"This \"self\" as 1st parameter doesn\u0027t look like it should be there. Can you remove it?","commit_id":"8c7e576be35d4b7d38d38db5803d5e22f4652287"}]}