)]}'
{"watcher/decision_engine/audit/base.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"062f1ab9b4345d09235c90955ff22dc3fa944dd8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class BaseAuditHandler(object):"},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def execute(self):"},{"line_number":27,"context_line":"        raise NotImplementedError()  # pragma:no cover"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_29c6a19a","line":27,"updated":"2015-12-16 06:02:33.000000000","message":"pragma not needed anymore due to https://review.openstack.org/#/c/254769/ ?","commit_id":"a6f1e481b0a0c6c42717e93ab6dba9dd3268fc0e"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"bb8748a1665d1678c655c3b583d7409528a0b602","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class BaseAuditHandler(object):"},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def execute(self):"},{"line_number":27,"context_line":"        raise NotImplementedError()  # pragma:no cover"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_7dd223d4","line":27,"in_reply_to":"5a710552_29c6a19a","updated":"2015-12-16 08:05:50.000000000","message":"yes, however, I would like to point out to that this patchset has to be rebased from  https://review.openstack.org/#/c/254769 therefore \"pragma: no cover\" will be deleted.","commit_id":"a6f1e481b0a0c6c42717e93ab6dba9dd3268fc0e"}],"watcher/decision_engine/audit/default.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"062f1ab9b4345d09235c90955ff22dc3fa944dd8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        except Exception as e:"},{"line_number":83,"context_line":"            self.update_audit_state(request_context, audit_uuid,"},{"line_number":84,"context_line":"                                    AuditStatus.FAILED)"},{"line_number":85,"context_line":"            LOG.error(\"Trigger audit %s \".format(unicode(e)))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_e96df998","line":85,"updated":"2015-12-16 06:02:33.000000000","message":"Log should go before the additional call to update_audit_state as that too could theoretically fail.  Also, this should be translatable and should not be using unicode on the exception.  See http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables","commit_id":"a6f1e481b0a0c6c42717e93ab6dba9dd3268fc0e"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"bb8748a1665d1678c655c3b583d7409528a0b602","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        except Exception as e:"},{"line_number":83,"context_line":"            self.update_audit_state(request_context, audit_uuid,"},{"line_number":84,"context_line":"                                    AuditStatus.FAILED)"},{"line_number":85,"context_line":"            LOG.error(\"Trigger audit %s \".format(unicode(e)))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_5dade72f","line":85,"in_reply_to":"5a710552_e96df998","updated":"2015-12-16 08:05:50.000000000","message":"Done","commit_id":"a6f1e481b0a0c6c42717e93ab6dba9dd3268fc0e"}]}