)]}'
{"watcher/decision_engine/strategy/context/default.py":[{"author":{"_account_id":13790,"name":"Zhenzan Zhou","email":"linuxosa@gmail.com","username":"zhenzanzhou"},"change_message_id":"0702eec13578ade5fa8f0a3c107580592e9eb798","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        selected_strategy \u003d self.strategy_selector. \\"},{"line_number":59,"context_line":"            define_from_goal(audit_template.goal)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        return selected_strategy.execute(cluster_data_model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_9344104a","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":32},"updated":"2015-12-22 08:30:52.000000000","message":"I don\u0027t know how we could effect selected strategy if we only pass cluster_data_model in. I think it needs another parameter e.g. execution_context.","commit_id":"e6a3dec9f397b9b51458dbfef788579a7cbbb777"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"8363e19a185fe0bae72a7f778f77f417149b7325","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        selected_strategy \u003d self.strategy_selector. \\"},{"line_number":59,"context_line":"            define_from_goal(audit_template.goal)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        return selected_strategy.execute(cluster_data_model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_04669829","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":32},"in_reply_to":"3a7e1126_9344104a","updated":"2015-12-22 09:49:56.000000000","message":"yes of course.\nIMHO, we will add several attribute like the parameters for the strategy (e.g: threshold)","commit_id":"e6a3dec9f397b9b51458dbfef788579a7cbbb777"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"78c271414c6d731a2197356d4095590874290931","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        # Retrieve the Audit Template"},{"line_number":47,"context_line":"        audit_template \u003d objects.AuditTemplate.get_by_id(request_context,"},{"line_number":48,"context_line":"                                                         audit."},{"line_number":49,"context_line":"                                                         audit_template_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # todo(jed) retrieve in audit_template parameters (threshold,...)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_65caea51","line":48,"range":{"start_line":48,"start_character":62,"end_line":48,"end_character":63},"updated":"2015-12-22 16:44:33.000000000","message":"nit: looks odd to put it on 2 lines","commit_id":"26a329476fc7b8863841dacd759eb09e1c92312f"}],"watcher/tests/decision_engine/audit/test_default_audit_handler.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"78c271414c6d731a2197356d4095590874290931","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"from mock import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from watcher.decision_engine.audit.default import DefaultAuditHandler"},{"line_number":19,"context_line":"from watcher.decision_engine.messaging.events import Events"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_653f4a26","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":21},"updated":"2015-12-22 16:44:33.000000000","message":"nit: import mock should be enough here","commit_id":"26a329476fc7b8863841dacd759eb09e1c92312f"}],"watcher/tests/decision_engine/messaging/test_audit_endpoint.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"78c271414c6d731a2197356d4095590874290931","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from mock import MagicMock"},{"line_number":18,"context_line":"from mock import patch"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from watcher.common import utils"},{"line_number":21,"context_line":"from watcher.decision_engine.audit.default import DefaultAuditHandler"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_45748efc","line":18,"updated":"2015-12-22 16:44:33.000000000","message":"can you avoid this import by using the one on line 16?","commit_id":"26a329476fc7b8863841dacd759eb09e1c92312f"}],"watcher/tests/decision_engine/strategy/context/test_strategy_context.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"78c271414c6d731a2197356d4095590874290931","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from mock import patch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from watcher.decision_engine.solution.default import DefaultSolution"},{"line_number":20,"context_line":"from watcher.decision_engine.strategy.context.default import \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_65dbcaee","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"updated":"2015-12-22 16:44:33.000000000","message":"2 imports from the same module: can you squish them together?","commit_id":"26a329476fc7b8863841dacd759eb09e1c92312f"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"78c271414c6d731a2197356d4095590874290931","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    DummyStrategy"},{"line_number":26,"context_line":"from watcher.metrics_engine.cluster_model_collector.manager import \\"},{"line_number":27,"context_line":"    CollectorManager"},{"line_number":28,"context_line":"from watcher.tests.db.base import DbTestCase"},{"line_number":29,"context_line":"from watcher.tests.objects import utils as obj_utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_45900eed","line":28,"range":{"start_line":28,"start_character":22,"end_line":28,"end_character":26},"updated":"2015-12-22 16:44:33.000000000","message":"nit: import base and then base.DbTestCase?","commit_id":"26a329476fc7b8863841dacd759eb09e1c92312f"}]}