)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"662cdd0beddf6a8ebf09796e4f3513297f5e0f31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gábor Antal \u003cantal@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-05 14:13:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Strategy goal required have to be True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the section \"WATCHER_GOALS_OPTS\" the dict option \"goals\""},{"line_number":10,"context_line":"is not mandatory. However it should be."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_2899677c","line":7,"updated":"2016-01-06 06:00:32.000000000","message":"s/.../Strategy goals should be required in conf","commit_id":"6ceb4d86db2439683da3f420a09eafc4fccc5a17"}],"watcher/decision_engine/strategy/selection/default.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"662cdd0beddf6a8ebf09796e4f3513297f5e0f31","unresolved":false,"context_lines":[{"line_number":30,"context_line":"WATCHER_GOALS_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.DictOpt("},{"line_number":32,"context_line":"        \u0027goals\u0027,"},{"line_number":33,"context_line":"        default\u003ddefault_goals,"},{"line_number":34,"context_line":"        required\u003dTrue,"},{"line_number":35,"context_line":"        help\u003d\u0027Goals used for the optimization. \u0027"},{"line_number":36,"context_line":"             \u0027Maps each goal to an associated strategy (for example: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_08710344","line":33,"updated":"2016-01-06 06:00:32.000000000","message":"Doesn\u0027t having the default defined here result in required\u003dTrue doing nothing?  If the user doesn\u0027t define the goals in watcher.conf then the default will be used.","commit_id":"6ceb4d86db2439683da3f420a09eafc4fccc5a17"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"cca35f57722d5f3a44a160e48ca6b22a55f47767","unresolved":false,"context_lines":[{"line_number":30,"context_line":"WATCHER_GOALS_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.DictOpt("},{"line_number":32,"context_line":"        \u0027goals\u0027,"},{"line_number":33,"context_line":"        default\u003ddefault_goals,"},{"line_number":34,"context_line":"        required\u003dTrue,"},{"line_number":35,"context_line":"        help\u003d\u0027Goals used for the optimization. \u0027"},{"line_number":36,"context_line":"             \u0027Maps each goal to an associated strategy (for example: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9c5c557e","line":33,"in_reply_to":"fa69d971_08710344","updated":"2016-01-06 08:28:18.000000000","message":"The user can override the goal in the configuration file and it can set nothing (goals \u003d ) so I believe that with required set to true the goal must be supplied for this option.\nbut I not sure.","commit_id":"6ceb4d86db2439683da3f420a09eafc4fccc5a17"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"fdcad504019a2166b5c47fcad63af396b40d2406","unresolved":false,"context_lines":[{"line_number":30,"context_line":"WATCHER_GOALS_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.DictOpt("},{"line_number":32,"context_line":"        \u0027goals\u0027,"},{"line_number":33,"context_line":"        default\u003ddefault_goals,"},{"line_number":34,"context_line":"        required\u003dTrue,"},{"line_number":35,"context_line":"        help\u003d\u0027Goals used for the optimization. \u0027"},{"line_number":36,"context_line":"             \u0027Maps each goal to an associated strategy (for example: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_fcda3116","line":33,"in_reply_to":"fa69d971_08710344","updated":"2016-01-06 08:23:29.000000000","message":"True, but I guess it\u0027s to prevent the case where you override the default with nothing being set like below although I think it is quite unlikely to happen.\n\n[watcher_goals]\ngoals\u003d","commit_id":"6ceb4d86db2439683da3f420a09eafc4fccc5a17"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"46f2aa99fe7c1d5a2163638e915dbbd2b2831d91","unresolved":false,"context_lines":[{"line_number":30,"context_line":"WATCHER_GOALS_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.DictOpt("},{"line_number":32,"context_line":"        \u0027goals\u0027,"},{"line_number":33,"context_line":"        default\u003ddefault_goals,"},{"line_number":34,"context_line":"        required\u003dTrue,"},{"line_number":35,"context_line":"        help\u003d\u0027Goals used for the optimization. \u0027"},{"line_number":36,"context_line":"             \u0027Maps each goal to an associated strategy (for example: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9f8f5974","line":33,"in_reply_to":"fa69d971_9c5c557e","updated":"2016-01-06 14:31:48.000000000","message":"I tested this out.\n\n  goals \u003d\n\nworks fine.\n\n  goals \u003d None\n\ndoes not.  So I suppose this is needed.","commit_id":"6ceb4d86db2439683da3f420a09eafc4fccc5a17"}]}