)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"45065ea449d2a43dbb3ffb80828941303ba5985e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Edwin Zhai \u003cedwin.zhai@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-29 08:14:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make directory in clean way for devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use install instead of mkdir and checking to handle existed directory"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_6d9974c3","line":7,"updated":"2016-02-02 06:25:55.000000000","message":"Use install instead of mkdir for DevStack dirs","commit_id":"f6fb35d23f5ab0df448710df9f1c75610cf3ef9d"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"45065ea449d2a43dbb3ffb80828941303ba5985e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make directory in clean way for devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use install instead of mkdir and checking to handle existed directory"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie582a4b393e898e007d73f31de490c4b77e40be3"},{"line_number":12,"context_line":"Closes-Bug: #1539422"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_0defa01e","line":9,"updated":"2016-02-02 06:25:55.000000000","message":"The current code will not work if WATCHER_CONF_DIR or WATCHER_AUTH_CACHE_DIR already exist but are owned by a different user such as root.  Use install instead of mkdir to handle this scenario.","commit_id":"f6fb35d23f5ab0df448710df9f1c75610cf3ef9d"}],"devstack/lib/watcher":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"f76b280c6d112cd2b9f9fb3731fd7471addd956e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Put config files in ``/etc/watcher`` for everyone to find"},{"line_number":83,"context_line":"    if [[  ! -d $WATCHER_CONF_DIR  ]]; then"},{"line_number":84,"context_line":"        sudo mkdir -p $WATCHER_CONF_DIR"},{"line_number":85,"context_line":"        sudo chown $STACK_USER $WATCHER_CONF_DIR"},{"line_number":86,"context_line":"    fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    install_default_policy watcher"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_8d115054","side":"PARENT","line":85,"updated":"2016-02-02 06:21:29.000000000","message":"Would moving this outside of the if check have solved your issue as well?","commit_id":"de307e536ef040afe506d1d2acc5c2025c31104e"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"395fb298bff4bfba0549f3b1ecdb89044d587429","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # Put config files in ``/etc/watcher`` for everyone to find"},{"line_number":83,"context_line":"    if [[  ! -d $WATCHER_CONF_DIR  ]]; then"},{"line_number":84,"context_line":"        sudo mkdir -p $WATCHER_CONF_DIR"},{"line_number":85,"context_line":"        sudo chown $STACK_USER $WATCHER_CONF_DIR"},{"line_number":86,"context_line":"    fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    install_default_policy watcher"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_8c106b5b","side":"PARENT","line":85,"in_reply_to":"7a5de9d1_8d115054","updated":"2016-02-02 09:57:17.000000000","message":"Yes,\nMoving chown out also works.\ninstall is concise, and commonly used in devstack.","commit_id":"de307e536ef040afe506d1d2acc5c2025c31104e"},{"author":{"_account_id":13790,"name":"Zhenzan Zhou","email":"linuxosa@gmail.com","username":"zhenzanzhou"},"change_message_id":"817a27f543516b3f82eeb5146189f801366821c7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"function create_watcher_cache_dir {"},{"line_number":177,"context_line":"    # Create cache dir"},{"line_number":178,"context_line":"    sudo install -d -o $STACK_USER $WATCHER_AUTH_CACHE_DIR"},{"line_number":179,"context_line":"    rm -f $WATCHER_AUTH_CACHE_DIR/*"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"# init_watcher() - Initialize databases, etc."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_837cffb5","line":179,"range":{"start_line":179,"start_character":6,"end_line":179,"end_character":9},"updated":"2016-02-01 03:42:00.000000000","message":"Could we use \u0027-rf\u0027 in case there are folders?","commit_id":"f6fb35d23f5ab0df448710df9f1c75610cf3ef9d"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"f76b280c6d112cd2b9f9fb3731fd7471addd956e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"function create_watcher_cache_dir {"},{"line_number":177,"context_line":"    # Create cache dir"},{"line_number":178,"context_line":"    sudo install -d -o $STACK_USER $WATCHER_AUTH_CACHE_DIR"},{"line_number":179,"context_line":"    rm -f $WATCHER_AUTH_CACHE_DIR/*"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"# init_watcher() - Initialize databases, etc."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_7a7a8cbe","line":179,"range":{"start_line":179,"start_character":6,"end_line":179,"end_character":9},"in_reply_to":"7a5de9d1_837cffb5","updated":"2016-02-02 06:21:29.000000000","message":"+1","commit_id":"f6fb35d23f5ab0df448710df9f1c75610cf3ef9d"}]}
