)]}'
{"watcher/decision_engine/strategy/strategies/basic_consolidation.py":[{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"0ac05453108f0e819e9660f251c31b252a5ec4d3","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            return 0"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def calculate_score_vm(self, vm, model):"},{"line_number":298,"context_line":"        \"\"\"Calculate Score of virtual machine"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        :param vm: the virtual machine"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_eb996120","line":297,"updated":"2016-02-04 15:23:48.000000000","message":"can you rename model to  cluster_data_model ?","commit_id":"eb61e4be61b20547a4db53e958c517998b67b924"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"0ac05453108f0e819e9660f251c31b252a5ec4d3","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                                 applies_to\u003dapplies_to,"},{"line_number":348,"context_line":"                                 input_parameters\u003dparameters)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def score_of_nodes(self, current_model, score):"},{"line_number":351,"context_line":"        \"\"\"Calculate score of nodes based on load by VMs\"\"\""},{"line_number":352,"context_line":"        for hypervisor_id in current_model.get_all_hypervisors():"},{"line_number":353,"context_line":"            hypervisor \u003d current_model.get_hypervisor_from_id(hypervisor_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_6b86d1ba","line":350,"updated":"2016-02-04 15:23:48.000000000","message":"can you please rename model to current_model to  cluster_data_model ?\nthanks","commit_id":"eb61e4be61b20547a4db53e958c517998b67b924"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"0ac05453108f0e819e9660f251c31b252a5ec4d3","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                score.append((hypervisor_id, result))"},{"line_number":363,"context_line":"        return score"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def node_and_vm_score(self, s, score, current_model):"},{"line_number":366,"context_line":"        \"\"\"Get List of VMs from Node\"\"\""},{"line_number":367,"context_line":"        node_to_release \u003d s[len(score) - 1][0]"},{"line_number":368,"context_line":"        vms_to_mig \u003d current_model.get_mapping().get_node_vms_from_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_cb64a523","line":365,"updated":"2016-02-04 15:23:48.000000000","message":"can please you rename \"s\" ?","commit_id":"eb61e4be61b20547a4db53e958c517998b67b924"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"0e72bdafba790003c58a25ab816c4d2232f3a48a","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                    self.create_migration_vm("},{"line_number":413,"context_line":"                        current_model, mig_vm,"},{"line_number":414,"context_line":"                        mig_src_hypervisor, mig_dst_hypervisor)"},{"line_number":415,"context_line":"                    num_migrations +\u003d 1"},{"line_number":416,"context_line":"                    break"},{"line_number":417,"context_line":"        return number_migrations"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_85cbfea4","line":415,"range":{"start_line":415,"start_character":20,"end_line":415,"end_character":34},"updated":"2016-02-04 14:41:35.000000000","message":"should be named \"number_migrations\" here","commit_id":"eb61e4be61b20547a4db53e958c517998b67b924"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"0ac05453108f0e819e9660f251c31b252a5ec4d3","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        else:"},{"line_number":425,"context_line":"            return unsuccessful_migration + 1"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def execute(self, orign_model):"},{"line_number":428,"context_line":"        LOG.info(_LI(\"Initializing Sercon Consolidation\"))"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if orign_model is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_ab484988","line":427,"updated":"2016-02-04 15:23:48.000000000","message":"Can you rename origin_model","commit_id":"eb61e4be61b20547a4db53e958c517998b67b924"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"0ac05453108f0e819e9660f251c31b252a5ec4d3","unresolved":false,"context_lines":[{"line_number":482,"context_line":"            # BFD: Best Fit Decrease"},{"line_number":483,"context_line":"            LOG.debug(\"VM(s) BFD {0}\".format(sorted_vms))"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"            m \u003d self.calculate_m(sorted_vms, current_model, node_to_release,"},{"line_number":486,"context_line":"                                 sorted_score)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"            unsuccessful_migration \u003d self.unsuccessful_migration_actualization("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_4b56755d","line":485,"updated":"2016-02-04 15:23:48.000000000","message":"Can you rename m ?","commit_id":"eb61e4be61b20547a4db53e958c517998b67b924"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"138efc540dbbe2cee267ec8d66caaee7513727e5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        self.migration_attempts \u003d size_cluster * self.bound_migration"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def check_migration(self, model,"},{"line_number":122,"context_line":"                        src_hypervisor,"},{"line_number":123,"context_line":"                        dest_hypervisor,"},{"line_number":124,"context_line":"                        vm_to_mig):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_10fd8e6d","line":121,"updated":"2016-02-08 14:18:06.000000000","message":"Can you please rename model to cluster_data_model in order to be consistent. thanks a lot.","commit_id":"03acb146170f6c25c89607b42c909088d8e7f4f0"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        total_cores \u003d 0"},{"line_number":142,"context_line":"        total_disk \u003d 0"},{"line_number":143,"context_line":"        total_mem \u003d 0"},{"line_number":144,"context_line":"        cap_cores \u003d cluster_data_model. \\"},{"line_number":145,"context_line":"            get_resource_from_id(ResourceType.cpu_cores)"},{"line_number":146,"context_line":"        cap_disk \u003d cluster_data_model. \\"},{"line_number":147,"context_line":"            get_resource_from_id(ResourceType.disk)"},{"line_number":148,"context_line":"        cap_mem \u003d cluster_data_model. \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_362babed","line":145,"range":{"start_line":144,"start_character":7,"end_line":145,"end_character":56},"updated":"2016-02-10 05:39:53.000000000","message":"Don\u0027t use backslash unless there is no better way:\n\n  cap_cores \u003d cluster_data_model.get_resource_from_id(\n    ResourceType.cpu_cores)\n\ns/cap_cores/cpu_capacity","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        total_mem \u003d 0"},{"line_number":144,"context_line":"        cap_cores \u003d cluster_data_model. \\"},{"line_number":145,"context_line":"            get_resource_from_id(ResourceType.cpu_cores)"},{"line_number":146,"context_line":"        cap_disk \u003d cluster_data_model. \\"},{"line_number":147,"context_line":"            get_resource_from_id(ResourceType.disk)"},{"line_number":148,"context_line":"        cap_mem \u003d cluster_data_model. \\"},{"line_number":149,"context_line":"            get_resource_from_id(ResourceType.memory)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_7677e302","line":146,"range":{"start_line":146,"start_character":8,"end_line":146,"end_character":16},"updated":"2016-02-10 05:39:53.000000000","message":"disk_capacity","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            get_resource_from_id(ResourceType.cpu_cores)"},{"line_number":146,"context_line":"        cap_disk \u003d cluster_data_model. \\"},{"line_number":147,"context_line":"            get_resource_from_id(ResourceType.disk)"},{"line_number":148,"context_line":"        cap_mem \u003d cluster_data_model. \\"},{"line_number":149,"context_line":"            get_resource_from_id(ResourceType.memory)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        for vm_id in cluster_data_model. \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_56650743","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":15},"updated":"2016-02-10 05:39:53.000000000","message":"memory_capacity","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    total_disk,"},{"line_number":167,"context_line":"                                    total_mem)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def check_threshold(self, model,"},{"line_number":170,"context_line":"                        dest_hypervisor,"},{"line_number":171,"context_line":"                        total_cores,"},{"line_number":172,"context_line":"                        total_disk,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_165f8f73","line":169,"range":{"start_line":169,"start_character":30,"end_line":169,"end_character":35},"updated":"2016-02-10 05:39:53.000000000","message":"Renamed model above to cluster_data_model - should this also be renamed?\n\nAlso, model should be added to the docstring.","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        :param total_mem"},{"line_number":183,"context_line":"        :return: True if the threshold is not exceed"},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        cap_cores \u003d model.get_resource_from_id(ResourceType.cpu_cores)"},{"line_number":186,"context_line":"        cap_disk \u003d model.get_resource_from_id(ResourceType.disk)"},{"line_number":187,"context_line":"        cap_mem \u003d model.get_resource_from_id(ResourceType.memory)"},{"line_number":188,"context_line":"        # available"},{"line_number":189,"context_line":"        cores_available \u003d cap_cores.get_capacity(dest_hypervisor)"},{"line_number":190,"context_line":"        disk_available \u003d cap_disk.get_capacity(dest_hypervisor)"},{"line_number":191,"context_line":"        mem_available \u003d cap_mem.get_capacity(dest_hypervisor)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if cores_available \u003e\u003d total_cores * self.threshold_cores \\"},{"line_number":194,"context_line":"                and disk_available \u003e\u003d total_disk * self.threshold_disk \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_b689dbcc","line":191,"range":{"start_line":185,"start_character":8,"end_line":191,"end_character":61},"updated":"2016-02-10 05:39:53.000000000","message":"Ditto, and consider combining these like calculate_weight does?","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def get_number_of_migrations(self):"},{"line_number":219,"context_line":"        return self.number_of_migrations"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def calculate_weight(self, model, element, total_cores_used,"},{"line_number":222,"context_line":"                         total_disk_used, total_memory_used):"},{"line_number":223,"context_line":"        \"\"\"Calculate weight of every resource"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_f6d0b3cb","line":221,"range":{"start_line":221,"start_character":31,"end_line":221,"end_character":36},"updated":"2016-02-10 05:39:53.000000000","message":"Ditto","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            :return:"},{"line_number":263,"context_line":"            \"\"\""},{"line_number":264,"context_line":"        resource_id \u003d \"%s_%s\" % (hypervisor.uuid, hypervisor.hostname)"},{"line_number":265,"context_line":"        cpu_avg_vm \u003d self.ceilometer. \\"},{"line_number":266,"context_line":"            statistic_aggregation(resource_id\u003dresource_id,"},{"line_number":267,"context_line":"                                  meter_name\u003dself.HOST_CPU_USAGE_METRIC_NAME,"},{"line_number":268,"context_line":"                                  period\u003d\"7200\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_56c187e3","line":265,"range":{"start_line":265,"start_character":8,"end_line":265,"end_character":18},"updated":"2016-02-10 05:39:53.000000000","message":"vm_average_cpu_utilization or vm_avg_cpu_util","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                          OFFLINE.value)"},{"line_number":400,"context_line":"            self.number_of_released_nodes +\u003d 1"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def calculate_m(self, sorted_vms, current_model, node_to_release,"},{"line_number":403,"context_line":"                    sorted_score):"},{"line_number":404,"context_line":"        number_migrations \u003d 0"},{"line_number":405,"context_line":"        for vm in sorted_vms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_962cdfac","line":402,"range":{"start_line":402,"start_character":8,"end_line":402,"end_character":19},"updated":"2016-02-10 05:39:53.000000000","message":"calculate_num_migrations ?","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                result \u003d self.check_migration(current_model,"},{"line_number":414,"context_line":"                                              mig_src_hypervisor,"},{"line_number":415,"context_line":"                                              mig_dst_hypervisor, mig_vm)"},{"line_number":416,"context_line":"                if result is True:"},{"line_number":417,"context_line":"                    self.create_migration_vm("},{"line_number":418,"context_line":"                        current_model, mig_vm,"},{"line_number":419,"context_line":"                        mig_src_hypervisor, mig_dst_hypervisor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_364acb84","line":416,"range":{"start_line":416,"start_character":16,"end_line":416,"end_character":34},"updated":"2016-02-10 05:39:53.000000000","message":"if result","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        else:"},{"line_number":430,"context_line":"            return unsuccessful_migration + 1"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def execute(self, origin_model):"},{"line_number":433,"context_line":"        LOG.info(_LI(\"Initializing Sercon Consolidation\"))"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        if origin_model is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_1649cf8b","line":432,"range":{"start_line":432,"start_character":22,"end_line":432,"end_character":34},"updated":"2016-02-10 05:39:53.000000000","message":"original?","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                                                  OFFLINE.value)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        while self.get_allowed_migration_attempts() \u003e\u003d unsuccessful_migration:"},{"line_number":462,"context_line":"            if first is not True:"},{"line_number":463,"context_line":"                self.efficacy \u003d self.calculate_migration_efficacy()"},{"line_number":464,"context_line":"                if self.efficacy \u003c float(self.target_efficacy):"},{"line_number":465,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_76584357","line":462,"range":{"start_line":462,"start_character":12,"end_line":462,"end_character":32},"updated":"2016-02-10 05:39:53.000000000","message":"if not first","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"b5e1b27d6decaed1b3a7e221e0a0cb22e1b99ed7","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                self.efficacy \u003d self.calculate_migration_efficacy()"},{"line_number":464,"context_line":"                if self.efficacy \u003c float(self.target_efficacy):"},{"line_number":465,"context_line":"                    break"},{"line_number":466,"context_line":"            first \u003d False"},{"line_number":467,"context_line":"            score \u003d []"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"            score \u003d self.score_of_nodes(current_model, score)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_36316b0c","line":466,"range":{"start_line":466,"start_character":12,"end_line":466,"end_character":17},"updated":"2016-02-10 05:39:53.000000000","message":"first_migration ?","commit_id":"8f6b39474698a6fa37e877bc9881a5ad7d700ec8"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5ce80ced5ef2274c32e1cba321b3e78fba915227","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        total_cores \u003d 0"},{"line_number":142,"context_line":"        total_disk \u003d 0"},{"line_number":143,"context_line":"        total_mem \u003d 0"},{"line_number":144,"context_line":"        "},{"line_number":145,"context_line":"        cpu_capacity \u003d cluster_data_model.get_resource_from_id("},{"line_number":146,"context_line":"            ResourceType.cpu_cores)"},{"line_number":147,"context_line":"        disk_capacity \u003d cluster_data_model.get_resource_from_id("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_a4cad09f","line":144,"updated":"2016-02-10 23:28:10.000000000","message":"oops!","commit_id":"bc9c122503ef83ea868050d6023a3bd200da54d8"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5ce80ced5ef2274c32e1cba321b3e78fba915227","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        memory_capacity \u003d cluster_data_model.get_resource_from_id("},{"line_number":192,"context_line":"            ResourceType.memory).get_capacity(dest_hypervisor)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if cpu_capacity \u003e\u003d total_cores * self.threshold_cores \\"},{"line_number":195,"context_line":"                and disk_capacity \u003e\u003d total_disk * self.threshold_disk \\"},{"line_number":196,"context_line":"                and memory_capacity \u003e\u003d total_mem * self.threshold_mem:"},{"line_number":197,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_c4aeec97","line":194,"updated":"2016-02-10 23:28:10.000000000","message":"style nit: use parens to avoid having to use \u0027\\\u0027 to continue lines. But since the original used that style, I can\u0027t complain too much. :)","commit_id":"bc9c122503ef83ea868050d6023a3bd200da54d8"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"b5f0aa33d668b7cc4fe7e82fa5173c567d0f7260","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            return unsuccessful_migration + 1"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def execute(self, original_model):"},{"line_number":435,"context_line":"        LOG.info(_LI(\"Initializing Sercon Consolidation\"))"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        if original_model is None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_3b24d2ad","line":434,"range":{"start_line":434,"start_character":22,"end_line":434,"end_character":36},"updated":"2016-02-16 08:46:58.000000000","message":"Please update also the abstract method signature, into base.py file (and also, as a consequence, please update this other strategy implementations)\n\nI\u0027m not sure, also, that the docstring on this line is correct https://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/base.py#L70. Please update it, to have something coherent ;)","commit_id":"291d97550e31b781df208b34c03f5ccd4bd9e4db"}]}