)]}'
{"watcher/tests/applier/actions/test_change_nova_service_state.py":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\", mock.Mock())"},{"line_number":32,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":33,"context_line":"    def test_execute_change_compute_state_without_target_state(self, m_helper):"},{"line_number":34,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":35,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":36,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.execute)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_8e3cec30","line":33,"range":{"start_line":33,"start_character":69,"end_line":33,"end_character":77},"updated":"2016-02-15 09:58:21.000000000","message":"not used","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\", mock.Mock())"},{"line_number":32,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":33,"context_line":"    def test_execute_change_compute_state_without_target_state(self, m_helper):"},{"line_number":34,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":35,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":36,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.execute)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f73aa4cc","line":33,"range":{"start_line":33,"start_character":69,"end_line":33,"end_character":77},"in_reply_to":"dae33548_8e3cec30","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":33,"context_line":"    def test_execute_change_compute_state_without_target_state(self, m_helper):"},{"line_number":34,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":35,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":36,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.execute)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\", mock.Mock())"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ee1ad816","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":25},"updated":"2016-02-15 09:58:21.000000000","message":"due to https://review.openstack.org/#/c/270642/, applies_to does not exist anymore","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":33,"context_line":"    def test_execute_change_compute_state_without_target_state(self, m_helper):"},{"line_number":34,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":35,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":36,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.execute)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\", mock.Mock())"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_972518ad","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":25},"in_reply_to":"dae33548_ee1ad816","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\", mock.Mock())"},{"line_number":39,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":40,"context_line":"    def test_revert_change_compute_state_without_target_state(self, m_helper):"},{"line_number":41,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":42,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":43,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.revert)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ee4938d2","line":40,"range":{"start_line":40,"start_character":68,"end_line":40,"end_character":76},"updated":"2016-02-15 09:58:21.000000000","message":"not used","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\", mock.Mock())"},{"line_number":39,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":40,"context_line":"    def test_revert_change_compute_state_without_target_state(self, m_helper):"},{"line_number":41,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":42,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":43,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.revert)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_772694bb","line":40,"range":{"start_line":40,"start_character":68,"end_line":40,"end_character":76},"in_reply_to":"dae33548_ee4938d2","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":40,"context_line":"    def test_revert_change_compute_state_without_target_state(self, m_helper):"},{"line_number":41,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":42,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":43,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.revert)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_4e5f8472","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":25},"updated":"2016-02-15 09:58:21.000000000","message":"ditto","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"},{"line_number":40,"context_line":"    def test_revert_change_compute_state_without_target_state(self, m_helper):"},{"line_number":41,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":42,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":43,"context_line":"        self.assertRaises(exception.IllegalArgumentException, action.revert)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_171bc873","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":25},"in_reply_to":"dae33548_4e5f8472","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        m_osc_cls.return_value \u003d m_osc"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":55,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":56,"context_line":"        input_parameters \u003d dict(state\u003dhstate.HypervisorState.ONLINE.value)"},{"line_number":57,"context_line":"        action.input_parameters \u003d input_parameters"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_6ed1a8cd","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":25},"updated":"2016-02-15 09:58:21.000000000","message":"ditto","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        m_osc_cls.return_value \u003d m_osc"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        action \u003d change_nova_service_state.ChangeNovaServiceState()"},{"line_number":55,"context_line":"        action.applies_to \u003d \"test_host\""},{"line_number":56,"context_line":"        input_parameters \u003d dict(state\u003dhstate.HypervisorState.ONLINE.value)"},{"line_number":57,"context_line":"        action.input_parameters \u003d input_parameters"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_371ecc63","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":25},"in_reply_to":"dae33548_6ed1a8cd","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        input_parameters \u003d dict(state\u003dhstate.HypervisorState.ONLINE.value)"},{"line_number":57,"context_line":"        action.input_parameters \u003d input_parameters"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.assertTrue(action.precondition() is not False)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\")"},{"line_number":62,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_d1e4d93c","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":45},"updated":"2016-02-15 09:58:21.000000000","message":"Should not this method return True, instead of \u0027pass\u0027 ?","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        input_parameters \u003d dict(state\u003dhstate.HypervisorState.ONLINE.value)"},{"line_number":57,"context_line":"        action.input_parameters \u003d input_parameters"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.assertTrue(action.precondition() is not False)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\")"},{"line_number":62,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_d7104051","line":59,"range":{"start_line":59,"start_character":24,"end_line":59,"end_character":45},"in_reply_to":"dae33548_d1e4d93c","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        input_parameters \u003d dict(state\u003dhstate.HypervisorState.ONLINE.value)"},{"line_number":73,"context_line":"        action.input_parameters \u003d input_parameters"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.assertTrue(action.postcondition() is not False)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\")"},{"line_number":78,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_512569a9","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":46},"updated":"2016-02-15 09:58:21.000000000","message":"ditto","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        input_parameters \u003d dict(state\u003dhstate.HypervisorState.ONLINE.value)"},{"line_number":73,"context_line":"        action.input_parameters \u003d input_parameters"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.assertTrue(action.postcondition() is not False)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @mock.patch.object(clients, \"OpenStackClients\")"},{"line_number":78,"context_line":"    @mock.patch.object(nova_helper, \"NovaHelper\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_37352cda","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":46},"in_reply_to":"dae33548_512569a9","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"02e054a094bc83a858f633828e2e556b6c8a35f4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.action.input_parameters \u003d {\"extra\": \"failed\"}"},{"line_number":85,"context_line":"        self.assertRaises(voluptuous.Invalid, self.action.validate_parameters)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_migration_precondition(self):"},{"line_number":88,"context_line":"        try:"},{"line_number":89,"context_line":"            self.action.precondition()"},{"line_number":90,"context_line":"        except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_2e801346","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":35},"updated":"2016-02-16 07:27:51.000000000","message":"migration here is confusing. pls. change it.","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95e9415e9b048595174ba694ebec9cbb450d0122","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.action.input_parameters \u003d {\"extra\": \"failed\"}"},{"line_number":85,"context_line":"        self.assertRaises(voluptuous.Invalid, self.action.validate_parameters)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_migration_precondition(self):"},{"line_number":88,"context_line":"        try:"},{"line_number":89,"context_line":"            self.action.precondition()"},{"line_number":90,"context_line":"        except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_1890f442","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":35},"in_reply_to":"dae33548_2e801346","updated":"2016-02-16 10:43:25.000000000","message":"Done","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"02e054a094bc83a858f633828e2e556b6c8a35f4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        except Exception as exc:"},{"line_number":91,"context_line":"            self.fail(exc)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_migration_postcondition(self):"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            self.action.postcondition()"},{"line_number":96,"context_line":"        except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_8e979f8f","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":36},"updated":"2016-02-16 07:27:51.000000000","message":"ditto","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95e9415e9b048595174ba694ebec9cbb450d0122","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        except Exception as exc:"},{"line_number":91,"context_line":"            self.fail(exc)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_migration_postcondition(self):"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            self.action.postcondition()"},{"line_number":96,"context_line":"        except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_589a7c64","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":36},"in_reply_to":"dae33548_8e979f8f","updated":"2016-02-16 10:43:25.000000000","message":"Done","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"}],"watcher/tests/applier/actions/test_migration.py":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.m_osc \u003d mock.Mock(spec\u003dclients.OpenStackClients)"},{"line_number":38,"context_line":"        self.m_osc_cls.return_value \u003d self.m_osc"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        m_open_stack_clients \u003d mock.patch.object("},{"line_number":41,"context_line":"            clients, \"OpenStackClients\", self.m_osc_cls)"},{"line_number":42,"context_line":"        m_nova_helper \u003d mock.patch.object("},{"line_number":43,"context_line":"            nova_helper, \"NovaHelper\", self.m_helper_cls)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_31b6e5dc","line":40,"range":{"start_line":40,"start_character":10,"end_line":40,"end_character":20},"updated":"2016-02-15 09:58:21.000000000","message":"s/open_stack/openstack/","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.m_osc \u003d mock.Mock(spec\u003dclients.OpenStackClients)"},{"line_number":38,"context_line":"        self.m_osc_cls.return_value \u003d self.m_osc"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        m_open_stack_clients \u003d mock.patch.object("},{"line_number":41,"context_line":"            clients, \"OpenStackClients\", self.m_osc_cls)"},{"line_number":42,"context_line":"        m_nova_helper \u003d mock.patch.object("},{"line_number":43,"context_line":"            nova_helper, \"NovaHelper\", self.m_helper_cls)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f7af44e1","line":40,"range":{"start_line":40,"start_character":10,"end_line":40,"end_character":20},"in_reply_to":"dae33548_31b6e5dc","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        m_nova_helper \u003d mock.patch.object("},{"line_number":43,"context_line":"            nova_helper, \"NovaHelper\", self.m_helper_cls)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        m_open_stack_clients.start()"},{"line_number":46,"context_line":"        m_nova_helper.start()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.addCleanup(m_open_stack_clients.stop)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f1491dd2","line":45,"range":{"start_line":45,"start_character":10,"end_line":45,"end_character":20},"updated":"2016-02-15 09:58:21.000000000","message":"ditto","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        m_nova_helper \u003d mock.patch.object("},{"line_number":43,"context_line":"            nova_helper, \"NovaHelper\", self.m_helper_cls)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        m_open_stack_clients.start()"},{"line_number":46,"context_line":"        m_nova_helper.start()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.addCleanup(m_open_stack_clients.stop)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_d7acc0ef","line":45,"range":{"start_line":45,"start_character":10,"end_line":45,"end_character":20},"in_reply_to":"dae33548_f1491dd2","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"12bb4622552c800fd4d13106a7bda1c1700b18c3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        m_open_stack_clients.start()"},{"line_number":46,"context_line":"        m_nova_helper.start()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.addCleanup(m_open_stack_clients.stop)"},{"line_number":49,"context_line":"        self.addCleanup(m_nova_helper.stop)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.input_parameters \u003d dict("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_715a2d85","line":48,"range":{"start_line":48,"start_character":26,"end_line":48,"end_character":36},"updated":"2016-02-15 09:58:21.000000000","message":"ditto","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"20630d9ac3eb1284283560cfe55b85238da9c7d0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        m_open_stack_clients.start()"},{"line_number":46,"context_line":"        m_nova_helper.start()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.addCleanup(m_open_stack_clients.stop)"},{"line_number":49,"context_line":"        self.addCleanup(m_nova_helper.stop)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.input_parameters \u003d dict("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_37ba4c24","line":48,"range":{"start_line":48,"start_character":26,"end_line":48,"end_character":36},"in_reply_to":"dae33548_715a2d85","updated":"2016-02-15 13:21:12.000000000","message":"Done","commit_id":"ce0701d617c70a921d8c5c7454d0d65895184cad"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"02e054a094bc83a858f633828e2e556b6c8a35f4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def test_parameters_exception_src_hypervisor(self):"},{"line_number":91,"context_line":"        parameters \u003d {baction.BaseAction.RESOURCE_ID:"},{"line_number":92,"context_line":"                      \"45a37aeb-95ab-4ddb-a305-7d9f62c2f5ba\","},{"line_number":93,"context_line":"                      \u0027migration_type\u0027: \u0027cold\u0027,"},{"line_number":94,"context_line":"                      \u0027src_hypervisor\u0027: None,"},{"line_number":95,"context_line":"                      \u0027dst_hypervisor\u0027: \u0027compute3\u0027}"},{"line_number":96,"context_line":"        self.action.input_parameters \u003d parameters"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_62cb4fa6","line":93,"range":{"start_line":93,"start_character":41,"end_line":93,"end_character":45},"updated":"2016-02-16 07:27:51.000000000","message":"should be \u0027live\u0027","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95e9415e9b048595174ba694ebec9cbb450d0122","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def test_parameters_exception_src_hypervisor(self):"},{"line_number":91,"context_line":"        parameters \u003d {baction.BaseAction.RESOURCE_ID:"},{"line_number":92,"context_line":"                      \"45a37aeb-95ab-4ddb-a305-7d9f62c2f5ba\","},{"line_number":93,"context_line":"                      \u0027migration_type\u0027: \u0027cold\u0027,"},{"line_number":94,"context_line":"                      \u0027src_hypervisor\u0027: None,"},{"line_number":95,"context_line":"                      \u0027dst_hypervisor\u0027: \u0027compute3\u0027}"},{"line_number":96,"context_line":"        self.action.input_parameters \u003d parameters"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_bb9bc271","line":93,"range":{"start_line":93,"start_character":41,"end_line":93,"end_character":45},"in_reply_to":"dae33548_62cb4fa6","updated":"2016-02-16 10:43:25.000000000","message":"Done","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"02e054a094bc83a858f633828e2e556b6c8a35f4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def test_parameters_exception_dst_hypervisor(self):"},{"line_number":100,"context_line":"        parameters \u003d {baction.BaseAction.RESOURCE_ID:"},{"line_number":101,"context_line":"                      \"45a37aeb-95ab-4ddb-a305-7d9f62c2f5ba\","},{"line_number":102,"context_line":"                      \u0027migration_type\u0027: \u0027cold\u0027,"},{"line_number":103,"context_line":"                      \u0027src_hypervisor\u0027: \u0027compute-1\u0027,"},{"line_number":104,"context_line":"                      \u0027dst_hypervisor\u0027: None}"},{"line_number":105,"context_line":"        self.action.input_parameters \u003d parameters"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_e2bf5ff9","line":102,"range":{"start_line":102,"start_character":41,"end_line":102,"end_character":45},"updated":"2016-02-16 07:27:51.000000000","message":"ditto","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95e9415e9b048595174ba694ebec9cbb450d0122","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def test_parameters_exception_dst_hypervisor(self):"},{"line_number":100,"context_line":"        parameters \u003d {baction.BaseAction.RESOURCE_ID:"},{"line_number":101,"context_line":"                      \"45a37aeb-95ab-4ddb-a305-7d9f62c2f5ba\","},{"line_number":102,"context_line":"                      \u0027migration_type\u0027: \u0027cold\u0027,"},{"line_number":103,"context_line":"                      \u0027src_hypervisor\u0027: \u0027compute-1\u0027,"},{"line_number":104,"context_line":"                      \u0027dst_hypervisor\u0027: None}"},{"line_number":105,"context_line":"        self.action.input_parameters \u003d parameters"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_fb8b8a1c","line":102,"range":{"start_line":102,"start_character":41,"end_line":102,"end_character":45},"in_reply_to":"dae33548_e2bf5ff9","updated":"2016-02-16 10:43:25.000000000","message":"Done","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"02e054a094bc83a858f633828e2e556b6c8a35f4","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_parameters_exception_empty_fields(self):"},{"line_number":109,"context_line":"        parameters \u003d {baction.BaseAction.RESOURCE_ID: None,"},{"line_number":110,"context_line":"                      \u0027migration_type\u0027: None,"},{"line_number":111,"context_line":"                      \u0027src_hypervisor\u0027: None,"},{"line_number":112,"context_line":"                      \u0027dst_hypervisor\u0027: None}"},{"line_number":113,"context_line":"        self.action.input_parameters \u003d parameters"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_0209a3dd","line":110,"range":{"start_line":110,"start_character":40,"end_line":110,"end_character":44},"updated":"2016-02-16 07:27:51.000000000","message":"Given that previous test already used \u0027None\u0027 to trigger error, why do it again?","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95e9415e9b048595174ba694ebec9cbb450d0122","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_parameters_exception_empty_fields(self):"},{"line_number":109,"context_line":"        parameters \u003d {baction.BaseAction.RESOURCE_ID: None,"},{"line_number":110,"context_line":"                      \u0027migration_type\u0027: None,"},{"line_number":111,"context_line":"                      \u0027src_hypervisor\u0027: None,"},{"line_number":112,"context_line":"                      \u0027dst_hypervisor\u0027: None}"},{"line_number":113,"context_line":"        self.action.input_parameters \u003d parameters"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_cce36a32","line":110,"range":{"start_line":110,"start_character":40,"end_line":110,"end_character":44},"in_reply_to":"dae33548_0209a3dd","updated":"2016-02-16 10:43:25.000000000","message":"This test is like the worst case scenario. I could remove it but this is kind of the reference for all the other tests which are pin pointing at a specific parameter. What do you think?","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"02e054a094bc83a858f633828e2e556b6c8a35f4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def test_execute_live_migration_invalid_instance(self):"},{"line_number":142,"context_line":"        self.m_helper.find_instance.return_value \u003d None"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self.assertRaises(exception.InstanceNotFound, self.action.execute)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_revert_live_migration(self):"},{"line_number":147,"context_line":"        self.m_helper.find_instance.return_value \u003d self.INSTANCE_UUID"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_022fe3f6","line":144,"updated":"2016-02-16 07:27:51.000000000","message":"It\u0027s better to check instance id inside the exception","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"95e9415e9b048595174ba694ebec9cbb450d0122","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def test_execute_live_migration_invalid_instance(self):"},{"line_number":142,"context_line":"        self.m_helper.find_instance.return_value \u003d None"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self.assertRaises(exception.InstanceNotFound, self.action.execute)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_revert_live_migration(self):"},{"line_number":147,"context_line":"        self.m_helper.find_instance.return_value \u003d self.INSTANCE_UUID"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_9bcfde7e","line":144,"in_reply_to":"dae33548_022fe3f6","updated":"2016-02-16 10:43:25.000000000","message":"Done","commit_id":"a1701e660ddf06bf4a4251dae2aa399f9bedf6ad"}]}