)]}'
{"watcher/api/controllers/v1/audit_template.py":[{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"085c460fd40f5d39ef7bb05869e0ef61bb48c3b7","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def _get_audit_templates_collection(self, filters, marker, limit,"},{"line_number":201,"context_line":"                                        sort_key, sort_dir, expand\u003dFalse,"},{"line_number":202,"context_line":"                                        resource_url\u003dNone):"},{"line_number":203,"context_line":"        filters \u003d api_utils.validate_search_filters("},{"line_number":204,"context_line":"            filters, objects.audit_template.AuditTemplate.fields.keys())"},{"line_number":205,"context_line":"        limit \u003d api_utils.validate_limit(limit)"},{"line_number":206,"context_line":"        sort_dir \u003d api_utils.validate_sort_dir(sort_dir)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_898ca680","line":203,"updated":"2016-02-16 13:29:56.000000000","message":"As discussed with you, I don\u0027t understand why we need to return \"filters\" because the function only check if the filter is in the allowed list.\n\nWe should remove that and do it also for validate_sort_dir in utils.py ( we can create a bug)","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f78c84ee2a7cbeac03cc04c03098ad7520328ca0","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def _get_audit_templates_collection(self, filters, marker, limit,"},{"line_number":201,"context_line":"                                        sort_key, sort_dir, expand\u003dFalse,"},{"line_number":202,"context_line":"                                        resource_url\u003dNone):"},{"line_number":203,"context_line":"        filters \u003d api_utils.validate_search_filters("},{"line_number":204,"context_line":"            filters, objects.audit_template.AuditTemplate.fields.keys())"},{"line_number":205,"context_line":"        limit \u003d api_utils.validate_limit(limit)"},{"line_number":206,"context_line":"        sort_dir \u003d api_utils.validate_sort_dir(sort_dir)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_57580756","line":203,"in_reply_to":"dae33548_898ca680","updated":"2016-02-18 08:45:23.000000000","message":"Bug created","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"085c460fd40f5d39ef7bb05869e0ef61bb48c3b7","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        filters \u003d {}"},{"line_number":241,"context_line":"        if goal:"},{"line_number":242,"context_line":"            filters[\"goal\"] \u003d goal"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        return self._get_audit_templates_collection("},{"line_number":245,"context_line":"            filters, marker, limit, sort_key, sort_dir)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_c9bd0ed9","line":242,"updated":"2016-02-16 13:29:56.000000000","message":"We can maybe create a dedicated function in order to factorize a little bit the code.\n\n    filters \u003d {}\n        if goal:\n            filters[\"goal\"] \u003d goal","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f78c84ee2a7cbeac03cc04c03098ad7520328ca0","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        filters \u003d {}"},{"line_number":241,"context_line":"        if goal:"},{"line_number":242,"context_line":"            filters[\"goal\"] \u003d goal"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        return self._get_audit_templates_collection("},{"line_number":245,"context_line":"            filters, marker, limit, sort_key, sort_dir)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_658e55d1","line":242,"in_reply_to":"dae33548_c9bd0ed9","updated":"2016-02-18 08:45:23.000000000","message":"Done","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"085c460fd40f5d39ef7bb05869e0ef61bb48c3b7","unresolved":false,"context_lines":[{"line_number":250,"context_line":"               sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":251,"context_line":"        \"\"\"Retrieve a list of audit templates with detail."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        :param marker: pagination marker for large data sets."},{"line_number":254,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":255,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":256,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: asc."}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_89bae608","line":253,"updated":"2016-02-16 13:29:56.000000000","message":"missing goal in docstring.","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f78c84ee2a7cbeac03cc04c03098ad7520328ca0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"               sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":251,"context_line":"        \"\"\"Retrieve a list of audit templates with detail."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        :param marker: pagination marker for large data sets."},{"line_number":254,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":255,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":256,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: asc."}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_a5c21de7","line":253,"in_reply_to":"dae33548_89bae608","updated":"2016-02-18 08:45:23.000000000","message":"Done","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"085c460fd40f5d39ef7bb05869e0ef61bb48c3b7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        filters \u003d {}"},{"line_number":264,"context_line":"        if goal:"},{"line_number":265,"context_line":"            filters[\"goal\"] \u003d goal"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expand \u003d True"},{"line_number":268,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027audit_templates\u0027, \u0027detail\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_69cfa27f","line":265,"updated":"2016-02-16 13:29:56.000000000","message":"ditto","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f78c84ee2a7cbeac03cc04c03098ad7520328ca0","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        filters \u003d {}"},{"line_number":264,"context_line":"        if goal:"},{"line_number":265,"context_line":"            filters[\"goal\"] \u003d goal"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expand \u003d True"},{"line_number":268,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027audit_templates\u0027, \u0027detail\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_c5bda169","line":265,"in_reply_to":"dae33548_69cfa27f","updated":"2016-02-18 08:45:23.000000000","message":"Done","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"085c460fd40f5d39ef7bb05869e0ef61bb48c3b7","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    def get_one(self, audit_template):"},{"line_number":275,"context_line":"        \"\"\"Retrieve information about the given audit template."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        :param audit template_uuid: UUID or name of an audit template."},{"line_number":278,"context_line":"        \"\"\""},{"line_number":279,"context_line":"        if self.from_audit_templates:"},{"line_number":280,"context_line":"            raise exception.OperationNotPermitted"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_29591aff","line":277,"updated":"2016-02-16 13:29:56.000000000","message":"s/audit template_uuid/audit_template","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f78c84ee2a7cbeac03cc04c03098ad7520328ca0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    def get_one(self, audit_template):"},{"line_number":275,"context_line":"        \"\"\"Retrieve information about the given audit template."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        :param audit template_uuid: UUID or name of an audit template."},{"line_number":278,"context_line":"        \"\"\""},{"line_number":279,"context_line":"        if self.from_audit_templates:"},{"line_number":280,"context_line":"            raise exception.OperationNotPermitted"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_7766eb51","line":277,"in_reply_to":"dae33548_29591aff","updated":"2016-02-18 08:45:23.000000000","message":"Done","commit_id":"0cf5048a7c71bf48a0521c1e0312dad8695e3952"}]}
