)]}'
{"id":"openstack%2Fwatcher~285235","triplet_id":"openstack%2Fwatcher~master~I695f6b84df33cdda520c32b3520afdcb258c5291","project":"openstack/watcher","branch":"master","topic":"bug/1550261","hashtags":[],"change_id":"I695f6b84df33cdda520c32b3520afdcb258c5291","subject":"Removed \u0027alarm\u0027 in Action","status":"ABANDONED","created":"2016-02-26 11:17:05.000000000","updated":"2016-05-23 16:21:48.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5e7dd61c996ea47a7922202d7cd74aef79c0c4a9","_number":285235,"virtual_id_number":285235,"owner":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"value":1,"date":"2016-02-26 11:37:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"value":-2,"date":"2016-05-02 12:24:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2016-02-26 11:56:28.000000000","_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},{"date":"2016-02-26 11:56:19.000000000","_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"date":"2016-02-26 11:56:25.000000000","_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-26 11:37:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-02-26 11:56:19.000000000","updated_by":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"reviewer":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"state":"REVIEWER"},{"updated":"2016-02-26 11:56:25.000000000","updated_by":{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},"reviewer":{"_account_id":18599,"name":"Péter Hegedűs","email":"hpeter@inf.u-szeged.hu","username":"hpeter"},"state":"REVIEWER"},{"updated":"2016-02-26 11:56:28.000000000","updated_by":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"reviewer":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"state":"REVIEWER"},{"updated":"2016-05-02 12:24:54.000000000","updated_by":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"reviewer":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"state":"REVIEWER"}],"messages":[{"id":"55a7d168b98c727d88e64714266a174dbd56a61c","author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"date":"2016-02-26 11:17:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aba75ae6d3c8c959dabfb90cc042fea3a5e417ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-26 11:37:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-watcher-pep8 http://logs.openstack.org/35/285235/1/check/gate-watcher-pep8/1a7d4d8/ : SUCCESS in 1m 14s\n- gate-watcher-docs http://docs-draft.openstack.org/35/285235/1/check/gate-watcher-docs/bbd6041//doc/build/html/ : SUCCESS in 1m 55s\n- gate-watcher-python27 http://logs.openstack.org/35/285235/1/check/gate-watcher-python27/1f20c64/ : SUCCESS in 2m 26s\n- gate-watcher-python34 http://logs.openstack.org/35/285235/1/check/gate-watcher-python34/8d2be15/ : SUCCESS in 2m 33s\n- watcher-coverage http://logs.openstack.org/35/285235/1/check/watcher-coverage/b435680/ : SUCCESS in 1m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e01be38a1017d01b865941d0c6c8ecc5121e7a09","author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"date":"2016-02-26 13:04:43.000000000","message":"Patch Set 1: Code-Review-1\n\nYou actually missed some of them here:\n - There is an APIImpact and you need to remove this alarm field from the action controller (see watcher/api/controllers/v1/action.py line 129 and 193) that\u0027s why I added watcher-dashboard and python-watcherclient as being affected by this bug.\n - DB wise, there are filters on this field in watcher/db/sqlalchemy/api.py:262\n - The Planner also contained a ref to alarm in watcher/decision_engine/planner/default.py:49\n\nObviously this will probably break some tests along the way...","accounts_in_message":[],"_revision_number":1},{"id":"d3c8913c724398d8091a4d44a0c7b3f069131ab3","author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"date":"2016-05-02 12:24:54.000000000","message":"Patch Set 1: Code-Review-2\n\nThis was done in a separate changeset (see https://review.openstack.org/#/c/307226/)","accounts_in_message":[],"_revision_number":1},{"id":"83428e23fdd3f868d41d0c5ce4eeb42c2ff797b7","author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"date":"2016-05-23 16:21:48.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"23c9376e602cc4b33fc95ed026abca1915579449","revisions":{"23c9376e602cc4b33fc95ed026abca1915579449":{"kind":"REWORK","_number":1,"created":"2016-02-26 11:17:05.000000000","uploader":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"ref":"refs/changes/35/285235/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/35/285235/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/35/285235/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/35/285235/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/35/285235/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/35/285235/1"}}},"commit":{"parents":[{"commit":"10823ce133d18fcb9967e04c3d1dc3644bb00e8e","subject":"Merge \"Cleanup in test_objects.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/10823ce133d18fcb9967e04c3d1dc3644bb00e8e"}]}],"author":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2016-02-26 11:13:13.000000000","tz":60},"committer":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2016-02-26 11:16:34.000000000","tz":60},"subject":"Removed \u0027alarm\u0027 in Action","message":"Removed \u0027alarm\u0027 in Action\n\nThis field is currently unused and so we should remove it.\nIt was todo in watcher/objects/action.py line 47. Also modified\nget_test_action in tests/db/utils.py method to match to the\nmodified action.\n\nChange-Id: I695f6b84df33cdda520c32b3520afdcb258c5291\nCloses-Bug: #1550261\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/23c9376e602cc4b33fc95ed026abca1915579449"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/23c9376e602cc4b33fc95ed026abca1915579449"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"10823ce133d18fcb9967e04c3d1dc3644bb00e8e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}