)]}'
{"watcher/tests/applier/workflow_engine/test_default_workflow_engine.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"2e88d693c34cc29242de450dbfeb7dd02a817764","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def test_execute_with_no_actions(self):"},{"line_number":95,"context_line":"        actions \u003d []"},{"line_number":96,"context_line":"        result \u003d self.engine.execute(actions)"},{"line_number":97,"context_line":"        self.assertEqual(True, result)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_execute_with_one_action(self):"},{"line_number":100,"context_line":"        actions \u003d [self.create_action(\"nop\", {\u0027message\u0027: \u0027test\u0027}, None)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_caac5f8e","line":97,"updated":"2016-03-04 08:03:43.000000000","message":"If we\u0027re going to be picky this should be:\n\nself.assertTrue(result)\n\nSame for all of these that compare against True / False.","commit_id":"c440cdd69fa536fe1f0ac374e41849a0559b2714"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"550ece55a06b332c57ba1b07c51ebe5e65fba154","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def test_execute_with_no_actions(self):"},{"line_number":95,"context_line":"        actions \u003d []"},{"line_number":96,"context_line":"        result \u003d self.engine.execute(actions)"},{"line_number":97,"context_line":"        self.assertEqual(True, result)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_execute_with_one_action(self):"},{"line_number":100,"context_line":"        actions \u003d [self.create_action(\"nop\", {\u0027message\u0027: \u0027test\u0027}, None)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_df2a3f2c","line":97,"in_reply_to":"7af24918_caac5f8e","updated":"2016-03-11 11:15:26.000000000","message":"Thanks for this suggestion, but in my opinion it should stay assertEqual. I thought about it, and checked some code also, and I think this way is the best way to check whether it\u0027s True or not. \n\nIn watcher\u0027s base test file - which DbTestCase is inherited from - (watcher/tests/base.py) the TestCase class inherits from oslotest\u0027s BaseTestCase (https://github.com/openstack/oslotest/blob/master/oslotest/base.py#L35) which inherits from testtools\u0027s TestCase (https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L225). That class inherits from unittest\u0027s TestCase class. According to unittest\u0027s documentation - especially assertTrue/assertFalse method\u0027s documentation - (can be found here: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertTrue) using assertEqual is better than using assertTrue/assertFalse as it provides a better error message in case of failure. And if that\u0027s correct, we should keep it in this way as it is not overrided in any child classes. That\u0027s why I think assertEqual should stay. How do you think about it ?","commit_id":"c440cdd69fa536fe1f0ac374e41849a0559b2714"}],"watcher/tests/common/test_nova_helper.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"2e88d693c34cc29242de450dbfeb7dd02a817764","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        nova_util.nova.servers.list.return_value \u003d [server]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        result \u003d nova_util.stop_instance(instance_id)"},{"line_number":54,"context_line":"        self.assertEqual(True, result)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_set_host_offline(self, mock_glance, mock_cinder, mock_neutron,"},{"line_number":57,"context_line":"                              mock_nova):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_aad593e5","line":54,"updated":"2016-03-04 08:03:43.000000000","message":"Ditto","commit_id":"c440cdd69fa536fe1f0ac374e41849a0559b2714"}]}
