)]}'
{"watcher/decision_engine/model/resource.py":[{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"38251710b5d46061a7a975b8bbc675226f77196e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class ResourceType(Enum):"},{"line_number":21,"context_line":"    cpu_cores \u003d \u0027num_cores\u0027"},{"line_number":22,"context_line":"    memory \u003d \u0027memory\u0027"},{"line_number":23,"context_line":"    disk \u003d \u0027disk\u0027"},{"line_number":24,"context_line":"    disk_capacity \u003d \u0027disk_capacity\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_27a1a694","line":23,"updated":"2016-03-09 08:32:11.000000000","message":"Can you please rename disk by free_disk_gb ? \nThanks a lot","commit_id":"9569640880f8f1f96568d19dd1b09c71c523dea8"},{"author":{"_account_id":12087,"name":"Bruno Grazioli","email":"gaea@zhaw.ch","username":"brunograz"},"change_message_id":"94f10b633cf7c680bb0d6b5375d1d6c1f7b83ceb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class ResourceType(Enum):"},{"line_number":21,"context_line":"    cpu_cores \u003d \u0027num_cores\u0027"},{"line_number":22,"context_line":"    memory \u003d \u0027memory\u0027"},{"line_number":23,"context_line":"    disk \u003d \u0027disk\u0027"},{"line_number":24,"context_line":"    disk_capacity \u003d \u0027disk_capacity\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_44a9ad7a","line":23,"in_reply_to":"5aef4532_a476b1a1","updated":"2016-03-09 15:08:48.000000000","message":"I think there should be another blueprint which explicitly deals with this point. As could affect other strategies. My basic concern is that changing data models within a simple bug description looks like the wrong approach.","commit_id":"9569640880f8f1f96568d19dd1b09c71c523dea8"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"97f0b34a656f729367e062c8f3852bebda53f910","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class ResourceType(Enum):"},{"line_number":21,"context_line":"    cpu_cores \u003d \u0027num_cores\u0027"},{"line_number":22,"context_line":"    memory \u003d \u0027memory\u0027"},{"line_number":23,"context_line":"    disk \u003d \u0027disk\u0027"},{"line_number":24,"context_line":"    disk_capacity \u003d \u0027disk_capacity\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_a476b1a1","line":23,"in_reply_to":"5aef4532_b039d0f4","updated":"2016-03-09 15:02:56.000000000","message":"Do you propose something else ?","commit_id":"9569640880f8f1f96568d19dd1b09c71c523dea8"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"7cfc860b5a936b29305ac9f2426414ce65883aae","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class ResourceType(Enum):"},{"line_number":21,"context_line":"    cpu_cores \u003d \u0027num_cores\u0027"},{"line_number":22,"context_line":"    memory \u003d \u0027memory\u0027"},{"line_number":23,"context_line":"    disk \u003d \u0027disk\u0027"},{"line_number":24,"context_line":"    disk_capacity \u003d \u0027disk_capacity\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_eab24e93","line":23,"in_reply_to":"5aef4532_cf4164ab","updated":"2016-03-09 14:55:01.000000000","message":"True, this change will impact the current available strategies. You must rename this variable in the strategies.\n\ne.g:\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/outlet_temp_control.py#L188","commit_id":"9569640880f8f1f96568d19dd1b09c71c523dea8"},{"author":{"_account_id":12087,"name":"Bruno Grazioli","email":"gaea@zhaw.ch","username":"brunograz"},"change_message_id":"a6c2ddb0b6549539f84f8624de87f9b45196608d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class ResourceType(Enum):"},{"line_number":21,"context_line":"    cpu_cores \u003d \u0027num_cores\u0027"},{"line_number":22,"context_line":"    memory \u003d \u0027memory\u0027"},{"line_number":23,"context_line":"    disk \u003d \u0027disk\u0027"},{"line_number":24,"context_line":"    disk_capacity \u003d \u0027disk_capacity\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b039d0f4","line":23,"in_reply_to":"5aef4532_eab24e93","updated":"2016-03-09 15:01:18.000000000","message":"this seems quite basic change, are you sure that this is the right approach?","commit_id":"9569640880f8f1f96568d19dd1b09c71c523dea8"},{"author":{"_account_id":12087,"name":"Bruno Grazioli","email":"gaea@zhaw.ch","username":"brunograz"},"change_message_id":"5f6659e052c97b74bf15fb548de15c2f3532a6bf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class ResourceType(Enum):"},{"line_number":21,"context_line":"    cpu_cores \u003d \u0027num_cores\u0027"},{"line_number":22,"context_line":"    memory \u003d \u0027memory\u0027"},{"line_number":23,"context_line":"    disk \u003d \u0027disk\u0027"},{"line_number":24,"context_line":"    disk_capacity \u003d \u0027disk_capacity\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_cf4164ab","line":23,"in_reply_to":"7af24918_27a1a694","updated":"2016-03-09 12:12:08.000000000","message":"I\u0027m not sure if this change might break other strategies, is there any other strategy using this parameter?","commit_id":"9569640880f8f1f96568d19dd1b09c71c523dea8"}]}