)]}'
{"watcher/decision_engine/sync.py":[{"author":{"_account_id":20515,"name":"Tomasz Kaczynski","email":"tomasz.kaczynski@intel.com","username":"tkaczynski"},"change_message_id":"d515538df70d62f9e32d9a44b59177ea8532f9fc","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return strategy_mapping"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    # def _sync_audit_templates(self):"},{"line_number":149,"context_line":"    #     stale_audit_templates_map \u003d {}"},{"line_number":150,"context_line":"    #     for goal_id, synced_goal in self.goal_mapping.items():"},{"line_number":151,"context_line":"    #         filters \u003d {\"goal_id\": goal_id}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_32682b87","line":148,"updated":"2016-04-14 12:03:12.000000000","message":"If the code is not used, should be removed. If ever needed again - can be taken from Git history...","commit_id":"6a962c32fa75a2835bbf5e4c2d9b5e439d6a9d85"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"07bae942209a47a4979a221f3f04ddce871deeda","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return strategy_mapping"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    # def _sync_audit_templates(self):"},{"line_number":149,"context_line":"    #     stale_audit_templates_map \u003d {}"},{"line_number":150,"context_line":"    #     for goal_id, synced_goal in self.goal_mapping.items():"},{"line_number":151,"context_line":"    #         filters \u003d {\"goal_id\": goal_id}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_1029a7e6","line":148,"in_reply_to":"5a18252c_32682b87","updated":"2016-04-14 16:07:04.000000000","message":"Done","commit_id":"6a962c32fa75a2835bbf5e4c2d9b5e439d6a9d85"},{"author":{"_account_id":20515,"name":"Tomasz Kaczynski","email":"tomasz.kaczynski@intel.com","username":"tkaczynski"},"change_message_id":"d515538df70d62f9e32d9a44b59177ea8532f9fc","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        stale_strategies \u003d []"},{"line_number":227,"context_line":"        for matching_strategy in matching_strategies:"},{"line_number":228,"context_line":"            if matching_strategy.display_name \u003d\u003d strategy_display_name:"},{"line_number":229,"context_line":"                LOG.info(_LI(\"Goal %s unchanged\"), strategy_name)"},{"line_number":230,"context_line":"            else:"},{"line_number":231,"context_line":"                LOG.info(_LI(\"Goal %s modified\"), strategy_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_952e4941","line":228,"updated":"2016-04-14 12:03:12.000000000","message":"So this is comparing display name, but below the log says that the Goal is changed/unchanged. I\u0027m probably missing something...","commit_id":"6a962c32fa75a2835bbf5e4c2d9b5e439d6a9d85"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"07bae942209a47a4979a221f3f04ddce871deeda","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        stale_strategies \u003d []"},{"line_number":227,"context_line":"        for matching_strategy in matching_strategies:"},{"line_number":228,"context_line":"            if matching_strategy.display_name \u003d\u003d strategy_display_name:"},{"line_number":229,"context_line":"                LOG.info(_LI(\"Goal %s unchanged\"), strategy_name)"},{"line_number":230,"context_line":"            else:"},{"line_number":231,"context_line":"                LOG.info(_LI(\"Goal %s modified\"), strategy_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_30730317","line":228,"in_reply_to":"5a18252c_952e4941","updated":"2016-04-14 16:07:04.000000000","message":"The log messages are off, so I fixed them to mention \"Strategy\" instead of \"Goal\"","commit_id":"6a962c32fa75a2835bbf5e4c2d9b5e439d6a9d85"}],"watcher/tests/api/base.py":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"cd200836b6b631ab8ad9bcd47247a9b85f0b5fff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027,"},{"line_number":56,"context_line":"                              enforce_type\u003dTrue)"},{"line_number":57,"context_line":"        self.app \u003d self._make_app()"},{"line_number":58,"context_line":"        goal_registry.register_goals()"},{"line_number":59,"context_line":"        strategy_registry.register_strategies()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        def reset_pecan():"},{"line_number":62,"context_line":"            pecan.set_config({}, overwrite\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_82bab06c","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":47},"updated":"2016-03-30 12:42:59.000000000","message":"Why register_goals() would not register strategies, to be more efficient. There is no strategy without goal, and register_goals() already scans list of strategies","commit_id":"ea7a685eb8ff7b62ea3ac278bb204279e91362d0"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"7617c53181058b5badc09e1791745ca267400269","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027,"},{"line_number":56,"context_line":"                              enforce_type\u003dTrue)"},{"line_number":57,"context_line":"        self.app \u003d self._make_app()"},{"line_number":58,"context_line":"        goal_registry.register_goals()"},{"line_number":59,"context_line":"        strategy_registry.register_strategies()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        def reset_pecan():"},{"line_number":62,"context_line":"            pecan.set_config({}, overwrite\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_ab6a25b1","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":47},"in_reply_to":"ba0121b8_82bab06c","updated":"2016-03-30 15:15:33.000000000","message":"Ok so I\u0027ll create a register_all() method that will abstract the call to the register_goals() and register_strategies()","commit_id":"ea7a685eb8ff7b62ea3ac278bb204279e91362d0"}]}