)]}'
{"watcher/decision_engine/strategy/selection/default.py":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"93a4b26245dee9fcb47fa361d3fe33ac49759c3c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if self.strategy_name:"},{"line_number":69,"context_line":"                strategy_to_load \u003d self.strategy_name"},{"line_number":70,"context_line":"            else:"},{"line_number":71,"context_line":"                available_strategies \u003d self.strategy_loader.list_available()"},{"line_number":72,"context_line":"                available_strategies_for_goal \u003d list("},{"line_number":73,"context_line":"                    key for key, strat in available_strategies.items()"},{"line_number":74,"context_line":"                    if strat.get_goal_name() \u003d\u003d self.goal_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_69393641","line":71,"range":{"start_line":71,"start_character":16,"end_line":71,"end_character":76},"updated":"2016-04-19 10:25:54.000000000","message":"why not, available_strategies \u003d self.strategy_loader.list_available(goal_name\u003dgoal_name), \nand move the code below inside the method list_available()","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"132ff7bf791b613da2e2d7462d8c4a0f7021b105","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if self.strategy_name:"},{"line_number":69,"context_line":"                strategy_to_load \u003d self.strategy_name"},{"line_number":70,"context_line":"            else:"},{"line_number":71,"context_line":"                available_strategies \u003d self.strategy_loader.list_available()"},{"line_number":72,"context_line":"                available_strategies_for_goal \u003d list("},{"line_number":73,"context_line":"                    key for key, strat in available_strategies.items()"},{"line_number":74,"context_line":"                    if strat.get_goal_name() \u003d\u003d self.goal_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_e569affa","line":71,"range":{"start_line":71,"start_character":16,"end_line":71,"end_character":76},"in_reply_to":"1a122d0e_69393641","updated":"2016-04-20 10:02:45.000000000","message":"The list_available() method is generic and shared by all the loaders so I don\u0027t want to overload/specialise it for now given that for now, I only need this extra data manipulation here.","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"},{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"93a4b26245dee9fcb47fa361d3fe33ac49759c3c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                # 1st one"},{"line_number":83,"context_line":"                strategy_to_load \u003d available_strategies_for_goal[0]"},{"line_number":84,"context_line":"            return self.strategy_loader.load(strategy_to_load, osc\u003dself.osc)"},{"line_number":85,"context_line":"        except (exception.LoadingError, exception.NoAvailableStrategyForGoal):"},{"line_number":86,"context_line":"            raise"},{"line_number":87,"context_line":"        except Exception as exc:"},{"line_number":88,"context_line":"            LOG.exception(exc)"},{"line_number":89,"context_line":"            raise exception.LoadingError("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_0950825c","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":17},"updated":"2016-04-19 10:25:54.000000000","message":"it is really useful ?","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"132ff7bf791b613da2e2d7462d8c4a0f7021b105","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                # 1st one"},{"line_number":83,"context_line":"                strategy_to_load \u003d available_strategies_for_goal[0]"},{"line_number":84,"context_line":"            return self.strategy_loader.load(strategy_to_load, osc\u003dself.osc)"},{"line_number":85,"context_line":"        except (exception.LoadingError, exception.NoAvailableStrategyForGoal):"},{"line_number":86,"context_line":"            raise"},{"line_number":87,"context_line":"        except Exception as exc:"},{"line_number":88,"context_line":"            LOG.exception(exc)"},{"line_number":89,"context_line":"            raise exception.LoadingError("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_250f2789","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":17},"in_reply_to":"1a122d0e_0950825c","updated":"2016-04-20 10:02:45.000000000","message":"Yes, I want to let my NoAvailableStrategyForGoal exception bubble up so I need this block to avoid having it caught by the \"except Exception ...\" one (line 87).\n\nI removed the exception.LoadingError exception from this block because it\u0027s actually useless.","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"}],"watcher/tests/decision_engine/audit/test_default_audit_handler.py":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"93a4b26245dee9fcb47fa361d3fe33ac49759c3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.goal \u003d obj_utils.create_test_goal("},{"line_number":32,"context_line":"            self.context, id\u003d1, name\u003d\"DUMMY\")"},{"line_number":33,"context_line":"        self.audit_template \u003d obj_utils.create_test_audit_template("},{"line_number":34,"context_line":"            self.context)"},{"line_number":35,"context_line":"        self.audit \u003d obj_utils.create_test_audit("},{"line_number":36,"context_line":"            self.context,"},{"line_number":37,"context_line":"            audit_template_id\u003dself.audit_template.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_8945b271","line":34,"updated":"2016-04-19 10:25:54.000000000","message":"add :\n\n, \ngoal \u003d self.goal.name\n\n\nor remove self.goal ?","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"132ff7bf791b613da2e2d7462d8c4a0f7021b105","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.goal \u003d obj_utils.create_test_goal("},{"line_number":32,"context_line":"            self.context, id\u003d1, name\u003d\"DUMMY\")"},{"line_number":33,"context_line":"        self.audit_template \u003d obj_utils.create_test_audit_template("},{"line_number":34,"context_line":"            self.context)"},{"line_number":35,"context_line":"        self.audit \u003d obj_utils.create_test_audit("},{"line_number":36,"context_line":"            self.context,"},{"line_number":37,"context_line":"            audit_template_id\u003dself.audit_template.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_38558af9","line":34,"in_reply_to":"1a122d0e_8945b271","updated":"2016-04-20 10:02:45.000000000","message":"Done","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"}],"watcher/tests/decision_engine/strategy/context/test_strategy_context.py":[{"author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"change_message_id":"93a4b26245dee9fcb47fa361d3fe33ac49759c3c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.goal \u003d obj_utils.create_test_goal("},{"line_number":35,"context_line":"            self.context, id\u003d1, name\u003d\"DUMMY\")"},{"line_number":36,"context_line":"        self.audit_template \u003d obj_utils.create_test_audit_template("},{"line_number":37,"context_line":"            self.context)"},{"line_number":38,"context_line":"        self.audit \u003d obj_utils.create_test_audit("},{"line_number":39,"context_line":"            self.context, audit_template_id\u003dself.audit_template.id)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_6424bdae","line":37,"updated":"2016-04-19 10:25:54.000000000","message":",\ngoal \u003d self.goal.name","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"132ff7bf791b613da2e2d7462d8c4a0f7021b105","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.goal \u003d obj_utils.create_test_goal("},{"line_number":35,"context_line":"            self.context, id\u003d1, name\u003d\"DUMMY\")"},{"line_number":36,"context_line":"        self.audit_template \u003d obj_utils.create_test_audit_template("},{"line_number":37,"context_line":"            self.context)"},{"line_number":38,"context_line":"        self.audit \u003d obj_utils.create_test_audit("},{"line_number":39,"context_line":"            self.context, audit_template_id\u003dself.audit_template.id)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b8b7da38","line":37,"in_reply_to":"1a122d0e_6424bdae","updated":"2016-04-20 10:02:45.000000000","message":"Done","commit_id":"1cfb99fba8178bba91605eba6c69e181fde9860d"}]}