)]}'
{"watcher/cmd/api.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f59ebd71aa2b15b0dd2d208ea8319da714274fd9","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Create the WSGI server and start it"},{"line_number":43,"context_line":"    host, port \u003d CONF.api.host, CONF.api.port"},{"line_number":44,"context_line":"    prefix \u003d \u0027http\u0027"},{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        if CONF.api.enable_ssl_api:"},{"line_number":47,"context_line":"            prefix \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c01e2c6f","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":10},"updated":"2016-05-10 14:54:29.000000000","message":"nit: how about calling it \"protocol\" instead?","commit_id":"b0a6eb71bbf0b5cbf64b059c32567dbee564e8d4"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"4958347a4d1a0da33d2296cd9dbebf8ee8019117","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Create the WSGI server and start it"},{"line_number":43,"context_line":"    host, port \u003d CONF.api.host, CONF.api.port"},{"line_number":44,"context_line":"    prefix \u003d \u0027http\u0027"},{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        if CONF.api.enable_ssl_api:"},{"line_number":47,"context_line":"            prefix \u003d \u0027https\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_035dde78","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":10},"in_reply_to":"dab17558_c01e2c6f","updated":"2016-05-10 15:01:35.000000000","message":"Sure!","commit_id":"b0a6eb71bbf0b5cbf64b059c32567dbee564e8d4"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"f59ebd71aa2b15b0dd2d208ea8319da714274fd9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        if CONF.api.enable_ssl_api:"},{"line_number":47,"context_line":"            prefix \u003d \u0027https\u0027"},{"line_number":48,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":49,"context_line":"        pass"},{"line_number":50,"context_line":"    srv \u003d simple_server.make_server(host, port, app)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_43dc0673","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":30},"updated":"2016-05-10 14:54:29.000000000","message":"why do you need this try...except block?\nIf there is anything wrong with the config, it should already be raised at line 38 with \"prepare_service()\".\n\nI would then simplify this block as followed:\n\nprotocol \u003d \"http\" if not CONF.api.enable_ssl_api else \"https\"","commit_id":"b0a6eb71bbf0b5cbf64b059c32567dbee564e8d4"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"4958347a4d1a0da33d2296cd9dbebf8ee8019117","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        if CONF.api.enable_ssl_api:"},{"line_number":47,"context_line":"            prefix \u003d \u0027https\u0027"},{"line_number":48,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":49,"context_line":"        pass"},{"line_number":50,"context_line":"    srv \u003d simple_server.make_server(host, port, app)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_83726e0f","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":30},"in_reply_to":"dab17558_43dc0673","updated":"2016-05-10 15:01:35.000000000","message":"Well, that\u0027s what I first tried, but it fails two tox tests with \"oslo_config.cfg.NoSuchOptError: no such option in group api: enable_ssl_api\". I assumed that this option was optional. Is that not the case?","commit_id":"b0a6eb71bbf0b5cbf64b059c32567dbee564e8d4"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"d8273b122f54b6320f57d295b1e4ef93defdd804","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    try:"},{"line_number":46,"context_line":"        if CONF.api.enable_ssl_api:"},{"line_number":47,"context_line":"            prefix \u003d \u0027https\u0027"},{"line_number":48,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":49,"context_line":"        pass"},{"line_number":50,"context_line":"    srv \u003d simple_server.make_server(host, port, app)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c695a433","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":30},"in_reply_to":"dab17558_83726e0f","updated":"2016-05-10 15:13:31.000000000","message":"Ok so I guess this is my mistake here. In the bug I created, I forgot to mention that it has a dependency on https://review.openstack.org/#/c/294556/ as the enable_ssl_api option is introduced there. So can you rebase your work on top of this changeset please? Sorry about that.","commit_id":"b0a6eb71bbf0b5cbf64b059c32567dbee564e8d4"}]}