)]}'
{"doc/source/dev/plugin/destination-selector-plugin.rst":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"d0c1bdd863ed58bba642ac38a67789e30bf73d98","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    class ExampleDestinationSelector(base.BaseDestinationSelector):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        def __init__(self):"},{"line_number":38,"context_line":"            super(ExampleDestinationSelector, self).__init__()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        def select_destinations(self, cluster_data_model):"},{"line_number":41,"context_line":"            selected_hosts \u003d {}"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_f0e9c3b8","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":62},"updated":"2016-05-25 10:06:31.000000000","message":"nit: useless, so you can remove it ;)","commit_id":"5bd44374e7586ad3bfd0e9756ac864f6d5c56340"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"f766a9e7cd60f56a2548b151f2e68a6406e16ab8","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    class ExampleDestinationSelector(base.BaseDestinationSelector):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        def __init__(self):"},{"line_number":38,"context_line":"            super(ExampleDestinationSelector, self).__init__()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        def select_destinations(self, cluster_data_model):"},{"line_number":41,"context_line":"            selected_hosts \u003d {}"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bab6814e_e0038740","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":62},"in_reply_to":"bab6814e_f0e9c3b8","updated":"2016-05-26 01:39:30.000000000","message":"Done","commit_id":"5bd44374e7586ad3bfd0e9756ac864f6d5c56340"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"d0c1bdd863ed58bba642ac38a67789e30bf73d98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bab6814e_30cceb60","line":112,"updated":"2016-05-25 10:06:31.000000000","message":"IMHO, you should also add a new section into the strategy-plugins.rst doc to explain that strategies should use the select destination plugin to perform VM placements.\n\nAs this is not part of the main strategy implementation example that is presented there, I guess we should put this extra doc into a new section like \"Tips\".","commit_id":"5bd44374e7586ad3bfd0e9756ac864f6d5c56340"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"f766a9e7cd60f56a2548b151f2e68a6406e16ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bab6814e_c0000337","line":112,"in_reply_to":"bab6814e_30cceb60","updated":"2016-05-26 01:39:30.000000000","message":"Done","commit_id":"5bd44374e7586ad3bfd0e9756ac864f6d5c56340"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"034eb231b77c893bbc69786c48be7ed9b784be68","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \u0027yournewselector\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Tips"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_4660a4cf","line":111,"updated":"2016-05-26 07:18:28.000000000","message":"Can you move this section into the strategy-plugin.rst doc please?\n\nAlso, I guess that \"Select Destination\" would actually be a better subsection name if you put it within the \"Using strategy plugins\" section.","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"82d390ce3b7525ad689446c7d3d72bd0b0d7958f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \u0027yournewselector\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Tips"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9abb7d3a_ca73744c","line":111,"in_reply_to":"bab6814e_4660a4cf","updated":"2016-05-27 14:43:01.000000000","message":"Done","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"034eb231b77c893bbc69786c48be7ed9b784be68","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"},{"line_number":115,"context_line":"be perform. We do not recommend implementing new select algorithm in strategy."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You need implement a new destination selector plugin first if you need a new"},{"line_number":118,"context_line":"algorithm to select destinations for V, then you can implement the select"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_7b1e2171","line":115,"range":{"start_line":115,"start_character":45,"end_line":115,"end_character":77},"updated":"2016-05-26 07:18:28.000000000","message":"I would rephrase it like:\n\n\"[...] custom destination selectors that would not leverage this plugin architecture in order to provide a standard interface to strategy developers.\"","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"034eb231b77c893bbc69786c48be7ed9b784be68","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"},{"line_number":115,"context_line":"be perform. We do not recommend implementing new select algorithm in strategy."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You need implement a new destination selector plugin first if you need a new"},{"line_number":118,"context_line":"algorithm to select destinations for V, then you can implement the select"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_fb75f1ca","line":115,"range":{"start_line":115,"start_character":3,"end_line":115,"end_character":10},"updated":"2016-05-26 07:18:28.000000000","message":"s/perform/placed","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"82d390ce3b7525ad689446c7d3d72bd0b0d7958f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"},{"line_number":115,"context_line":"be perform. We do not recommend implementing new select algorithm in strategy."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You need implement a new destination selector plugin first if you need a new"},{"line_number":118,"context_line":"algorithm to select destinations for V, then you can implement the select"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9abb7d3a_4a9e6457","line":115,"range":{"start_line":115,"start_character":3,"end_line":115,"end_character":10},"in_reply_to":"bab6814e_fb75f1ca","updated":"2016-05-27 14:43:01.000000000","message":"Done","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"034eb231b77c893bbc69786c48be7ed9b784be68","unresolved":false,"context_lines":[{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"},{"line_number":115,"context_line":"be perform. We do not recommend implementing new select algorithm in strategy."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You need implement a new destination selector plugin first if you need a new"},{"line_number":118,"context_line":"algorithm to select destinations for V, then you can implement the select"},{"line_number":119,"context_line":"algorithm in select_destinations of new plugin."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_063cdcc6","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":47},"updated":"2016-05-26 07:18:28.000000000","message":"See the rephrasing from above.","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"82d390ce3b7525ad689446c7d3d72bd0b0d7958f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"All strategies should call the select_destinations to decide where the VM will"},{"line_number":115,"context_line":"be perform. We do not recommend implementing new select algorithm in strategy."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You need implement a new destination selector plugin first if you need a new"},{"line_number":118,"context_line":"algorithm to select destinations for V, then you can implement the select"},{"line_number":119,"context_line":"algorithm in select_destinations of new plugin."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9abb7d3a_6ddd4242","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":47},"in_reply_to":"bab6814e_063cdcc6","updated":"2016-05-27 14:43:01.000000000","message":"Done","commit_id":"a74b4c90bdd11b9011ab8ac1cf48daa3bfe47648"}]}