)]}'
{"watcher/common/exception.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"00c3636170ceb9fda3a94147c11d7131c6412d13","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    msg_fmt \u003d _(\"The metrics resource collector is not defined\")"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"class ClusterStateStale(WatcherException):"},{"line_number":344,"context_line":"    msg_fmt \u003d _(\"The cluster state is stale\")"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_d798be7a","line":343,"range":{"start_line":343,"start_character":6,"end_line":343,"end_character":23},"updated":"2016-11-18 08:00:17.000000000","message":"This new exception you have created has yet to be used within Watcher. The idea would be to raise it in\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/basic_consolidation.py#L388\nand also in the other pre_execute() methods is self.compute_model is stale (which is the case when self.compute_model.stale is True)","commit_id":"905723fafd2edd0d2a8ace16b869f4c8b204bca7"},{"author":{"_account_id":7833,"name":"Anton Khaldin","email":"anton.haldin@gmail.com","username":"akhaldin"},"change_message_id":"10d51a0e0fd4e9ccd866275fe9c8b72582bbfe32","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    msg_fmt \u003d _(\"The metrics resource collector is not defined\")"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"class ClusterStateStale(WatcherException):"},{"line_number":344,"context_line":"    msg_fmt \u003d _(\"The cluster state is stale\")"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_f58af619","line":343,"range":{"start_line":343,"start_character":6,"end_line":343,"end_character":23},"in_reply_to":"7a77a97e_d798be7a","updated":"2016-11-18 19:27:47.000000000","message":"Done","commit_id":"905723fafd2edd0d2a8ace16b869f4c8b204bca7"}],"watcher/decision_engine/strategy/strategies/base.py":[{"author":{"_account_id":15949,"name":"Atul Pandey","email":"atul.pandey@nectechnologies.in","username":"atulpandey"},"change_message_id":"5766a4d9df037ea93ba3483441b035b6c00cd16a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            raise exception.ClusterStateNotDefined()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if self._compute_model.stale:"},{"line_number":189,"context_line":"            raise exception.ClusterStateStale()"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return self._compute_model"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_c528da88","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":47},"updated":"2016-12-07 05:17:27.000000000","message":"Shouldn\u0027t we check the cluster state in start of this function if _compute_model is not none.","commit_id":"abcf627d50b41fb7b0dcfa7e0ea5efae353fc9ec"},{"author":{"_account_id":15949,"name":"Atul Pandey","email":"atul.pandey@nectechnologies.in","username":"atulpandey"},"change_message_id":"c98907a47308bb3f212b9f44f9992ae5c7a1c0c9","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            raise exception.ClusterStateNotDefined()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if self._compute_model.stale:"},{"line_number":189,"context_line":"            raise exception.ClusterStateStale()"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return self._compute_model"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_4bfbfb78","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":47},"in_reply_to":"3a71b18c_088109fb","updated":"2016-12-07 06:53:24.000000000","message":"Yes I guess you are correct.","commit_id":"abcf627d50b41fb7b0dcfa7e0ea5efae353fc9ec"},{"author":{"_account_id":7833,"name":"Anton Khaldin","email":"anton.haldin@gmail.com","username":"akhaldin"},"change_message_id":"3a1209807277ad79cf2559f6dfc4522c085f8324","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            raise exception.ClusterStateNotDefined()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if self._compute_model.stale:"},{"line_number":189,"context_line":"            raise exception.ClusterStateStale()"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return self._compute_model"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_088109fb","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":47},"in_reply_to":"3a71b18c_c528da88","updated":"2016-12-07 06:00:26.000000000","message":"As I can see current logic is : if compute_model is not defined, then we will try to define it by using collector_manager.  We can check stale only if _compute_model is defined. Please correct me if I\u0027m wrong.","commit_id":"abcf627d50b41fb7b0dcfa7e0ea5efae353fc9ec"}]}