)]}'
{"watcher_tempest_plugin/services/infra_optim/v1/json/client.py":[{"author":{"_account_id":15949,"name":"Atul Pandey","email":"atul.pandey@nectechnologies.in","username":"atulpandey"},"change_message_id":"0e737b90799cc722c940bfb007a2c2623751aba4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_serialization import jsonutils"},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":"from watcher_tempest_plugin.services.infra_optim import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_66d91322","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":15},"updated":"2016-11-28 08:34:58.000000000","message":"We can make use of existing functionality inside watcher/common/utils.py which also has similar functionality:\nutils.generate_uuid()","commit_id":"0132e9862f495142fbe17bab39a014250a6d2663"},{"author":{"_account_id":15949,"name":"Atul Pandey","email":"atul.pandey@nectechnologies.in","username":"atulpandey"},"change_message_id":"0e737b90799cc722c940bfb007a2c2623751aba4","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        parameters \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":70,"context_line":"        # This name is unique to avoid the DB unique constraint on names"},{"line_number":71,"context_line":"        unique_name \u003d \u0027Tempest Audit Template %s\u0027 % uuidutils.generate_uuid()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        audit_template \u003d {"},{"line_number":74,"context_line":"            \u0027name\u0027: parameters.get(\u0027name\u0027, unique_name),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_a605eb7a","line":71,"range":{"start_line":71,"start_character":56,"end_line":71,"end_character":57},"updated":"2016-11-28 08:34:58.000000000","message":"same as above.","commit_id":"0132e9862f495142fbe17bab39a014250a6d2663"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"b9edbdd491acf919d9c79948868ab620e2a677fe","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        parameters \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":70,"context_line":"        # This name is unique to avoid the DB unique constraint on names"},{"line_number":71,"context_line":"        unique_name \u003d \u0027Tempest Audit Template %s\u0027 % utils.generate_uuid"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        audit_template \u003d {"},{"line_number":74,"context_line":"            \u0027name\u0027: parameters.get(\u0027name\u0027, unique_name),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_e91ce26b","line":71,"range":{"start_line":71,"start_character":53,"end_line":71,"end_character":71},"updated":"2016-11-29 03:00:35.000000000","message":"lack of ()","commit_id":"f37346b8043f8587a640016b01dfbbaf943b7e6c"},{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"8ef0225ae2b4f9b5b6906617b8962426d1c4cabd","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        parameters \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":70,"context_line":"        # This name is unique to avoid the DB unique constraint on names"},{"line_number":71,"context_line":"        unique_name \u003d \u0027Tempest Audit Template %s\u0027 % utils.generate_uuid"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        audit_template \u003d {"},{"line_number":74,"context_line":"            \u0027name\u0027: parameters.get(\u0027name\u0027, unique_name),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_b480828c","line":71,"range":{"start_line":71,"start_character":53,"end_line":71,"end_character":71},"in_reply_to":"5a74a57a_e91ce26b","updated":"2016-11-29 05:34:14.000000000","message":"This uses existing functionality inside watcher/common/utils.py which has similar functionality with oslo_utils.uuidutils.generate_uuid(), generate_uuid is a parameter of watcher/common/utils, it has already invoked uuidutils.generate_uuid() in that file, I just invoke the parameter. So it doesn\u0027t need ()","commit_id":"f37346b8043f8587a640016b01dfbbaf943b7e6c"}]}