)]}'
{"watcher/decision_engine/model/collector/nova.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"76fb2747625a5acda64a9672fdbaf26bcbf58529","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    capacity \u003d v.flavor[\u0027disk\u0027]"},{"line_number":110,"context_line":"                else:"},{"line_number":111,"context_line":"                    # change the unit from Bytes to Gbytes"},{"line_number":112,"context_line":"                    capacity \u003d capacity/(1024**3)"},{"line_number":113,"context_line":"                disk.set_capacity(instance, capacity)"},{"line_number":114,"context_line":"                disk_capacity.set_capacity(instance, capacity)"},{"line_number":115,"context_line":"                num_cores.set_capacity(instance, v.flavor[\u0027vcpus\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_53b8e5e5","line":112,"range":{"start_line":112,"start_character":41,"end_line":112,"end_character":48},"updated":"2016-12-19 11:13:04.000000000","message":"Can you instead use http://docs.openstack.org/developer/oslo.utils/api/units.html#oslo_utils.units.Gi please?","commit_id":"f5bdc79e2c6f4e4b696bde219d1ed7c54322e43a"},{"author":{"_account_id":22775,"name":"Prudhvi Rao Shedimbi","email":"prudhvi.rao.shedimbi@intel.com","username":"pshedimb"},"change_message_id":"ac8244383e21d0828bcf38cb13cfe9249918bc0f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    capacity \u003d v.flavor[\u0027disk\u0027]"},{"line_number":110,"context_line":"                else:"},{"line_number":111,"context_line":"                    # change the unit from Bytes to Gbytes"},{"line_number":112,"context_line":"                    capacity \u003d capacity/(1024**3)"},{"line_number":113,"context_line":"                disk.set_capacity(instance, capacity)"},{"line_number":114,"context_line":"                disk_capacity.set_capacity(instance, capacity)"},{"line_number":115,"context_line":"                num_cores.set_capacity(instance, v.flavor[\u0027vcpus\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_9c56ee04","line":112,"range":{"start_line":112,"start_character":41,"end_line":112,"end_character":48},"in_reply_to":"1a6eadb0_53b8e5e5","updated":"2016-12-19 22:15:28.000000000","message":"Agree with Vincent. You can use oslo_utils.units.Ki instead.","commit_id":"f5bdc79e2c6f4e4b696bde219d1ed7c54322e43a"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"81c38d2ad41e587414eadf526a041795f615741e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    capacity \u003d v.flavor[\u0027disk\u0027]"},{"line_number":110,"context_line":"                else:"},{"line_number":111,"context_line":"                    # change the unit from Bytes to Gbytes"},{"line_number":112,"context_line":"                    capacity \u003d capacity/(1024**3)"},{"line_number":113,"context_line":"                disk.set_capacity(instance, capacity)"},{"line_number":114,"context_line":"                disk_capacity.set_capacity(instance, capacity)"},{"line_number":115,"context_line":"                num_cores.set_capacity(instance, v.flavor[\u0027vcpus\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_449c67c0","line":112,"range":{"start_line":112,"start_character":41,"end_line":112,"end_character":48},"in_reply_to":"1a6eadb0_53b8e5e5","updated":"2016-12-24 07:18:24.000000000","message":"Done","commit_id":"f5bdc79e2c6f4e4b696bde219d1ed7c54322e43a"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"81c38d2ad41e587414eadf526a041795f615741e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    capacity \u003d v.flavor[\u0027disk\u0027]"},{"line_number":110,"context_line":"                else:"},{"line_number":111,"context_line":"                    # change the unit from Bytes to Gbytes"},{"line_number":112,"context_line":"                    capacity \u003d capacity/(1024**3)"},{"line_number":113,"context_line":"                disk.set_capacity(instance, capacity)"},{"line_number":114,"context_line":"                disk_capacity.set_capacity(instance, capacity)"},{"line_number":115,"context_line":"                num_cores.set_capacity(instance, v.flavor[\u0027vcpus\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_84a64f0e","line":112,"range":{"start_line":112,"start_character":41,"end_line":112,"end_character":48},"in_reply_to":"1a6eadb0_9c56ee04","updated":"2016-12-24 07:18:24.000000000","message":"Done","commit_id":"f5bdc79e2c6f4e4b696bde219d1ed7c54322e43a"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"c9b7ee142726639bca94318fda09e81947f1ef39","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                mem.set_capacity(instance, v.flavor[\u0027ram\u0027])"},{"line_number":105,"context_line":"                # FIXME: update all strategies to use disk_capacity"},{"line_number":106,"context_line":"                # for instances instead of disk"},{"line_number":107,"context_line":"                capacity \u003d self.ceilometer.statistic_aggregation("},{"line_number":108,"context_line":"                    instance.uuid, \u0027disk.capacity\u0027, 700, \u0027avg\u0027)"},{"line_number":109,"context_line":"                if capacity is None:"},{"line_number":110,"context_line":"                    capacity \u003d v.flavor[\u0027disk\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_69911747","line":107,"updated":"2016-12-28 16:12:18.000000000","message":"The use of metrics to build the internal Watcher model is IMHO not the best solution because this means we introduce a dependency between the model and the the datasource i.e. Ceilometer. As we move forward, I reckon we should ease the process allowing people to plug Watcher to their own metrics backend.\nAs part of this reflection, I have pushed https://review.openstack.org/#/c/348891/ and https://review.openstack.org/#/c/414617/ for review.\nAs you can see in https://review.openstack.org/#/c/414617/1/doc/source/dev/plugin/strategy-plugin.rst , your change would not fit the narrative I wrote anymore.","commit_id":"b36178b2aca1bc06c9636af9fcf985c6c0ec6a9f"}],"watcher/tests/decision_engine/cluster/test_nova_cdmc.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"76fb2747625a5acda64a9672fdbaf26bcbf58529","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_nova_cdmc_execute(self, m_nova_helper_cls, m_statistic_disk):"},{"line_number":39,"context_line":"        m_nova_helper \u003d mock.Mock()"},{"line_number":40,"context_line":"        m_nova_helper_cls.return_value \u003d m_nova_helper"},{"line_number":41,"context_line":"        m_statistic_disk.return_value \u003d 1024**3"},{"line_number":42,"context_line":"        fake_compute_node \u003d mock.Mock("},{"line_number":43,"context_line":"            service\u003d{\u0027id\u0027: 123},"},{"line_number":44,"context_line":"            hypervisor_hostname\u003d\u0027test_hostname\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_33aa8986","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":47},"updated":"2016-12-19 11:13:04.000000000","message":"ditto","commit_id":"f5bdc79e2c6f4e4b696bde219d1ed7c54322e43a"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"81c38d2ad41e587414eadf526a041795f615741e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_nova_cdmc_execute(self, m_nova_helper_cls, m_statistic_disk):"},{"line_number":39,"context_line":"        m_nova_helper \u003d mock.Mock()"},{"line_number":40,"context_line":"        m_nova_helper_cls.return_value \u003d m_nova_helper"},{"line_number":41,"context_line":"        m_statistic_disk.return_value \u003d 1024**3"},{"line_number":42,"context_line":"        fake_compute_node \u003d mock.Mock("},{"line_number":43,"context_line":"            service\u003d{\u0027id\u0027: 123},"},{"line_number":44,"context_line":"            hypervisor_hostname\u003d\u0027test_hostname\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_a4a993e1","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":47},"in_reply_to":"1a6eadb0_33aa8986","updated":"2016-12-24 07:18:24.000000000","message":"Done","commit_id":"f5bdc79e2c6f4e4b696bde219d1ed7c54322e43a"}]}