)]}'
{"watcher/decision_engine/strategy/strategies/vm_workload_consolidation.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"fbde8cfa45ced0fa7707966077b22dbef9d94a8f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        if instance.uuid in self.datasource_instance_data_cache.keys():"},{"line_number":255,"context_line":"            return self.datasource_instance_data_cache.get(instance.uuid)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        cpu_util_metric \u003d \u0027cpu_util\u0027"},{"line_number":258,"context_line":"        ram_util_metric \u003d \u0027memory.usage\u0027"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        ram_alloc_metric \u003d \u0027memory\u0027"},{"line_number":261,"context_line":"        disk_alloc_metric \u003d \u0027disk.root.size\u0027"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if self.config.datasource \u003d\u003d \"ceilometer\":"},{"line_number":264,"context_line":"            instance_cpu_util \u003d self.ceilometer.statistic_aggregation("}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_7f867abb","line":261,"range":{"start_line":257,"start_character":0,"end_line":261,"end_character":44},"updated":"2017-03-29 12:55:30.000000000","message":"can you also refactor this to use METRIC_NAMES just like in basic_consolidation, instead of hardcoding it into the function?","commit_id":"7e32b84c93e011395e8e014ef13064289758193e"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"20cd45445e2b7e08bd7fa22ee09c56510380b9b9","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            stop_time \u003d datetime.datetime.utcnow()"},{"line_number":301,"context_line":"            start_time \u003d stop_time - datetime.timedelta("},{"line_number":302,"context_line":"                seconds\u003dint(self.period))"},{"line_number":303,"context_line":"            instance_cpu_util \u003d self.gnocchi.statistic_aggregation("},{"line_number":304,"context_line":"                resource_id\u003dinstance.uuid,"},{"line_number":305,"context_line":"                metric\u003dcpu_util_metric,"},{"line_number":306,"context_line":"                granularity\u003dself.granularity,"},{"line_number":307,"context_line":"                start_time\u003dstart_time,"},{"line_number":308,"context_line":"                stop_time\u003dstop_time,"},{"line_number":309,"context_line":"                aggregation\u003d\u0027mean\u0027"},{"line_number":310,"context_line":"            )"},{"line_number":311,"context_line":"            instance_ram_util \u003d self.gnocchi.statistic_aggregation("},{"line_number":312,"context_line":"                resource_id\u003dinstance.uuid,"},{"line_number":313,"context_line":"                metric\u003dram_util_metric,"},{"line_number":314,"context_line":"                granularity\u003dself.granularity,"},{"line_number":315,"context_line":"                start_time\u003dstart_time,"},{"line_number":316,"context_line":"                stop_time\u003dstop_time,"},{"line_number":317,"context_line":"                aggregation\u003d\u0027mean\u0027"},{"line_number":318,"context_line":"            )"},{"line_number":319,"context_line":"            if not instance_ram_util:"},{"line_number":320,"context_line":"                instance_ram_util \u003d self.gnocchi.statistic_aggregation("},{"line_number":321,"context_line":"                    resource_id\u003dinstance.uuid,"},{"line_number":322,"context_line":"                    metric\u003dram_alloc_metric,"},{"line_number":323,"context_line":"                    granularity\u003dself.granularity,"},{"line_number":324,"context_line":"                    start_time\u003dstart_time,"},{"line_number":325,"context_line":"                    stop_time\u003dstop_time,"},{"line_number":326,"context_line":"                    aggregation\u003d\u0027mean\u0027"},{"line_number":327,"context_line":"                )"},{"line_number":328,"context_line":"            instance_disk_util \u003d self.gnocchi.statistic_aggregation("},{"line_number":329,"context_line":"                resource_id\u003dinstance.uuid,"},{"line_number":330,"context_line":"                metric\u003ddisk_alloc_metric,"},{"line_number":331,"context_line":"                granularity\u003dself.granularity,"},{"line_number":332,"context_line":"                start_time\u003dstart_time,"},{"line_number":333,"context_line":"                stop_time\u003dstop_time,"},{"line_number":334,"context_line":"                aggregation\u003d\u0027mean\u0027"},{"line_number":335,"context_line":"            )"},{"line_number":336,"context_line":"        if instance_cpu_util:"},{"line_number":337,"context_line":"            total_cpu_utilization \u003d ("},{"line_number":338,"context_line":"                instance.vcpus * (instance_cpu_util / 100.0))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_2e0a7720","line":335,"range":{"start_line":303,"start_character":12,"end_line":335,"end_character":13},"updated":"2017-04-07 13:32:47.000000000","message":"It\u0027s ok since release will be soon, but I reckon this code should be refactored.","commit_id":"4642a92e789d06cec06ef7e2bdb0644435569524"}]}
