)]}'
{"watcher/decision_engine/strategy/strategies/vm_workload_consolidation.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"c0582d8d645132f26a27f9fa7a529b5a39d8666b","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            total_cpu_utilization \u003d instance.vcpus"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if not instance_ram_util:"},{"line_number":343,"context_line":"            instance_ram_util \u003d instance.memory"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if not instance_disk_util:"},{"line_number":346,"context_line":"            instance_disk_util \u003d instance.disk"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_869a11b6","line":343,"updated":"2017-04-12 07:27:45.000000000","message":"IMHO we should still have a warning log to say that because we couldn\u0027t retrieve any measurement from the datasource, we set a sensible default value.","commit_id":"8a5b8f77ec1dcd006cda42c74f68672d3716a58f"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"65404bc26d9bf231cad0d52418269e0756c7213b","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            total_cpu_utilization \u003d instance.vcpus"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if not instance_ram_util:"},{"line_number":343,"context_line":"            instance_ram_util \u003d instance.memory"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if not instance_disk_util:"},{"line_number":346,"context_line":"            instance_disk_util \u003d instance.disk"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_8818b6d3","line":343,"in_reply_to":"bff0334d_869a11b6","updated":"2017-04-13 05:43:46.000000000","message":"Done","commit_id":"8a5b8f77ec1dcd006cda42c74f68672d3716a58f"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"c0582d8d645132f26a27f9fa7a529b5a39d8666b","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            instance_ram_util \u003d instance.memory"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if not instance_disk_util:"},{"line_number":346,"context_line":"            instance_disk_util \u003d instance.disk"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        self.datasource_instance_data_cache[instance.uuid] \u003d dict("},{"line_number":349,"context_line":"            cpu\u003dtotal_cpu_utilization, ram\u003dinstance_ram_util,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_268b4568","line":346,"updated":"2017-04-12 07:27:45.000000000","message":"ditto","commit_id":"8a5b8f77ec1dcd006cda42c74f68672d3716a58f"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"65404bc26d9bf231cad0d52418269e0756c7213b","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            instance_ram_util \u003d instance.memory"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if not instance_disk_util:"},{"line_number":346,"context_line":"            instance_disk_util \u003d instance.disk"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        self.datasource_instance_data_cache[instance.uuid] \u003d dict("},{"line_number":349,"context_line":"            cpu\u003dtotal_cpu_utilization, ram\u003dinstance_ram_util,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_680d728f","line":346,"in_reply_to":"bff0334d_268b4568","updated":"2017-04-13 05:43:46.000000000","message":"Done","commit_id":"8a5b8f77ec1dcd006cda42c74f68672d3716a58f"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"c0c5173ff3f40280aad4e1845c2580ff76d16053","unresolved":false,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if not instance_ram_util:"},{"line_number":343,"context_line":"            instance_ram_util \u003d instance.memory"},{"line_number":344,"context_line":"            LOG.warning(\u0027No values returned by %s for memory.usage \u0027,"},{"line_number":345,"context_line":"                        \u0027use instance flavor ram value\u0027, instance.uuid)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        if not instance_disk_util:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_1eefd0b0","line":344,"range":{"start_line":344,"start_character":68,"end_line":344,"end_character":69},"updated":"2017-04-19 12:57:41.000000000","message":"Not sure this comma makes sense here. Since you have only 1 %s, it\u0027s like you are injecting 2 variable in the string formatting where only 1 is expected:\n\n- \u0027use instance flavor ram value\u0027\n- instance.uuid","commit_id":"94322b46b99cc3ac853d9152dc47e86f1c182398"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"b0c851a640c2a2bc27b6ba086086ae35886c47a8","unresolved":false,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if not instance_ram_util:"},{"line_number":343,"context_line":"            instance_ram_util \u003d instance.memory"},{"line_number":344,"context_line":"            LOG.warning(\u0027No values returned by %s for memory.usage \u0027,"},{"line_number":345,"context_line":"                        \u0027use instance flavor ram value\u0027, instance.uuid)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        if not instance_disk_util:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_b1519a11","line":344,"range":{"start_line":344,"start_character":68,"end_line":344,"end_character":69},"in_reply_to":"7ffa3b31_1eefd0b0","updated":"2017-04-24 06:53:30.000000000","message":"Done","commit_id":"94322b46b99cc3ac853d9152dc47e86f1c182398"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"c0c5173ff3f40280aad4e1845c2580ff76d16053","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        if not instance_disk_util:"},{"line_number":348,"context_line":"            instance_disk_util \u003d instance.disk"},{"line_number":349,"context_line":"            LOG.warning(\u0027No values returned by %s for disk.root.size \u0027,"},{"line_number":350,"context_line":"                        \u0027use instance flavor disk value\u0027, instance.uuid)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        self.datasource_instance_data_cache[instance.uuid] \u003d dict("}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_de2e08f9","line":349,"range":{"start_line":349,"start_character":70,"end_line":349,"end_character":71},"updated":"2017-04-19 12:57:41.000000000","message":"ditto","commit_id":"94322b46b99cc3ac853d9152dc47e86f1c182398"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"b0c851a640c2a2bc27b6ba086086ae35886c47a8","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        if not instance_disk_util:"},{"line_number":348,"context_line":"            instance_disk_util \u003d instance.disk"},{"line_number":349,"context_line":"            LOG.warning(\u0027No values returned by %s for disk.root.size \u0027,"},{"line_number":350,"context_line":"                        \u0027use instance flavor disk value\u0027, instance.uuid)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        self.datasource_instance_data_cache[instance.uuid] \u003d dict("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_91569e06","line":349,"range":{"start_line":349,"start_character":70,"end_line":349,"end_character":71},"in_reply_to":"7ffa3b31_de2e08f9","updated":"2017-04-24 06:53:30.000000000","message":"Done","commit_id":"94322b46b99cc3ac853d9152dc47e86f1c182398"}]}