)]}'
{"watcher/decision_engine/sync.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"4ba8df8d7f2eed235a593cf1472c41eda2000e7f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._available_goals_map \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self._available_strategies \u003d None"},{"line_number":53,"context_line":"        self._available_strategies_map \u003d dict()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._available_scoringengines \u003d None"},{"line_number":56,"context_line":"        self._available_scoringengines_map \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_44020271","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":47},"updated":"2017-05-11 14:02:28.000000000","message":"can you please write the unit test that shows you actually fixed the bug? Because it\u0027s difficult to understand why changing None to dict() makes it work","commit_id":"69cd037d6bbb063ae7b5bb2fd3f003bc9655bb4a"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"52610297987cdf6860bf753423b1fc8cc5ff77a5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._available_goals_map \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self._available_strategies \u003d None"},{"line_number":53,"context_line":"        self._available_strategies_map \u003d dict()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._available_scoringengines \u003d None"},{"line_number":56,"context_line":"        self._available_scoringengines_map \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_c63778e3","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":47},"in_reply_to":"1f013ff3_2f775a3d","updated":"2017-05-17 10:07:11.000000000","message":"I agree but the problem is that you also have a self._available_scoringengines_map \u003d None 2 lines below and you didn\u0027t change it to dict() as well so I was wondering why :)","commit_id":"69cd037d6bbb063ae7b5bb2fd3f003bc9655bb4a"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"2f7fdb45cfd3e880e4cbb80ee05b1c19b1b9781b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._available_goals_map \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self._available_strategies \u003d None"},{"line_number":53,"context_line":"        self._available_strategies_map \u003d dict()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._available_scoringengines \u003d None"},{"line_number":56,"context_line":"        self._available_scoringengines_map \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_8b553453","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":47},"in_reply_to":"3f044301_44020271","updated":"2017-05-15 19:18:36.000000000","message":"+1, what is the trace of bug? I think it is better to explicitly check if the variable is None, and throw exceptions if it is unexpected.","commit_id":"69cd037d6bbb063ae7b5bb2fd3f003bc9655bb4a"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"0cc4f798f160daeb59172aea21973c90088d4201","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._available_goals_map \u003d None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self._available_strategies \u003d None"},{"line_number":53,"context_line":"        self._available_strategies_map \u003d dict()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._available_scoringengines \u003d None"},{"line_number":56,"context_line":"        self._available_scoringengines_map \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_2f775a3d","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":47},"in_reply_to":"3f044301_44020271","updated":"2017-05-15 10:29:50.000000000","message":"Obviously, it\u0027s a dict type, we should initialize\n it by dict().","commit_id":"69cd037d6bbb063ae7b5bb2fd3f003bc9655bb4a"}]}
