)]}'
{"watcher/decision_engine/strategy/strategies/vm_workload_consolidation.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"aee789a222027342b3992a13c222e07d54fd3c45","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # Here will makes repeated actions to enable the same compute node,"},{"line_number":238,"context_line":"        # when migrating VMs to the destination node which is disabled."},{"line_number":239,"context_line":"        # Whether should we remove the same actions in the solution???"},{"line_number":240,"context_line":"        destination_node_state_str \u003d self.get_state_str("},{"line_number":241,"context_line":"            destination_node.status)"},{"line_number":242,"context_line":"        if destination_node_state_str \u003d\u003d element.ServiceState.DISABLED.value:"},{"line_number":243,"context_line":"            self.add_action_enable_compute_node(destination_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_570e863b","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":34},"updated":"2017-05-19 07:37:14.000000000","message":"LGTM but can you also rename all misleading variable that mention \"state\" to now mention \"status\" instead?","commit_id":"10408fbc0e57ea3945706f607518ca561ed6b3b5"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"aee789a222027342b3992a13c222e07d54fd3c45","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # Here will makes repeated actions to enable the same compute node,"},{"line_number":238,"context_line":"        # when migrating VMs to the destination node which is disabled."},{"line_number":239,"context_line":"        # Whether should we remove the same actions in the solution???"},{"line_number":240,"context_line":"        destination_node_state_str \u003d self.get_state_str("},{"line_number":241,"context_line":"            destination_node.status)"},{"line_number":242,"context_line":"        if destination_node_state_str \u003d\u003d element.ServiceState.DISABLED.value:"},{"line_number":243,"context_line":"            self.add_action_enable_compute_node(destination_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_f7023a0b","line":240,"range":{"start_line":240,"start_character":42,"end_line":240,"end_character":55},"updated":"2017-05-19 07:37:14.000000000","message":"get_status_str()","commit_id":"10408fbc0e57ea3945706f607518ca561ed6b3b5"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"f1b392e99b7b4b2bdd2abeeb2fdf163a826eadca","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # Here will makes repeated actions to enable the same compute node,"},{"line_number":238,"context_line":"        # when migrating VMs to the destination node which is disabled."},{"line_number":239,"context_line":"        # Whether should we remove the same actions in the solution???"},{"line_number":240,"context_line":"        destination_node_state_str \u003d self.get_state_str("},{"line_number":241,"context_line":"            destination_node.status)"},{"line_number":242,"context_line":"        if destination_node_state_str \u003d\u003d element.ServiceState.DISABLED.value:"},{"line_number":243,"context_line":"            self.add_action_enable_compute_node(destination_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_c80e543a","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":34},"in_reply_to":"ff0f0b1f_570e863b","updated":"2017-05-20 10:41:32.000000000","message":"yes, how about to separate get_status_str into two functions,like get_instance_state and get_node_status.\n\nhow to do the other problem about repeated actions?","commit_id":"10408fbc0e57ea3945706f607518ca561ed6b3b5"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"aee789a222027342b3992a13c222e07d54fd3c45","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        rcu \u003d {}"},{"line_number":411,"context_line":"        counters \u003d {}"},{"line_number":412,"context_line":"        for node in nodes:"},{"line_number":413,"context_line":"            node_state_str \u003d self.get_state_str(node.status)"},{"line_number":414,"context_line":"            if node_state_str \u003d\u003d element.ServiceState.ENABLED.value:"},{"line_number":415,"context_line":"                rhu \u003d self.get_relative_node_utilization(node)"},{"line_number":416,"context_line":"                for k in rhu.keys():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_a909062d","line":413,"range":{"start_line":413,"start_character":12,"end_line":413,"end_character":26},"updated":"2017-05-19 07:37:14.000000000","message":"ditto","commit_id":"10408fbc0e57ea3945706f607518ca561ed6b3b5"}]}