)]}'
{"tox.ini":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"a86b3a20a2c3e544c7542892c2b7421002c38154","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[flake8]"},{"line_number":49,"context_line":"show-source\u003dTrue"},{"line_number":50,"context_line":"ignore\u003d H105,E123,E226,N320,H202"},{"line_number":51,"context_line":"builtins\u003d _"},{"line_number":52,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,*sqlalchemy/alembic/versions/*,demo/,releasenotes"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f1d235d_4bda69e9","line":50,"range":{"start_line":50,"start_character":28,"end_line":50,"end_character":32},"updated":"2017-07-12 01:38:43.000000000","message":"Could you please teach me why you added H202 to ignore?","commit_id":"67b8ce79b39d8929cb94d834841a6baad811b82f"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"a02cba74a4a39a7b6605a351c924a9626b35f319","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[flake8]"},{"line_number":49,"context_line":"show-source\u003dTrue"},{"line_number":50,"context_line":"ignore\u003d H105,E123,E226,N320,H202"},{"line_number":51,"context_line":"builtins\u003d _"},{"line_number":52,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,*sqlalchemy/alembic/versions/*,demo/,releasenotes"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f1d235d_6602ccb6","line":50,"range":{"start_line":50,"start_character":28,"end_line":50,"end_character":32},"in_reply_to":"3f1d235d_4bda69e9","updated":"2017-07-12 04:59:28.000000000","message":"because i am raising Exception here \nhttps://review.openstack.org/#/c/474568/5/watcher/common/nova_helper.py which is very generic causing pep8 failure\nH202 assertRaises Exception too broad","commit_id":"67b8ce79b39d8929cb94d834841a6baad811b82f"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"e92c31f2be37e6f2349b40739aecd08f6178315e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[flake8]"},{"line_number":49,"context_line":"show-source\u003dTrue"},{"line_number":50,"context_line":"ignore\u003d H105,E123,E226,N320,H202"},{"line_number":51,"context_line":"builtins\u003d _"},{"line_number":52,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,*sqlalchemy/alembic/versions/*,demo/,releasenotes"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f1d235d_a1d0cef8","line":50,"range":{"start_line":50,"start_character":28,"end_line":50,"end_character":32},"in_reply_to":"3f1d235d_6602ccb6","updated":"2017-07-12 06:06:02.000000000","message":"Thanks, I understand.","commit_id":"67b8ce79b39d8929cb94d834841a6baad811b82f"}],"watcher/applier/workflow_engine/default.py":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"a98407634c998fe2bb007783c2b798abafcfd5fb","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def do_abort(self, *args, **kwargs):"},{"line_number":144,"context_line":"        LOG.warning(\"Aborting action: %s\", self.name)"},{"line_number":145,"context_line":"        try:"},{"line_number":146,"context_line":"            result \u003d self.action.abort()"},{"line_number":147,"context_line":"            if result \u003d\u003d 1:"},{"line_number":148,"context_line":"                # Aborted the action."},{"line_number":149,"context_line":"                self.engine.notify(self._db_action,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_e9e2932f","line":146,"range":{"start_line":146,"start_character":12,"end_line":146,"end_character":19},"updated":"2017-06-29 13:53:11.000000000","message":"In my understanding, abort will return the followings in this patch set.\n 1: abort succeeded\n -1 abort failed but original action succeeded\n 0: abort failed and original action failed\n\n\nIf do_abort method raises exception, action will be FAILED state. So can we do the followings?\n  True: abort succeeded\n  False: abort failed but original action succeeded\n  raise exception: abort failed and original action failed","commit_id":"a92965fc55b6632b451678eca1a88586e187f69c"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"811f0e36f4f716bcec57960ea798b479fa404c11","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def do_abort(self, *args, **kwargs):"},{"line_number":144,"context_line":"        LOG.warning(\"Aborting action: %s\", self.name)"},{"line_number":145,"context_line":"        try:"},{"line_number":146,"context_line":"            result \u003d self.action.abort()"},{"line_number":147,"context_line":"            if result \u003d\u003d 1:"},{"line_number":148,"context_line":"                # Aborted the action."},{"line_number":149,"context_line":"                self.engine.notify(self._db_action,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_020cf991","line":146,"range":{"start_line":146,"start_character":12,"end_line":146,"end_character":19},"in_reply_to":"3f1d235d_e9e2932f","updated":"2017-07-05 09:07:14.000000000","message":"ok hidekazu, thanks for suggestion i will try to do that","commit_id":"a92965fc55b6632b451678eca1a88586e187f69c"}],"watcher/common/nova_helper.py":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"e92c31f2be37e6f2349b40739aecd08f6178315e","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                self.nova.server_migrations.live_migration_abort("},{"line_number":442,"context_line":"                    server\u003dinstance_id, migration\u003dmigration_id)"},{"line_number":443,"context_line":"            except exception as e:"},{"line_number":444,"context_line":"                # Notë: Does not return from here, as abort request can\u0027t be"},{"line_number":445,"context_line":"                # accepted but migration still going on."},{"line_number":446,"context_line":"                LOG.exception(e)"},{"line_number":447,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_c102aa6f","line":444,"range":{"start_line":444,"start_character":21,"end_line":444,"end_character":22},"updated":"2017-07-12 06:06:02.000000000","message":"I do not know this character.. Please write \u0027e\u0027.","commit_id":"67b8ce79b39d8929cb94d834841a6baad811b82f"}]}