)]}'
{"watcher/applier/actions/change_nova_service_state.py":[{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ChangeNovaServiceState(base.BaseAction):"},{"line_number":30,"context_line":"    \"\"\"change the state of nova-compute service, deployed on a host"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    By using this action, you will be able to update the state of a"},{"line_number":33,"context_line":"    nova-compute service. A disabled nova-compute service can not be selected"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_e20e18e4","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":13},"updated":"2017-06-21 12:38:38.000000000","message":"nit: s/change/Change","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9970394f05d618c9fb871756277c21c5dc2f1941","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ChangeNovaServiceState(base.BaseAction):"},{"line_number":30,"context_line":"    \"\"\"change the state of nova-compute service, deployed on a host"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    By using this action, you will be able to update the state of a"},{"line_number":33,"context_line":"    nova-compute service. A disabled nova-compute service can not be selected"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_36cfd62a","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":13},"in_reply_to":"5f201791_e20e18e4","updated":"2017-07-20 04:53:53.000000000","message":"Done","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    By using this action, you will be able to update the state of a"},{"line_number":33,"context_line":"    nova-compute service. A disabled nova-compute service can not be selected"},{"line_number":34,"context_line":"    by the nova scheduler for future deployment of server. A maintaining"},{"line_number":35,"context_line":"    nova-compute service can not be selected by watcher for future migration"},{"line_number":36,"context_line":"    of servers."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    The action schema is::"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_c2131c0d","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":55},"updated":"2017-06-21 12:38:38.000000000","message":"Watcher","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9970394f05d618c9fb871756277c21c5dc2f1941","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    By using this action, you will be able to update the state of a"},{"line_number":33,"context_line":"    nova-compute service. A disabled nova-compute service can not be selected"},{"line_number":34,"context_line":"    by the nova scheduler for future deployment of server. A maintaining"},{"line_number":35,"context_line":"    nova-compute service can not be selected by watcher for future migration"},{"line_number":36,"context_line":"    of servers."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    The action schema is::"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_b6e2c69f","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":55},"in_reply_to":"5f201791_c2131c0d","updated":"2017-07-20 04:53:53.000000000","message":"Done","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    nova-compute service. A disabled nova-compute service can not be selected"},{"line_number":34,"context_line":"    by the nova scheduler for future deployment of server. A maintaining"},{"line_number":35,"context_line":"    nova-compute service can not be selected by watcher for future migration"},{"line_number":36,"context_line":"    of servers."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    The action schema is::"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_2279b0fb","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":14},"updated":"2017-06-21 12:38:38.000000000","message":"instances","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9970394f05d618c9fb871756277c21c5dc2f1941","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    nova-compute service. A disabled nova-compute service can not be selected"},{"line_number":34,"context_line":"    by the nova scheduler for future deployment of server. A maintaining"},{"line_number":35,"context_line":"    nova-compute service can not be selected by watcher for future migration"},{"line_number":36,"context_line":"    of servers."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    The action schema is::"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_96dfcad5","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":14},"in_reply_to":"5f201791_2279b0fb","updated":"2017-07-20 04:53:53.000000000","message":"Done","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    The `resource_id` references a nova-compute service name (list of available"},{"line_number":47,"context_line":"    nova-compute services is returned by this command: ``nova service-list"},{"line_number":48,"context_line":"    --binary nova-compute``)."},{"line_number":49,"context_line":"    The `current` and \u0027target\u0027 value should be one of `ONLINE`, `OFFLINE`,"},{"line_number":50,"context_line":"    \u0027MAINTAINING\u0027."},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    CURRENT_STATE \u003d \u0027current\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_82c88455","line":50,"range":{"start_line":49,"start_character":55,"end_line":50,"end_character":18},"updated":"2017-06-21 12:38:38.000000000","message":"In the schema down below you also included ENABLED and DISABLED. Why?","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"dd54af61c42a6e3720ce8165ca6e316504977e02","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    The `resource_id` references a nova-compute service name (list of available"},{"line_number":47,"context_line":"    nova-compute services is returned by this command: ``nova service-list"},{"line_number":48,"context_line":"    --binary nova-compute``)."},{"line_number":49,"context_line":"    The `current` and \u0027target\u0027 value should be one of `ONLINE`, `OFFLINE`,"},{"line_number":50,"context_line":"    \u0027MAINTAINING\u0027."},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    CURRENT_STATE \u003d \u0027current\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_532b4dea","line":50,"range":{"start_line":49,"start_character":55,"end_line":50,"end_character":18},"in_reply_to":"5f201791_53b8edc6","updated":"2017-06-22 02:28:08.000000000","message":"sorry, doc error. The `current` and \u0027target\u0027 value should be one of `ENABLED`, `DISABLED`,  \u0027MAINTAINING\u0027.","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"5f90e59137a62e3755153420599298b8e8249e1d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    The `resource_id` references a nova-compute service name (list of available"},{"line_number":47,"context_line":"    nova-compute services is returned by this command: ``nova service-list"},{"line_number":48,"context_line":"    --binary nova-compute``)."},{"line_number":49,"context_line":"    The `current` and \u0027target\u0027 value should be one of `ONLINE`, `OFFLINE`,"},{"line_number":50,"context_line":"    \u0027MAINTAINING\u0027."},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    CURRENT_STATE \u003d \u0027current\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_53b8edc6","line":50,"range":{"start_line":49,"start_character":55,"end_line":50,"end_character":18},"in_reply_to":"5f201791_82c88455","updated":"2017-06-22 02:22:29.000000000","message":"If maintain one node, just set one compute node disabled and \u0027disabled_reanson\u0027 is \u0027watcher_maintaining\u0027.\nUse the existing action \u0027change_nova_servic_state\u0027, and it should still works if enable/disable one node.\nPlease refer to BP:extend-node-status","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":63,"context_line":"                    \"minlength\": 1"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027current\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":67,"context_line":"                    \u0027enum\u0027: [element.ServiceState.ONLINE.value,"},{"line_number":68,"context_line":"                             element.ServiceState.OFFLINE.value,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_42f02c91","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":25},"updated":"2017-06-21 12:38:38.000000000","message":"IMHO, you should either use the CURRENT_STATE variable here or remove it altogether because it is only used in the current_state() property at line 98.\nSame goes for TARGET_STATE","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"5f90e59137a62e3755153420599298b8e8249e1d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":63,"context_line":"                    \"minlength\": 1"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027current\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":67,"context_line":"                    \u0027enum\u0027: [element.ServiceState.ONLINE.value,"},{"line_number":68,"context_line":"                             element.ServiceState.OFFLINE.value,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_330a11d2","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":25},"in_reply_to":"5f201791_42f02c91","updated":"2017-06-22 02:22:29.000000000","message":"The service states is not just two state(enabled/disabled) any more. I add a \u0027maintaining\u0027 state.\nThe target state is useful to execute this action, while the current state is useful to revert this action.","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":67,"context_line":"                    \u0027enum\u0027: [element.ServiceState.ONLINE.value,"},{"line_number":68,"context_line":"                             element.ServiceState.OFFLINE.value,"},{"line_number":69,"context_line":"                             element.ServiceState.ENABLED.value,"},{"line_number":70,"context_line":"                             element.ServiceState.DISABLED.value,"},{"line_number":71,"context_line":"                             element.ServiceState.MAINTAINING.value]"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027target\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_42c26c35","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":65},"updated":"2017-06-21 12:38:38.000000000","message":"See previous comment","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_description(self):"},{"line_number":133,"context_line":"        \"\"\"Description of the action\"\"\""},{"line_number":134,"context_line":"        return (\"change the state of nova-compute service.\""},{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for future deployment of new server. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_221410a0","line":134,"range":{"start_line":134,"start_character":17,"end_line":134,"end_character":23},"updated":"2017-06-21 12:38:38.000000000","message":"s/change/Change","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9970394f05d618c9fb871756277c21c5dc2f1941","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_description(self):"},{"line_number":133,"context_line":"        \"\"\"Description of the action\"\"\""},{"line_number":134,"context_line":"        return (\"change the state of nova-compute service.\""},{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for future deployment of new server. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_56f37274","line":134,"range":{"start_line":134,"start_character":17,"end_line":134,"end_character":23},"in_reply_to":"5f201791_221410a0","updated":"2017-07-20 04:53:53.000000000","message":"Done","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for future deployment of new server. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by watcher for future migration of servers.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_c212fcb1","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":27},"updated":"2017-06-21 12:38:38.000000000","message":"Watcher","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":18971,"name":"Vincent Françoise","email":"Vincent.FRANCOISE@b-com.com","username":"v-francoise"},"change_message_id":"e20e1e4823d6bf6cc30743f7e48ab55edf9d2ceb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for future deployment of new server. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by watcher for future migration of servers.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_421eecba","line":138,"range":{"start_line":138,"start_character":52,"end_line":138,"end_character":59},"updated":"2017-06-21 12:38:38.000000000","message":"instances","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9970394f05d618c9fb871756277c21c5dc2f1941","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for future deployment of new server. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by watcher for future migration of servers.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_d6fe6237","line":138,"range":{"start_line":138,"start_character":52,"end_line":138,"end_character":59},"in_reply_to":"5f201791_421eecba","updated":"2017-07-20 04:53:53.000000000","message":"Done","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9970394f05d618c9fb871756277c21c5dc2f1941","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for future deployment of new server. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by watcher for future migration of servers.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_f6015e3b","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":27},"in_reply_to":"5f201791_c212fcb1","updated":"2017-07-20 04:53:53.000000000","message":"Done","commit_id":"d47966b595936021d1fa237853aa0c951bcf45da"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"e3877dd9eccad14bbfbba1a5f59c95abb606ab90","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\"Description of the action\"\"\""},{"line_number":134,"context_line":"        return (\"Change the state of nova-compute service.\""},{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for furture deployment of new instances. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by Watcher for furture migration of instances.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_b0ca2a4b","line":136,"range":{"start_line":136,"start_character":33,"end_line":136,"end_character":40},"updated":"2017-07-26 20:59:20.000000000","message":"furture-\u003efuture","commit_id":"913a9114f686cfb1597a07d8de5078d300cd6c4e"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"b1739e2a43c8c286520fd1d3f4f604bf8ecff0af","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\"Description of the action\"\"\""},{"line_number":134,"context_line":"        return (\"Change the state of nova-compute service.\""},{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for furture deployment of new instances. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by Watcher for furture migration of instances.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_b77459ff","line":136,"range":{"start_line":136,"start_character":33,"end_line":136,"end_character":40},"in_reply_to":"ff346bd7_b0ca2a4b","updated":"2017-07-27 02:08:31.000000000","message":"ok","commit_id":"913a9114f686cfb1597a07d8de5078d300cd6c4e"},{"author":{"_account_id":25026,"name":"Bin Zhou","email":"lakerzhou@gmail.com","username":"lakerzhou"},"change_message_id":"e3877dd9eccad14bbfbba1a5f59c95abb606ab90","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for furture deployment of new instances. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by Watcher for furture migration of instances.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_133fc087","line":138,"range":{"start_line":138,"start_character":32,"end_line":138,"end_character":39},"updated":"2017-07-26 20:59:20.000000000","message":"furture-\u003efuture\nQ: from the nova BP, it looks to me there is no real host state of maintenance. Essentially, maintenance state is the same as disable state, e.g. nova compute service is not available on this host. If above understanding is true, watcher should only schedule workload on compute nodes with \"enabled\" state. \"disabled\" and \"maintaining\" should be treated the same. Can you please clarify the design intent a little bit. Thanks.\nhttps://blueprints.launchpad.net/nova/+spec/host-maintenance-mode","commit_id":"913a9114f686cfb1597a07d8de5078d300cd6c4e"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"b1739e2a43c8c286520fd1d3f4f604bf8ecff0af","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                \"A disabled nova-compute service can not be selected \""},{"line_number":136,"context_line":"                \"by the nova for furture deployment of new instances. \""},{"line_number":137,"context_line":"                \"A maintaining nova-compute service can not be selected \""},{"line_number":138,"context_line":"                \"by Watcher for furture migration of instances.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_3a20509b","line":138,"range":{"start_line":138,"start_character":32,"end_line":138,"end_character":39},"in_reply_to":"ff346bd7_133fc087","updated":"2017-07-27 02:08:31.000000000","message":"Not all the same. The \u0027maintaining\u0027  node is in \u0027disabled\u0027 status, but with a disabled_reason \u0027maintaining\u0027, which differentiates them.","commit_id":"913a9114f686cfb1597a07d8de5078d300cd6c4e"}],"watcher/applier/actions/maintain_nova_compute_node.py":[{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"7071865e86fdbdfd4d8b4322d3e5a5e9f5618127","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        compute_node \u003d nova.get_compute_node_by_hostname(node)"},{"line_number":74,"context_line":"        return compute_node.running_vms"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def maintaince_nova_compute(self, node):"},{"line_number":77,"context_line":"        nova \u003d nova_helper.NovaHelper(osc\u003dself.osc)"},{"line_number":78,"context_line":"        nova.disable_service_nova_compute(self.host, \u0027watcher_maintaining\u0027)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_a2487e2c","line":76,"updated":"2017-06-16 09:45:36.000000000","message":"s/maintaince/maintenance","commit_id":"6aca4a2203b10581604bc04c94fd347269147eec"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"bac0edb63b349b7e8c626708d242b9564746fb33","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        compute_node \u003d nova.get_compute_node_by_hostname(node)"},{"line_number":74,"context_line":"        return compute_node.running_vms"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def maintaince_nova_compute(self, node):"},{"line_number":77,"context_line":"        nova \u003d nova_helper.NovaHelper(osc\u003dself.osc)"},{"line_number":78,"context_line":"        nova.disable_service_nova_compute(self.host, \u0027watcher_maintaining\u0027)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_8c859709","line":76,"in_reply_to":"7f231b9d_a2487e2c","updated":"2017-06-19 03:04:05.000000000","message":"yes,maintain","commit_id":"6aca4a2203b10581604bc04c94fd347269147eec"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"7071865e86fdbdfd4d8b4322d3e5a5e9f5618127","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def maintaince_nova_compute(self, node):"},{"line_number":77,"context_line":"        nova \u003d nova_helper.NovaHelper(osc\u003dself.osc)"},{"line_number":78,"context_line":"        nova.disable_service_nova_compute(self.host, \u0027watcher_maintaining\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def execute(self):"},{"line_number":81,"context_line":"        self.maintain_nova_compute(self.host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_22346e92","line":78,"updated":"2017-06-16 09:45:36.000000000","message":"IMHO, a to define a seperate action is necessary??can it be worked with change_nova_servic_state??","commit_id":"6aca4a2203b10581604bc04c94fd347269147eec"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"bac0edb63b349b7e8c626708d242b9564746fb33","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def maintaince_nova_compute(self, node):"},{"line_number":77,"context_line":"        nova \u003d nova_helper.NovaHelper(osc\u003dself.osc)"},{"line_number":78,"context_line":"        nova.disable_service_nova_compute(self.host, \u0027watcher_maintaining\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def execute(self):"},{"line_number":81,"context_line":"        self.maintain_nova_compute(self.host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_ace8537b","line":78,"in_reply_to":"7f231b9d_22346e92","updated":"2017-06-19 03:04:05.000000000","message":"I previously considered that they should have diffrent weight,\u0027change_nova_servic_state\u0027 executing before migrate, while maintain_nova_compute after migrate.\nYou thought is better. If use change_nova_servic_state, the action should known current and latter service_state which is passed by strategys as paramters. That will change much.\nOk, I will try to refactor \u0027change_nova_servic_state\u0027 action.","commit_id":"6aca4a2203b10581604bc04c94fd347269147eec"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"7071865e86fdbdfd4d8b4322d3e5a5e9f5618127","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        nova.disable_service_nova_compute(self.host, \u0027watcher_maintaining\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def execute(self):"},{"line_number":81,"context_line":"        self.maintain_nova_compute(self.host)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def revert(self):"},{"line_number":84,"context_line":"        nova \u003d nova_helper.NovaHelper(osc\u003dself.osc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_2266aec2","line":81,"updated":"2017-06-16 09:45:36.000000000","message":"check the called function name","commit_id":"6aca4a2203b10581604bc04c94fd347269147eec"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"bac0edb63b349b7e8c626708d242b9564746fb33","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        nova.disable_service_nova_compute(self.host, \u0027watcher_maintaining\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def execute(self):"},{"line_number":81,"context_line":"        self.maintain_nova_compute(self.host)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def revert(self):"},{"line_number":84,"context_line":"        nova \u003d nova_helper.NovaHelper(osc\u003dself.osc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_ecf2cb6f","line":81,"in_reply_to":"7f231b9d_2266aec2","updated":"2017-06-19 03:04:05.000000000","message":"ok","commit_id":"6aca4a2203b10581604bc04c94fd347269147eec"}]}