)]}'
{"watcher/decision_engine/model/collector/manager.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"ffdf5fc4cb87f70b56a48dabecfeb5928768a2f1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    try:"},{"line_number":43,"context_line":"                        cinder_helper.get_storage_node_list()"},{"line_number":44,"context_line":"                    except Exception:"},{"line_number":45,"context_line":"                        LOG.info(\"storage data model not loaded\")"},{"line_number":46,"context_line":"                        continue"},{"line_number":47,"context_line":"                collector \u003d self.collector_loader.load(collector_name)"},{"line_number":48,"context_line":"                collectors[collector_name] \u003d collector"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_ee5a3af1","line":45,"range":{"start_line":45,"start_character":28,"end_line":45,"end_character":32},"updated":"2017-08-02 05:41:19.000000000","message":"Warning level is better.","commit_id":"d73731ee8999d9ee00d8403a633fc7faec2abea3"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"556b432fe96aee94bd613c70ce2e4b2c3afb9b59","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    try:"},{"line_number":43,"context_line":"                        cinder_helper.get_storage_node_list()"},{"line_number":44,"context_line":"                    except Exception:"},{"line_number":45,"context_line":"                        LOG.info(\"storage data model not loaded\")"},{"line_number":46,"context_line":"                        continue"},{"line_number":47,"context_line":"                collector \u003d self.collector_loader.load(collector_name)"},{"line_number":48,"context_line":"                collectors[collector_name] \u003d collector"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_ae04324b","line":45,"range":{"start_line":45,"start_character":28,"end_line":45,"end_character":32},"in_reply_to":"df3967d1_ee5a3af1","updated":"2017-08-02 06:08:54.000000000","message":"Done","commit_id":"d73731ee8999d9ee00d8403a633fc7faec2abea3"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"20d32a623d3a06e98906e44ea2d1fc01800a67ef","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            for collector_name in available_collectors:"},{"line_number":41,"context_line":"                if collector_name \u003d\u003d \u0027storage\u0027:"},{"line_number":42,"context_line":"                    try:"},{"line_number":43,"context_line":"                        cinder_helper.get_storage_node_list()"},{"line_number":44,"context_line":"                    except Exception:"},{"line_number":45,"context_line":"                        LOG.warning(\"storage data model not loaded\")"},{"line_number":46,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_71c62f4b","line":43,"range":{"start_line":43,"start_character":24,"end_line":43,"end_character":61},"updated":"2017-08-02 06:42:28.000000000","message":"cinder_help is a module and get_storage_list() is method of class CinderHelper(). This method returns a list and I don\u0027t see the usage of this list.","commit_id":"6eeef53a0d21dea813d2b4bdf21dc5acd186fb26"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"c54b3324f07869a2db8a811c09c046248b5a28c2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            collectors \u003d utils.Struct()"},{"line_number":39,"context_line":"            available_collectors \u003d self.collector_loader.list_available()"},{"line_number":40,"context_line":"            for collector_name in available_collectors:"},{"line_number":41,"context_line":"                if collector_name \u003d\u003d \u0027storage\u0027:"},{"line_number":42,"context_line":"                    try:"},{"line_number":43,"context_line":"                        cinder_helper.CinderHelper().get_storage_node_list()"},{"line_number":44,"context_line":"                    except Exception:"},{"line_number":45,"context_line":"                        LOG.warning(\"storage data model not loaded\")"},{"line_number":46,"context_line":"                        continue"},{"line_number":47,"context_line":"                collector \u003d self.collector_loader.load(collector_name)"},{"line_number":48,"context_line":"                collectors[collector_name] \u003d collector"},{"line_number":49,"context_line":"            self._collectors \u003d collectors"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_4473674e","line":46,"range":{"start_line":41,"start_character":16,"end_line":46,"end_character":32},"updated":"2017-08-02 07:20:47.000000000","message":"After taking a look at watcher code and bug, I don\u0027t think this actually fix this bug. As I understand, you call get_storage_node_list() because it will raise an Exception when calling self.osc.cinder() (CinderClient) in init method. And the next action is \u0027continue`, ignore to load collector. Is this right? Please correct me if I\u0027m wrong.\n\nIMO, I think it\u0027s redundant and not actually fix bug. We need another solution, like what Alexander Chadlin mentioned in bug description: \"Maybe we need to add option to config file where all plugins (compute, storage) are listed and can be deleted.\"","commit_id":"17411078c040b751e5e39e00952a36f4e2a0015a"}]}