)]}'
{"watcher/decision_engine/goal/efficacy/specs.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"be62c0bb216de366e3b88a8a9538c8b4e8c989b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        return ()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_global_efficacy_indicator(self, indicators_map):"},{"line_number":29,"context_line":"        \"\"\"Global efficacy"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        It returns list of global efficacy indicator for"},{"line_number":32,"context_line":"        each resource optimized by the strategy."},{"line_number":33,"context_line":"        \"\"\""},{"line_number":34,"context_line":"        return None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_3686b6bc","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":11},"updated":"2017-11-09 02:08:56.000000000","message":"I think the description should be in the class ServerConsolidation(line 46)","commit_id":"f967ddc35febd4f95daea44abe06e63cc12774fb"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"eb44e74ad0d5971ce3b031451f1c9fdd280999f5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        return ()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_global_efficacy_indicator(self, indicators_map):"},{"line_number":29,"context_line":"        \"\"\"Global efficacy"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        It returns list of global efficacy indicator for"},{"line_number":32,"context_line":"        each resource optimized by the strategy."},{"line_number":33,"context_line":"        \"\"\""},{"line_number":34,"context_line":"        return None"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_19a9addc","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":11},"in_reply_to":"3f4b6375_3686b6bc","updated":"2017-11-09 02:32:14.000000000","message":"I think its better to move it in base class.\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/goal/efficacy/base.py#L53\n\nI will modify description in base class","commit_id":"f967ddc35febd4f95daea44abe06e63cc12774fb"}]}