)]}'
{"watcher/decision_engine/strategy/strategies/vm_workload_consolidation.py":[{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"544312730114cc44ff246645164cadf9dceaa17e","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            # Watcher currently only supports live VM migration and block live"},{"line_number":250,"context_line":"            # VM migration which both requires migrated VM to be active."},{"line_number":251,"context_line":"            # When supported, the cold migration may be used as a fallback"},{"line_number":252,"context_line":"            # migration mechanism to move non active VMs."},{"line_number":253,"context_line":"            LOG.error("},{"line_number":254,"context_line":"                \u0027Cannot live migrate: instance_uuid\u003d%(instance_uuid)s, \u0027"},{"line_number":255,"context_line":"                \u0027state\u003d%(instance_state)s.\u0027 % dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_ef84dcb2","line":252,"updated":"2017-11-08 01:38:53.000000000","message":"just one query, i think this code is written while watcher was not supporting cold migration, but considering it can support now, should there be any status check here for migration?? if we see other strategies add_migration method then there is no conditional check.","commit_id":"ce9470ce01fb5d4d8a67ba0c99dfcd1373f012c7"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"f114a05d5082095e72a9c7a1c2ef21b328339cc7","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            # Watcher currently only supports live VM migration and block live"},{"line_number":250,"context_line":"            # VM migration which both requires migrated VM to be active."},{"line_number":251,"context_line":"            # When supported, the cold migration may be used as a fallback"},{"line_number":252,"context_line":"            # migration mechanism to move non active VMs."},{"line_number":253,"context_line":"            LOG.error("},{"line_number":254,"context_line":"                \u0027Cannot live migrate: instance_uuid\u003d%(instance_uuid)s, \u0027"},{"line_number":255,"context_line":"                \u0027state\u003d%(instance_state)s.\u0027 % dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_b27f5eaa","line":252,"in_reply_to":"3f4b6375_ef84dcb2","updated":"2017-11-09 12:04:57.000000000","message":"I suppose, there should be single patch, that will modify this part of strategy","commit_id":"ce9470ce01fb5d4d8a67ba0c99dfcd1373f012c7"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"5760cdf9b50189b809d868cd103e8ab44da11d2c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            # Watcher currently only supports live VM migration and block live"},{"line_number":250,"context_line":"            # VM migration which both requires migrated VM to be active."},{"line_number":251,"context_line":"            # When supported, the cold migration may be used as a fallback"},{"line_number":252,"context_line":"            # migration mechanism to move non active VMs."},{"line_number":253,"context_line":"            LOG.error("},{"line_number":254,"context_line":"                \u0027Cannot live migrate: instance_uuid\u003d%(instance_uuid)s, \u0027"},{"line_number":255,"context_line":"                \u0027state\u003d%(instance_state)s.\u0027 % dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_187ac723","line":252,"in_reply_to":"3f4b6375_ef84dcb2","updated":"2017-11-10 02:29:35.000000000","message":"refer to line 260, this strategy is just for live migration.","commit_id":"ce9470ce01fb5d4d8a67ba0c99dfcd1373f012c7"}]}