)]}'
{"id":"openstack%2Fwatcher~518480","triplet_id":"openstack%2Fwatcher~master~I174c8a0c653e322bbf951d72445b1a43251baa7e","project":"openstack/watcher","branch":"master","topic":"package_install","hashtags":[],"change_id":"I174c8a0c653e322bbf951d72445b1a43251baa7e","subject":"Do not use “-y” for package install","status":"MERGED","created":"2017-11-08 07:40:57.000000000","updated":"2017-11-09 02:03:01.000000000","submitted":"2017-11-09 02:03:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"518480-1510192981768-1be58a97","meta_rev_id":"ed886a04f82c5d548652d9fb99b799a619a131fe","_number":518480,"virtual_id_number":518480,"owner":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":2,"date":"2017-11-09 02:03:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"all":[{"value":2,"date":"2017-11-09 00:18:56.000000000","_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2017-11-08 09:16:07.000000000","_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-11-09 01:52:45.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-08 09:16:07.000000000","updated_by":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"reviewer":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"state":"REVIEWER"},{"updated":"2017-11-09 00:18:56.000000000","updated_by":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"reviewer":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"state":"REVIEWER"},{"updated":"2017-11-09 01:52:45.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2017-11-09 02:03:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e9926e410e594685b5ef03886d32059f3ac0e7e3","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-11-08 07:40:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08fb233ef41d21864741d85abc14cef995619af1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-08 07:54:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/80/518480/1/check/openstack-tox-pep8/d3bf7d2/ : SUCCESS in 5m 20s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/518480/1/check/build-openstack-sphinx-docs/764b979/html/ : SUCCESS in 12m 06s","accounts_in_message":[],"_revision_number":1},{"id":"ef4c35a5a1418387ea364fbcd86d589e643d5e6d","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-11-08 09:13:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e28e2ae153bea8d6f06285d91fb03e56a0ab912f","author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"date":"2017-11-08 09:16:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"77e2fa4da447d16ea6a43b76750f47c9989c3725","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-08 10:08:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/80/518480/2/check/openstack-tox-pep8/057efb1/ : SUCCESS in 4m 53s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/518480/2/check/build-openstack-sphinx-docs/d6f9932/html/ : SUCCESS in 7m 17s","accounts_in_message":[],"_revision_number":2},{"id":"6702bb97853988dc4bbc212c7798deb8448860b5","author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"date":"2017-11-09 00:18:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"741b4cbf30e5080a265816b36231254f0eebcd81","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2017-11-09 01:52:45.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7fb5068eec4322ae7876abf7ef7ee4eb728df404","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-09 01:52:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a0b431263c5bd4fc6b4439f6780add8939431f8d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-09 02:03:01.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"320561b4cd8fd1c092af3b4ca0438571338fd127","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-09 02:03:01.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/80/518480/2/gate/openstack-tox-pep8/816d6ad/ : SUCCESS in 7m 29s\n- build-openstack-sphinx-docs http://logs.openstack.org/80/518480/2/gate/build-openstack-sphinx-docs/f571a72/html/ : SUCCESS in 5m 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1b4c5dfc8bdd00ba32b8a604ff52f0bbe4efdeb1","revisions":{"b3720d6d5f0d7b05b95aeb5352a18fc5d7f37761":{"kind":"REWORK","_number":1,"created":"2017-11-08 07:40:57.000000000","uploader":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"ref":"refs/changes/80/518480/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/80/518480/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/80/518480/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/80/518480/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/80/518480/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/80/518480/1"}}},"commit":{"parents":[{"commit":"6c29df11ca88c833ecc1ee2e707b700a34032d83","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6c29df11ca88c833ecc1ee2e707b700a34032d83"}]}],"author":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-08 07:40:54.000000000","tz":420},"committer":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-08 07:40:54.000000000","tz":420},"subject":"Do not use “-y” for package install","message":"Do not use “-y” for package install\n\nAccording to \"code conventions\" [1], do not use \"-y\" option.\nInstead, use apt-get install package, yum install package,\nor zypper install package.\n\n[1] https://docs.openstack.org/doc-contrib-guide/writing-style/\ncode-conventions.html\n\nChange-Id: I174c8a0c653e322bbf951d72445b1a43251baa7e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b3720d6d5f0d7b05b95aeb5352a18fc5d7f37761"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b3720d6d5f0d7b05b95aeb5352a18fc5d7f37761"}]},"branch":"refs/heads/master"},"1b4c5dfc8bdd00ba32b8a604ff52f0bbe4efdeb1":{"kind":"REWORK","_number":2,"created":"2017-11-08 09:13:33.000000000","uploader":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"ref":"refs/changes/80/518480/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/80/518480/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/80/518480/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/80/518480/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/80/518480/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/80/518480/2"}}},"commit":{"parents":[{"commit":"4179cfd036cee921bf97bbd3f51f518b7934d114","subject":"Merge \"check task_state in the live_migrate_instance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4179cfd036cee921bf97bbd3f51f518b7934d114"}]}],"author":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-08 07:40:54.000000000","tz":420},"committer":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-08 09:13:30.000000000","tz":420},"subject":"Do not use “-y” for package install","message":"Do not use “-y” for package install\n\nAccording to \"code conventions\" [1], do not use \"-y\" option.\nInstead, use apt-get install package, yum install package,\nor zypper install package.\n\n[1] https://docs.openstack.org/doc-contrib-guide/writing-style/\ncode-conventions.html\n\nChange-Id: I174c8a0c653e322bbf951d72445b1a43251baa7e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/1b4c5dfc8bdd00ba32b8a604ff52f0bbe4efdeb1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/1b4c5dfc8bdd00ba32b8a604ff52f0bbe4efdeb1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}