)]}'
{"watcher/common/nova_helper.py":[{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"04e6715979f9baa94a7f651fe4700de08ec77820","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            try:"},{"line_number":454,"context_line":"                instance.live_migrate(host\u003ddest_hostname)"},{"line_number":455,"context_line":"            except Exception as e:"},{"line_number":456,"context_line":"                LOG.exception(e)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            instance \u003d self.nova.servers.get(instance_id)"},{"line_number":459,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_5d039b0e","line":456,"range":{"start_line":456,"start_character":16,"end_line":456,"end_character":32},"updated":"2017-11-09 12:12:33.000000000","message":"shouldn\u0027t we raise an exception here? we can get into endless while block starting at 480 line.","commit_id":"7f4b862e277f10ca2c5807eac2dbccf9543896cb"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"ec92937ee35234b4a1f5c2a8125a4b4e3db8145f","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            try:"},{"line_number":454,"context_line":"                instance.live_migrate(host\u003ddest_hostname)"},{"line_number":455,"context_line":"            except Exception as e:"},{"line_number":456,"context_line":"                LOG.exception(e)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"            instance \u003d self.nova.servers.get(instance_id)"},{"line_number":459,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_983237a7","line":456,"range":{"start_line":456,"start_character":16,"end_line":456,"end_character":32},"in_reply_to":"1f485f77_5d039b0e","updated":"2017-11-10 02:15:40.000000000","message":"I don\u0027t think we need exception catch here, we have exception catch https://github.com/openstack/watcher/blob/master/watcher/applier/actions/migration.py#L111","commit_id":"7f4b862e277f10ca2c5807eac2dbccf9543896cb"}]}