)]}'
{"watcher/applier/actions/volume_migration.py":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"ec410f3d57eea3c9004b0cb588480413467c267b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Migrates a volume to destination node or type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    By using this action, you will be able to migrate cinder volume."},{"line_number":38,"context_line":"    Migration type \u0027swap\u0027 can only be used for migrating attached volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The action schema is::"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_b1d251ff","line":38,"updated":"2017-11-27 05:22:04.000000000","message":"Could you explain migration type \u0027migrate\u0027 and \u0027retype\u0027 instead of \u0027swap\u0027?","commit_id":"9cd918e75504b18a4030afe6726d6788ae3f9a34"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"ff4a26bf6880e9d7c5ae105a2c10d8b1a1668a4f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Migrates a volume to destination node or type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    By using this action, you will be able to migrate cinder volume."},{"line_number":38,"context_line":"    Migration type \u0027swap\u0027 can only be used for migrating attached volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The action schema is::"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_da688e88","line":38,"in_reply_to":"df87a7cf_d366542a","updated":"2017-12-05 23:21:29.000000000","message":"Please add \u0027migrate\u0027 and \u0027retype\u0027 explanation as the following.\n\nMigration type \u0027migrate\u0027 can be used for migrating detached volume to the pool of same volume type.\nMigration type \u0027retype\u0027 can be used for changing volume type of detached volume.","commit_id":"9cd918e75504b18a4030afe6726d6788ae3f9a34"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"9dbbc580600dda7ff586333330b8dd737ab64b9c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Migrates a volume to destination node or type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    By using this action, you will be able to migrate cinder volume."},{"line_number":38,"context_line":"    Migration type \u0027swap\u0027 can only be used for migrating attached volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The action schema is::"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_d366542a","line":38,"in_reply_to":"ff82abbf_6ec9ed23","updated":"2017-12-05 08:22:44.000000000","message":"Hi, pls see the update in the commit message.","commit_id":"9cd918e75504b18a4030afe6726d6788ae3f9a34"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"4c7ca57d6da0e1434b56216ce1f8b6a8de5bd8cf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Migrates a volume to destination node or type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    By using this action, you will be able to migrate cinder volume."},{"line_number":38,"context_line":"    Migration type \u0027swap\u0027 can only be used for migrating attached volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The action schema is::"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_cc94d739","line":38,"in_reply_to":"ff82abbf_b1d251ff","updated":"2017-11-29 09:49:40.000000000","message":"hi, \u0027migrate\u0027and \u0027retype\u0027 are used in this strategy: https://review.openstack.org/#/c/516500/\n\u0027cold\u0027 action is suggested here to remove: https://review.openstack.org/#/c/516500/4/watcher/applier/actions/volume_migration.py\nBut if it\u0027s necessary to discuss more, please feel free to let me know.","commit_id":"9cd918e75504b18a4030afe6726d6788ae3f9a34"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"388fe110ed9bd27e3bc0abbf52706f28cd155555","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Migrates a volume to destination node or type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    By using this action, you will be able to migrate cinder volume."},{"line_number":38,"context_line":"    Migration type \u0027swap\u0027 can only be used for migrating attached volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The action schema is::"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_6ec9ed23","line":38,"in_reply_to":"ff82abbf_cc94d739","updated":"2017-11-29 23:45:15.000000000","message":"sorry my bad.\ninstead of \u0027cold\u0027 :)","commit_id":"9cd918e75504b18a4030afe6726d6788ae3f9a34"}],"watcher/tests/applier/actions/test_volume_migration.py":[{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"8d683046c9790ed32619456bd417f76a5760b965","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.action_swap.input_parameters \u003d self.input_parameters_swap"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.input_parameters_migrate \u003d {"},{"line_number":87,"context_line":"            \"migration_type\": \"migrate\","},{"line_number":88,"context_line":"            \"destination_node\": \"storage1-poolname\","},{"line_number":89,"context_line":"            \"destination_type\": \"\","},{"line_number":90,"context_line":"            baction.BaseAction.RESOURCE_ID: self.VOLUME_UUID,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_60de4c6e","line":87,"updated":"2017-12-07 06:24:14.000000000","message":"you are replacing \u0027cold\u0027 with \u0027retype\u0027 then why migrate here??","commit_id":"02163d64aa0de7c99455c351b124cec865a5cf98"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"6ec674ddce0fecec8445b64d63a898ee92dfb079","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.action_swap.input_parameters \u003d self.input_parameters_swap"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.input_parameters_migrate \u003d {"},{"line_number":87,"context_line":"            \"migration_type\": \"migrate\","},{"line_number":88,"context_line":"            \"destination_node\": \"storage1-poolname\","},{"line_number":89,"context_line":"            \"destination_type\": \"\","},{"line_number":90,"context_line":"            baction.BaseAction.RESOURCE_ID: self.VOLUME_UUID,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_b3ace08c","line":87,"in_reply_to":"df87a7cf_60de4c6e","updated":"2017-12-26 09:16:30.000000000","message":"hi aditi, this is because the watcher\u0027s action \"cold\" finally invokes both cinder \"retype\" and \"migrate\".","commit_id":"02163d64aa0de7c99455c351b124cec865a5cf98"}]}